Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

2015-12-23 Thread David Miller
From: "David Rivshin (Allworx)" <drivshin.allw...@gmail.com> Date: Tue, 22 Dec 2015 19:36:31 -0500 > Testing by anyone who has real hardware using phy-handle or dual_emac > with fixed-link would be appreciated. I'm going to wait for such testing before applyin

Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

2015-12-23 Thread David Rivshin (Allworx)
On Thu, 24 Dec 2015 00:34:49 +0100 Nicolas Chauvet <kwiz...@gmail.com> wrote: > 2015-12-23 22:54 GMT+01:00 David Rivshin (Allworx) < > drivshin.allw...@gmail.com>: > > > On Wed, 23 Dec 2015 22:20:58 +0100 > > Nicolas Chauvet <kwiz...@gmail.com> wrote: &g

Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

2015-12-23 Thread David Rivshin (Allworx)
On Wed, 23 Dec 2015 19:35:37 +0100 Markus Brunner <systemprogrammierung.brun...@gmail.com> wrote: > On Wednesday 23 December 2015 12:04:25 David Miller wrote: > > From: "David Rivshin (Allworx)" <drivshin.allw...@gmail.com> > > Date: Tue, 22 Dec 2015 19:36:

Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

2015-12-23 Thread David Rivshin (Allworx)
On Wed, 23 Dec 2015 22:20:58 +0100 Nicolas Chauvet <kwiz...@gmail.com> wrote: > 2015-12-23 1:36 GMT+01:00 David Rivshin (Allworx) < > drivshin.allw...@gmail.com>: > > > From: David Rivshin <drivs...@allworx.com> > > > > This series is based on the

[PATCH 3/3] drivers: net: cpsw: use of_phy_connect() in fixed-link case

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin <drivs...@allworx.com> If a fixed-link DT subnode is used, the phy_device was looked up so that a PHY ID string could be constructed and passed to phy_connect(). This is not necessary, as the device_node can be passed directly to of_phy_connect() instead. This reuses th

[PATCH 1/3] drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac config

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin <drivs...@allworx.com> Commit 9e42f715264ff158478fa30eaed847f6e131366b ("drivers: net: cpsw: add phy-handle parsing") saved the "phy-handle" phandle into a new cpsw_priv field. However, phy connections are per-slave, so the phy_node field should be

[PATCH 0/3] drivers: net: cpsw: phy-handle fixes

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin <drivs...@allworx.com> This series is based on the tip of the net tree. The first patch fixes a bug that makes dual_emac mode break if either slave uses the phy-handle property in the devicetree. The second patch fixes some cosmetic problems with error messages, an

[PATCH 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

2015-12-22 Thread David Rivshin (Allworx)
From: David Rivshin <drivs...@allworx.com> The phy-handle, phy_id, and fixed-link properties are mutually exclusive, and only one need be specified. However if phy-handle was specified, an error message would complain about the lack of phy_id or fixed-link. Also, if phy-handle was spe

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-18 Thread David Miller
From: "David Rivshin (Allworx)" <drivshin.allw...@gmail.com> Date: Wed, 16 Dec 2015 23:02:08 -0500 > Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw: > Add support for fixed-link PHY") added initial fixed-link PHY support > for CP

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-18 Thread David Rivshin (Allworx)
On Fri, 18 Dec 2015 11:20:21 +0100 Daniel Trautmann <dtrautm...@ibhsoftec.com> wrote: > On Thu, Dec 17, 2015 at 03:45:08PM -0500, David Miller wrote: > > From: "David Rivshin (Allworx)" <drivshin.allw...@gmail.com> > > Date: Wed, 16 Dec 2015 23

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-17 Thread David Miller
From: "David Rivshin (Allworx)" <drivshin.allw...@gmail.com> Date: Wed, 16 Dec 2015 23:02:08 -0500 > I have tested on the following hardware configurations: > - (EVMSK) dual emac with two real MDIO-connected phys using RGMII-TXID > - single emac with fixed-link using

Re: [PATCH] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-16 Thread David Rivshin (Allworx)
On Wed, 16 Dec 2015 07:39:16 +0100 Markus Brunner <systemprogrammierung.brun...@gmail.com> wrote: > On Monday 14 December 2015 13:04:46 David Rivshin wrote: > > On Sat, 12 Dec 2015 16:44:19 +0100 > ... > > > Your patch works fine on my board, which uses MII and dual_

[PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

2015-12-16 Thread David Rivshin (Allworx)
slave node. - Update binding documentation to no longer say that phy_mode is also mutually exclusive with fixed-link. - Dropped unnecessary include of phy_fixed.h. [1] https://patchwork.ozlabs.org/patch/554989/ David Rivshin (2): drivers: net: cpsw: fix RMII/RGMII mode when used with fixe

[PATCH v2 2/3] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-16 Thread David Rivshin (Allworx)
From: David Rivshin <drivs...@allworx.com> Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw: Add support for fixed-link PHY") did not parse the "phy-mode" property in the case of a fixed-link PHY, leaving slave_data->phy_if with its defau

[PATCH v2 1/3] ethernet:ti:cpsw: fix phy identification with multiple slaves on fixed-phy

2015-12-16 Thread David Rivshin (Allworx)
From: Pascal Speck (Iktek) Date: Fri, 04 Dec 2015 16:55:17 +0100 When using more than one slave with ti cpsw and fixed phy the pd->phy_id will be always zero, but slave_data->phy_id must be unique. pd->phy_id means a "phy hardware id" whereas slave_data->phy_id means an "unique

[PATCH v2 3/3] drivers: net: cpsw: increment reference count on fixed-link PHY node

2015-12-16 Thread David Rivshin (Allworx)
From: David Rivshin <drivs...@allworx.com> When a fixed-link sub-node exists in a slave node, the slave node is also the PHY node. Since this is a separate use of the slave node, of_node_get() should be used to increment the reference count. Fixes: 1f71e8c96fc6 ("drivers: net: cpsw:

Re: [PATCH] drivers: net: cpsw: fix RMII/RGMII mode when used with fixed-link PHY

2015-12-14 Thread David Rivshin (Allworx)
On Sat, 12 Dec 2015 16:44:19 +0100 Markus Brunner <systemprogrammierung.brun...@gmail.com> wrote: > On Wednesday 09 December 2015 22:31:15 David Rivshin wrote: > ... > > This patch was originally developed in parallel with 1f71e8c96fc6 to > > accomplish the same goal. Wh

Re: [PATCH] net: cpsw: Fix ethernet regression for dm814x

2015-11-20 Thread David Miller
From: Tony Lindgren Date: Wed, 18 Nov 2015 17:27:25 -0800 > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > id to common file") started using of_machine_is_compatible for detecting > type but missed at dm8148 causing Ethernet to stop working. > >

Re: [PATCH] drivers: net: cpsw: Add support for fixed-link PHY

2015-11-04 Thread David Miller
From: Markus Brunner Date: Tue, 03 Nov 2015 22:09:51 +0100 > Add support for a fixed-link devicetree sub-node in case the the > cpsw MAC is directly connected to a non-mdio PHY/device. > > Signed-off-by: Markus Brunner

Re: [PATCH] drivers: net: cpsw: use module_platform_driver

2015-10-23 Thread David Miller
From: Grygorii Strashko Date: Fri, 23 Oct 2015 14:41:12 +0300 > There is no reasons to probe cpsw from late_initcall level > and it's not recommended. Hence, use module_platform_driver() > to register and probe cpsw driver from module_init() level. > > Cc: Tony

Re: [PATCH 00/38] Fixes related to incorrect usage of unsigned types

2015-09-21 Thread David Howells
x being changed to signed at some point in the future for no cost. In which case, your changing the <= to an == "because the < part of the case is useless" is arguably wrong. David -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a

Re: [net-next PATCH 0/4] Add support for reading macid when DT macid not found

2015-09-21 Thread David Miller
From: Mugunthan V N Date: Mon, 21 Sep 2015 15:56:49 +0530 > Did a boot test on dra7-evm [1] and am437x-gp-evm [2]. > Pushed a branch [3] for others to test the patch. > > [1]: http://pastebin.ubuntu.com/12513420/ > [2]: http://pastebin.ubuntu.com/12513428/ > [3]:

Re: [net-next PATCH v3] drivers: net: cpsw: Add support to drive gpios for ethernet to be functional

2015-09-15 Thread David Miller
From: Mugunthan V N Date: Mon, 7 Sep 2015 15:16:44 +0530 > In DRA72x EVM, by default slave 1 is connected to the onboard > phy, but slave 2 pins are also muxed with video input module > which is controlled by pcf857x gpio and currently to select slave > 0 to connect to phy

Re: [PATCH] net/smsc911x: Fix deferred probe for interrupt

2015-08-29 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Fri, 28 Aug 2015 11:50:15 -0700 The interrupt handler may not be available when smsc911x probes if the interrupt handler is a GPIO controller for example. Let's fix that by adding handling for -EPROBE_DEFER. Cc: Steve Glendinning

Re: [net-next PATCH 0/3] Add AM335x PG1.0 CPSW errata workaround

2015-08-13 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Wed, 12 Aug 2015 15:22:52 +0530 With commit 870915feabdc (drivers: net: cpsw: remove disable_irq/enable_irq as irq can be masked from cpsw itself), CPSW on AM335x beagle bone white is broken as there is a errata for AM335x PG1.0. This patch series

RE: [PATCH v5 02/46] usb: gadget: add endpoint capabilities flags

2015-07-31 Thread David Laight
) would the be explicitly assigning 'not supported' to the other fields. The compiler will also generate much better code... David

Re: [net-next PATCH] net: Reserve skb headroom and set skb-dev even if using __alloc_skb

2015-05-13 Thread David Miller
From: Alexander Duyck alexander.h.du...@redhat.com Date: Wed, 13 May 2015 13:34:13 -0700 When I had inlined __alloc_rx_skb into __netdev_alloc_skb and __napi_alloc_skb I had overlooked the fact that there was a return in the __alloc_rx_skb. As a result we weren't reserving headroom or setting

Re: [PATCH 1/2] net: davinci_mdio: add hibernation callbacks

2015-03-01 Thread David Miller
From: grygorii.stras...@linaro.org Date: Fri, 27 Feb 2015 13:19:44 +0200 From: Grygorii Strashko grygorii.stras...@linaro.org Setting a dev_pm_ops suspend_late/resume_early pair but not a set of hibernation functions means those pm functions will not be called upon hibernation. Fix this by

Re: [PATCH 2/2] net: ti: cpsw: add hibernation callbacks

2015-03-01 Thread David Miller
From: grygorii.stras...@linaro.org Date: Fri, 27 Feb 2015 13:19:45 +0200 From: Grygorii Strashko grygorii.stras...@linaro.org Setting a dev_pm_ops suspend/resume pair but not a set of hibernation functions means those pm functions will not be called upon hibernation. Fix this by using

Re: [PATCH v2] dtc: parser: Add label while overriding nodes

2015-02-22 Thread David Gibson
of tree1 tests. The fact that you can only apply a single label by this method is a bit of a wart, but it's something we can fix later. I had a look at it and (as I suspect you already discovered) it's surprisingly complicated to do so. -- David Gibson| I'll have my music baroque

Re: [PATCH 0/3] Changes to cpsw and davinci_emac for getting MAC address

2015-01-30 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Wed, 28 Jan 2015 11:33:03 -0800 Here are a few patches to add common code for cpsw and davinci_emac for getting the MAC address. Looks like we can also now add code to get the MAC address on 3517 but in a slightly different way. Applied to net-next,

Re: [PATCH] dtc: parser: Add label while overriding nodes

2015-01-29 Thread David Gibson
On Thu, Jan 29, 2015 at 09:07:31PM +1100, David Gibson wrote: On Wed, Jan 28, 2015 at 08:20:11PM +0530, Nikhil Devshatwar wrote: This patch changes the dtc grammar to allow following syntax i2cexp: i2c2 { ... }; Current device tree compiler allows to define multiple labels

Re: [PATCH] dtc: parser: Add label while overriding nodes

2015-01-29 Thread David Gibson
, and the implementation looks fine. Only 2 things before I'm ready to merge: 1) It wants a testcase 2) I need to stare at the syntax for a while and convince myself it's as good as we can reasonably do. -- David Gibson| I'll have my music baroque, and my code david

Re: [patch-net-next v3 2/2] net: ethernet: cpsw: don't requests IRQs we don't use

2015-01-19 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Mon, 19 Jan 2015 08:40:17 -0600 On Sun, Jan 18, 2015 at 01:07:50AM -0500, David Miller wrote: From: Felipe Balbi ba...@ti.com Date: Fri, 16 Jan 2015 10:11:12 -0600 CPSW never uses RX_THRESHOLD or MISC interrupts. In fact, they are always kept masked

Re: [patch-net-next v3] net: ethernet: ti: cpsw: fix buld break when NET_POLL_CONTROLLER

2015-01-19 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Mon, 19 Jan 2015 11:52:36 -0600 Commit c03abd84634d (net: ethernet: cpsw: don't requests IRQs we don't use) left one build breakage when NET_POLL_CONTROLLER is enabled. Fix this build break by referring to the correct irqs_table array. Fixes:

Re: [patch-net-next v3 1/2] net: ethernet: cpsw: unroll IRQ request loop

2015-01-17 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 16 Jan 2015 10:11:11 -0600 This patch is in preparation for a nicer IRQ handling scheme where we use different IRQ handlers for each IRQ line (as it should be). Later, we will also drop IRQs offset 0 and 3 because they are always disabled in this

Re: [patch-net-next v3 2/2] net: ethernet: cpsw: don't requests IRQs we don't use

2015-01-17 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 16 Jan 2015 10:11:12 -0600 CPSW never uses RX_THRESHOLD or MISC interrupts. In fact, they are always kept masked in their appropriate IRQ Enable register. Instead of allocating an IRQ that never fires, it's best to remove that code altogether and

Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use

2015-01-15 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Thu, 15 Jan 2015 09:20:53 -0600 On Thu, Jan 15, 2015 at 01:19:16PM +0530, Mugunthan V N wrote: On Wednesday 14 January 2015 10:28 PM, Felipe Balbi wrote: CPSW never uses RX_THRESHOLD or MISC interrupts. In fact, they are always kept masked in their

Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use

2015-01-15 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Thu, 15 Jan 2015 19:28:52 -0600 On Thu, Jan 15, 2015 at 06:16:15PM -0500, David Miller wrote: Indeed, I agree that adding something as a placeholder that just gets immediately removed should be avoided unless it is extremely difficult to do so. what

Re: [PATCHv2 0/6] Fixes for davinci_emac

2015-01-15 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Thu, 15 Jan 2015 14:45:08 -0800 Here's a repost of the fixes for davinci_emac with patches updated for comments and acks collected. Series applied, thanks Tony. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a

Re: [patch-net-next 1/3] net: ethernet: cpsw: unroll IRQ request loop

2015-01-13 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Tue, 13 Jan 2015 13:44:46 -0600 + ret = devm_request_irq(pdev-dev, irq, cpsw_interrupt, + 0, dev_name(pdev-dev), priv); When a function call spans multiple lines, the argument on the second and subsequent lines must start on the

Re: [PATCH 3/6] net: davinci_emac: Free clock after checking the frequency

2015-01-13 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Tue, 13 Jan 2015 11:54:16 -0800 * Tom Lendacky thomas.lenda...@amd.com [150113 11:51]: On 01/13/2015 01:29 PM, Tony Lindgren wrote: We only use clk_get() to get the frequency, the rest is done by the runtime PM calls. Let's free the clock too. Cc:

Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

2015-01-06 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Tue, 6 Jan 2015 11:43:32 -0600 CPSW completely hangs if we add, and later remove, VLAN ID #1. What happens is that after removing VLAN ID #1, no packets will be received by CPSW rendering network unusable. In order to fix the issue, we're returning

Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

2015-01-06 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Tue, 6 Jan 2015 14:31:19 -0600 What you're saying here is that you prefer to drop a feature that works for all other 1023 IDs because 1 ID is quirky. Sounds like overkill to me. The other option is to software fallback only for VLAN 1. -- To unsubscribe

Re: [PATCH] net: ethernet: cpsw: fix hangs with interrupts

2015-01-04 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 2 Jan 2015 16:15:59 -0600 The CPSW IP implements pulse-signaled interrupts. Due to that we must write a correct, pre-defined value to the CPDMA_MACEOIVECTOR register so the controller generates a pulse on the correct IRQ line to signal the End Of

Re: [PATCH 0/4] net: cpsw: fix hangs and improve IRQ handling

2015-01-02 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 2 Jan 2015 12:10:24 -0600 In any case, patch 1 should go in during the -rc an get backported all the way back to v3.9, while the other patches can (should) be delayed for v3.20 merge window. If that's what you want, the way you submitted these

Re: [PATCH 0/4] net: cpsw: fix hangs and improve IRQ handling

2015-01-02 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 2 Jan 2015 15:53:35 -0600 On Fri, Jan 02, 2015 at 04:45:36PM -0500, David Miller wrote: You should instead submit patch #1 all by itself, correctly targetting 'net'. Then, after the next time I merge 'net' into 'net-next', you can submit the rest

Re: [PATCH v2] drivers: net : cpsw: Update Kconfig for CPSW

2014-12-09 Thread David Miller
From: Lokesh Vutla lokeshvu...@ti.com Date: Thu, 4 Dec 2014 10:24:29 +0530 CPSW is present in AM33xx, AM43xx, DRA7xx. Updating the Kconfig to depend on ARCH_OMAP2PLUS instead of listing all SoC's. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Applied to net-next, thanks. -- To unsubscribe

Re: [PATCH] net: smc91x: Fix gpios for device tree based booting

2014-10-29 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Mon, 27 Oct 2014 13:25:56 -0700 +/** + * of_try_set_control_gpio - configure a gpio if it exists + */ +static int try_toggle_control_gpio(struct device *dev, +struct gpio_desc **desc, +

RE: [PATCH] ARM: Blacklist GCC 4.8.0 to GCC 4.8.2 - PR58854

2014-10-16 Thread David Laight
through 4.8.2 #endif David int main(void) -- 1.8.3.1

RE: RCU bug with v3.17-rc3 ?

2014-10-13 Thread David Laight
number to avoid false positives. David -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND v6 0/7] net: cpsw: Support for am335x chip MACIDs

2014-09-29 Thread David Miller
From: Markus Pargmann m...@pengutronix.de Date: Mon, 29 Sep 2014 08:53:12 +0200 Another resend of this series to add the netdev list. This series adds support to the cpsw driver to read the MACIDs of the am335x chip and use them as fallback. These addresses are only used if there are no mac

Re: [PATCH RESEND v6 0/7] DT doc: net: cpsw mac-address is optional

2014-09-28 Thread David Miller
From: Markus Pargmann m...@pengutronix.de Date: Sun, 28 Sep 2014 18:59:14 +0200 This is a resend of v6 of this series. I added the Acked-by of Tony Lindgren for patch 5/7. There are no other changes. This series adds support to the cpsw driver to read the MACIDs of the am335x chip and use

[PATCH 1/1] omap2: fix parser-bug in platform muxing code

2014-06-16 Thread David R. Piegdon
Fix a parser-bug in the omap2 muxing code where muxtable-entries will be wrongly selected if the requested muxname is a *prefix* of their m0-entry and they have a matching mN-entry. Fix by additionally checking that the length of the m0_entry is equal. Signed-off-by: David R. Piegdon l

Re: [PATCH v2 0/6] Add CPTS support for AM437x

2014-05-05 Thread David Miller
From: George Cherian george.cher...@ti.com Date: Fri, 2 May 2014 12:01:58 +0530 The series adds CPTS support for AM4372. Patch 1 - DT changes w.r.t clock changes for AM33xx. Patch 2 - CPTS clock name harcoding in the driver is removed. Easier to pass the clock name from dt rather

RE: [PATCH 1/2] usb: rename 'phy' field of 'struct usb_hcd' to 'transceiver'

2014-04-10 Thread David Laight
. I'd have thought that would happen if you had a single controller that select between multiply PHY. David -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

RE: [PATCH 1/2] usb: rename 'phy' field of 'struct usb_hcd' to 'transceiver'

2014-04-10 Thread David Laight
From: Ben Dooks On 10/04/14 11:49, Sergei Shtylyov wrote: On 10-04-2014 13:20, David Laight wrote: It doesn't do any pin muxing. It switches SoC internal USB signals between USB controllers. The pins remain the same. Doesn't something like that already happen for the companion

Re: [PATCH] net: micrel : ks8851-ml: add vdd-supply support

2014-03-23 Thread David Miller
From: Nishanth Menon n...@ti.com Date: Fri, 21 Mar 2014 01:52:48 -0500 Few platforms use external regulator to keep the ethernet MAC supplied. So, request and enable the regulator for driver functionality. Fixes: 66fda75f47dc (regulator: core: Replace direct ops-disable usage) Reported-by:

Re: [PATCH 1/1] net: cpsw: fix cpdma rx descriptor leak on down interface

2014-03-03 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 3 Mar 2014 16:19:06 +0530 From: Schuyler Patton spat...@ti.com This patch fixes a CPDMA RX Descriptor leak that occurs after taking the interface down when the CPSW is in Dual MAC mode. Previously the CPSW_ALE port was left open up which

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: enable promiscuous mode support

2014-01-23 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Thu, 23 Jan 2014 00:03:12 +0530 Enable promiscuous mode support for CPSW. Signed-off-by: Mugunthan V N mugunthan...@ti.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to

Re: [net-next PATCH 1/1] drivers: net: cpsw: enable promiscuous mode support

2014-01-21 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 20 Jan 2014 17:38:38 +0530 + if (!enable ((priv-slaves[0].ndev-flags IFF_PROMISC) || + (priv-slaves[1].ndev-flags IFF_PROMISC))) { This assumption that there are exactly 2 slaves is not valid. Use

Re: [net PATCH v3 1/1] drivers: net : cpsw: pass proper device name while requesting irq

2013-12-22 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Wed, 18 Dec 2013 21:33:50 +0530 During checking the interrupts with cat /proc/interrupts, it is showing device name as (null), this change was done with commit id aa1a15e2d where request_irq is changed to devm_request_irq also changing the irq name

Re: [PATCH 1/1] drivers: net cpsw: Enable In Band mode in cpsw for 10 mbps

2013-12-18 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Fri, 13 Dec 2013 18:42:55 +0530 This patch adds support for enabling In Band mode in 10 mbps speed. RGMII supports 1 Gig and 100 mbps mode for Forced mode of operation. For 10mbps mode it should be configured to in band mode so that link status,

Re: [PATCH V3] usb: musb: Fix unstable init of OTG_INTERFSEL.

2013-12-17 Thread David Cohen
, David Cohen + musb_writel(musb-mregs, OTG_INTERFSEL, musb-context.otg_interfsel); usb_phy_set_suspend(musb-xceiv, 0); -- 1.8.4.1 -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body

Re: [net PATCH v2 1/1] drivers: net : cpsw: pass proper device name while requesting irq

2013-12-17 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Fri, 13 Dec 2013 14:35:27 +0530 During checking the interrupts with cat /proc/interrupts, it is showing device name as (null), this change was done with commit id aa1a15e2d where request_irq is changed to devm_request_irq also changing the irq name

Re: [PATCH 0/7] usb: dwc3: pm_runtime implementation

2013-12-17 Thread David Cohen
around pm callback functions. Instead of saying DWC3 will start to have warnings when CONFIG_PM is not selected, I'd say your patch set is now a dependence of my RFC :) https://lkml.org/lkml/2013/12/13/4 Br, David Cohen Felipe Balbi (7): usb: dwc3: keystone: add basic PM support usb: dwc3

Re: [PATCH 0/7] usb: dwc3: pm_runtime implementation

2013-12-17 Thread David Cohen
On Tue, Dec 17, 2013 at 03:31:40PM -0800, David Cohen wrote: On Thu, Dec 12, 2013 at 03:38:38PM -0600, Felipe Balbi wrote: hi all, these patches add pm_runtime support for all glue layers. I plan to add pm_runtime support for dwc3 after these patches are merged upstream. Please

Re: [PATCH 2/2] drivers: net: cpsw: fix for cpsw crash when build as modules

2013-12-12 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Wed, 11 Dec 2013 22:09:05 -0600 From: Mugunthan V N mugunthan...@ti.com When CPSW and Davinci MDIO are build as modules, CPSW crashes when accessing CPSW registers in CPSW probe. The same is working in built-in as the CPSW clocks are enabled in Davindi

Re: [PATCH 3/7] usb: dwc3: pci: add pm_runtime support

2013-12-12 Thread David Cohen
-by: David Cohen david.a.co...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/7] usb: dwc3: pci: add pm_runtime support

2013-12-12 Thread David Cohen
On Thu, Dec 12, 2013 at 10:17:19PM -0600, Felipe Balbi wrote: On Thu, Dec 12, 2013 at 05:56:05PM -0800, David Cohen wrote: On Thu, Dec 12, 2013 at 03:38:41PM -0600, Felipe Balbi wrote: teach the PCI glue about pm_runtime so that it's easier to teach dwc3 core about it later

Re: [PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-11 Thread David Cohen
, + if (musb-context.otg_interfsel != 0) You might want to write an inline comment explaining why you're checking otg_interfsel for 0 here (as you explained 0 is not a valid value to be found). Br, David + musb_writel(musb-mregs, OTG_INTERFSEL, musb

Re: [PATCH 1/2] net: eth: davinci_cpdma: 64-bit phys/dma_addr_t cleanup

2013-12-11 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Wed, 11 Dec 2013 15:51:20 -0800 Silences the below warnings when building with ARM_LPAE enabled, which gives longer dma_addr_t by default: drivers/net/ethernet/ti/davinci_cpdma.c: In function 'cpdma_desc_pool_create':

Re: [PATCH] net: eth: cpsw: 64-bit phys_addr_t and sparse cleanup

2013-12-11 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Wed, 11 Dec 2013 15:58:07 -0800 Minor fix for printk format of a phys_addr_t, and the switch of two local functions to static since they're not used outside of the file. Signed-off-by: Olof Johansson o...@lixom.net Applied. -- To unsubscribe from

Re: [PATCH 2/2] net: eth: davinci_cpdma: Mark a local variable static

2013-12-11 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Wed, 11 Dec 2013 15:51:21 -0800 Only used locally. Found by sparse. Signed-off-by: Olof Johansson o...@lixom.net Applied. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [PATCH 1/1] drivers: net : cpsw: Use netdev_name while requesting irq

2013-12-09 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 9 Dec 2013 14:59:05 +0530 commit 50a5fb068 This commit doesn't appear in any tree. And any change which makes a real struct device return NULL for dev_name() is broken. I'm not applying this patch, you have completely failed to provide any

Re: [PATCH 1/1] drivers: net : cpsw: Use netdev_name while requesting irq

2013-12-06 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Fri, 6 Dec 2013 12:28:27 +0530 From: George Cherian george.cher...@ti.com Use netdev_name while requesting irq so that eth* name is shown in /proc/interrupts. Previously it was showing device name as (null) for cpsw interrupts. For using

Re: [PATCH] net: davinci_emac: Fix platform data handling and make usable for am3517

2013-12-05 Thread David Miller
From: Tony Lindgren t...@atomide.com Date: Tue, 3 Dec 2013 15:13:02 -0800 When booted with device tree, we may still have platform data passed as auxdata. For am3517 this is needed for passing the interrupt_enable and interrupt_disable callbacks that access the omap system control module

RE: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread David Laight
From: Roger Quadros [mailto:rog...@ti.com] On 11/29/2013 03:17 PM, David Laight wrote: ... + timeout = jiffies + msecs_to_jiffies(100); + while (!(usbhs_read(omap-uhh_base, OMAP_UHH_SYSSTATUS) + OMAP_UHH_SYSSTATUS_RESETDONE)) { + cpu_relax(); You mean use

Re: [PATCH 1/1] drivers: net: cpsw: fix dt probe for one port ethernet

2013-12-02 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 2 Dec 2013 12:53:39 +0530 When only one port of the two port is pinned out, then dt probe is failing because second port phy is not found. fixing this by checking the number of slaves and breaking the loop. Signed-off-by: Mugunthan V N

RE: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-11-29 Thread David Laight
differences, the udelay(2) won't be significant. I'm not sure of the context this code runs in, but if the reset is likely to take a significant portion of the 100ms timeout period, why not just sleep for a few ms between status polls. David -- To unsubscribe from this list: send the line

Re: [net PATCH 1/1] drivers: net: cpsw: fix kernel warn during iperf test with interrupt pacing

2013-10-21 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Sun, 20 Oct 2013 12:32:26 +0530 When interrupt pacing is enabled, receive/transmit statistics are not updated properly by hardware which leads to ISR return with IRQ_NONE and inturn kernel disables the interrupt. This patch removed the checking of

Re: [RFC 00/15] Device Tree schemas and validation

2013-10-02 Thread David Gibson
ahead! Benoit, Sorry, I meant to ask earlier but forgot. Shouldn't this development be based on the upstream DTC repository and not the in-kernel copy of the DTC? Absolutely. Please work against upstream dtc. -- David Gibson| I'll have my music baroque, and my

Re: [RFC 00/15] Device Tree schemas and validation

2013-10-02 Thread David Gibson
between a binding document and a formal schema is that a binding defines both the syntax required of a node, and its semantics, whereas a schema defines only syntax - the semantics still need to be defined somewhere. -- David Gibson| I'll have my music baroque, and my code david

Re: [RFC 00/15] Device Tree schemas and validation

2013-10-02 Thread David Gibson
the schema language needs to be substantially more flexible than the draft presented here. While I think a schema syntax which mirrors dts syntax makes a lot of sense, actually defining schemas as device trees doesn't seem quite right to me. -- David Gibson| I'll have my music

Re: [RFC 01/15] scripts/dtc: fix most memory leaks in dtc

2013-10-02 Thread David Gibson
; + + free_node_list(bi-dt); + free(bi); +} -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson pgpIqVVeRdOcK.pgp

Re: [RFC 00/15] Device Tree schemas and validation

2013-10-02 Thread David Gibson
-parent or interrupt-map -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson pgpODmqrjd5GL.pgp Description: PGP

Re: [RFC 00/15] Device Tree schemas and validation

2013-10-02 Thread David Gibson
On Wed, Oct 02, 2013 at 07:08:41PM +0100, Mark Brown wrote: On Wed, Oct 02, 2013 at 11:54:50PM +1000, David Gibson wrote: On Tue, Oct 01, 2013 at 03:54:20PM -0500, Rob Herring wrote: I would expect the schema to replace Documentation/devicetree/bindings/* over time. I think the thing

Re: [net-next PATCH 0/4] cpsw: support for control module register

2013-09-24 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Sat, 21 Sep 2013 00:50:37 +0530 This patch series adds the support for configuring GMII_SEL register of control module to select the phy mode type and also to configure the clock source for RMII phy mode whether to use internal clock or the

CONFIDENTIAL TRUST REPLY .

2013-09-17 Thread David Williams
will be highly appreciated Best regards, Mr. David Williams -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] cpsw: support for control module register

2013-08-22 Thread David Miller
Patch #3 doesn't apply to net-next because it makes changes to a file include/linux/platform_data/cpsw.h which doesn't exist. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: Add support for new CPSW IP version

2013-08-05 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 5 Aug 2013 17:30:05 +0530 The new IP version has a minor changes and the offsets are same as the previous version, so adding new IP version support in the driver. Signed-off-by: Mugunthan V N mugunthan...@ti.com Reviewed-by: Felipe Balbi

Re: [net PATCH 1/1] net: ethernet: davinci_emac: drop IRQF_DISABLED

2013-08-03 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Sat, 3 Aug 2013 16:39:45 +0530 IRQF_DISABLED is a no-op by now and should be removed. Signed-off-by: Mugunthan V N mugunthan...@ti.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a

Re: [PATCH] net: ethernet: cpsw: drop IRQF_DISABLED

2013-08-02 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Fri, 2 Aug 2013 10:44:10 +0300 IRQF_DISABLED is a no-op by now and should be removed. Signed-off-by: Felipe Balbi ba...@ti.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to

Re: [net-next PATCH 1/1] drivers: net: cpsw: Add support for new CPSW IP version

2013-07-31 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Wed, 31 Jul 2013 17:42:26 +0530 The new IP version has a minor changes and the offsets are same as the previous version, so instead of adding CPSW version number in the driver, make the driver to fall through to the latest versions so that the

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: add support to show hw stats via ethtool

2013-07-24 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 23 Jul 2013 15:38:17 +0530 Add support to show CPSW hardware statistics to user via ethtool so user can find if there were any error reported by hardware or the system is over loaded duing high data rate transfer. Signed-off-by: Mugunthan V

Re: [net-next PATCH 1/1] drivers: net: cpsw: add support to show hw stats via ethtool get_regs

2013-07-19 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Fri, 19 Jul 2013 19:37:21 +0530 Add support to show CPSW hardware statistics to user via ethtool get_regs ops so user can find if there were any error reported or the system is over loaded duing hagh data rate transfer. Signed-off-by: Mugunthan

Re: [net-next PATCH v4 1/5] net: cpsw: enhance pinctrl support

2013-06-13 Thread David Miller
From: Linus Walleij linus.wall...@linaro.org Date: Mon, 10 Jun 2013 17:48:16 +0200 On Fri, Jun 7, 2013 at 4:49 PM, Mugunthan V N mugunthan...@ti.com wrote: If you want to merge the direct networking parts of this series into another tree, I'm fine with that: Acked-by: David S. Miller da

Re: [net PATCH 0/2] Fixes for davinci MDIO on suspend/resume

2013-06-13 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 11 Jun 2013 15:32:03 +0530 This patch series fixes the following issues with Davinci MDIO * Bring up MDIO driver earlier than Ethernet driver so that ethernet driver can communicate with the phy as soon as it is resumed. * On suspend/resume

Re: [net-next PATCH v4 1/5] net: cpsw: enhance pinctrl support

2013-06-07 Thread David Miller
of this series into another tree, I'm fine with that: Acked-by: David S. Miller da...@davemloft.net -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 0/8] add phy driver for Atheros AR8031 and CPSW phy-mode DT enhancement

2013-06-04 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Tue, 4 Jun 2013 11:40:03 +0530 This patch series adds the following feature * Atheros phy driver code cleanup * Add AT8031 phy driver to at803x driver * Add RGMII tx delay support via phy_if * Add phy_if DT enhancement to CPSW Driver and DT

  1   2   3   4   5   6   7   8   9   10   >