Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-31 Thread Samuel Ortiz
Hi Keerthy, On Sat, Jan 22, 2011 at 10:19:33PM +0530, J, KEERTHY wrote: > On Fri, Jan 7, 2011 at 5:42 PM, J, KEERTHY wrote: > > On Fri, Jan 7, 2011 at 3:25 AM, Guenter Roeck > > wrote: > >> On Thu, 2011-01-06 at 15:21 -0500, Mark Brown wrote: > >>> On Thu, Jan 06, 2011 at 07:04:30AM -0800, Guent

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-22 Thread J, KEERTHY
On Fri, Jan 7, 2011 at 5:42 PM, J, KEERTHY wrote: > On Fri, Jan 7, 2011 at 3:25 AM, Guenter Roeck > wrote: >> On Thu, 2011-01-06 at 15:21 -0500, Mark Brown wrote: >>> On Thu, Jan 06, 2011 at 07:04:30AM -0800, Guenter Roeck wrote: >>> > On Thu, Jan 06, 2011 at 07:07:13AM -0500, Mark Brown wrote: >

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-07 Thread Guenter Roeck
On Fri, Jan 07, 2011 at 07:12:13AM -0500, J, KEERTHY wrote: > On Fri, Jan 7, 2011 at 3:25 AM, Guenter Roeck > wrote: > > On Thu, 2011-01-06 at 15:21 -0500, Mark Brown wrote: > >> On Thu, Jan 06, 2011 at 07:04:30AM -0800, Guenter Roeck wrote: > >> > On Thu, Jan 06, 2011 at 07:07:13AM -0500, Mark Br

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-07 Thread J, KEERTHY
On Fri, Jan 7, 2011 at 3:25 AM, Guenter Roeck wrote: > On Thu, 2011-01-06 at 15:21 -0500, Mark Brown wrote: >> On Thu, Jan 06, 2011 at 07:04:30AM -0800, Guenter Roeck wrote: >> > On Thu, Jan 06, 2011 at 07:07:13AM -0500, Mark Brown wrote: >> >> > > Why?  It's not like hwmon has an unreasonably lar

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-07 Thread J, KEERTHY
On Fri, Jan 7, 2011 at 4:14 PM, Mark Brown wrote: > On Fri, Jan 07, 2011 at 02:55:45PM +0530, J, KEERTHY wrote: >> On Thu, Jan 6, 2011 at 5:34 PM, Mark Brown >> > On Thu, Jan 06, 2011 at 09:26:40AM +0530, Keerthy wrote: > >> >> +static ssize_t madc_read(struct device *dev, >> >> +                

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-07 Thread Mark Brown
On Fri, Jan 07, 2011 at 02:55:45PM +0530, J, KEERTHY wrote: > On Thu, Jan 6, 2011 at 5:34 PM, Mark Brown > > On Thu, Jan 06, 2011 at 09:26:40AM +0530, Keerthy wrote: > >> +static ssize_t madc_read(struct device *dev, > >> +                      struct device_attribute *devattr, char *buf) > >> +{

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-07 Thread J, KEERTHY
On Thu, Jan 6, 2011 at 5:34 PM, Mark Brown wrote: > On Thu, Jan 06, 2011 at 09:26:40AM +0530, Keerthy wrote: > >> --- >>  drivers/hwmon/Kconfig            |   11 + >>  drivers/hwmon/Makefile           |    1 + >>  drivers/hwmon/twl4030-madc.c     |  794 >> ++ >

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-06 Thread Guenter Roeck
On Thu, 2011-01-06 at 15:21 -0500, Mark Brown wrote: > On Thu, Jan 06, 2011 at 07:04:30AM -0800, Guenter Roeck wrote: > > On Thu, Jan 06, 2011 at 07:07:13AM -0500, Mark Brown wrote: > > > > Why? It's not like hwmon has an unreasonably large core or similar. > > > Because it creates an unnecessar

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-06 Thread Mark Brown
On Thu, Jan 06, 2011 at 07:04:30AM -0800, Guenter Roeck wrote: > On Thu, Jan 06, 2011 at 07:07:13AM -0500, Mark Brown wrote: > > Why? It's not like hwmon has an unreasonably large core or similar. > Because it creates an unnecessary dependency, and because it is not hwmon's > responsibility to

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-06 Thread Guenter Roeck
On Thu, Jan 06, 2011 at 07:07:13AM -0500, Mark Brown wrote: > On Wed, Jan 05, 2011 at 09:33:28PM -0800, Guenter Roeck wrote: > > > [...] > > > +EXPORT_SYMBOL_GPL(twl4030_madc_conversion); > > [...] > > > +EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion); > > > No symbol export from hwmon drivers. O

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-06 Thread Mark Brown
On Wed, Jan 05, 2011 at 09:33:28PM -0800, Guenter Roeck wrote: > [...] > > +EXPORT_SYMBOL_GPL(twl4030_madc_conversion); > [...] > > +EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion); > No symbol export from hwmon drivers. Other parts of the kernel > should not depend on HWMON configuration. Why?

Re: [lm-sensors] [PATCH v3] hwmon: twl4030: Driver for twl4030 madc module

2011-01-06 Thread Mark Brown
On Thu, Jan 06, 2011 at 09:26:40AM +0530, Keerthy wrote: > --- > drivers/hwmon/Kconfig| 11 + > drivers/hwmon/Makefile |1 + > drivers/hwmon/twl4030-madc.c | 794 > ++ > include/linux/i2c/twl4030-madc.h | 118 ++ > 4 files