Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-07-02 Thread Hiroshi DOYU
On Wed, 23 Jun 2010 02:29:00 +0200 ext Ohad Ben-Cohen o...@wizery.com wrote: On Wed, Jun 16, 2010 at 8:50 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Ohad Ben-Cohen o...@wizery.com Thanks, I'll prepare them and resubmit You can use the following branch which has accumulateed

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-22 Thread Ohad Ben-Cohen
On Wed, Jun 16, 2010 at 8:50 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Ohad Ben-Cohen o...@wizery.com Thanks, I'll prepare them and resubmit You can use the following branch which has accumulateed unmerged mailbox patches. git://gitorious.org/~doyu/lk/mainline.git

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-15 Thread Hiroshi DOYU
From: ext C.A, Subramaniam subramaniam...@ti.com Subject: RE: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Mon, 14 Jun 2010 17:56:35 +0200 Hi Ohad/Hiroshi, Good to see the new mailbox requirements. While we are at it can we add some more :)? * Make the mailbox

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-15 Thread Hiroshi DOYU
Hi Ohad, From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 15 Jun 2010 06:43:21 +0200 Hi Hiroshi, On Mon, Jun 14, 2010 at 3:58 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: Does dspbridge really need its own defered

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-15 Thread Ohad Ben-Cohen
On Tue, Jun 15, 2010 at 3:04 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: Fair enough. Thanks, I'll prepare them and resubmit -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-15 Thread Hiroshi DOYU
Hi Ohad, From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Wed, 16 Jun 2010 07:09:13 +0200 On Tue, Jun 15, 2010 at 3:04 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: Fair enough. Thanks, I'll prepare them and resubmit You

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-14 Thread Hiroshi DOYU
Hi Ohad, From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Mon, 14 Jun 2010 01:52:16 +0200 On Wed, Jun 9, 2010 at 12:07 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat

RE: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-14 Thread C.A, Subramaniam
; Kanigeri, Hari; linux-omap@vger.kernel.org Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Hi Ohad, From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Mon, 14 Jun 2010 01:52:16 +0200 On Wed, Jun

RE: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-14 Thread Sapiens, Rene
; linux- o...@vger.kernel.org Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Hi Ohad, From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Mon, 14 Jun 2010 01:52:16 +0200 On Wed, Jun 9, 2010 at 12:07

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-14 Thread Felipe Contreras
On Mon, Jun 14, 2010 at 11:58 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Ohad Ben-Cohen o...@wizery.com * Let's make sure no one accidentally registers two receivers on the same time (which would result in one overwriting the other's callback field). I'd like to allow mutiple

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-14 Thread Ohad Ben-Cohen
Hi Hiroshi, On Mon, Jun 14, 2010 at 3:58 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: Does dspbridge really need its own defered work for sending mailbox messages? We do, according to http://permalink.gmane.org/gmane.linux.ports.arm.omap/38240 (thanks Rene for the explanation). For

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-14 Thread Ohad Ben-Cohen
Hi Subbu, On Mon, Jun 14, 2010 at 10:56 AM, C.A, Subramaniam subramaniam...@ti.com wrote: Hi Ohad/Hiroshi, Good to see the new mailbox requirements. While we are at it can we add some more :)? ... Please provide your feedback! Feel free to send the patches ;) Thanks, Ohad. -- To

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-13 Thread Ohad Ben-Cohen
On Wed, Jun 9, 2010 at 12:07 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 87e0cde..1b79b32 100644 --- a/arch/arm/plat-omap/mailbox.c +++ b/arch/arm/plat-omap/mailbox.c @@ -188,7 +188,7 @@ static void

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-08 Thread Felipe Contreras
On Tue, Jun 8, 2010 at 6:46 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Guzman Lugo, Fernando fernando.l...@ti.com I think the best thing to do here is remove the spinlock, if not, you are preventing that omap_mbox_msg_send be executed from a tasklet or isr context. That maybe in

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-08 Thread Felipe Contreras
On Tue, Jun 8, 2010 at 6:55 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 8 Jun 2010 05:11:50 +0200 Hi Deepak, On Mon, Jun 7, 2010 at 6:27 PM, Deepak Chitriki

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-08 Thread Hiroshi DOYU
From: ext Felipe Contreras felipe.contre...@gmail.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 8 Jun 2010 11:43:28 +0200 On Tue, Jun 8, 2010 at 6:46 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote: From: ext Guzman Lugo, Fernando fernando.l...@ti.com I

RE: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-08 Thread Guzman Lugo, Fernando
: mailbox: convert block api to kfifo From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Mon, 7 Jun 2010 23:40:34 +0200 Hi Deepak, On Mon, Jun 7, 2010 at 1:52 PM, Deepak Chitriki deepak.chitr...@ti.com wrote

RE: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-08 Thread Guzman Lugo, Fernando
: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo From: ext Felipe Contreras felipe.contre...@gmail.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 8 Jun 2010 11:43:28 +0200 On Tue, Jun 8, 2010 at 6:46 AM, Hiroshi DOYU hiroshi.d...@nokia.com

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-08 Thread Ohad Ben-Cohen
On Mon, Jun 7, 2010 at 6:14 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: I think the best thing to do here is remove the spinlock I'm afraid we can't do that: we need it to support OMAP4 syslink IPC use cases which have multiple simultaneous sending contexts. , if not, you are

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-08 Thread Hiroshi DOYU
From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 8 Jun 2010 04:54:55 +0200 On Mon, Jun 7, 2010 at 6:14 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: I think the best thing to do here is remove the spinlock I'm

RE: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-08 Thread Guzman Lugo, Fernando
: mailbox: convert block api to kfifo From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 8 Jun 2010 04:54:55 +0200 On Mon, Jun 7, 2010 at 6:14 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: I think the best thing to do

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-07 Thread Deepak Chitriki
Ohad Ben-Cohen wrote: The underlying buffering implementation of mailbox is converted from block API to kfifo due to the simplicity and speed of kfifo. The default size of the kfifo buffer is set to 256 bytes. This value is configurable at compile time (via CONFIG_OMAP_MBOX_KFIFO_SIZE), and can

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-07 Thread Ohad Ben-Cohen
Hi Deepak, On Mon, Jun 7, 2010 at 1:52 PM, Deepak Chitriki deepak.chitr...@ti.com wrote: With this patch I observed inconsistent lock state warning. Thanks for the report! Kfifo is acccessed in omap_mbox_msg_send() and mbox_tx_tasklet() functions.In order to protect this critical section we

RE: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-07 Thread Guzman Lugo, Fernando
Hi, -Original Message- From: Ohad Ben-Cohen [mailto:o...@wizery.com] Sent: Monday, June 07, 2010 4:41 PM To: Chitriki Rudramuni, Deepak; Guzman Lugo, Fernando; Ramirez Luna, Omar; Kanigeri, Hari Cc: linux-omap@vger.kernel.org; Hiroshi Doyu Subject: Re: [PATCH v3 4/4] omap

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-07 Thread Deepak Chitriki
Ohad Ben-Cohen wrote: Hi Deepak, On Mon, Jun 7, 2010 at 1:52 PM, Deepak Chitriki deepak.chitr...@ti.com wrote: With this patch I observed inconsistent lock state warning. Thanks for the report! Kfifo is acccessed in omap_mbox_msg_send() and mbox_tx_tasklet() functions.In order

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-07 Thread Ohad Ben-Cohen
Hi Deepak, On Mon, Jun 7, 2010 at 6:27 PM, Deepak Chitriki deepak.chitr...@ti.com wrote: Ohad Ben-Cohen wrote: Somewhat relevant note about mailbox performance: omap_mbox_msg_send often (i.e. when the kfifo is empty) can just send the message directly, without triggering the tasklet to do

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-07 Thread Hiroshi DOYU
From: ext Guzman Lugo, Fernando fernando.l...@ti.com Subject: RE: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 8 Jun 2010 01:14:41 +0200 Hi, -Original Message- From: Ohad Ben-Cohen [mailto:o...@wizery.com] Sent: Monday, June 07, 2010 4:41 PM To: Chitriki

Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo

2010-06-07 Thread Hiroshi DOYU
From: ext Ohad Ben-Cohen o...@wizery.com Subject: Re: [PATCH v3 4/4] omap: mailbox: convert block api to kfifo Date: Tue, 8 Jun 2010 05:11:50 +0200 Hi Deepak, On Mon, Jun 7, 2010 at 6:27 PM, Deepak Chitriki deepak.chitr...@ti.com wrote: Ohad Ben-Cohen wrote: Somewhat relevant note about