Re: Re: Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-19 Thread Pavel Machek
Hi! > > Nothing relating to setting CISREG_COR (at least on pcnet_cs) changed, and > serial_cs does not modify CISREG_COR on such pseudo-multifunction devices. > > Would it be possible for you to re-check plain 2.6.35 and 2.6.35 with the > pcmcia patchset availble at > http://userweb.kerne

Re: Re: Re: Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-19 Thread Komuro
rg >Subject: Re: Re: Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not > use io_req_t when calling pcmcia_request_io() > > >Hey, > >On Sat, Sep 18, 2010 at 09:50:31PM +0900, Komuro wrote: >> >Also on re-inserting the card (with 2.6.36-rc4+ as of today)? >

Re: Re: Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-18 Thread Dominik Brodowski
Hey, On Sat, Sep 18, 2010 at 09:50:31PM +0900, Komuro wrote: > >Also on re-inserting the card (with 2.6.36-rc4+ as of today)? > > I tried the 2.6.36-rc4-git4. Thanks for testing! > >elese we wouldn't see the "is a 16550A" message, right? > > Even if the COR(Configuration Option Register) of ir

Re: Re: Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-18 Thread Komuro
Hi, >Also on re-inserting the card (with 2.6.36-rc4+ as of today)? I tried the 2.6.36-rc4-git4. The serial part still does not work, before and after re-inserting the card. >elese we wouldn't see the "is a 16550A" message, right? Even if the COR(Configuration Option Register) of irq is not p

Re: Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-18 Thread Dominik Brodowski
Hey, On Sat, Sep 18, 2010 at 07:20:31PM +0900, Komuro wrote: > With this patch, fmvj18x_cs based card works (both network and serial). good. Will push the patch upstream, then. > but Serial part of Xircom card still does not work. Also on re-inserting the card (with 2.6.36-rc4+ as of today)? >

Re: Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-18 Thread Komuro
Hi, With this patch, fmvj18x_cs based card works (both network and serial). but Serial part of Xircom card still does not work. I think the reason is irq or io_width or io_lines is not setuped properly for Xircom-card by pcmcia_core. > > >Hey, > >On Sat, Sep 18, 2010 at 11:48:32AM +0900, Komu

Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-18 Thread Dominik Brodowski
Hey, with 2.6.36-rc4+ (as of today), I see a (similar?) issue: When inserting a multifunction card after reboot for the first time, the serial part does not work. After re-inserting the card, it works. Re-loading the PCMCIA modules does not make the bug re-appear, so I presume the issue to be rela

Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-18 Thread Dominik Brodowski
Hey, On Sat, Sep 18, 2010 at 11:48:32AM +0900, Komuro wrote: > Attached file is dmesg of another multi-function card(fmvj18x_cs) Thanks for the debug output -- this helps a lot! > This card works with 2.6.35 > but does not work with 2.6.36rc3(+patch). does this patch help (at least with the net

Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-17 Thread Komuro
t;To: Komuro >Cc: linux-pcmcia@lists.infradead.org, linux-ser...@vger.kernel.org >Subject: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when > calling pcmcia_request_io() > > >Dear Komuro, > >On Fri, Sep 17, 2010 at 10:06:51PM +0900, Komuro wrote: >> Xirc

Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-17 Thread Dominik Brodowski
Dear Komuro, On Fri, Sep 17, 2010 at 10:06:51PM +0900, Komuro wrote: > Xircom multi-function card still does not work. Huh, that is indeed surprising, as the dmesg has all the usual config descriptions: eth0: Xircom: port 0x300, irq 18, hwaddr 00:10:a4:f3:db:02 ... 0.1: ttyS3 at I/O 0x2e8 (irq =

Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-17 Thread Komuro
org >Subject: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when > calling pcmcia_request_io() > > >Dear Komuro, > >does the attached patch help with 2.6.36-rc4? > >Best, > Dominik > >commit 1852d6b8c3fa2d1765f66cd7d96a8c6bf9f01997 >Author: D

Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-13 Thread Dominik Brodowski
Dear Komuro, does the attached patch help with 2.6.36-rc4? Best, Dominik commit 1852d6b8c3fa2d1765f66cd7d96a8c6bf9f01997 Author: Dominik Brodowski Date: Mon Aug 30 08:18:54 2010 +0200 pcmcia serial_cs.c: fix multifunction card handling We shouldn't overwrite pre-set valu

Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-07 Thread Dominik Brodowski
Dear Komuro, On Tue, Sep 07, 2010 at 09:24:30PM +0900, Komuro wrote: > Attached file is the output of /sys/kernel/debug/dynamic_debug/control. Could you issue $ echo "module pcmcia +p" > /sys/kernel/debug/dynamic_debug/control and (re-)insert the card, and then send the dmesg (probably $ dmes

Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-07 Thread Komuro
Hi, Attached file is the output of /sys/kernel/debug/dynamic_debug/control. kernel 2.6..36-rc3. xirc2pcs_cs multi-function card. # filename:lineno [module]function flags format arch/x86/kernel/cpu/perfctr-watchdog.c:244 [perfctr_watchdog]write_watchdog_counter - "setting %s to -0x%08Lx\012" a

Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-04 Thread Dominik Brodowski
Hey, On Sat, Sep 04, 2010 at 09:03:40PM +0900, Komuro wrote: > >$ echo "module pcmcia +p" > /sys/kernel/debug/dynamic_debug/control > > > > Which kernel .config option do I need to enable dynamic_debug? CONFIG_DYNAMIC_DEBUG=y Then mount debugfs to /sys/kernel/debug, if it isn't done automatical

Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-04 Thread Komuro
Hi, > >$ echo "module pcmcia +p" > /sys/kernel/debug/dynamic_debug/control > Which kernel .config option do I need to enable dynamic_debug? My kernel does not have /sys/kernel/debug/dynamic_debug/control. ___ Linux PCMCIA reimplementation list http:

Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-04 Thread Dominik Brodowski
Dear Komuro, On Tue, Aug 31, 2010 at 09:05:26PM +0900, Komuro wrote: > Hi, > > The serial part still does not work. > > > >does this patch help? If not, could you please enable dynamic debug by > >issuing > > I will try it later. any update on this, by chance? Thanks & best wishes,

Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-08-31 Thread Komuro
Hi, The serial part still does not work. >does this patch help? If not, could you please enable dynamic debug by >issuing I will try it later. > >Hey, > >does this patch help? If not, could you please enable dynamic debug by >issuing > >$ echo "module pcmcia +p" > /sys/kernel/debug/dynamic_de

Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-08-29 Thread Dominik Brodowski
Hey, does this patch help? If not, could you please enable dynamic debug by issuing $ echo "module pcmcia +p" > /sys/kernel/debug/dynamic_debug/control Thanks, Dominik From: Dominik Brodowski Date: Mon, 30 Aug 2010 08:18:54 +0200 Subject: [PATCH] pcmcia: fix multifunction card handlin

Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-08-20 Thread Komuro
Hi >@@ -463,13 +463,13 @@ static int simple_config(struct pcmcia_device *link) > /* If the card is already configured, look up the port and irq */ > if (link->function_config) { > unsigned int port = 0; >- if ((link->io.BasePort2 != 0) && >-

Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-08-20 Thread Komuro
Hi >--- a/drivers/serial/serial_cs.c >+++ b/drivers/serial/serial_cs.c >@@static int serial_probe(struct pcmcia_device *link) > info->p_dev = link; > link->priv = info; > >- link->io.Attributes1 = IO_DATA_PATH_WIDTH_8; >- link->io.NumPorts1 = 8; >+ link->resource[0]->fl

Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-08-14 Thread Dominik Brodowski
Hey, On Sat, Aug 14, 2010 at 08:59:11AM +0900, Komuro wrote: > >@@ -248,9 +248,8 @@ static int fmvj18x_probe(struct pcmcia_device *link) > > lp->base = NULL; > > > > /* The io structure describes IO port mapping */ > >-link->io.NumPorts1 = 32; > >-link->io.Attributes1 = IO_DATA_PA

Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-08-13 Thread Komuro
Hi, >@@ -248,9 +248,8 @@ static int fmvj18x_probe(struct pcmcia_device *link) > lp->base = NULL; > > /* The io structure describes IO port mapping */ >-link->io.NumPorts1 = 32; >-link->io.Attributes1 = IO_DATA_PATH_WIDTH_AUTO; >-link->io.IOAddrLines = 5; >+link->resource[

Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-08-08 Thread Komuro
Hi, > >-link->io.IOAddrLines =10; >-link->io.Attributes1 = IO_DATA_PATH_WIDTH_16; >+link->resource[0]->flags |= IO_DATA_PATH_WIDTH_16; link->io_lines should be set here? >@@ -840,14 +839,15 @@ xirc2ps_config(struct pcmcia_device * link) > } > printk(KNOT_XIRC "no ports