On Thu, Mar 22, 2012 at 3:44 PM, Jason Gunthorpe
wrote:
> For hardware facing structures I'd combine this with a static assert
> to verify structure size at compile time.
>
> So..
>
> 1) Avoid using attributes unless the structure has unaligned members.
> 2) Avoid creating structures with unaligne
On Thu, Mar 22, 2012 at 02:20:28PM -0700, parav.pan...@emulex.com wrote:
> I got a question here lately.
>
> aligned directive will ensure that it will fall on boundary. Say
> aligned(4) ensures that structure is aligned to 4 byte boundary.
> Compiler can (at least theoretically) still have 4 byt
I got a question here lately.
aligned directive will ensure that it will fall on boundary.
Say aligned(4) ensures that structure is aligned to 4 byte boundary.
Compiler can (at least theoretically) still have 4 byte structure aligned to 8
byte boundary on 64-bit platform (which is 4 byte aligned
> -Original Message-
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com]
> Sent: Friday, March 23, 2012 2:28 AM
> To: Pandit, Parav
> Cc: david.lai...@aculab.com; rol...@purestorage.com; linux-
> r...@vger.kernel.org; net...@vger.kernel.org
> Subject: Re: [PATCH 2/9] ocrdma:
On Thu, Mar 22, 2012 at 01:52:30PM -0700, parav.pan...@emulex.com wrote:
> > This can be used to force 32bit alignment in amd64 code in order to match
> > definitions in 32bit userspace.
> > For new things it would make sense to force 64bit alignment of 64bit fields
> > for 32bit code.
>
> o.k. s
> -Original Message-
> From: David Laight [mailto:david.lai...@aculab.com]
> Sent: Wednesday, March 21, 2012 10:02 PM
> To: Roland Dreier; Pandit, Parav
> Cc: linux-rdma@vger.kernel.org; net...@vger.kernel.org
> Subject: RE: [PATCH 2/9] ocrdma: Driver for Emulex OneConnect RDMA
> adapter
> -Original Message-
> From: Roland Dreier [mailto:rol...@purestorage.com]
> Sent: Thursday, March 22, 2012 9:30 PM
> To: Pandit, Parav
> Cc: sean.he...@intel.com; linux-rdma@vger.kernel.org
> Subject: Re: [PATCH 1/9] ocrdma: Driver for Emulex OneConnect RDMA
> adapter
>
> On Thu, Mar 22,
On Wed, 21 Mar 2012, Or Gerlitz wrote:
> Christoph, I will not attend, but will love to get any related
> feedback. Looking on the agenda
> (https://www.openfabrics.org/images/docs/PR/schedule.pdf) I see that
> on Wednesday noon there are two sessions dealing with exactly this -
> "User Mode Ether
On Thu, Mar 22, 2012 at 7:27 AM, wrote:
> I prefer to have it in this first patch and once the internal test cycle is
> finish (with removed code) in few days, will submit the separate patch?
It's fine to leave some of these items for future cleanups post-merge.
Just please try to get to the cl
>> Does OneConnect not support UC? (I thought UC was required for
>> compliance.)
> As of now UC is unsupported. I need to check with other teams. I'll add the
> support in follow on checkin after this initial version, if its supported.
> Is it o.k. if UC is unsupported in this initial release?
> -Original Message-
> From: Hefty, Sean [mailto:sean.he...@intel.com]
> Sent: Wednesday, March 21, 2012 10:49 PM
> To: Pandit, Parav; linux-rdma@vger.kernel.org
> Subject: RE: [PATCH 1/9] ocrdma: Driver for Emulex OneConnect RDMA
> adapter
>
> > +struct ocrdma_cq {
> > + struct ib_cq
Partition enforcement types are in, out, and both.
Prior to this support, both was being used so that is the default.
--
Changes since v2:
Cosmetic changes
Added comments in man, conf file and help
Signed-off-by: Hal Rosenstock
Signed-off-by: Alex Netes
---
include/opensm/osm_
block_num should be less than port's Alias GUID capability.
Signed-off-by: Alex Netes
Signed-off-by: Hal Rosenstock
---
opensm/osm_sa_guidinfo_record.c | 23 +++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/opensm/osm_sa_guidinfo_record.c b/opensm/osm_sa
p_pkey_tbl->accum_pkeys maximal size is 0x1 (last used index is 0x),
so when we itterate over accum_pkeys we should make sure we don't go over the
bounds of uint16_t.
Signed-off-by: Alex Netes
Signed-off-by: Hal Rosenstock
---
opensm/osm_pkey.c |5 +++--
opensm/osm_pkey_mgr.c |
Sending IB_SA_MAD_STATUS_NO_RECORDS for SA GUIDInfo requests with
invalid LID in record identifier.
Signed-off-by: Daniel Klein
Signed-off-by: Alex Netes
Signed-off-by: Hal Rosenstock
---
opensm/osm_sa_guidinfo_record.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a
If the program decides to add a pkey to block 1. It might not allocate memory
for block 0. As a result, when the program searches for a pkey, it might try
access a not allocated block.
Signed-off-by: Daniel Klein
Signed-off-by: Hal Rosenstock
Signed-off-by: Alex Netes
---
opensm/osm_pkey_mgr.c
After internal testing, applied the following list of the patches that were
submitted to the list by Hal Rosenstock.
7fce500 opensm/Makefile.am: Add doc/opensm-sriov.txt to docs
264aeb1 opensm: Add documentation for SRIOV support
c639832 opensm: Enhance osm_physp_share_this_pkey for allow_both_pke
> -Original Message-
> From: Hefty, Sean [mailto:sean.he...@intel.com]
> Sent: Thursday, March 22, 2012 6:14 AM
> To: Pandit, Parav; linux-rdma@vger.kernel.org
> Subject: RE: [PATCH 5/9] ocrdma: Driver for Emulex OneConnect RDMA
> adapter
>
> > +static int ocrdma_inet6addr_event(struct n
Inline.
> -Original Message-
> From: Hefty, Sean [mailto:sean.he...@intel.com]
> Sent: Thursday, March 22, 2012 5:50 AM
> To: Pandit, Parav; linux-rdma@vger.kernel.org
> Subject: RE: [PATCH 4/9] ocrdma: Driver for Emulex OneConnect RDMA
> adapter
>
> > +static inline void *ocrdma_get_eqe(s
19 matches
Mail list logo
