Re: [PATCH v1 00/24] New fast registration API

2015-09-23 Thread Sagi Grimberg
On 9/20/2015 1:45 AM, Christoph Hellwig wrote: Hi Sagi, I've converted the driver I'm developing to your API and it works great. I think this is an important step towards making the RDMA more usable! Thanks Christoph, should I take it as your "Tested-by: " on ib_core + mlx4 changes? -- To un

[PATCH] IB/mlx4: Use vmalloc for WR buffers when needed

2015-09-23 Thread Wengang Wang
There are several hits that WR buffer allocation(kmalloc) failed. It failed at order 3 and/or 4 contigous pages allocation. At the same time there are actually 100MB+ free memory but well fragmented. So try vmalloc when kmalloc failed. Signed-off-by: Wengang Wang --- drivers/infiniband/hw/mlx4/q

Re: [PATCH] IB: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Sagi Grimberg
Christoph, We had a smaller volume move to cache the device attributes on the IB device structure, and I just realized it was dropped on the floor. Ira, that was a reviewer comment you got when worked on OPA and I missed the fact it didn't reach to acceptance http://marc.info/?t=14230931066&r

Re: [PATCH] mlx4: vmalloc for mlx4_ib_wq.wrid and mlx4_ib_srq.wrid

2015-09-23 Thread Wengang Wang
Hi Or, 在 2015年09月24日 13:33, Or Gerlitz 写道: On 9/24/2015 5:10 AM, Wengang Wang wrote: Use __vmalloc to allocate memory for mlx4_ib_wq.wrid and mlx4_ib_srq.wrid. Several hits that the kmalloc for wrid failed with the following like call back stack: Using vmalloc and friends should be done wit

Re: [PATCH] IB: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Or Gerlitz
On 9/23/2015 9:41 PM, Christoph Hellwig wrote: On Wed, Sep 23, 2015 at 10:23:15AM -0700, Chuck Lever wrote: Getting rid of ib_query_device() makes sense. Moving the device attributes into ib_device is nice. Getting rid of ib_device_attr is of questionable value. Why do we need to go there? IB c

Re: [PATCH] mlx4: vmalloc for mlx4_ib_wq.wrid and mlx4_ib_srq.wrid

2015-09-23 Thread Or Gerlitz
On 9/24/2015 5:10 AM, Wengang Wang wrote: Use __vmalloc to allocate memory for mlx4_ib_wq.wrid and mlx4_ib_srq.wrid. Several hits that the kmalloc for wrid failed with the following like call back stack: Using vmalloc and friends should be done with care, specifically, we'd like to go there on

[PATCH] mlx4: vmalloc for mlx4_ib_wq.wrid and mlx4_ib_srq.wrid

2015-09-23 Thread Wengang Wang
Use __vmalloc to allocate memory for mlx4_ib_wq.wrid and mlx4_ib_srq.wrid. Several hits that the kmalloc for wrid failed with the following like call back stack: kworker/u:4: page allocation failure: order:4, mode:0x2000d0 Pid: 16388, comm: kworker/u:4 Not tainted Call Trace: [] warn_alloc_faile

Re: [PATCH] IB: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Christoph Hellwig
On Wed, Sep 23, 2015 at 10:23:15AM -0700, Chuck Lever wrote: > Getting rid of ib_query_device() makes sense. Moving the device > attributes into ib_device is nice. Getting rid of ib_device_attr > is of questionable value. Why do we need to go there? > > IB core API changes generate merge conflicts

Re: [PATCH] IB: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Chuck Lever
Hey Christoph- > On Sep 23, 2015, at 8:52 AM, Christoph Hellwig wrote: > > Avoid the need to query for device attributes and store them in a > separate structure by merging struct ib_device_attr into struct > ib_device. This matches how the device structures are used in most > Linux subsystems

libibverbs-1.2.0-rc1 release

2015-09-23 Thread Doug Ledford
I have done a pre-release of the upcoming libibverbs-1.2.0 release. The code has been pushed to the official git repo and also an -rc1 tarball uploaded to the https://ww.openfabrics.org/downloads/verbs download area. From the tag message: tag libibverbs-1.2.0-rc1 Tagger: Doug Ledford Date: We

Re: [v1 0/2] libmlx4: Add support for checksum offload

2015-09-23 Thread Doug Ledford
On 09/22/2015 04:22 PM, wbd2...@gmail.com wrote: > From: Bodong Wang > > Changes from v1: > * Update patches to use the device_cap_flags to get the checksum offload caps > > Bodong Wang (2): > libmlx4: Update ibv_create_flow/ibv_destroy_flow according to change > of libibverbs > libm

Re: [v1] libibverbs: Add support for checksum offload

2015-09-23 Thread Doug Ledford
On 09/22/2015 04:20 PM, wbd2...@gmail.com wrote: > From: Bodong Wang > > Changes from v1: > * Use the CSUM caps from device_cap_flags rather than defining new fileds > > Bodong Wang (1): > libibverbs: Report checksum offload capabilities > > include/infiniband/verbs.h | 14 -- >

[PATCH] IB: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Christoph Hellwig
Avoid the need to query for device attributes and store them in a separate structure by merging struct ib_device_attr into struct ib_device. This matches how the device structures are used in most Linux subsystems. Signed-off-by: Christoph Hellwig --- drivers/infiniband/core/cm.c

merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Christoph Hellwig
This patch gets rid of struct ib_device_attr and cleans up drivers nicely. It goes on top of my send_wr cleanups and the memory registration udpates from Sagi. [resend that hopefully comes through with the increased message limits] -- To unsubscribe from this list: send the line "unsubscribe lin

Re: message size, was Re: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread 'Christoph Hellwig'
On Wed, Sep 23, 2015 at 10:26:38AM +0200, Yann Droneaud wrote: > Perhaps you could change ib_query_device() to use the ib_device_attr > from struct ib_device so that ulp doesn't have to be modified at the > same time the drivers. Then further patches can update the users of > ib_query_device(), one

RE: message size, was Re: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Steve Wise
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, September 22, 2015 6:08 PM > > > How do we change the message size limits? Reviewing w/o it being > > inline is painful for the (many) reviewers... > > I've increased it. Thanks! -- To unsubscribe

Re: [v1 0/2] Checksum offload capability report

2015-09-23 Thread Doug Ledford
On 09/22/2015 04:18 PM, wbd2...@gmail.com wrote: > From: Bodong Wang > > This series adds kernel support for checksum offload cap report. The first > patch > adds reporting for RAW and RC QPs. Patch 2 sets the capability according to > hardware. > > Changes from v1: > * The cap is reported th

[PATCH for-next 0/2] RDMA/cxgb4: Add iWARP support for T6 adapter

2015-09-23 Thread Hariprasad Shenai
Hi, PATCH 1/2 adds changes like new register, structure and functions in cxgb4 driver for iw_cxgb4 driver, and PATCH 2/2 adds iw_cxgb4 specific code to support T6 adapter. This patch series has been created against Doug's linux tree and includes patches on cxgb4 and iw_cxgb4 driver. We have incl

[PATCH for-next 1/2] cxgb4: T6 adapter lld support for iw_cxgb4 driver

2015-09-23 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 41 +-- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 22 ++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h| 2 + drivers/net/ethernet/chelsio/cxgb4/t4_chip_type.h | 85

[PATCH for-next 2/2] iw_cxgb4: Adds support for T6 adapter

2015-09-23 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/infiniband/hw/cxgb4/cm.c | 317 - drivers/infiniband/hw/cxgb4/device.c | 10 +- drivers/infiniband/hw/cxgb4/provider.c | 2 +- drivers/infiniband/hw/cxgb4/qp.c | 16 +- drivers/infiniband/hw/cxgb4/t4.h

Re: message size, was Re: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Yann Droneaud
Hi, Le mardi 22 septembre 2015 à 23:55 +0200, 'Christoph Hellwig' a écrit : > On Tue, Sep 22, 2015 at 04:06:17PM -0500, Steve Wise wrote: > > Can you create a series of smaller patches that will fit on the > > list? > > That would make it easier for everyone to review/comment. > > I don't see ho