later patchset).
>> (2) Instead of removing qp_attr_mask flags, reserve them.
>> (3) Remove the kref from IB devices in favor of rwsem.
>> (4) Change the name of roce_gid_cache to roce_gid_table.
>> (5) Fix a race when roce_gid_table is free'd while getting events.
>> (6) Remove the roce_gid_cache active/inactive flag/API.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
be the appropriate location to document? In the source itself?
> Somewhere else?
At the function for both write and writev (and a patch to update to
write_iter would be a good next step to keep us in line with qib),
document how each is used and point to the other one and point out that
t
for other kernel generalists that might come
poking around this way. Or, another option would be to drop the write
function altogether and just make all commands come through
writev/write_iter and if you only have one command, you only send one
element. Regardless, those things can be cleaned up in follo
On 07/30/2015 12:50 PM, Jason Gunthorpe wrote:
> On Thu, Jul 30, 2015 at 12:46:52PM -0400, Doug Ledford wrote:
>
>> I've pulled this series in for 4.3. There were some additional items in
>> some of Jason's comments that ought to be looked into, but I think this
On 07/30/2015 01:09 PM, Jason Gunthorpe wrote:
> On Thu, Jul 30, 2015 at 12:59:30PM -0400, Doug Ledford wrote:
>> On 07/30/2015 12:50 PM, Jason Gunthorpe wrote:
>>> On Thu, Jul 30, 2015 at 12:46:52PM -0400, Doug Ledford wrote:
>>>
>>>> I've pul
fprintf(stderr, PFX "Warning: no userspace
> device-specific "
> "driver found for %s\n", sysfs_dev->sysfs_path);
> if (statically_linked)
>
This has been applied, thanks.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
and/hw/mlx4/main.c | 139 ++-
> drivers/infiniband/hw/mlx4/mlx4_ib.h | 13 +
> include/rdma/ib_verbs.h |1 +
> 7 files changed, 714 insertions(+), 137 deletions(-)
>
I've pulled this series in for 4.3. There were some additional items in
some of J
egion).
>>
>>
>
> Series looks good.
>
> Reviewed-by: Steve Wise
I've pulled this in for 4.3.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
able of
running without csum, then send that specific packet without doing a
checksum. If the IP address is not link local, then do the checksum as
normal. That way if our final destination is on the other side of a
router, we aren't leaking un-checksummed packets. It means we woul
On 07/30/2015 05:03 AM, Haggai Eran wrote:
> On 29/07/2015 17:49, Doug Ledford wrote:
>> This doesn't apply on to a clean 4.2-rc4 kernel tree. Can you please
>> rebase against either that or my to-be-rebase/for-4.3 branch of my
>> github repo?
>
> Sure. Keep
c | 7 +-
> drivers/infiniband/core/sa_query.c| 6 +-
> drivers/infiniband/core/ucm.c | 9 +-
> drivers/infiniband/core/user_mad.c| 6 +-
> drivers/infiniband/core/uverbs_main.c | 6 +-
> drivers/infiniband/ulp/ipoib/ipoib_cm.c | 2 +-
> dr
CE
>
> drivers/infiniband/hw/mlx4/ah.c| 6 +-
> drivers/infiniband/hw/mlx4/mcg.c | 15 ++-
> drivers/infiniband/hw/mlx4/sysfs.c | 5 -
> 3 files changed, 19 insertions(+), 7 deletions(-)
>
These all looked fine to me. Picked up for 4.3.
--
til the code is removed from the kernel in a few
> releases.
>
> Reviewed-by: Mike Marciniszyn
> Signed-off-by: Dennis Dalessandro
Thanks, picked up for 4.3.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
ommits/remove-ib_get_dma_mr
Hi Jason,
If you think this is nearing a stable enough state for 4.3, please go
ahead and repost. I'm trying to pull together all of the 4.3 material
and I already have the mlx5 fix you referenced.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
d be to add TCP checksum support to your
firmware for connected mode QPs, so it's possible that in the future the
types of IP CSUM support could grow. This patchset doesn't allow for
that or for distinguishing between hardware that has new or old firmware.
--
Doug Ledford
GPG
On 07/29/2015 10:44 AM, Steve Wise wrote:
> The HW hasn't been sold since 2005, and the SW has definite bit rot.
> Its time to remove it. So move it to staging for a few releases and
> then remove it after that.
>
> Signed-off-by: Steve Wise
Thanks, applied
gt; drivers/infiniband/core/user_mad.c| 6 +-
> drivers/infiniband/core/uverbs_main.c | 6 +-
> drivers/infiniband/ulp/ipoib/ipoib_cm.c | 2 +-
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 236 ++-
> drivers/infiniband/ulp/srp/ib_srp.c | 6 +-
> drivers/infiniband/ulp/srpt/ib_srpt.c | 7 +-
> include/rdma/ib_cm.h | 25 +-
> include/rdma/ib_verbs.h | 33 +-
> net/rds/ib.c | 5 +-
> net/rds/iw.c | 5 +-
> 18 files changed, 1012 insertions(+), 303 deletions(-)
>
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
On 07/29/2015 10:31 AM, Steve Wise wrote:
>
>
>> -Original Message-----
>> From: Doug Ledford [mailto:dledf...@redhat.com]
>> Sent: Wednesday, July 29, 2015 9:28 AM
>> To: Dennis Dalessandro
>> Cc: Steve Wise; linux-rdma@vger.kernel.org
>> Subjec
lloc_fmr(rds_ibdev);
>> -if (IS_ERR(ibmr))
>> +if (IS_ERR(ibmr)) {
>> +rds_ib_dev_put(rds_ibdev);
>> return ibmr;
>> + }
>> ret = rds_ib_map_fmr(rds_ibdev, ibmr, sg, nents);
>> if (ret == 0)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
g/ipath/ipath_user_sdma.h
> similarity index 100%
> rename from drivers/infiniband/hw/ipath/ipath_user_sdma.h
> rename to drivers/staging/ipath/ipath_user_sdma.h
> diff --git a/drivers/infiniband/hw/ipath/ipath_verbs.c
> b/drivers/staging/ipath/ipath_verbs.c
> similarity index 100%
> rename from drivers/infiniband/hw/ipath/ipath_verbs.c
> rename to drivers/staging/ipath/ipath_verbs.c
> diff --git a/drivers/infiniband/hw/ipath/ipath_verbs.h
> b/drivers/staging/ipath/ipath_verbs.h
> similarity index 100%
> rename from drivers/infiniband/hw/ipath/ipath_verbs.h
> rename to drivers/staging/ipath/ipath_verbs.h
> diff --git a/drivers/infiniband/hw/ipath/ipath_verbs_mcast.c
> b/drivers/staging/ipath/ipath_verbs_mcast.c
> similarity index 100%
> rename from drivers/infiniband/hw/ipath/ipath_verbs_mcast.c
> rename to drivers/staging/ipath/ipath_verbs_mcast.c
> diff --git a/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c
> b/drivers/staging/ipath/ipath_wc_ppc64.c
> similarity index 100%
> rename from drivers/infiniband/hw/ipath/ipath_wc_ppc64.c
> rename to drivers/staging/ipath/ipath_wc_ppc64.c
> diff --git a/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c
> b/drivers/staging/ipath/ipath_wc_x86_64.c
> similarity index 100%
> rename from drivers/infiniband/hw/ipath/ipath_wc_x86_64.c
> rename to drivers/staging/ipath/ipath_wc_x86_64.c
>
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
On 07/21/2015 04:45 PM, Doug Ledford wrote:
>
>> On Jul 21, 2015, at 4:42 PM, Dalessandro, Dennis
>> wrote:
>>
>>> -Original Message-
>>> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
>>> ow...@vger.kernel.org] On Behalf Of Do
QPID=0x%0x\n",
> CQE_STATUS(&cqe), CQE_QPID(&cqe));
> - ret = -EINVAL;
> + wc->status = IB_WC_FATAL_ERR;
> }
> }
> out:
>
Accepted for 4.2-rc.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
DESC(mpa_rev, "MPA Revision, 0 supports amso1100, "
> "1 is RFC0544 spec compliant, 2 is IETF MPA Peer Connect Draft"
> - " compliant (default=1)");
> + " compliant (default=2)");
>
> static int marke
.kernel.org
> Reviewed-by: Vinit Agnihotri
> Signed-off-by: Mike Marciniszyn
Thanks, I've picked this up for 4.3.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
off-by: Sagi Grimberg
Thanks, I've picked this up for 4.3.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
gt;ib_device->dma_device)) {
> mutex_unlock(&iser_conn->state_mutex);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Thanks Steve, I'm picking this one up today.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
k);
> -
> - if (mr)
> - break;
> }
>
> if (!mr)
>
Thanks Roland. Picking this up for 4.3 today.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
sport.c |4 ++++
> 9 files changed, 11 insertions(+), 39 deletions(-)
>
Thanks Steve, I'm picking this up for my for-next work today.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
/ocrdma_verbs.c | 53
+--
drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 53
+--
drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 3 +-
14 files changed, 415 insertions(+), 230 deletions(-)
--
Doug Ledford
GPG KeyID: 0E572FDD
On 07/24/2015 10:50 AM, Steve Wise wrote:
>
>
>> -Original Message-
>> From: linux-rdma-ow...@vger.kernel.org
>> [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Doug Ledford
>> Sent: Friday, July 24, 2015 9:45 AM
>> To: Steve Wise
>> Cc:
On 07/23/2015 06:47 PM, Steve Wise wrote:
>> -Original Message- From: Doug Ledford
>> Should this be a static check of the pointer size versus installed
>> memory? Would it be possible to have this work for machines with
>> less than 4GB of physical memory
On 07/23/2015 05:48 PM, Jason Gunthorpe wrote:
> On Thu, Jul 23, 2015 at 05:41:38PM -0400, Doug Ledford wrote:
>
>> I assume this prevents the driver from working at all on certain arches
>> (like ppc with 64k page size)?
>
> Nothing uses page_size_cap correctly, so it
> drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 53 -
> 12 files changed, 409 insertions(+), 229 deletions(-)
Thanks Devesh. I've picked these up and have them slated for 4.2-rc so
that we won't need to track down any additional contributors.
--
Doug Ledford
installed
memory? Would it be possible to have this work for machines with less
than 4GB of physical memory even if they have 64bit pointers, or are you
concerned that hotplug memory could take us over the limit after
registration and cause problems?
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
s the driver from working at all on certain arches
(like ppc with 64k page size)? It looks obviously correct enough that
I've picked it up for 4.2-rc. Thanks.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
>
> cq_attr.cqe = size;
> priv->recv_cq = ib_create_cq(priv->ca, ipoib_ib_completion, NULL,
>
Thanks, applied for 4.2-rc.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
> On Jul 21, 2015, at 4:42 PM, Dalessandro, Dennis
> wrote:
>
>> -Original Message-
>> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
>> ow...@vger.kernel.org] On Behalf Of Doug Ledford
>> Sent: Tuesday, July 21, 2015 2:49 PM
&g
atch that uses git mv to move it to staging and we’ll leave it
there for a release or two and then remove it after that.
—
Doug Ledford
GPG Key ID: 0E572FDD
signature.asc
Description: Message signed with OpenPGP using GPGMail
he copyright change, and in
the commit message clearly document the change you are making, and include all
of the people that you contacted in the Cc: list in the changelog. This will
provide the necessary legal documentation for the change.
> On Thu, Jul 9, 2015 at 2:38 AM, Doug Ledford wr
> On Jul 20, 2015, at 2:31 PM, Chuck Lever wrote:
>
> Hi Doug-
>
> Are you comfortable ack’ing this one? If so, I can carry it in my
> nfs-rdma-for-4.3 series following the patch that removes the last
> ib_reg_phys_mr() call site.
Yes.
Acked-by: Doug Ledford
>
&g
> Signed-off-by: Luis R. Rodriguez
Acked-by: Doug Ledford
—
Doug Ledford
GPG Key ID: 0E572FDD
signature.asc
Description: Message signed with OpenPGP using GPGMail
t; To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
for switches only, to not
using node_type at all across a series of two kernels.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
of note has been done on ehca for a long time, and I wouldn't be
surprised if there is some bit rot in this driver. We need to speak
with IBM, but I think it's a candidate for future removal.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
items
Amir Vadai (1):
IB/IPoIB: Fix bad error flow in ipoib_add_port()
Carol L Soto (1):
IB/ucm: Fix bitmap wrap when devnum > IB_UCM_MAX_DEVICES
Doug Ledford (2):
IB/mlx4: Fix memory leak in do_slave_init
On 07/10/2015 07:34 PM, Jason Gunthorpe wrote:
> On Fri, Jul 10, 2015 at 06:27:59PM -0400, Doug Ledford wrote:
>
>> 1) An RDMA connection exists or can be created (TOE and iSCSI offload do
>> not do this, so something else would have to be listening and accepting
>> i
t;
> Can you explain this conclusion?
I think Tom's comment was referring to the fact that if you have a
trusted client, then a third party attacker can't attack your rkey
because they wouldn't have a QP in your PD and so the rkey would be
invalid for them. Your arguments have be
output
that pointed a big, accusatory finger at the offending module with the
long term goal of reforming the memory registration models to a method
that eliminates this problem in the kernel.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
On 07/10/2015 04:57 PM, Jason Gunthorpe wrote:
> On Fri, Jul 10, 2015 at 01:56:36PM -0400, Doug Ledford wrote:
>
>> Are there security issues? Yes. Are we going to solve them in this
>> patch set? No. Especially since those security issues extend beyond
>> iSER
CEd on
probably a per module basis or something like that.
From there, we can start to look at the bigger picture of cleanup up the
default trust domain in the kernel and user space both (and soliciting
feedback on that...I have a suspicion that some users will not like us
tightening up security as it might interfere with their usage in their
sequestered clusters).
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
redesigns and rearchitecting. Steve, I'm OK
with the cleanup and would prefer that it stay separate from these
larger issues.
Baby steps, one things at a time.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
t for
> the patch to apply -- simply fetch from the latest upstream tree, they're
> there.
>
> Dave, to make it clear, the fix will go through the IB subsystem, as it
> depends on other changes on that area.
I fixed up your commit message slightly (subject was too long),
otherwis
gt; 1. mark the going_down bit.
> 2. flush the wq.
> 3. [make sure no new works for that device.]
> 4. unregister mad agent.
>
> otherwise, works that are already queued can be scheduled after the mad
> agent was freed.
>
> Signed-off-by: Erez Shitrit
Thanks, applied.
--
On 07/09/2015 10:02 AM, Or Gerlitz wrote:
> On 7/9/2015 3:31 PM, Doug Ledford wrote:
>>> i Doug,
>>> >
>>> >I'd like Jack to review this before we ack, not sure if he's in today,
>>> >so he might get to look on that only on Sunday.
>
, have all of our work structs batched up, take the
spin_lock once and only once, and do all of the batch under the one
spin_lock invocation instead of incurring all of the locked memory cycles
we would otherwise incur to take/release the spin_lock over and over
again.
Signed-off-by: Doug Ledford
ff-by: Doug Ledford
---
drivers/infiniband/hw/mlx4/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/infiniband/hw/mlx4/main.c
b/drivers/infiniband/hw/mlx4/main.c
index 064454aee863..1c59e4749736 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/m
On 07/09/2015 06:49 AM, Or Gerlitz wrote:
> On Thu, Jul 9, 2015 at 1:36 AM, Doug Ledford wrote:
>> Thanks, both applied.
>
> to where?!
To my tree. The fact that I've taken it in does not mean I have pushed
the tree out yet. The set of rc fixes has not yet passed my bu
On 07/09/2015 04:28 AM, Or Gerlitz wrote:
> On 7/9/2015 1:30 AM, Doug Ledford wrote:
>> In mlx4_main.c:do_slave_init(), the function is supposed to queue up
>> each work struct. However, it checks to make sure the sriov support
>> isn't going down first. When it is go
On 07/02/2015 01:49 PM, Tatyana Nikolova wrote:
> Neighbor resolution doesn't work without this fix
>
> Signed-off-by: Tatyana Nikolova
Thanks, applied.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
sing
> rdma_[start end]_port rather than the open coding
> previously used.
>
> Reviewed-by: Sean Hefty
> Reviewed-By: Jason Gunthorpe
> Reviewed-by: Ira Weiny
> Tested-by: Ira Weiny
> Signed-off-by: Hal Rosenstock
> ---
> Identical to RFCv2 patch with additional R
if (opa_drslid != OPA_LID_PERMISSIVE &&
> + if (opa_drslid != be32_to_cpu(OPA_LID_PERMISSIVE) &&
> opa_drslid & 0x) {
> ret = -EINVAL;
> dev_err(&device->dev, "OPA Invalid dr_slid 0x%x\n",
>
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
t; + * @reg: The given registration type to compare with
> *
> * Call iwpm_register_pid() to register a client
> + * Returns true if the client registration matches reg,
> + * otherwise returns false
> + */
> +u32 iwpm_check_registration(u8 nl_client, u32 reg);
> +
> +/**
> + * iwpm_set_registration - Set the client registration
> + * @nl_client: The index of the netlink client
> + * @reg: Registration type to set
> */
> -int iwpm_registered_client(u8 nl_client);
> +void iwpm_set_registration(u8 nl_client, u32 reg);
>
> /**
> - * iwpm_set_registered - Set the port mapper client to registered or not
> + * iwpm_get_registration
> * @nl_client: The index of the netlink client
> - * @reg: 1 if registered or 0 if not
> + *
> + * Returns the client registration type
> */
> -void iwpm_set_registered(u8 nl_client, int reg);
> +u32 iwpm_get_registration(u8 nl_client);
>
> /**
> * iwpm_send_mapinfo - Send local and mapped IPv4/IPv6 address info of
>
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
ipoib: Prevent lockdep warning in __ipoib_ib_dev_flush
>
> drivers/infiniband/core/ucma.c | 4 ++--
> drivers/infiniband/ulp/ipoib/ipoib_ib.c | 13 +++--
> 2 files changed, 9 insertions(+), 8 deletions(-)
>
Thanks, both applied.
--
Doug Ledford
GPG KeyID: 0E572FD
gt; - (((u32)mac_addr[0]) << 16) | (u32)mac_addr[1]);
> + (((u32)mac_addr[0]) << 8) | (u32)mac_addr[1]);
> } else {
> cqp_wqe->wqe_words[NES_CQP_ARP_WQE_MAC_ADDR_LOW_IDX] = 0;
> cqp_wqe->
done under the spin lock
and then release it.
Signed-off-by: Doug Ledford
---
drivers/infiniband/hw/mlx4/main.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/main.c
b/drivers/infiniband/hw/mlx4/main.c
index 064454aee863..3f21a
On 07/08/2015 12:23 AM, Maninder Singh wrote:
> Hello,
>
>>> + for (i = 0; i < dev->caps.num_ports; i++)
>>> + kfree(dm[i]);
>>> goto out;
>>> }
>>> }
>>> --
>>> 1.7.9.5
>>>
>>
>> If you are going to change this, you m
exactly and only the devices
for which the original memory allocation succeeded and free just those.
Signed-off-by: Maninder Singh
Signed-off-by: Doug Ledford
>
> Signed-off-by: Maninder Singh
> ---
> drivers/infiniband/hw/mlx4/main.c |8 +++-
> 1 file change
On 07/08/2015 11:23 AM, Johannes Thumshirn wrote:
> Destroy ocrdma_dev_id IDR on module exit, reclaiming the allocated memory.
>
Thanks, applied.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
On 07/08/2015 11:21 AM, Johannes Thumshirn wrote:
> Destroy multcast_idr on moudle exit, reclaiming the allocated memory.
Thanks, applied.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
On 07/08/2015 04:25 PM, Christoph Hellwig wrote:
> On Wed, Jul 08, 2015 at 04:15:00PM -0400, Doug Ledford wrote:
>> On 07/08/2015 04:02 PM, Christoph Hellwig wrote:
>>> So how about someone tells OFED to stop trying to enforce this BS?
>>
>> Unfortunately, simply &quo
e the bylaw, which usually involves its own
draconian process.
> This just confirms my byass that Open-Fabrics Alliance are a bunch of
> idiots making life hard, similar to all their horrible OFED driver
> distributions that crated a total mess for everyone involved.
--
Doug Ledford
They need to comply with the
OFA bylaws, but because of the way GPL requirements play out and the
fact that this code only works as part of the linux kernel, it's only
ever in use in GPL situations. It's really the user space code where
people wanted the BSD option. I presume that make
contributor's
patches would need to be analyzed by a competent attorney in this area
and all of the contributors with patches that are not exempted would
have to be contacted.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
kfree(dm[i]);
> goto out;
> }
> }
> --
> 1.7.9.5
>
If you are going to change this, you might as well make it 100% correct:
i—-;
while (i >= 0)
kfree(dm[i]);
Then you don’t have to worry about whethe
h.
>
> Reviewed-by: Bart Van Assche
Picked up for 4.2-rc, thanks!
—
Doug Ledford
GPG Key ID: 0E572FDD
signature.asc
Description: Message signed with OpenPGP using GPGMail
etif_queue_stopped(dev))
> netif_wake_queue(dev);
> @@ -868,7 +877,7 @@ int ipoib_ib_dev_stop(struct net_device *dev)
> while ((int) priv->tx_tail - (int) priv->tx_head < 0) {
> tx_req = &priv->tx_ring[priv->tx_tail &
> (ipoib_sendq_size - 1)];
> - ipoib_dma_unmap_tx(priv->ca, tx_req);
> + ipoib_dma_unmap_tx(priv, tx_req);
> dev_kfree_skb_any(tx_req->skb);
> ++priv->tx_tail;
> --priv->tx_outstanding;
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index 9e1b203..4ee2784 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -190,7 +190,7 @@ static netdev_features_t ipoib_fix_features(struct
> net_device *dev, netdev_featu
> struct ipoib_dev_priv *priv = netdev_priv(dev);
>
> if (test_bit(IPOIB_FLAG_ADMIN_CM, &priv->flags))
> - features &= ~(NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO);
> + features &= ~(NETIF_F_IP_CSUM | NETIF_F_TSO);
>
> return features;
> }
> --
> 1.7.1
>
—
Doug Ledford
GPG Key ID: 0E572FDD
signature.asc
Description: Message signed with OpenPGP using GPGMail
On 07/06/2015 09:35 AM, Jeff Squyres (jsquyres) wrote:
> On Jun 17, 2015, at 10:25 AM, Doug Ledford
> wrote:
>>
>> The patch is accepted, I just haven’t pushed it out yet.
>
> Is there a timeline for when this patch will be available in the
> upstream git repo and r
ese commits
> have been tested and confirmed to resolve
> http://bugs.launchpad.net/bugs/1467912 .
>
>
> commit be7aa663fc1d9156798f5af3c60e6df45e1fe5de
> Author: Doug Ledford
> Date: Sat Feb 21 19:27:00 2015 -0500
>
> IB/ipo
gt; I agree.
>
> Ok, then I'll do this:
>
> 1) series with iser changes to enable iwarp including mlx/ipath/qib patches
> to set max_sge_rd
> 2) series on transport independent access flags / memory reg - updating the
> kernel ULPs too.
I've quickly reviewed the series and you plan here seems fine. I'm
bouncing this out of my queue and will wait for the next version.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: OpenPGP digital signature
: Remove !ch->target tests from the reconnect code
IB/srp: Add 64-bit LUN support
IB/ipoib: Fix RCU annotations in ipoib_neigh_hash_init()
Colin Ian King (1):
RDMA/ocrdma: fix double free on pd
Dan Carpenter (1):
IB/usnic: clean up some error handling code
Doug Ledford
> On Jun 14, 2015, at 10:31 AM, Or Gerlitz wrote:
>
> On Sat, Jun 13, 2015 at 8:35 AM, Doug Ledford wrote:
>> I ran across a problem today when I went to do some run tests of my
>> for-4.2 tree. For a second there, I was about to seriously have a
>> conniption fit
> On Jun 16, 2015, at 5:05 PM, Liran Liss wrote:
>
>> From: Doug Ledford [mailto:dledf...@redhat.com]
>
>>> No. RoCE is as an open standard from the IBTA with the exact same RDMA
>> protocol semantics as InfiniBand and a clear set of compliancy rules without
&g
On Jun 3, 2015, at 12:50 PM, Doug Ledford wrote:
>>
>> On Mon, 2015-06-01 at 22:02 +, Jeff Squyres (jsquyres) wrote:
>>> On May 22, 2015, at 9:44 AM, Doug Ledford wrote:
>>>>
>>>>> Did that happen yet?
>>>>
>>>> I
On 06/14/2015 03:16 PM, Liran Liss wrote:
>> From: Doug Ledford [mailto:dledf...@redhat.com]
>
>>> But the node_type stands for more than just an abstract RDMA device:
>>> In IB, it designates an instance of an industry-standard, well-defined,
>> device type: it
8
And I'm guessing that your internal regression tests must not have a
machine in IB/Eth SRIOV mode as a standard config. I would consider
adding it to the mix. I have it myself, but only on a few machines and
I don't always use them for initial testing.
--
Doug Ledford
On 06/12/2015 04:24 PM, Carol Soto wrote:
>
>
> On 6/12/2015 3:08 PM, Doug Ledford wrote:
>> On 06/11/2015 12:06 PM, cls...@linux.vnet.ibm.com wrote:
>>> From: Carol L Soto
>>>
>>> ib_ucm_release_dev clears wrong bit if devnum is greater than
>>&g
On 06/11/2015 12:06 PM, cls...@linux.vnet.ibm.com wrote:
> From: Carol L Soto
>
> ib_ucm_release_dev clears wrong bit if devnum is greater than
> IB_UCM_MAX_DEVICES.
>
> Signed-off-by: Carol L Soto
> ---
> drivers/infiniband/core/ucm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(
On 06/11/2015 07:08 PM, Mike Marciniszyn wrote:
> This patch series adds the OPA gen1 driver.
>
> The patch depends on the this MAD patch series:
>
> https://patchwork.kernel.org/patch/6584551/
This patchset has now been picked up. Just to make things work
smoothly, especially since I know you
On 06/06/2015 02:38 PM, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> The following patch series modifies the kernel MAD processing (ib_mad/ib_umad)
> and related interfaces to send and receive Intel Omni-Path Architecture MADs
> on
> devices which support them.
>
> OPA MADs share the same c
On 06/11/2015 09:35 AM, Or Gerlitz wrote:
> Hi Doug,
>
> This patchset adds the kernel control path for completion timestamping
> support by user-space verbs consumers.
>
> Timestamping is used by applications in order to know when a WQE was
> received/transmitted by the HW. The value is given
On 06/10/2015 12:31 PM, Fabian Frederick wrote:
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick
Thanks, applied.
> ---
> drivers/infiniband/hw/mthca/mthca_profile.c | 8 ++--
> 1 file changed, 2 insertions(+
On 06/11/2015 02:27 PM, Liran Liss wrote:
>> From: Doug Ledford [mailto:dledf...@redhat.com]
>
>>>>> OPA cannot impersonate IB; OPA node and link types have to be
>>>>> designated as such. In terms of MAD processing flows, both
>>>>> explici
On 06/11/2015 03:54 PM, Borislav Petkov wrote:
> On Thu, Jun 11, 2015 at 10:50:01AM -0700, Luis R. Rodriguez wrote:
>> From: "Luis R. Rodriguez"
>>
>> There is no good reason not to, we eventually delete it as well.
>>
>> Cc: Toshi Kani
>> Cc: Roland Dreier
>> Cc: Sean Hefty
>> Cc: Hal Rosensto
On Thu, 2015-06-11 at 09:08 -0500, Steve Wise wrote:
> > -Original Message-
> > From: linux-rdma-ow...@vger.kernel.org
> > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Doug Ledford
> > Sent: Thursday, June 11, 2015 12:01 AM
> > To: Haripr
a/ocrdma_verbs.c
> @@ -679,7 +679,6 @@ err:
> ocrdma_release_ucontext_pd(uctx);
> } else {
> status = _ocrdma_dealloc_pd(dev, pd);
> - kfree(pd);
> }
> exit:
> return ERR_PTR(status);
Thanks, applied.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: This is a digitally signed message part
;
> - if (WARN_ON(!rdma_cap_ib_sa(handler->device, port->port_num)))
> + if (!rdma_cap_ib_sa(handler->device, port->port_num))
> return;
>
> spin_lock_irqsave(&port->ah_lock, flags);
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: This is a digitally signed message part
hernet/chelsio/cxgb4/sge.c| 4 +-
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 7 +--
> 10 files changed, 109 insertions(+), 75 deletions(-)
>
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: This is a digitally signed message part
On Wed, 2015-06-10 at 21:57 -0600, Jason Gunthorpe wrote:
> On Wed, Jun 10, 2015 at 09:06:28PM -0400, Doug Ledford wrote:
>
> > People tend to push the "patches should be small, self contained,
> > incremental" ideal. In some cases, that gets carried to an extreme
el.org] On Behalf Of Hefty, Sean
> > Sent: Wednesday, June 10, 2015 12:10 PM
> > To: Or Gerlitz; Doug Ledford; Jason Gunthorpe
> > Cc: Matan Barak; Moni Shoua; Somnath Kotur; linux-rdma@vger.kernel.org
> > Subject: RE: [PATCH for-next V5 00/12] Move RoCE GID management to
&g
t; v6 is the best effort *team Mellanox* can put forward.
>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: This is a digitally signed message part
301 - 400 of 778 matches
Mail list logo
