Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-21 Thread Roland Dreier
On Thu, Oct 17, 2013 at 8:29 AM, Yann Droneaud ydrone...@opteya.com wrote: Just to double check, by no means we are talking on reverting the whole series, flow-steering will be in 3.12 in the IB core and mlx4_ib Correct, just hiding the unstable userspace ABI for now. I believe it will

Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-17 Thread Or Gerlitz
On 16/10/2013 03:04, Roland Dreier wrote: On Tue, Oct 15, 2013 at 2:34 PM, Or Gerlitz or.gerl...@gmail.com wrote: Roland, after applying a small fix which was sent to you by Matan on Sep 22nd + another tiny fix by Yann to Matan's patch (the two can be surely squashed into one small patch),

Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-17 Thread Yann Droneaud
Hi Or, Le 17.10.2013 11:19, Or Gerlitz a écrit : On 16/10/2013 03:04, Roland Dreier wrote: On Tue, Oct 15, 2013 at 2:34 PM, Or Gerlitz or.gerl...@gmail.com wrote: Roland, after applying a small fix which was sent to you by Matan on Sep 22nd + another tiny fix by Yann to Matan's patch (the two

Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-15 Thread Yann Droneaud
Hi Roland, Le 14.10.2013 20:19, Roland Dreier a écrit : On Mon, Oct 14, 2013 at 8:46 AM, Yann Droneaud ydrone...@opteya.com wrote: Let's try for inclusion in v3.12-rc6 Hi everyone. First of sorry for being incommunicado for so long, been swamped with a lot of stuff. Anyway, given that

Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-15 Thread Roland Dreier
On Tue, Oct 15, 2013 at 7:08 AM, Yann Droneaud ydrone...@opteya.com wrote: But, in the mean time, we failed at providing the required fixes/cleanups before v3.12-rc5. We have not agreed on a definitive, small, urgent patchset for v3.12-rc5. And I think, and it's easy to think so, that Linus

Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-15 Thread Yann Droneaud
Hi Roland, Le 15.10.2013 18:44, Roland Dreier a écrit : On Tue, Oct 15, 2013 at 7:08 AM, Yann Droneaud ydrone...@opteya.com wrote: But, in the mean time, we failed at providing the required fixes/cleanups before v3.12-rc5. We have not agreed on a definitive, small, urgent patchset for

Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-15 Thread Or Gerlitz
On Tue, Oct 15, 2013 at 7:44 PM, Roland Dreier rol...@purestorage.com wrote: I agree. So as I said before, I think the best idea is just to disable the half-baked command extension stuff before 3.12, and get things right for 3.13. Roland, after applying a small fix which was sent to you by

Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-15 Thread Roland Dreier
On Tue, Oct 15, 2013 at 2:34 PM, Or Gerlitz or.gerl...@gmail.com wrote: Roland, after applying a small fix which was sent to you by Matan on Sep 22nd + another tiny fix by Yann to Matan's patch (the two can be surely squashed into one small patch), things are working OK. Yann is suggesting to

Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-14 Thread Matan Barak
On 11/10/2013 8:19 PM, Yann Droneaud wrote: Flow spec length don't depend on the size of the command header: they are part of different layers. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http://marc.info/?i=ver.1381510045.git.ydrone...@opteya.com Link:

Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-14 Thread Yann Droneaud
Hi, Le 14.10.2013 17:21, Matan Barak a écrit : On 11/10/2013 8:19 PM, Yann Droneaud wrote: Flow spec length don't depend on the size of the command header: they are part of different layers. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link:

Re: [PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-14 Thread Roland Dreier
On Mon, Oct 14, 2013 at 8:46 AM, Yann Droneaud ydrone...@opteya.com wrote: Let's try for inclusion in v3.12-rc6 Hi everyone. First of sorry for being incommunicado for so long, been swamped with a lot of stuff. Anyway, given that everyone seems to agree we want something along the lines of

[PATCH 3/9] IB/core: Don't include command header size in uverbs create_flow

2013-10-11 Thread Yann Droneaud
Flow spec length don't depend on the size of the command header: they are part of different layers. Signed-off-by: Yann Droneaud ydrone...@opteya.com Link: http://marc.info/?i=cover.1381510045.git.ydrone...@opteya.com Link: http://mid.gmane.org/cover.1381510045.git.ydrone...@opteya.com ---