Re: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-09-11 Thread Upinder Malhi (umalhi)
Hi Or, The GRH is emulated by software. That is, when the app receives a packet, the first 40 bytes contain the GRH. Upinder On Sep 11, 2013, at 12:19 PM, Or Gerlitz wrote: > So you are supporting UD QPs but these QPs don't generate IBTA UD > headers nor iWARP headers, correct? -- To

Re: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-09-11 Thread Or Gerlitz
On 12/09/2013 00:07, Upinder Malhi (umalhi) wrote: Hi Or, The GRH is emulated by software. That is, when the app receives a packet, the first 40 bytes contain the GRH. I was asking what protocol you are using in the Ethernet MAC header on the wire? Or. On Sep 11, 2013, at 12:19

RE: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-09-12 Thread Hefty, Sean
> We are using the RoCE ethertype in the MAC frames, and that is all of the > similarity between usNIC protocol and RoCE. L3 is not the GRH, but rather > a usNIC L3 header. Customers can distinguish between RoCE traffic and > usNIC traffic by looking at the version of the L3 frame. It is set to

Re: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-09-12 Thread Upinder Malhi (umalhi)
We are using the RoCE ethertype in the MAC frames, and that is all of the similarity between usNIC protocol and RoCE. L3 is not the GRH, but rather a usNIC L3 header. Customers can distinguish between RoCE traffic and usNIC traffic by looking at the version of the L3 frame. It is set to 6 for

Re: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-09-13 Thread Upinder Malhi (umalhi)
Hi Sean, We selected version 8 because it is unused - not a standard version and not in use by anyone. Upinder On Sep 12, 2013, at 10:02 AM, "Hefty, Sean" wrote: >> We are using the RoCE ethertype in the MAC frames, and that is all of the >> similarity between usNIC protocol and RoCE.

Re: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-12-10 Thread Roland Dreier
On Mon, Sep 9, 2013 at 8:38 PM, Upinder Malhi (umalhi) wrote: > +/*TODO: Future - usnic_modify_qp needs to pass in generic filters */ > +struct usnic_ib_create_qp_resp { > + u32 vfid; > + u32 qp_grp_id; > + u64

Re: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-12-10 Thread Roland Dreier
On Mon, Sep 9, 2013 at 8:38 PM, Upinder Malhi (umalhi) wrote: > +static ssize_t summary_show(struct usnic_ib_qp_grp *qp_grp, char *buf) > +{ > + int i, j, n; > + int left; > + char *ptr; > + struct usnic_vnic_res_chunk *res_chunk; > + struct usnic_fwd_filter_hndl *def

Re: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-12-10 Thread Upinder Malhi (umalhi)
Ack. That's a bug. Will fix. Upinder On Dec 10, 2013, at 1:14 PM, Roland Dreier wrote: > On Mon, Sep 9, 2013 at 8:38 PM, Upinder Malhi (umalhi) > wrote: >> +/*TODO: Future - usnic_modify_qp needs to pass in generic filters */ >> +struct usnic_ib_create_qp_resp { >> + u32

Re: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-12-10 Thread Upinder Malhi (umalhi)
Roland, All the values don't have to be in one file. We can have one value per file; we thought it wouldn't be efficent to have one value per file bc 1) these values are related and 2) it is socially acceptable to have multiple values per file. Some of these provide critical informatio