RE: [PATCH V2 for-next 1/4] IB/core: Add receive Flow Steering support

2013-06-27 Thread Hefty, Sean
The TCP/IP filters are broken into separate filters based in L4/L3. It would seem to make sense if the IB filters were similarly divided into L2/L3/L4 filters. IB and IPv6 could probably share the same filter definition. IPv6 filters wasn't defined through this submission, but as I

Re: [PATCH V2 for-next 1/4] IB/core: Add receive Flow Steering support

2013-06-27 Thread Or Gerlitz
On Thu, Jun 27, 2013 at 12:33 AM, Steve Wise sw...@opengridcomputing.com wrote: On 6/26/2013 4:13 PM, Or Gerlitz wrote: On Wed, Jun 26, 2013 at 10:56 PM, Hefty, Sean sean.he...@intel.com Steering rules processing order is according to rules priority. The user sets the 12 low-order bits from

Re: [PATCH V2 for-next 1/4] IB/core: Add receive Flow Steering support

2013-06-27 Thread Or Gerlitz
On Thu, Jun 27, 2013 at 11:55 PM, Hefty, Sean sean.he...@intel.com wrote: My point was that the IPv6 filter should be defined and used here. The following basic filters were defined: ethernet - src/dst mac ... ip -src/dst ip tcp/udp - src/dst port These are at

RE: [PATCH V2 for-next 1/4] IB/core: Add receive Flow Steering support

2013-06-27 Thread Hefty, Sean
Still for the initial set of patches that goes in I tend to just remove the IB filter structure and define the different IB filters along your proposal in a follow-up patches/es, OK? That sounds fine to me. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a

[PATCH V2 for-next 1/4] IB/core: Add receive Flow Steering support

2013-06-26 Thread Or Gerlitz
From: Hadar Hen Zion had...@mellanox.com The RDMA stack allows for applications to create IB_QPT_RAW_PACKET QPs, for which plain Ethernet packets are used, specifically packets which don't carry any QPN to be matched by the receiving side. Applications using these QPs must be provided with a

RE: [PATCH V2 for-next 1/4] IB/core: Add receive Flow Steering support

2013-06-26 Thread Hefty, Sean
The input to ib_create_flow is instance of struct ib_flow_attr which contain few mandatory control elements and optional flow specs. struct ib_flow_attr { enum ib_flow_attr_type type; u16 size; u16 priority; u8 num_of_specs; u8 port;

Re: [PATCH V2 for-next 1/4] IB/core: Add receive Flow Steering support

2013-06-26 Thread Or Gerlitz
On Wed, Jun 26, 2013 at 10:56 PM, Hefty, Sean sean.he...@intel.com wrote: The input to ib_create_flow is instance of struct ib_flow_attr which contain few mandatory control elements and optional flow specs. struct ib_flow_attr { enum ib_flow_attr_type type; u16 size;

Re: [PATCH V2 for-next 1/4] IB/core: Add receive Flow Steering support

2013-06-26 Thread Steve Wise
On 6/26/2013 4:13 PM, Or Gerlitz wrote: On Wed, Jun 26, 2013 at 10:56 PM, Hefty, Sean sean.he...@intel.com wrote: The input to ib_create_flow is instance of struct ib_flow_attr which contain few mandatory control elements and optional flow specs. struct ib_flow_attr { enum