Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-14 Thread Doug Ledford
On 08/14/2015 12:20 PM, Bart Van Assche wrote: > On 08/14/2015 06:36 AM, Doug Ledford wrote: >> On 08/11/2015 04:50 PM, Bart Van Assche wrote: >>> On 08/01/2015 01:05 PM, Doug Ledford wrote: On 07/31/2015 07:14 PM, Jason Gunthorpe wrote: > On Fri, Jul 31, 2015 at 04:04:35PM -0700, Bart Van

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-14 Thread Bart Van Assche
On 08/14/2015 06:36 AM, Doug Ledford wrote: On 08/11/2015 04:50 PM, Bart Van Assche wrote: On 08/01/2015 01:05 PM, Doug Ledford wrote: On 07/31/2015 07:14 PM, Jason Gunthorpe wrote: On Fri, Jul 31, 2015 at 04:04:35PM -0700, Bart Van Assche wrote: With only patches 1/12 and 8/12 applied my te

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-14 Thread Doug Ledford
On 08/11/2015 04:50 PM, Bart Van Assche wrote: > On 08/01/2015 01:05 PM, Doug Ledford wrote: >> On 07/31/2015 07:14 PM, Jason Gunthorpe wrote: >>> On Fri, Jul 31, 2015 at 04:04:35PM -0700, Bart Van Assche wrote: >>> With only patches 1/12 and 8/12 applied my test passes. >>> >>> Thanks Bart! >

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-11 Thread Bart Van Assche
On 08/01/2015 01:05 PM, Doug Ledford wrote: On 07/31/2015 07:14 PM, Jason Gunthorpe wrote: On Fri, Jul 31, 2015 at 04:04:35PM -0700, Bart Van Assche wrote: With only patches 1/12 and 8/12 applied my test passes. Thanks Bart! If you like, I can try and work on #9 (no promises :(), but I thin

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-06 Thread Bart Van Assche
On 08/05/2015 09:36 PM, Jason Gunthorpe wrote: On Wed, Aug 05, 2015 at 05:19:10PM -0700, Bart Van Assche wrote: A few experimental and untested patches are available for review at https://github.com/bvanassche/linux/tree/srp-initiator-for-next-experimental. I'll leave this is in your hands the

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-05 Thread Jason Gunthorpe
On Wed, Aug 05, 2015 at 05:19:10PM -0700, Bart Van Assche wrote: > A few experimental and untested patches are available for review at > https://github.com/bvanassche/linux/tree/srp-initiator-for-next-experimental. I'll leave this is in your hands then.. Thanks, Jason -- To unsubscribe from this

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-05 Thread Bart Van Assche
On 08/05/2015 05:10 PM, Jason Gunthorpe wrote: On Wed, Aug 05, 2015 at 03:41:46PM -0700, Bart Van Assche wrote: Regarding the discussion in 2011 about FMR (http://thread.gmane.org/gmane.linux.drivers.rdma/7149): since in 2011 nobody recalled the root cause of the issue with non-page aligned FMR

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-05 Thread Jason Gunthorpe
On Wed, Aug 05, 2015 at 03:41:46PM -0700, Bart Van Assche wrote: > Regarding the discussion in 2011 about FMR > (http://thread.gmane.org/gmane.linux.drivers.rdma/7149): since in 2011 > nobody recalled the root cause of the issue with non-page aligned FMR my > proposal is to drop the page alignment

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-05 Thread Bart Van Assche
On 08/05/2015 02:45 PM, Bart Van Assche wrote: On 08/05/2015 12:51 PM, Jason Gunthorpe wrote: On Tue, Aug 04, 2015 at 11:41:16PM -0700, David Dillow wrote: On Tue, 2015-08-04 at 12:09 -0600, Jason Gunthorpe wrote: On Mon, Aug 03, 2015 at 11:33:51AM -0700, Bart Van Assche wrote: Bart, do you k

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-05 Thread Bart Van Assche
On 08/05/2015 12:51 PM, Jason Gunthorpe wrote: On Tue, Aug 04, 2015 at 11:41:16PM -0700, David Dillow wrote: On Tue, 2015-08-04 at 12:09 -0600, Jason Gunthorpe wrote: On Mon, Aug 03, 2015 at 11:33:51AM -0700, Bart Van Assche wrote: Bart, do you know what hardware this workaround is for? I ho

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-05 Thread Jason Gunthorpe
On Tue, Aug 04, 2015 at 11:41:16PM -0700, David Dillow wrote: > On Tue, 2015-08-04 at 12:09 -0600, Jason Gunthorpe wrote: > > On Mon, Aug 03, 2015 at 11:33:51AM -0700, Bart Van Assche wrote: > > > >Bart, do you know what hardware this workaround is for? > > > > > > I hope the HW vendors can commen

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-05 Thread David Dillow
On Tue, 2015-08-04 at 12:09 -0600, Jason Gunthorpe wrote: > On Mon, Aug 03, 2015 at 11:33:51AM -0700, Bart Van Assche wrote: > > >Bart, do you know what hardware this workaround is for? > > > > I hope the HW vendors can comment on this. Sorry but I'm not sure which HCA > > models and/or firmware v

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-04 Thread Jason Gunthorpe
On Mon, Aug 03, 2015 at 11:33:51AM -0700, Bart Van Assche wrote: > >Bart, do you know what hardware this workaround is for? > > I hope the HW vendors can comment on this. Sorry but I'm not sure which HCA > models and/or firmware versions do not support FMR mapping with a non-zero > offset. Perhap

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-03 Thread Bart Van Assche
On 08/03/2015 08:24 AM, Christoph Hellwig wrote: On Fri, Jul 31, 2015 at 03:20:40PM -0700, Bart Van Assche wrote: SRP login fails with this patch series applied on top of Linux kernel v4.2-rc4. At the target side the following message appears every time the SRP initiator tries to log in: "ib_srp

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-03 Thread Christoph Hellwig
On Fri, Jul 31, 2015 at 03:20:40PM -0700, Bart Van Assche wrote: > On 07/30/2015 04:22 PM, Jason Gunthorpe wrote: > >All patches are compile tested. I've done basic testing up to and including > >the IPoIB patch, the rest required specialized setups I don't have access to, > >but are fairly straigh

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-08-01 Thread Doug Ledford
On 07/31/2015 07:14 PM, Jason Gunthorpe wrote: > On Fri, Jul 31, 2015 at 04:04:35PM -0700, Bart Van Assche wrote: > >> With only patches 1/12 and 8/12 applied my test passes. > > Thanks Bart! > > If you like, I can try and work on #9 (no promises :(), but I think > I'll need some way to test it

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-07-31 Thread Bart Van Assche
On 07/31/2015 04:14 PM, Jason Gunthorpe wrote: Do you by chance have a straightforward recipe to setup SRP and SRPT on two Linux's for this simple purpose? Some time ago I wrote a script that loads the upstream SRP target driver and creates two LUNs for local RAM disks (attached to this e-mail

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-07-31 Thread Jason Gunthorpe
On Fri, Jul 31, 2015 at 04:04:35PM -0700, Bart Van Assche wrote: > With only patches 1/12 and 8/12 applied my test passes. Thanks Bart! If you like, I can try and work on #9 (no promises :(), but I think I'll need some way to test it here. Do you by chance have a straightforward recipe to setu

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-07-31 Thread Bart Van Assche
On 07/31/2015 03:32 PM, Jason Gunthorpe wrote: On Fri, Jul 31, 2015 at 03:20:40PM -0700, Bart Van Assche wrote: On 07/30/2015 04:22 PM, Jason Gunthorpe wrote: All patches are compile tested. I've done basic testing up to and including the IPoIB patch, the rest required specialized setups I don'

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-07-31 Thread Jason Gunthorpe
On Fri, Jul 31, 2015 at 03:20:40PM -0700, Bart Van Assche wrote: > On 07/30/2015 04:22 PM, Jason Gunthorpe wrote: > >All patches are compile tested. I've done basic testing up to and including > >the IPoIB patch, the rest required specialized setups I don't have access to, > >but are fairly straigh

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-07-31 Thread Bart Van Assche
On 07/30/2015 04:22 PM, Jason Gunthorpe wrote: All patches are compile tested. I've done basic testing up to and including the IPoIB patch, the rest required specialized setups I don't have access to, but are fairly straightforward. Hello Jason, SRP login fails with this patch series applied o

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-07-31 Thread Steve Wise
Series looks good. Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-07-31 Thread Christoph Hellwig
Hi Jason, this series look fine to me, although I don't feel comfortable enough to give a Reviewed-by: tag for the RDMA subsystem yet. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

[PATCH v2 00/12] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey

2015-07-30 Thread Jason Gunthorpe
This series moves dealing with the safe all physical mr: ib_get_dma_mr(pd,IB_ACCESS_LOCAL_WRITE); Into ib_alloc_pd, and in the process makes the global local_dma_lkey functionality broadly enabled for all ULPs. The remaining users of ib_get_dma_mr are all unsafe: drivers/infiniband/ulp/iser/