RE: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-24 Thread Moni Shoua
en; e...@openfabrics.org; linux-rdma@vger.kernel.org; Tziporet Koren; Yiftah Shahar Subject: Re: [ewg] [PATCH v4] IB Core: RAW ETH support > There is no qp type IBV_QPT_RAW_ETY in user space (at least not in the definitions > coming with libibverbs). In fact, libibverbs that comes with OFED defines (in verbs

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-23 Thread Roland Dreier
> There is no qp type IBV_QPT_RAW_ETY in user space (at least not in the > definitions > coming with libibverbs). In fact, libibverbs that comes with OFED defines > (in verbs.h) > a qp type called IBV_QPT_RAW_ETT which equals to 7. > The patch that is under discussion here adds a new qp typ

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-17 Thread Doug Ledford
On 06/16/2010 01:12 PM, Steve Wise wrote: > Jason Gunthorpe wrote: >> On Wed, Jun 16, 2010 at 09:09:59AM -0500, Steve Wise wrote: >> >> >>> Granted our dev process may not be documented, but I always assumed >>> the general idea was to get changes accepted upstream, then pull into >>> ofed. OFED

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-17 Thread Doug Ledford
On 06/16/2010 02:35 PM, Steve Wise wrote: > Jason Gunthorpe wrote: >> On Wed, Jun 16, 2010 at 12:12:06PM -0500, Steve Wise wrote: >> >> > Granted our dev process may not be documented, but I always assumed > the general idea was to get changes accepted upstream, then pull > into ofed.

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-16 Thread Steve Wise
Jason Gunthorpe wrote: On Wed, Jun 16, 2010 at 12:12:06PM -0500, Steve Wise wrote: Granted our dev process may not be documented, but I always assumed the general idea was to get changes accepted upstream, then pull into ofed. OFED is just a mechanism to make top-of-tree linux work on dist

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-16 Thread Jason Gunthorpe
On Wed, Jun 16, 2010 at 12:12:06PM -0500, Steve Wise wrote: >>> Granted our dev process may not be documented, but I always assumed >>> the general idea was to get changes accepted upstream, then pull into >>> ofed. OFED is just a mechanism to make top-of-tree linux work on >>> distro kernels.

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-16 Thread Steve Wise
Jason Gunthorpe wrote: On Wed, Jun 16, 2010 at 09:09:59AM -0500, Steve Wise wrote: Granted our dev process may not be documented, but I always assumed the general idea was to get changes accepted upstream, then pull into ofed. OFED is just a mechanism to make top-of-tree linux work on distr

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-16 Thread Jason Gunthorpe
On Wed, Jun 16, 2010 at 09:09:59AM -0500, Steve Wise wrote: > Granted our dev process may not be documented, but I always assumed the > general idea was to get changes accepted upstream, then pull into ofed. > OFED is just a mechanism to make top-of-tree linux work on distro > kernels. There ar

RE: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-16 Thread Tung, Chien Tin
> >> It doesn't even look like this patch and the mlx4 patch were ever posted > >> to linux-rdma. Only to the EWG list. > >> > >> > > Not 100% correct. See thread from April 30. > > Patches to core, libibverbs and NES driver were presented there. > > > > > > I'll go look, but I thought the NES stu

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-16 Thread Steve Wise
Moni Shoua wrote: It doesn't even look like this patch and the mlx4 patch were ever posted to linux-rdma. Only to the EWG list. Not 100% correct. See thread from April 30. Patches to core, libibverbs and NES driver were presented there. I'll go look, but I thought the NES stuff

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-16 Thread Moni Shoua
> > > It doesn't even look like this patch and the mlx4 patch were ever posted > to linux-rdma. Only to the EWG list. > Not 100% correct. See thread from April 30. Patches to core, libibverbs and NES driver were presented there. > Granted our dev process may not be documented, but I always as

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-16 Thread Moni Shoua
Hi Roland, > What the hell is the thinking behind introducing IB_QPT_RAW_ETH? You're > inserting an enum value before IB_QPT_RAW_ETY, so any old userspace > passing in IB_QPT_RAW_ETY will silently get different behavior depending > on the kernel version. And you're creating two constands that di

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-16 Thread Steve Wise
Roland Dreier wrote: > I tested it before on the Roland tree ( iboe branch ) and it fails, > because it writen in the way suitable for OFED. If adapt the patch to > the Roland tree, then appling Mellanox OFED patches will fail, because > it changes the same functions in the code. > Here is o

Re: [ewg] [PATCH v4] IB Core: RAW ETH support

2010-06-15 Thread Roland Dreier
> I tested it before on the Roland tree ( iboe branch ) and it fails, > because it writen in the way suitable for OFED. If adapt the patch to > the Roland tree, then appling Mellanox OFED patches will fail, because > it changes the same functions in the code. > Here is one example: > Look at