Re: [PATCH v2] drm: rcar-du: calculate DPLLCR to be more small jitter

2017-12-13 Thread Kuninori Morimoto
Hi Laurent Thank you for your feedback > > +* NOTES > > +* N = (n + 1), M = (m + 1), P = 2 > > +* 2000 < fvco < 4096Mhz > > Are you sure that the fvco constraint is really 2kHz, and not 2GHz ? 2kHz - > 4GHz would be a surprisingly large range. It is 2kHz. This is came fr

Re: [RFC PATCH 1/3] kms-tests: Provide .gitignore

2017-12-13 Thread Kieran Bingham
On 14/12/17 00:25, Kieran Bingham wrote: > From: Kieran Bingham Ahem - Please excuse that person - he's not meant to be working. > From: Kieran Bingham This guy is. One day I'll acknowledge that my e-mail aliasing is completely overcomplicated. -- George (Must be one of my other alter-egos)

[RFC PATCH 2/3] rcar_vin: Provide VIN configuration helpers

2017-12-13 Thread Kieran Bingham
From: Kieran Bingham From: Kieran Bingham To handle capturing frames through the RCar VIN subsystem we must correctly configure the device links and identify the device nodes to capture from. Implement a helper class to abstract and handle the VIN objects Signed-off-by: Kieran Bingham --- t

[RFC PATCH 3/3] tests: Add a DU->VIN loopback test

2017-12-13 Thread Kieran Bingham
From: Kieran Bingham From: Kieran Bingham Provide an initial test which outputs an image over HDMI using the R-Car DU, and captures from HDMI-in on the same board. This test is targetted specifically to the Salvator-X(S) with an ADV748x HDMI input, and the R-Car VIN driver as a capture interfa

[RFC PATCH 0/3] [RFC] Video HDMI Loop-back Test

2017-12-13 Thread Kieran Bingham
From: Kieran Bingham This short series works towards providing automated system validation by introducing the ability to capture frames using the R-Car VIN device with an HDMI cable connected to our HDMI output of the DU. To support this test, relevant patches and support must be provided by kms

[RFC PATCH 1/3] kms-tests: Provide .gitignore

2017-12-13 Thread Kieran Bingham
From: Kieran Bingham From: Kieran Bingham Provide an initial .gitignore file to hide python related files that may be created in an active workspace Signed-off-by: Kieran Bingham --- .gitignore | 4 1 file changed, 4 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore

Re: [PATCH] kmstest.py: Update to th latest kmsxx Python bindings

2017-12-13 Thread Kieran Bingham
Hi Laurent, Thankyou for this patch. It successfully allows me to use the latest kmsxx, rather than a much older base that I had been sat on. Your commit title could do with an 'e' after 'th', but otherwise this patch is good :D On 07/12/17 18:33, Laurent Pinchart wrote: > Commit 706a44abb3aa ("

Re: [PATCH 0/4] kms++util: Provide validation helpers

2017-12-13 Thread Kieran Bingham
Hi Tomi, Apologies that I didn't make it particularly clear, but I should have prefixed this series title with a nice big [RFC] :-D This is ongoing work to support loop-back validation on our platforms. Regards Kieran On 13/12/17 23:10, Kieran Bingham wrote: > From: Kieran Bingham > > Our km

[PATCH 4/4] kms++util: Add frame compare functionality

2017-12-13 Thread Kieran Bingham
From: Kieran Bingham Provide a means to compare two identically sized framebuffers. This basic implementation expects the two buffers to have the same formats and sizes, and will return zero for identical frames, or a positive float representing and average difference otherwise. Signed-off-by:

[PATCH 0/4] kms++util: Provide validation helpers

2017-12-13 Thread Kieran Bingham
From: Kieran Bingham Our kms-tests test suite for verifying the R-Car DU is based on kmsxx. We are implementing a 'loop-back' validator, by providing an HDMI cable from the display output directly into the HDMI receiver on the same development board. By using the existing VideoStreamer and pyvi

[PATCH 1/4] videodevice: Fix minor spacing

2017-12-13 Thread Kieran Bingham
From: Kieran Bingham Provide a space between the return type and the function definition Signed-off-by: Kieran Bingham --- kms++util/src/videodevice.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kms++util/src/videodevice.cpp b/kms++util/src/videodevice.cpp index e2191

[PATCH 2/4] py: pyvid: Provide stream_off binding

2017-12-13 Thread Kieran Bingham
From: Kieran Bingham The videodevice module defines a stream_off function call, but this is not available in the python bindings interface. Provide the binding of VideoStreamer::stream_off. Signed-off-by: Kieran Bingham --- py/pykms/pyvid.cpp | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 3/4] kms++util: Add verification module

2017-12-13 Thread Kieran Bingham
From: Kieran Bingham Provide a util module to provide helpers involved in validation and verification of data frames. The first addition is a raw frame binary output with bindings to python modelled on Tomi's implementation in wbcap. Signed-off-by: Kieran Bingham --- kms++util/inc/kms++util/k

[PATCH/RFC v1.1] drm: rcar-du: Allow importing non-contiguous dma-buf with VSP

2017-12-13 Thread Laurent Pinchart
When the DU sources its frames from a VSP, it performs no memory access and thus has no requirements on imported dma-buf memory types. In particular the DU could import a physically non-contiguous buffer that would later be mapped contiguously through the VSP IOMMU. This use case isn't supported a

[PATCH 4/4] spi: sh-msiof: Document hardware limitations related to chip selects

2017-12-13 Thread Geert Uytterhoeven
Guide users to maintain the proper balance between native and GPIO chip selects. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/spi/sh-msiof.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/spi/sh-msiof.txt b/Document

[PATCH 1/4] spi: sh-msiof: Avoid writing to registers from spi_master.setup()

2017-12-13 Thread Geert Uytterhoeven
The spi_master.setup() callback must not change configuration registers, as that could corrupt I/O that is in progress for other SPI slaves. The only exception is the configuration of the native chip select polarity in SPI master mode, as a wrong chip select polarity will cause havoc during all fu

[PATCH 0/4] spi: sh-msiof: Multi-slave enhancements

2017-12-13 Thread Geert Uytterhoeven
Hi MarkĀ², Rob, This patch series enhances the Renesas MSIOF SPI controller driver for multiple SPI slave devices. The first patch fixes the classical pitfall of writing to configuration registers from the spi_master.setup() callback, where possible. The second patch extends support from 1

[PATCH 2/4] spi: sh-msiof: Extend support to 3 native chip selects

2017-12-13 Thread Geert Uytterhoeven
Currently only the MSIOF_SYNC signal can be used as a native chip select. Extend support to up to 3 native chipselects using the MSIOF_SS1 and MSIOF_SS2 signals. Inspired by a patch in the BSP by Hiromitsu Yamasaki. Signed-off-by: Geert Uytterhoeven --- Documentation/devicetree/bindings/spi/sh

[PATCH 3/4] spi: sh-msiof: Implement cs-gpios configuration

2017-12-13 Thread Geert Uytterhoeven
The current support for GPIO chip selects assumes the GPIOs have been configured by platform code or the boot loader. This includes pinmux setup and GPIO direction. Hence it does not work as expected when just described in DT using the "cs-gpios" property. Fix this by: 1. using devm_gpiod_get_

[PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

2017-12-13 Thread Jacopo Mondi
The v4l2-async module operations are quite complex to follow, due to the asynchronous nature of subdevices and notifiers registration and matching procedures. In order to help with debugging of failed or erroneous matching between a subdevice and the notifier collected async_subdevice it gets match

[PATCH 3/5] include: v4l2_async: Add 'owner' field to notifier

2017-12-13 Thread Jacopo Mondi
Notifiers can be registered as root notifiers (identified by a 'struct v4l2_device *') or subdevice notifiers (identified by a 'struct v4l2_subdev *'). In order to identify a notifier no matter if it is root or not, add a 'struct fwnode_handle *owner' field, whose name can be printed out for debug

[PATCH 1/5] v4l: async: Use endpoint node, not device node, for fwnode match

2017-12-13 Thread Jacopo Mondi
From: Sakari Ailus V4L2 async framework can use both device's fwnode and endpoints's fwnode for matching the async sub-device with the sub-device. In order to proceed moving towards endpoint matching assign the endpoint to the async sub-device. As most async sub-device drivers (and the related h

[PATCH 2/5] device property: Add fwnode_get_name() operation

2017-12-13 Thread Jacopo Mondi
Add operation to retrieve the device name from a fwnode handle. Signed-off-by: Jacopo Mondi --- drivers/acpi/property.c | 6 ++ drivers/base/property.c | 12 drivers/of/property.c| 6 ++ include/linux/fwnode.h | 2 ++ include/linux/property.h | 1 + 5 files chang

[PATCH 4/5] v4l2: async: Postpone subdev_notifier registration

2017-12-13 Thread Jacopo Mondi
Currently, subdevice notifiers are tested against all available subdevices as soon as they get registered. It often happens anyway that the subdevice they are connected to is not yet initialized, as it usually gets registered later in drivers' code. This makes debug of v4l2_async particularly painf

[PATCH 0/5] Add debug output to v4l2-async

2017-12-13 Thread Jacopo Mondi
Hello Sakari, while testing rcar-vin setup on top of your RFC (included in the series) that moves the framework to perform endpoint matching, I realized how hard is to follow what happens with asynchronous notifiers, sub-notifiers and sub-devices. In order to better understand what happens and

Re: [PATCH] mmc: renesas_sdhi: Add MODULE_LICENSE

2017-12-13 Thread Wolfram Sang
On Wed, Dec 13, 2017 at 11:33:00AM +0900, Yoshihiro Shimoda wrote: > From: Masaharu Hayakawa > > The following error occurs when loading renesas_sdhi_core.c module, > so add MODULE_LICENSE("GPL v2"). > > renesas_sdhi_core: module license 'unspecified' taints kernel. > > Signed-off-by: Masaharu

Re: [PATCH] Revert "ravb: add workaround for clock when resuming with WoL enabled"

2017-12-13 Thread David Miller
From: Geert Uytterhoeven Date: Mon, 11 Dec 2017 09:54:09 +0100 > This reverts commit fbf3d034f2ff6264183cfa6845770e8cc2a986c8. > > As of commit 560869100b99a3da ("clk: renesas: cpg-mssr: Restore module > clocks during resume"), the workaround is no longer needed. > > Signed-off-by: Geert Uytter

Applied "ASoC: rsnd: Add device tree support for r8a774[35]" to the asoc tree

2017-12-13 Thread Mark Brown
The patch ASoC: rsnd: Add device tree support for r8a774[35] has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and se

Re: [PATCH 3/6] i2c: add 'set_sda' to bus_recovery_info

2017-12-13 Thread Andy Shevchenko
On Tue, 2017-12-05 at 16:31 +0100, Linus Walleij wrote: > On Tue, Dec 5, 2017 at 2:38 PM, Wolfram Sang > wrote: > > Two statice inlines in > named > > int gpiod_is output() > int gpiod_is_input() Ha, just proposed similar. > > should conform to Rusty Russell's API hierarchy. > > Intereste

Re: [PATCH 3/6] i2c: add 'set_sda' to bus_recovery_info

2017-12-13 Thread Andy Shevchenko
On Mon, 2017-12-04 at 13:36 +0100, Wolfram Sang wrote: > This will be needed when we want to create STOP conditions, too, > later. > Create the needed fields and populate them for the GPIO case if the > GPIO > is set to output. > +#include > #include I think it should be not done like this. (Y

Re: [PATCH 2/6] i2c: add identifier in declarations for i2c_bus_recovery

2017-12-13 Thread Andy Shevchenko
On Mon, 2017-12-04 at 13:36 +0100, Wolfram Sang wrote: > No reason to have them undefined, so let's add them. > > int (*recover_bus)(struct i2c_adapter *); > > - int (*get_scl)(struct i2c_adapter *); > - void (*set_scl)(struct i2c_adapter *, int val); > - int (*get_sda)(struct

Re: [PATCH] gpio: Add helpers to determin direction of gpiods

2017-12-13 Thread Wolfram Sang
> > You need to fix the kerneldoc for 'gpiod_get_direction", too. It still > > mentions GPIOF_DIR_*. > > More places? I can't find them! drivers/gpio/gpiolib.c Line 198 in both 4.15-rc3 and linux-next. Or as I said, the kerneldoc of gpiod_get_direction ;) > Together with Geert's comments I st

Re: [PATCH] gpio: Add helpers to determin direction of gpiods

2017-12-13 Thread Linus Walleij
On Tue, Dec 12, 2017 at 11:42 PM, Wolfram Sang wrote: >> Documentation/gpio/consumer.txt | 14 +++--- > > You need to fix the kerneldoc for 'gpiod_get_direction", too. It still > mentions GPIOF_DIR_*. More places? I can't find them! I thought the patch removed that here: -This function

Re: [PATCH v2] ASoC: rsnd: Add device tree support for r8a774[35]

2017-12-13 Thread Geert Uytterhoeven
On Wed, Dec 13, 2017 at 2:35 PM, Biju Das wrote: > Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME] > (r8a774[35]) sound modules are identical to the R-Car Gen2 family. > No driver change is needed as the fallback compatible string > "renesas,rcar_sound-gen2" activates the ri

[PATCH v2] ASoC: rsnd: Add device tree support for r8a774[35]

2017-12-13 Thread Biju Das
Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME] (r8a774[35]) sound modules are identical to the R-Car Gen2 family. No driver change is needed as the fallback compatible string "renesas,rcar_sound-gen2" activates the right code in the driver. Signed-off-by: Biju Das Reviewed

Re: [PATCH 1/2] dt-bindings: thermal: rcar: Add device tree support for r8a7743

2017-12-13 Thread Geert Uytterhoeven
On Wed, Dec 13, 2017 at 11:57 AM, Biju Das wrote: > Add thermal sensor support for r8a7743 SoC. The Renesas RZ/G1M > (r8a7743) thermal sensor module is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,rcar-gen2-thermal". > > Signed-

RE: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]

2017-12-13 Thread Biju Das
Hi all, Thanks for the feedback, I will send a v2. Regards, Biju > -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: 13 December 2017 12:56 > To: Geert Uytterhoeven > Cc: Biju Das ; Liam Girdwood > ; Rob Herring ; Mark Rutland > ; Simon Horman ; Magnus > Damm ; C

Re: [PATCH v1 07/10] v4l: i2c: Copy ov772x soc_camera sensor driver

2017-12-13 Thread Philippe Ombredanne
Jacopo, On Wed, Nov 15, 2017 at 11:56 AM, Jacopo Mondi wrote: > Copy the soc_camera based driver in v4l2 sensor driver directory. > This commit just copies the original file without modifying it. > > Signed-off-by: Jacopo Mondi > --- /dev/null > +++ b/drivers/media/i2c/ov772x.c > @@ -0,0 +1,1

Re: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]

2017-12-13 Thread Mark Brown
On Wed, Dec 13, 2017 at 01:34:40PM +0100, Geert Uytterhoeven wrote: > The confusing part here is that for most[*] subsystems, patches touching > only DT bindings should have a "dt-bindings" prefix, while patches touching > both DT bindings and driver code should have the drivers' subsystem prefix.

Re: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]

2017-12-13 Thread Geert Uytterhoeven
Hi Mark, On Wed, Dec 13, 2017 at 1:20 PM, Mark Brown wrote: > On Tue, Dec 12, 2017 at 06:09:15PM +, Biju Das wrote: >> Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME] >> (r8a774[35]) sound modules are identical to the R-Car Gen2 family. >> No driver change is needed as

Re: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]

2017-12-13 Thread Mark Brown
On Tue, Dec 12, 2017 at 06:09:15PM +, Biju Das wrote: > Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME] > (r8a774[35]) sound modules are identical to the R-Car Gen2 family. > No driver change is needed as the fallback compatible string > "renesas,rcar_sound-gen2" activate

Re: [PATCH v1 10/10] media: i2c: tw9910: Remove soc_camera dependencies

2017-12-13 Thread Hans Verkuil
On 15/11/17 11:56, Jacopo Mondi wrote: > Remove soc_camera framework dependencies from tw9910 sensor driver. > - Handle clock directly > - Register async subdevice > - Add platform specific enable/disable functions > - Adjust build system > > This commit does not remove the original soc_camera bas

Re: [PATCH v1 07/10] v4l: i2c: Copy ov772x soc_camera sensor driver

2017-12-13 Thread Hans Verkuil
On 15/11/17 11:56, Jacopo Mondi wrote: > Copy the soc_camera based driver in v4l2 sensor driver directory. > This commit just copies the original file without modifying it. > > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/ov772x.c | 1124 > >

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

2017-12-13 Thread Hans Verkuil
On 15/11/17 11:55, Jacopo Mondi wrote: > Add driver for Renesas Capture Engine Unit (CEU). > > The CEU interface supports capturing 'data' (YUV422) and 'images' > (NV[12|21|16|61]). > > This driver aims to replace the soc_camera based sh_mobile_ceu one. > > Tested with ov7670 camera sensor, prov

[PATCH 2/2] ARM: dts: r8a7743: Add thermal device to DT

2017-12-13 Thread Biju Das
This patch instantiates the thermal sensor module with thermal-zone support. This patch is based on the commit cac68a56e34b ("ARM: dts: r8a7791: enable to use thermal-zone") by Kuninori Morimoto. Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro --- arch/arm/boot/dts/r8a7743.dtsi | 32 +

[PATCH 1/2] dt-bindings: thermal: rcar: Add device tree support for r8a7743

2017-12-13 Thread Biju Das
Add thermal sensor support for r8a7743 SoC. The Renesas RZ/G1M (r8a7743) thermal sensor module is identical to the R-Car Gen2 family. No driver change is needed due to the fallback compatible value "renesas,rcar-gen2-thermal". Signed-off-by: Biju Das Reviewed-by: Fabrizio Castro --- Documentat

[PATCH 0/2] Add thermal support for iWave RZ/G1M board

2017-12-13 Thread Biju Das
This series aims to add thermal support for iWave RZ/G1M board. This patch series based on renesas tag renesas-devel-20171211-v4.15-rc3. Biju Das (2): dt-bindings: thermal: rcar: Add device tree support for r8a7743 ARM: dts: r8a7743: Add thermal device to DT .../devicetree/bindings/thermal/

Re: arm64: unhandled level 0 translation fault

2017-12-13 Thread Will Deacon
Hi Geert, Thanks for trying to bisect this. On Tue, Dec 12, 2017 at 09:54:05PM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 12, 2017 at 5:57 PM, Will Deacon wrote: > > Do you reckon you can bisect between -rc1 and -rc2? We've been unable to > > reproduce this on any of our systems, unfortunate

Re: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]

2017-12-13 Thread Geert Uytterhoeven
On Tue, Dec 12, 2017 at 7:09 PM, Biju Das wrote: > Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME] > (r8a774[35]) sound modules are identical to the R-Car Gen2 family. > No driver change is needed as the fallback compatible string > "renesas,rcar_sound-gen2" activates the ri

RE: [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support

2017-12-13 Thread Fabrizio Castro
Hello Geert, thank you for your feedback. > Hi Fabrizio, > > On Wed, Dec 13, 2017 at 10:42 AM, Fabrizio Castro > wrote: > >> On Tue, Dec 12, 2017 at 06:49:38PM +, Fabrizio Castro wrote: > >> > Add CMT[01] support to SoC DT. > >> > Signed-off-by: Fabrizio Castro > >> > Reviewed-by: Biju Das

Re: [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support

2017-12-13 Thread Geert Uytterhoeven
Hi Fabrizio, On Wed, Dec 13, 2017 at 10:42 AM, Fabrizio Castro wrote: >> On Tue, Dec 12, 2017 at 06:49:38PM +, Fabrizio Castro wrote: >> > Add CMT[01] support to SoC DT. >> > Signed-off-by: Fabrizio Castro >> > Reviewed-by: Biju Das >> > --- >> > arch/arm/boot/dts/r8a7743.dtsi | 30 +++

Re: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support

2017-12-13 Thread Geert Uytterhoeven
Hi Fabrizio, On Tue, Dec 12, 2017 at 7:49 PM, Fabrizio Castro wrote: > Document SoC specific compatible strings for r8a7743 and r8a7745. > No driver change is needed as the fallback strings will activate > the right code. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das With the issue

RE: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support

2017-12-13 Thread Fabrizio Castro
Hello Simon, thank you for the feedback. I'll apply your comments to V2, but I'll wait for your reply on the CMT "enable by default" issue. Thanks, Fab > Subject: Re: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document > r8a774[35] CMT support > > On Tue, Dec 12, 2017 at 06:49:37PM +, F

RE: [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support

2017-12-13 Thread Fabrizio Castro
Hello Simon, thank you for your feedback. > On Tue, Dec 12, 2017 at 06:49:38PM +, Fabrizio Castro wrote: > > Add CMT[01] support to SoC DT. > > > > Signed-off-by: Fabrizio Castro > > Reviewed-by: Biju Das > > --- > > arch/arm/boot/dts/r8a7743.dtsi | 30 ++ > > 1

RE: [PATCH 0/5] Add Sound support for iWave RZ/G1M board

2017-12-13 Thread Biju Das
Hi Simon, Thanks. There is a typo in the documentation dependency link. The correct one is https://patchwork.kernel.org/patch/10108015/ Regards, Biju > -Original Message- > From: Simon Horman [mailto:ho...@verge.net.au] > Sent: 13 December 2017 09:03 > To: Biju Das > Cc: Rob Herring ;

Re: [PATCH 2/5] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling

2017-12-13 Thread Sergei Shtylyov
Hello! On 12/13/2017 9:27 AM, Yoshihiro Shimoda wrote: This patch unifies the OBINTEN handling to clean-up the code. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/dr

Re: [PATCH v2] drm: rcar-du: calculate DPLLCR to be more small jitter

2017-12-13 Thread Laurent Pinchart
Hello Morimoto-san, Thank you for the patch. On Wednesday, 6 December 2017 08:05:38 EET Kuninori Morimoto wrote: > From: Kuninori Morimoto > > In general, PLL has VCO (= Voltage controlled oscillator), > one of the very important electronic feature called as "jitter" > is related to this VCO. >

Re: [PATCH 0/5] Add Sound support for iWave RZ/G1M board

2017-12-13 Thread Simon Horman
On Tue, Dec 12, 2017 at 06:25:06PM +, Biju Das wrote: > This series aims to add sound support for iWave RZ/G1M board. > > This patch series has documentation dependency on > https://patchwork.kernel.org/patch/10108014/ > > Biju Das (5): > ARM: shmobile: defconfig: Enable SGTL5000 audio cod

Re: [PATCH 5/5] phy: renesas: rcar-gen3-usb2: add gpio handling

2017-12-13 Thread Geert Uytterhoeven
Hi Shimoda-san, On Wed, Dec 13, 2017 at 7:27 AM, Yoshihiro Shimoda wrote: > Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS > and ID. So, they may be connected to gpio pins. To handle the gpio > pins, this patch adds the handling of VBUS and ID pins instead of > dedicated pins

Re: [PATCH 3/3] ARM: dts: r8a7745: Add CMT SoC specific support

2017-12-13 Thread Simon Horman
On Tue, Dec 12, 2017 at 06:49:39PM +, Fabrizio Castro wrote: > Add CMT[01] support to SoC DT. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das > --- > arch/arm/boot/dts/r8a7745.dtsi | 30 ++ > 1 file changed, 30 insertions(+) Please see my review of th

Re: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support

2017-12-13 Thread Simon Horman
On Tue, Dec 12, 2017 at 06:49:37PM +, Fabrizio Castro wrote: > Document SoC specific compatible strings for r8a7743 and r8a7745. > No driver change is needed as the fallback strings will activate > the right code. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das > --- > Documentat

Re: [PATCH 2/3] ARM: dts: r8a7743: Add CMT SoC specific support

2017-12-13 Thread Simon Horman
On Tue, Dec 12, 2017 at 06:49:38PM +, Fabrizio Castro wrote: > Add CMT[01] support to SoC DT. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das > --- > arch/arm/boot/dts/r8a7743.dtsi | 30 ++ > 1 file changed, 30 insertions(+) I was expecting the cmt no

Re: [PATCH 2/3] arm64: dts: renesas: r8a7796: move nodes which have no reg property out of bus

2017-12-13 Thread Geert Uytterhoeven
Hi Simon, On Wed, Dec 13, 2017 at 9:25 AM, Simon Horman wrote: > For now I've applied the following: > > From: Simon Horman > Date: Tue, 12 Dec 2017 09:24:35 +0100 > Subject: [PATCH] arm64: dts: renesas: r8a7796: move nodes which have no reg > property out of bus > > Move pmu_a5[73], timer and

Re: [PATCH] mmc: renesas_sdhi: Add MODULE_LICENSE

2017-12-13 Thread Simon Horman
On Wed, Dec 13, 2017 at 11:33:00AM +0900, Yoshihiro Shimoda wrote: > From: Masaharu Hayakawa > > The following error occurs when loading renesas_sdhi_core.c module, > so add MODULE_LICENSE("GPL v2"). > > renesas_sdhi_core: module license 'unspecified' taints kernel. > > Signed-off-by: Masaharu

Re: [PATCH 1/2] PCI: rcar: Fix use-after-free in probe error path

2017-12-13 Thread Simon Horman
On Tue, Dec 12, 2017 at 01:29:42PM -0600, Bjorn Helgaas wrote: > On Thu, Dec 07, 2017 at 11:15:19AM +0100, Geert Uytterhoeven wrote: > > If CONFIG_DEBUG_SLAB=y, and no PCIe card is inserted, the kernel crashes > > during probe on r8a7791/koelsch: > > > > rcar-pcie fe00.pcie: PCIe link down

Re: [PATCH 3/3] arm64: dts: renesas: r8a7796: add reg properties to pciec[01] nodes

2017-12-13 Thread Simon Horman
On Tue, Dec 12, 2017 at 10:50:33AM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 12, 2017 at 9:24 AM, Simon Horman > wrote: > > Add reg properties to pciec[01] placeholder nodes > > > > This is to stop the compiler complaining as follows: > > $ make > > ... > > DTC arch/arm64/boot/dts/renes

Re: [PATCH 2/3] arm64: dts: renesas: r8a7796: move nodes which have no reg property out of bus

2017-12-13 Thread Simon Horman
On Tue, Dec 12, 2017 at 10:44:53AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, Dec 12, 2017 at 9:24 AM, Simon Horman > wrote: > > Move pmu_a5[73], timer and thermal-zones nodes from soc node to root node. > > The nodes that have been moved do not have any register properties and thus

Re: [PATCH 1/3] arm64: dts: renesas: r8a7796: sort subnodes of root node alphabetically

2017-12-13 Thread Simon Horman
On Tue, Dec 12, 2017 at 10:30:34AM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 12, 2017 at 9:24 AM, Simon Horman > wrote: > > Sort root sub-nodes alphabetically for allow for easier maintenance > > of this file. > > > > Signed-off-by: Simon Horman > > Reviewed-by: Geert Uytterhoeven Thanks,

Re: [PATCH 1/3] arm64: dts: renesas: r8a7796: sort subnodes of root node alphabetically

2017-12-13 Thread Simon Horman
On Tue, Dec 12, 2017 at 10:30:34AM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 12, 2017 at 9:24 AM, Simon Horman > wrote: > > Sort root sub-nodes alphabetically for allow for easier maintenance > > of this file. > > > > Signed-off-by: Simon Horman > > Reviewed-by: Geert Uytterhoeven Thanks,

Re: [PATCH] arm64: dts: renesas: r8a7795: sort subnodes of root node alphabetically

2017-12-13 Thread Simon Horman
On Tue, Dec 12, 2017 at 10:45:58AM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 12, 2017 at 9:27 AM, Simon Horman > wrote: > > Sort root sub-nodes alphabetically for allow for easier maintenance > > of this file. > > > > Signed-off-by: Simon Horman > > Reviewed-by: Geert Uytterhoeven Thanks,