Re: [PATCH] arm: exynos: generalize power register address calculation

2014-04-09 Thread Chander Kashyap
Hi Tomasz, On 9 April 2014 20:15, Tomasz Figa wrote: > On 09.04.2014 15:49, Chander Kashyap wrote: >> >> Hi Tomasz, >> >> On 9 April 2014 17:19, Tomasz Figa wrote: >>> >>> Hi Chander, >>> >>> >>> On 09.04.2014 13:09, Chander Kashyap wrote: Currently status/configuration power regi

Re: [PATCH 1/2] usb: ehci-exynos: Return immediately from suspend if ehci_suspend fails

2014-04-09 Thread Vivek Gautam
Hi Alan, On Thu, Apr 10, 2014 at 7:06 AM, Alan Stern wrote: > On Thu, 10 Apr 2014, Jingoo Han wrote: > >> > > --- a/drivers/usb/host/ehci-exynos.c >> > > +++ b/drivers/usb/host/ehci-exynos.c >> > > @@ -212,6 +212,8 @@ static int exynos_ehci_suspend(struct device *dev) >> > > int rc; >> > > >>

Re: [PATCH 05/10] ARM: EXYNOS: Move "regs-pmu" header inclusion in common.h

2014-04-09 Thread Pankaj Dubey
Hi Tomasz, On 04/09/2014 01:09 AM, Tomasz Figa wrote: Hi Pankaj, On 02.04.2014 09:50, Pankaj Dubey wrote: There are many machine files under "mach-exynos" including "regs-pmu.h" as well as "common.h", so better we move this header inclusion in common.h. Signed-off-by: Pankaj Dubey --- arch

Re: [PATCH 01/10] ARM: EXYNOS: Cleanup "mach-exynos/common.h" file

2014-04-09 Thread Pankaj Dubey
Hi Tomasz, On 04/09/2014 12:59 AM, Tomasz Figa wrote: Hi Pankaj, On 02.04.2014 09:50, Pankaj Dubey wrote: Remove unused declarations from "mach-exynos/common.h" Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/common.h |3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/

Re: [PATCH 1/2] usb: ehci-exynos: Return immediately from suspend if ehci_suspend fails

2014-04-09 Thread Alan Stern
On Thu, 10 Apr 2014, Jingoo Han wrote: > > > --- a/drivers/usb/host/ehci-exynos.c > > > +++ b/drivers/usb/host/ehci-exynos.c > > > @@ -212,6 +212,8 @@ static int exynos_ehci_suspend(struct device *dev) > > > int rc; > > > > > > rc = ehci_suspend(hcd, do_wakeup); > > > + if (rc) > > > +

Re: [PATCH 1/2] usb: ehci-exynos: Return immediately from suspend if ehci_suspend fails

2014-04-09 Thread Jingoo Han
On Thursday, April 10, 2014 3:32 AM, Alan Stern wrote: > On Wed, 9 Apr 2014, Vivek Gautam wrote: > > > Patch 'b8efdaf USB: EHCI: add check for wakeup/suspend race' > > adds a check for possible race between suspend and wakeup interrupt, > > and thereby it returns -EBUSY as error code if there's a

Re: [PATCH 1/2] usb: ehci-exynos: Return immediately from suspend if ehci_suspend fails

2014-04-09 Thread Alan Stern
On Wed, 9 Apr 2014, Vivek Gautam wrote: > Patch 'b8efdaf USB: EHCI: add check for wakeup/suspend race' > adds a check for possible race between suspend and wakeup interrupt, > and thereby it returns -EBUSY as error code if there's a wakeup > interrupt. > So the platform host controller should not

Re: [PATCH] arm: exynos: generalize power register address calculation

2014-04-09 Thread Tomasz Figa
On 09.04.2014 15:49, Chander Kashyap wrote: Hi Tomasz, On 9 April 2014 17:19, Tomasz Figa wrote: Hi Chander, On 09.04.2014 13:09, Chander Kashyap wrote: Currently status/configuration power register values are hard-coded for cpu1. Make it generic so that it is useful for SoC's with more t

Re: [PATCH] arm: exynos: generalize power register address calculation

2014-04-09 Thread Chander Kashyap
Hi Tomasz, On 9 April 2014 17:19, Tomasz Figa wrote: > Hi Chander, > > > On 09.04.2014 13:09, Chander Kashyap wrote: >> >> Currently status/configuration power register values are hard-coded for >> cpu1. >> >> Make it generic so that it is useful for SoC's with more than two cpus. >> >> Signed-of

Re: [PATCH V3 11/17] ARM: exynos: cpuidle: Move the power sequence call in the cpu_pm notifier

2014-04-09 Thread Daniel Lezcano
On 04/09/2014 02:17 PM, Tomasz Figa wrote: Hi Daniel, On 08.04.2014 14:19, Daniel Lezcano wrote: The code to initiate and exit the powerdown sequence is the same in pm.c and cpuidle.c. Let's split the common part in the pm.c and reuse it from the cpu_pm notifier. That is one more step forward

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-09 Thread Tomasz Figa
On 09.04.2014 13:49, Vivek Gautam wrote: Hi, On Wed, Apr 9, 2014 at 4:36 PM, Tomasz Figa wrote: Hi Vivek, Please see my comments inline. On 08.04.2014 16:36, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework

Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-09 Thread Sylwester Nawrocki
On 09/04/14 14:24, Vivek Gautam wrote: > On Wed, Apr 9, 2014 at 5:41 PM, Sylwester Nawrocki > wrote: >> > On 09/04/14 13:54, Vivek Gautam wrote: >>> >> Adding support to enable/disable VBUS hooked to a gpio >>> >> to enable vbus supply on the port. >> > >> > Does the GPIO control a fixed voltage r

Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-09 Thread Tomasz Figa
Hi, On 09.04.2014 14:24, Vivek Gautam wrote: Hi Sylwester, On Wed, Apr 9, 2014 at 5:41 PM, Sylwester Nawrocki wrote: Hi Vivek, On 09/04/14 13:54, Vivek Gautam wrote: Adding support to enable/disable VBUS hooked to a gpio to enable vbus supply on the port. Does the GPIO control a fixed vo

Re: [PATCH V3 00/17] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle

2014-04-09 Thread Tomasz Figa
Hi Daniel, On 08.04.2014 14:19, Daniel Lezcano wrote: Changelog: V3: * Added patch : "ARM: exynos: cpuidle: Disable cpuidle for 5440" * Removed patch : "ARM: exynos: config: Enable cpuidle" * Removed default ARM_EXYNOS4210_CPUIDLE=y * Added comment about bug fi

Re: [PATCH V3 16/17] ARM: exynos: cpuidle: Pass the AFTR callback to the platform_data

2014-04-09 Thread Tomasz Figa
Hi Daniel, On 08.04.2014 14:19, Daniel Lezcano wrote: No more dependency on the arch code. The platform_data field is used to set the PM callback as the other cpuidle drivers. Signed-off-by: Daniel Lezcano Reviewed-by: Viresh Kumar Reviewed-by: Bartlomiej Zolnierkiewicz --- arch/arm/mach-e

Re: [PATCH V3 14/17] ARM: exynos: cpuidle: Move the boot vector in pm.c

2014-04-09 Thread Tomasz Figa
Hi Daniel, On 08.04.2014 14:19, Daniel Lezcano wrote: As usual, move the boot vector setting in the pm.c file and use the cpu_pm notifier to set it up. Remove the unused headers. Signed-off-by: Daniel Lezcano Reviewed-by: Viresh Kumar Reviewed-by: Bartlomiej Zolnierkiewicz --- arch/arm/ma

Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-09 Thread Vivek Gautam
Hi Sylwester, On Wed, Apr 9, 2014 at 5:41 PM, Sylwester Nawrocki wrote: > Hi Vivek, > > On 09/04/14 13:54, Vivek Gautam wrote: >> Adding support to enable/disable VBUS hooked to a gpio >> to enable vbus supply on the port. > > Does the GPIO control a fixed voltage regulator ? If so, shouldn't >

Re: [PATCH V3 12/17] ARM: exynos: cpuidle: Move S5P_CHECK_AFTR in a header

2014-04-09 Thread Tomasz Figa
Hi Daniel, On 08.04.2014 14:19, Daniel Lezcano wrote: Move the S5P_CHECK_AFTR definition to the header it belongs to. Signed-off-by: Daniel Lezcano Reviewed-by: Viresh Kumar Reviewed-by: Bartlomiej Zolnierkiewicz --- arch/arm/mach-exynos/cpuidle.c |2 -- arch/arm/mach-exynos/regs-pmu

Re: [PATCH V3 11/17] ARM: exynos: cpuidle: Move the power sequence call in the cpu_pm notifier

2014-04-09 Thread Tomasz Figa
Hi Daniel, On 08.04.2014 14:19, Daniel Lezcano wrote: The code to initiate and exit the powerdown sequence is the same in pm.c and cpuidle.c. Let's split the common part in the pm.c and reuse it from the cpu_pm notifier. That is one more step forward to make the cpuidle driver arch indenpendan

Re: [PATCH V3 10/17] ARM: exynos: cpuidle: Move exynos_set_wakeupmask in the cpu_pm notifier

2014-04-09 Thread Tomasz Figa
Hi Daniel, On 08.04.2014 14:19, Daniel Lezcano wrote: Let's encapsulate more the PM code inside the PM file by moving the 'exynos_set_wakeupmask' function inside the pm.c and the call in the cpu_pm notifier. Signed-off-by: Daniel Lezcano Reviewed-by: Viresh Kumar Reviewed-by: Bartlomiej Zolni

Re: [PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-09 Thread Sylwester Nawrocki
Hi Vivek, On 09/04/14 13:54, Vivek Gautam wrote: > Adding support to enable/disable VBUS hooked to a gpio > to enable vbus supply on the port. Does the GPIO control a fixed voltage regulator ? If so, shouldn't it be modelled by the regulator API instead ? > Signed-off-by: Vivek Gautam [...] > +

[PATCH] phy: exynos5-usbdrd: Add facility to toggle vbus gpio on/off

2014-04-09 Thread Vivek Gautam
Adding support to enable/disable VBUS hooked to a gpio to enable vbus supply on the port. Signed-off-by: Vivek Gautam --- Based on 'phy-exynos5-usbdrd' patches: [PATCH V4 0/5] Add Exynos5 USB 3.0 phy driver based on generic PHY framework http://www.spinics.net/lists/linux-usb/msg105507.html dr

Re: [PATCH] arm: exynos: generalize power register address calculation

2014-04-09 Thread Tomasz Figa
Hi Chander, On 09.04.2014 13:09, Chander Kashyap wrote: Currently status/configuration power register values are hard-coded for cpu1. Make it generic so that it is useful for SoC's with more than two cpus. Signed-off-by: Chander Kashyap --- changes in v2 : Used existing macros for clusterid a

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-09 Thread Vivek Gautam
Hi, On Wed, Apr 9, 2014 at 4:36 PM, Tomasz Figa wrote: > Hi Vivek, > > Please see my comments inline. > > > On 08.04.2014 16:36, Vivek Gautam wrote: >> >> Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. >> The new driver uses the generic PHY framework and will interact >> with DW

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-04-09 Thread Andreas Oberritter
Hello Andrzej, On 09.04.2014 10:37, Andrzej Hajda wrote: >> +static int exynos_phy_probe(struct platform_device *pdev) >> +{ >> +const struct of_device_id *of_id = of_match_device( >> +of_match_ptr(exynos_phy_of_match), &pdev->dev); >> +const u32 *offsets = of_id->data; >> +

Re: [PATCH V4 5/5] usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver

2014-04-09 Thread Vivek Gautam
Hi Tomasz, ' On Wed, Apr 9, 2014 at 4:43 PM, Tomasz Figa wrote: > Hi Vivek, > Thanks for reviewing the patch series. > > On 08.04.2014 16:36, Vivek Gautam wrote: >> >> Removing this older USB 3.0 DRD controller PHY driver, since >> a new driver based on generic phy framework is now available. >>

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-04-09 Thread Tomasz Stanislawski
Hi Rahul, On 04/09/2014 11:12 AM, Rahul Sharma wrote: > Hi Tomasz, > > On 9 April 2014 14:07, Andrzej Hajda wrote: >> Hi Tomasz, >> >> On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote: >>> Add exynos-simple-phy driver to support a single register >>> PHY interfaces present on Exynos4 SoC. >>> >

Re: [PATCH V4 5/5] usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver

2014-04-09 Thread Tomasz Figa
Hi Vivek, On 08.04.2014 16:36, Vivek Gautam wrote: Removing this older USB 3.0 DRD controller PHY driver, since a new driver based on generic phy framework is now available. Also removing the dt node for older driver from Exynos5250 device tree and updating the dt node for DWC3 controller. Sig

Re: [PATCH V4 4/5] dt: exynos5250: Enable support for generic USB DRD phy

2014-04-09 Thread Tomasz Figa
On 08.04.2014 16:36, Vivek Gautam wrote: Add device tree node for new usbdrd-phy driver, which is based on generic phy framework. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.d

Re: [PATCH V4 3/5] dt: exynos5420: Enable support for DWC3 controller

2014-04-09 Thread Tomasz Figa
On 08.04.2014 16:36, Vivek Gautam wrote: Add device tree nodes for DWC3 controller present on Exynos 5420 SoC, to enable support for USB 3.0. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5420.dtsi | 34 ++ 1 file changed, 34 insertions(+) diff --

Re: [PATCH v4 2/5] dt: exynos5420: Enable support for USB 3.0 PHY controller

2014-04-09 Thread Tomasz Figa
On 08.04.2014 16:36, Vivek Gautam wrote: Add device tree nodes for USB 3.0 PHY present alongwith USB 3.0 controller Exynos 5420 SoC. This phy driver is based on generic phy framework. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5420.dtsi | 20 1 file change

[PATCH] arm: exynos: generalize power register address calculation

2014-04-09 Thread Chander Kashyap
Currently status/configuration power register values are hard-coded for cpu1. Make it generic so that it is useful for SoC's with more than two cpus. Signed-off-by: Chander Kashyap --- changes in v2 : Used existing macros for clusterid and cpuid calculation arch/arm/mach-exynos/hotplug.c |

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-09 Thread Tomasz Figa
Hi Vivek, Please see my comments inline. On 08.04.2014 16:36, Vivek Gautam wrote: Add a new driver for the USB 3.0 PHY on Exynos5 series of SoCs. The new driver uses the generic PHY framework and will interact with DWC3 controller present on Exynos5 series of SoCs. Thereby, removing old phy-sam

Re: [PATCHv2 2/3] drm: exynos: hdmi: use hdmiphy as PHY

2014-04-09 Thread Tomasz Stanislawski
Hi Andrzej, This issue could be solved by exporting a regmap from PMU driver or Exynos clock provider for the usage by exynos-simple-phy. The operations on PHYs from exynos-simple-phy provider would be chained to PMU driver and protected by a spinlock in the regmap. Luckily, the divider is not use

Re: [PATCH v7 3/3] ARM: dts: add dts files for xyref5260 board

2014-04-09 Thread Tomasz Figa
On 07.04.2014 10:40, Sachin Kamat wrote: On 3 April 2014 15:30, Rahul Sharma wrote: The patch adds the dts files for xyref5260 board which is based on Exynos5260 Evt0 sample. Signed-off-by: Rahul Sharma --- +/ { + model = "SAMSUNG XYREF5260 EVT0 board based on EXYNOS5260"; + co

Re: [PATCHv2 2/3] drm: exynos: hdmi: use hdmiphy as PHY

2014-04-09 Thread Rahul Sharma
Hi Andrzej, On 9 April 2014 16:00, Andrzej Hajda wrote: > Hi Tomasz, > > On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote: >> The HDMIPHY (physical interface) is controlled by a single >> bit in a power controller's regiter. It was implemented >> as clock. It was a simple but effective hack. > >

Re: [PATCH v6 2/3] ARM: dts: add dts files for exynos5260 SoC

2014-04-09 Thread Sachin Kamat
On 7 April 2014 14:14, Sachin Kamat wrote: > On 3 April 2014 10:47, Rahul Sharma wrote: >> The patch adds the dts files for exynos5260. >> >> Signed-off-by: Pankaj Dubey >> Signed-off-by: Rahul Sharma >> Signed-off-by: Arun Kumar K >> Reviewed-by: Tomasz Figa >> --- > > >> +/ { >> + co

Re: [PATCHv2 2/3] drm: exynos: hdmi: use hdmiphy as PHY

2014-04-09 Thread Andrzej Hajda
Hi Tomasz, On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote: > The HDMIPHY (physical interface) is controlled by a single > bit in a power controller's regiter. It was implemented > as clock. It was a simple but effective hack. This power controller register has also bits to control HDMI clock d

Re: [PATCH v7 2/3] ARM: dts: add dts files for exynos5260 SoC

2014-04-09 Thread Tomasz Figa
Hi Rahul, On 03.04.2014 12:00, Rahul Sharma wrote: The patch adds the dts files for exynos5260. Signed-off-by: Pankaj Dubey Signed-off-by: Rahul Sharma Signed-off-by: Arun Kumar K Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 574 +

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-04-09 Thread Sylwester Nawrocki
Hi, On 09/04/14 11:12, Rahul Sharma wrote: > Idea looks good. How about keeping compatible which is independent > of SoC, something like "samsung,exynos-simple-phy" and provide Reg > and Bit through phy provider node. This way we can avoid SoC specific > hardcoding in phy driver and don't need to

Re: [PATCH v7 1/3] ARM: EXYNOS: initial board support for exynos5260 SoC

2014-04-09 Thread Rahul Sharma
On 9 April 2014 14:34, Tomasz Figa wrote: > On 07.04.2014 10:38, Sachin Kamat wrote: >> >> Hi Rahul, >> >> On 3 April 2014 15:30, Rahul Sharma wrote: >>> >>> From: Pankaj Dubey >>> >>> This patch add basic arch side support for exynos5260 SoC. >> >> >> >>> @@ -374,6 +374,7 @@ static char const

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-04-09 Thread Rahul Sharma
Hi Tomasz, On 9 April 2014 14:07, Andrzej Hajda wrote: > Hi Tomasz, > > On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote: >> Add exynos-simple-phy driver to support a single register >> PHY interfaces present on Exynos4 SoC. >> >> Signed-off-by: Tomasz Stanislawski >> --- >> .../devicetree/bin

Re: [PATCH v7 1/3] ARM: EXYNOS: initial board support for exynos5260 SoC

2014-04-09 Thread Tomasz Figa
On 07.04.2014 10:38, Sachin Kamat wrote: Hi Rahul, On 3 April 2014 15:30, Rahul Sharma wrote: From: Pankaj Dubey This patch add basic arch side support for exynos5260 SoC. @@ -374,6 +374,7 @@ static char const *exynos_dt_compat[] __initconst = { "samsung,exynos4412", "s

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-04-09 Thread Andrzej Hajda
Hi Tomasz, On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote: > Add exynos-simple-phy driver to support a single register > PHY interfaces present on Exynos4 SoC. > > Signed-off-by: Tomasz Stanislawski > --- > .../devicetree/bindings/phy/samsung-phy.txt| 24 +++ > drivers/phy/Kconfig