On Wed, Oct 16, 2013 at 09:10:52PM +0200, Tomasz Figa wrote:
> With support for amba-pl08x driver, on S3C64xx the generic DMA engine
> API can be used instead of the private s3c-dma interface.
>
> Signed-off-by: Tomasz Figa
Acked-by: Mark Brown
in case we can get thi
to use this driver and drop the legacy DMA code.
Tested-by: Mark Brown
signature.asc
Description: Digital signature
On Mon, Oct 14, 2013 at 10:51:06PM +0800, ysh wrote:
> Got it, then what about the setting of clk, mosi, miso pin in slave mode?
> Do you mean I need to simulate spi slave side using four gpios?
Hrm, now I think about it clock is going to be a problem... you're
probably stuck with bitbanging unl
On Sun, Oct 13, 2013 at 08:29:47PM +0200, Tomasz Figa wrote:
> On Saturday 12 of October 2013 13:33:29 Mark Brown wrote:
> > Did the s3c64xx pl08x stuff get merged?
> Most of. All the patches for the amba-pl08x driver got merged. Just the
> platform glue remains. I will
On Mon, Oct 14, 2013 at 03:05:58AM +0800, YouShenghui wrote:
Please fix your mailer to word wrap within paragraphs, your messages are
very hard to read.
> Ok, I have one question when reading drivers/spi/spi-s3c64xx.c
> In s3c64xx_spi_setup, cs->line(S3C64XX_GPC(3)) is set to GPIOF_OUT_INIT_HIGH,
On Sat, Oct 12, 2013 at 06:36:36AM +0200, Tomasz Figa wrote:
> Big thanks for this series and the one adding DMA engine support for
> S3C24xx. It would be great if someone could test this on affected
> platforms, so we could finally drop the old S3C-DMA nonsense.
Did the s3c64xx pl08x stuff get m
On Fri, Oct 11, 2013 at 10:17:48AM +0530, Rajeshwari S Shinde wrote:
> This patch enables word transfer for s3c64xx spi driver.
> User can set bits_per_word to 32 before calling spi_setup,
> which would enable the word transfer mode.
As someone mentioned on previous reviews there's nothing in thi
On Thu, Oct 10, 2013 at 08:40:38PM +0900, Inki Dae wrote:
> That is what I mentioned. Some boards _could control_ the actual regulator
> for lvds-bridge, and that would be depended on how HW engineer designs the
> board.
For the driver this should be totally transparent - it should just
control
From: Mark Brown
The loops which SPI controller drivers use to process the list of transfers
in a spi_message are typically very similar and have some error prone areas
such as the handling of /CS. Help simplify drivers by factoring this code
out into the core - if drivers provide a transfer_one
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 152 +-
1 file changed, 56 insertions(+), 96 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index c7b36c0..25eb352 100644
--- a/drivers/spi
On Thu, Oct 10, 2013 at 01:18:05PM +0900, Inki Dae wrote:
> > > I still think the pin could be replaced with a regulator. But
> > > lvds-bridge node has "powerdown-gpio" property - it say this board
> > > will use gpio pin - specific to board. So it seems no problem.
> > No, don't model things t
On Fri, Oct 04, 2013 at 11:05:48AM +0900, Inki Dae wrote:
> 2013/10/4 Olof Johansson :
> > "If PD_N is LOW, then the device is in Deep power-down completely,
> > even if supply rail is ON; for the device to be able to operate, the
> > PD_N pin must be HIGH."
> I still think the pin could be repla
From: Mark Brown
Many SPI drivers perform setup and tear down on every message, usually
doing things like DMA mapping the message. Provide hooks for them to use
to provide such operations.
This is of limited value for drivers that implement transfer_one_message()
but will be of much greater
From: Mark Brown
This is of very little value in itself but will be useful once the loop
iterating over the transfers is also factored out into the core.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 36
1 file changed, 28 insertions(+), 8
From: Mark Brown
Ensure that unused I2C controllers are not activated, causing problems due
to inappropriate pinmuxing or similar, by marking the controllers as
disabled by default and requiring boards to explicitly enable those that
are in use.
Signed-off-by: Mark Brown
Acked-by: Tomasz Figa
From: Mark Brown
There is a 16.934MHz fixed rate clock connected to MCLK1 on the CODEC, add
this to the device tree bindings.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 +
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250
From: Mark Brown
Make it easier to notice the common file for ChromeOS devices based on
the Exynos5250 by giving it the exynos5250 prefix that the boards have.
Signed-off-by: Mark Brown
Acked-by: Tomasz Figa
---
arch/arm/boot/dts/cros5250-common.dtsi| 313
From: Mark Brown
Rather than requiring each board to explicitly disable the I2S controllers
it is not using instead require boards to enable those that they are using.
This is required for audio operation on Arndale, one of the unused I2S
controllers is pinmuxed with the LDO enable GPIOs for
From: Mark Brown
Rather than requiring each board to explicitly disable the SPI controllers
it is not using instead require boards to enable those that they are using.
This is less work overall since normally at most one of the controllers is
in use and avoids issues caused by inappropriate
On Sat, Oct 05, 2013 at 12:25:10AM +0800, YouShenghui wrote:
> At 2013-09-30 17:33:17,"Mark Brown" wrote: >On Mon, Sep
> 30, 2013 at 01:20:42AM +0200, Tomasz Figa wrote: > >> Mark will probably know
> better, but AFAIK there is no API for slave mode >> SPI
On Tue, Oct 01, 2013 at 11:31:27PM +0200, Thierry Reding wrote:
> On Tue, Oct 01, 2013 at 02:59:43PM -0600, Stephen Warren wrote:
> > OK, hopefully it (the regulator core) complains about the missing DT
> > property though; I assume you're using regulator_get() not
> > regulator_get_optional(), si
On Tue, Oct 01, 2013 at 04:03:40PM +0530, Yuvaraj Kumar C D wrote:
> +static bool is_ack(struct s3c24xx_i2c *i2c)
> +{
> + u32 time_out = i2c->tx_setup;
> +
> + while (--time_out) {
> + if (readl(i2c->regs + S3C2410_IICCON)
> + & S3C2410_IICCON_IRQPEND) {
>
On Mon, Sep 30, 2013 at 01:32:43PM +0530, Rajeshwari Birje wrote:
> Please do let me know if you have any comments on this patch.
Don't top post. You need to follow Tomasz's advice and send the patch
to me (using the above address from get_maintainer.pl) after addressing
the issues he identified
On Mon, Sep 30, 2013 at 01:20:42AM +0200, Tomasz Figa wrote:
> Mark will probably know better, but AFAIK there is no API for slave mode
> SPI available in Linux kernel. Please correct me if I'm wrong.
That's correct.
> The code mentioned in the post from your link was some internal vendor
> co
On Sat, Sep 28, 2013 at 08:21:36PM +0200, Tomasz Figa wrote:
> Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies
> the s3c-i2s-v2 driver to use the proper way of checking for S3C64xx
> support - CONFIG_ARCH_S3C64XX.
Acked-by: Mark Brown
signature.asc
Description
From: Mark Brown
Rather than using the driver custom platform data to store the chip select
GPIO use the cs_gpio field provided by the SPI core, supporting future
refectoring.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 24 ++--
1 file changed, 10 insertions
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 2e267ce..dd5ed13 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi
From: Mark Brown
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index dd5ed13..7f960db 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -205,7 +205,6
From: Mark Brown
To help with bisection of future refactoring to share more of the code for
handling a spi_message pull the enabling of GPIO based /CS prior to all
the hardware setup for starting a transfer.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 6 +++---
1 file changed, 3
From: Mark Brown
Ensure that the FIFOs are fully drained before we deassert /CS or do any
delays that have been requested in order to ensure that the behaviour
visible on the bus matches that which was requested by the caller.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 4
From: Mark Brown
The hardware level /CS handling is tied to the start of the data path so
is rolled into the same function as we use to manipulate GPIO /CS. In
order to support factoring out the /CS handling into the core separate the
two and explicitly start transfers separately to the /CS
From: Mark Brown
Otherwise we may try to start transfers immediately and then fail to
runtime resume the device causing us not to have clocks enabled.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi
On Mon, Sep 23, 2013 at 11:45:45AM +0200, Mateusz Krawczuk wrote:
> Add compatibles for s3c6410, s5pc100 and s5pc110/s5pv210 boards.
> static const struct of_device_id s3c64xx_spi_dt_match[] = {
> + { .compatible = "samsung,s3c2443-spi",
> + .data = (void *)&s3c2443_spi_po
From: Mark Brown
Help ensure that updates to the Samsung device trees get sent to the
Samsung maintainers for review by adding file patterns to MAINTAINERS.
Signed-off-by: Mark Brown
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6d0dabe
On Tue, Sep 17, 2013 at 12:31:20PM +0200, Tomasz Figa wrote:
> > +F: arch/arm/boot/s3c*
> > +F: arch/arm/boot/exynos*
> I believe it should be arch/arm/boot/dts/.
Bah, so it should. I wonder why I did actually start seeing the
appropriate things turning up after I did this patch then?
signatu
From: Mark Brown
Signed-off-by: Mark Brown
---
sound/soc/samsung/smdk_wm8994.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c
index 5fd7a05..831972d 100644
--- a/sound/soc/samsung/smdk_wm8994.c
From: Mark Brown
Simplify error handling and remove repetitive (and rarely executed) code
for unregistration by providing a devm_snd_soc_register() card.
Signed-off-by: Mark Brown
---
include/sound/soc.h| 1 +
sound/soc/soc-devres.c | 34 ++
2 files
From: Mark Brown
There is a 16.934MHz fixed rate clock connected to MCLK1 on the CODEC, add
this to the device tree bindings.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 +
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250
From: Mark Brown
Ensure that unused I2C controllers are not activated, causing problems due
to inappropriate pinmuxing or similar, by marking the controllers as
disabled by default and requiring boards to explicitly enable those that
are in use.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts
From: Mark Brown
Make it easier to notice the common file for ChromeOS devices based on
the Exynos5250 by giving it the exynos5250 prefix that the boards have.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts/{cros5250-common.dtsi => exynos5250-cros-common.dtsi} | 0
arch/arm/boot/
From: Mark Brown
Rather than requiring each board to explicitly disable the SPI controllers
it is not using instead require boards to enable those that they are using.
This is less work overall since normally at most one of the controllers is
in use and avoids issues caused by inappropriate
From: Mark Brown
Rather than requiring each board to explicitly disable the I2S controllers
it is not using instead require boards to enable those that they are using.
This is required for audio operation on Arndale, one of the unused I2S
controllers is pinmuxed with the LDO enable GPIOs for
On Wed, Sep 11, 2013 at 03:27:29PM +0100, Charles Keepax wrote:
> Signed-off-by: Charles Keepax
APPLIED, THANKS. Please also remember to CC maintainers on patches.
signature.asc
Description: Digital signature
On Fri, Sep 13, 2013 at 01:02:11AM +0200, Tomasz Figa wrote:
> On Thursday 12 of September 2013 21:00:13 Mark Brown wrote:
> > > i2c@12CA does look like a normal hardware I2C controller, which
> > > needs some extra properties like samsung,i2c-sda-delay or
>
On Thu, Sep 12, 2013 at 05:55:59PM +0200, Tomasz Figa wrote:
> On Thursday 12 of September 2013 14:52:33 Mark Brown wrote:
> > Please delete unneeded context from your mails, it makes it much easier
> > to find the new content.
> I always snip unnecessary parts of quoted mes
On Thu, Sep 12, 2013 at 05:51:58PM +0200, Tomasz Figa wrote:
> On Thursday 12 of September 2013 14:50:28 Mark Brown wrote:
> > There are no SPI devices on that board (at least not ones that are
> > currently instantiated by the DT).
> I can see a bunch of nodes simply adding
On Thu, Sep 12, 2013 at 02:58:59PM +0200, Tomasz Figa wrote:
> On Thursday 12 of September 2013 11:40:27 Mark Brown wrote:
Please delete unneeded context from your mails, it makes it much easier
to find the new content.
> > + i2c@12CA {
> > + status = "oka
On Thu, Sep 12, 2013 at 01:56:44PM +0200, Tomasz Figa wrote:
> I wonder if exynos5250-arndale shouldn't be also considered in this patch.
There are no SPI devices on that board (at least not ones that are
currently instantiated by the DT).
signature.asc
Description: Digital signature
From: Mark Brown
Help ensure that updates to the Samsung device trees get sent to the
Samsung maintainers for review by adding file patterns to MAINTAINERS.
Signed-off-by: Mark Brown
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6d0dabe
From: Mark Brown
Rather than requiring each board to explicitly disable the SPI controllers
it is not using instead require boards to enable those that they are using.
This is less work overall since normally at most one of the controllers is
in use and avoids issues caused by inappropriate
From: Mark Brown
Ensure that unused I2C controllers are not activated, causing problems due
to inappropriate pinmuxing or similar, by marking the controllers as
disabled by default and requiring boards to explicitly enable those that
are in use.
Signed-off-by: Mark Brown
---
arch/arm/boot/dts
From: Mark Brown
Rather than requiring each board to explicitly disable the I2S controllers
it is not using instead require boards to enable those that they are using.
This is required for audio operation on Arndale, one of the unused I2S
controllers is pinmuxed with the LDO enable GPIOs for
On Wed, Sep 11, 2013 at 09:45:58AM +0200, Łukasz Czerwiński wrote:
> I based my patch on the spi-tegra114.c driver.There is
> dma_chanel_request at the beginning in the probe function.
> I really should correct S5C73M3 firmware upload function.
Yes, that can be the best idea in cases wher
On Tue, Sep 10, 2013 at 06:35:48PM +0100, Mark Rutland wrote:
> It seems far more sensible to me to mark devices disabled by default in
> shared dtsi files and then okay them as needed in particular dts files.
> I'd be happy with more of this.
Yeah, me too - though only for devices that have an e
On Tue, Sep 10, 2013 at 03:16:59PM +0200, Łukasz Czerwiński wrote:
> On 09/10/2013 02:03 PM, Mark Brown wrote:
> >On Tue, Sep 10, 2013 at 01:24:01PM +0200, Łukasz Czerwiński wrote:
> >>For 16kB buffer upload time is reduced from ~90ms to ~80ms (I tested
> >>with S5C73M
On Tue, Sep 10, 2013 at 01:24:01PM +0200, Łukasz Czerwiński wrote:
> For 16kB buffer upload time is reduced from ~90ms to ~80ms (I tested
> with S5C73M3 355560B transfer). If you think that performance
> increase isn't valuable we should skip that patch.
That does seem worthwhile. Is that just a
On Tue, Sep 10, 2013 at 01:23:45PM +0200, Łukasz Czerwiński wrote:
> On 09/09/2013 04:45 PM, Mark Brown wrote:
> >This seems like a very low limit to have, consider things like firmware
> >downloads for example. It seems reasonable to have a preallocated small
> >buffer but
On Mon, Sep 09, 2013 at 04:09:26PM +0200, Lukasz Czerwinski wrote:
> This patch removes DMA channel initialization and deinitialization for each
> transfer. Now DMA channel is requested only at the driver initialization
> and stored in driver data.
So, this is fine but I had been under the impress
On Mon, Sep 09, 2013 at 04:09:25PM +0200, Lukasz Czerwinski wrote:
> subsys_init_call() initializes driver too early.
> It's preventing to move DMA channel allocation at the begining
> (driver probe).
Applied, thanks.
signature.asc
Description: Digital signature
On Mon, Sep 09, 2013 at 04:09:23PM +0200, Lukasz Czerwinski wrote:
> The spi-s3c64xx currently doesn't support transfers from non-contiguous
> client buffers.
>
> This patch adds two coherent buffers which allow transfers from
> non-contiguous client buffers without extra coherent memory allocatio
On Mon, Sep 09, 2013 at 04:09:21PM +0200, Lukasz Czerwinski wrote:
> Since support for generic DMA engine has beed added, there is no need
> to keep platform specific code (behind the #ifdef CONFIG_S3C_DMA).
This would break s3c64xx at least until Tomasz's dmaengine conversion
for that gets merged
From: Mark Brown
Rather than requiring each board to explicitly disable the I2S controllers
it is not using instead require boards to enable those that they are using.
This is required for audio operation on Arndale, one of the unused I2S
controllers is pinmuxed with the LDO enable GPIOs for
From: Mark Brown
Help simplify the cleanup code for SPI master drivers by providing a
managed master registration function, ensuring that the master is
automatically unregistered whenever the device is unbound.
Signed-off-by: Mark Brown
---
Documentation/driver-model/devres.txt | 3
From: Mark Brown
Also improve the error reporting on failure and remove a duplicate put.
This provides a small code saving.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b
From: Mark Brown
The clock aliases for SPI devices do not reflect the actual usage in the
driver causing the SPI controller to fail to probe when the clock driver
is in use, fix this up.
Signed-off-by: Mark Brown
---
drivers/clk/samsung/clk-s3c64xx.c | 4 ++--
1 file changed, 2 insertions
On Sun, Aug 11, 2013 at 07:59:21PM +0200, Tomasz Figa wrote:
> The legacy S3C-DMA API required every period of a cyclic buffer to be
> queued separately. After conversion of Samsung ASoC to Samsung DMA
> wrappers somebody made an assumption that the same is needed for DMA
> engine API, which is not
From: Mark Brown
It is possible that we may fail to set the clock rate, if we do so then
log the failure and don't bother reprogramming the IP.
Signed-off-by: Mark Brown
---
drivers/mmc/host/sdhci-s3c.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/driver
On Tue, Jul 30, 2013 at 04:58:59PM +0900, Jingoo Han wrote:
> Use the wrapper function for retrieving the platform data instead of
> accessing dev->platform_data directly.
Applied, thanks.
signature.asc
Description: Digital signature
On Wed, Aug 28, 2013 at 09:06:27AM +0200, Linus Walleij wrote:
> If patch 1 thru 9 are uncontroversial now, maybe Vinod can apply
> these for v3.12 so we can get less noise and risk of collissions
> in the next merge window?
Patch 9 I was going to apply to ASoC towards the end of the release
cycl
On Thu, Aug 22, 2013 at 06:15:02PM +0530, Tushar Behera wrote:
> commit 85ff3c29d720 ("ASoC: samsung: Rename DMA platform registration
> functions") renames the DMA registration functions. Fix the places where
> it was left out.
Applied, thanks.
signature.asc
Description: Digital signature
On Thu, Aug 22, 2013 at 10:06:46AM +0200, Tomasz Figa wrote:
> On Thursday 22 of August 2013 01:21:25 Linus Walleij wrote:
> > This seems like something I should apply to the GPIO tree
> > right now, shall I?
> Would be nice, but since this patch is a dependency for rest of this
> series and the
From: Mark Brown
The current naming with a simple asoc_ prefix is too generic for use in
multiplatform kernels.
Signed-off-by: Mark Brown
---
sound/soc/samsung/ac97.c | 4 ++--
sound/soc/samsung/dma.c | 8
sound/soc/samsung/dma.h | 4 ++--
sound/soc/samsung/i2s.c | 6 +++---
4
From: Mark Brown
Signed-off-by: Mark Brown
---
sound/soc/samsung/dma.c | 4
1 file changed, 4 insertions(+)
diff --git a/sound/soc/samsung/dma.c b/sound/soc/samsung/dma.c
index 6e2b2b4..d54df85 100644
--- a/sound/soc/samsung/dma.c
+++ b/sound/soc/samsung/dma.c
@@ -183,6 +183,10 @@ static
On Fri, Aug 16, 2013 at 09:04:41AM -0700, Olof Johansson wrote:
> Really, what we want is to just turn on the LPAE functionality and
> keep everything else common. Forking into two defconfigs seems like
There's issues with that at the minute due to the DMA mask fun breaking
stuff, though Russell'
On Fri, Aug 16, 2013 at 09:56:18AM +0530, Padmavathi Venna wrote:
> This patch removes quirks from i2s node and change the i2s
> compatible names.
Applied, thanks.
signature.asc
Description: Digital signature
On Fri, Aug 16, 2013 at 09:53:23AM +0200, Tomasz Figa wrote:
> Sorry, I don't think this is a good idea, unless you can force the IP team
> to release a version table containing version of _every_ IP for _every_
> released SoC, including those historical ones, like S3C24xx and S3C64xx.
> Of cou
On Fri, Aug 16, 2013 at 01:35:57AM +0100, Mark Brown wrote:
> On Fri, Aug 16, 2013 at 09:04:28AM +0900, Kukjin Kim wrote:
> > NO, the build breakage is due to commit 6187288f15bc ("ARM: dts: exynos5250:
> > move common i2s properties to exynos5 dtsi" which is in Mar
On Fri, Aug 16, 2013 at 09:04:28AM +0900, Kukjin Kim wrote:
> NO, the build breakage is due to commit 6187288f15bc ("ARM: dts: exynos5250:
> move common i2s properties to exynos5 dtsi" which is in Mark Brown's tree.
> Mark, pleaser revert it in your tree...
I'll do that but I don't know if that'
From: Mark Brown
The Arndale has a SMSC USB3503 connected in hardware only mode like a PHY,
support it using the usb-nop-xceiv binding.
Note that due to a regrettable decision to use a regulator to represent
the reset signal this uses a fixed voltage regulator to do that, there
is a plan to use
From: Mark Brown
While the Linux driver stack is capable of figuring this out for itself
document the fact that we really do use the internal PHY even with the
directly wired hub on the board to save anyone else having to work this
out for themselves.
Signed-off-by: Mark Brown
---
arch/arm
On Wed, Aug 14, 2013 at 11:11:16AM +0200, Julia Lawall wrote:
> From: Julia Lawall
>
> Remove unneeded error handling on the result of a call to
> platform_get_resource when the value is passed to devm_ioremap_resource.
Applied, thanks.
signature.asc
Description: Digital signature
On Wed, Aug 14, 2013 at 04:00:16PM +0530, Tushar Behera wrote:
> On 14 August 2013 15:28, Mark Brown wrote:
> > + usb@1211 {
> > + usb-phy = <&usb2_phy>;
> > + };
> ehci-s5p driver doesn't use 'usb-phy' property to
On Wed, Aug 14, 2013 at 10:25:27AM +0200, Tomasz Figa wrote:
> Hmm, this series looks good to me too, except one thing. What about the
> bisection breakage introduced by the hole between patches 1/4 and 4/4
> (after the list of supported compatible changes in the driver and before
> respective
From: Mark Brown
The Arndale has a SMSC USB3503 connected in hardware only mode like a PHY,
support it using the usb-nop-xceiv binding.
Note that due to a regrettable decision to use a regulator to represent
the reset signal this uses a fixed voltage regulator to do that, there
is a plan to use
On Tue, Aug 13, 2013 at 01:10:02PM -0700, Tomasz Figa wrote:
> On Tuesday 13 of August 2013 18:52:51 Mark Brown wrote:
> > On Sun, Aug 11, 2013 at 07:59:24PM +0200, Tomasz Figa wrote:
> > > +#define pl330_filter pl08x_filter_id
> > So, this is pretty fun and probably not
On Tue, Aug 13, 2013 at 10:20:19PM +0200, Tomasz Figa wrote:
> On Tuesday 13 of August 2013 21:18:16 Mark Brown wrote:
> > if (dev->chancnt > 1 && !dma_has_cap(DMA_PRIVATE, dev->cap_mask))
> > list_for_each_entry(chan, &dev->channels, device_
On Tue, Aug 13, 2013 at 07:55:47PM +0100, Mark Brown wrote:
> I'm still debugging what's going on here - the basic refcounting all
> looks OK in the SPI driver, I can see it requesting and releasing with
> the refcounts all going back to zero in the DMA driver as expected but
On Tue, Aug 13, 2013 at 01:49:53AM +0200, Tomasz Figa wrote:
> I've been testing this without any significant patches, like PWM, CCF or
> DT support, just everything from the branch I pointed to and some board-
> specific patches to help in debugging.
Done some more digging. It's not failing th
From: Mark Brown
We always need the device to be runtime PM enabled to use it so just skip
the DMA initialisation not the entire prepare when polling.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 39 +++
1 file changed, 19 insertions(+), 20
On Sun, Aug 11, 2013 at 07:59:24PM +0200, Tomasz Figa wrote:
> +#define pl330_filter pl08x_filter_id
So, this is pretty fun and probably not going to play too nicely for
multiplatform kernels...
signature.asc
Description: Digital signature
On Mon, Aug 12, 2013 at 03:19:50PM +0530, Padmavathi Venna wrote:
> Samsung has different versions of I2S introduced in different
> platforms. Each version has some new support added for multichannel,
> secondary fifo, s/w reset control, internal mux for rclk src clk and
> tdm support. Each newly a
On Tue, Aug 13, 2013 at 01:49:53AM +0200, Tomasz Figa wrote:
> I've been testing this without any significant patches, like PWM, CCF or
> DT support, just everything from the branch I pointed to and some board-
> specific patches to help in debugging.
I retested with the SPI patches you sent sep
On Tue, Aug 13, 2013 at 11:27:04AM +0900, Inki Dae wrote:
> > Ensure that all externally accessed functions are correctly prototyped
> > when defined in each file by making sure the headers with the protoypes
> > are included in the file with the definition.
> I definitely missed it. sorry about
From: Mark Brown
Ensure that all externally accessed functions are correctly prototyped
when defined in each file by making sure the headers with the protoypes
are included in the file with the definition.
Signed-off-by: Mark Brown
---
drivers/gpu/drm/exynos/exynos_drm_connector.c | 1
On Mon, Aug 12, 2013 at 05:18:34PM -0600, Stephen Warren wrote:
> On 08/12/2013 05:13 PM, Mark Brown wrote:
> >> (although I dare say that at least samsung,supports-rstclr should
> >> be modified to use the new reset controller bindings)
> > Really? That doesn&#
On Sun, Aug 11, 2013 at 07:59:22PM +0200, Tomasz Figa wrote:
> With support for amba-pl08x driver, on S3C64xx the generic DMA engine
> API can be used instead of the private s3c-dma interface.
I'm still getting issues for SPI with this:
[ 50.952845] s3c64xx-spi s3c6410-spi.0: Failed to get RX D
On Mon, Aug 12, 2013 at 04:57:53PM -0600, Stephen Warren wrote:
> On 08/12/2013 03:49 AM, Padmavathi Venna wrote:
> > +- compatible : should be one of the following.
> > + - samsung,s3c6410-i2s: for 8/16/24bit stereo I2S.
> > + - samsung,s5pv210-i2s: for 8/16/24bit multichannel(5.1) I2S with
>
On Mon, Aug 12, 2013 at 01:41:23PM +0200, Tomasz Figa wrote:
> On Monday 12 of August 2013 12:34:48 Mark Brown wrote:
> > I'd expect that to interact badly with the pinmuxing - unless the device
> > is disabled it'll try to grab its pins on probe which is not going to be
On Mon, Aug 12, 2013 at 01:14:20PM +0200, Tomasz Figa wrote:
> On Monday 12 of August 2013 15:37:47 Padmavathi Venna wrote:
> > + i2s_0: i2s@0383 {
> > + status = "disabled";
> If a node does not require any board-specific properties for the device to
> operate properly, there is
On Mon, Aug 12, 2013 at 01:03:19AM +0200, Tomasz Figa wrote:
> On Sunday 11 of August 2013 20:11:40 Mark Brown wrote:
> > Do we need the select here (or should we have other selects for the
> > Exynos SoCs)?
> The driver would build fine without this symbol selected, but sin
501 - 600 of 1261 matches
Mail list logo
