Hi All,
Since I made the same mistake myself I've done a quick grep for
GFP_DMA32 in the kernel and drivers/scsi/aacraid/commctrl.c
came up as a result of this grep, it does:
p = kmalloc(sg_count[i], GFP_KERNEL|GFP_DMA32);
But kmalloc always returns memory from t
Hi,
On 10-01-18 16:23, Oliver Neukum wrote:
Am Mittwoch, den 10.01.2018, 08:13 +0100 schrieb Hans de Goede:
If we return 1 from our post_reset handler, then our disconnect handler
will be called immediately afterwards. Since pre_reset blocks all scsi
requests our disconnect handler will then
error")
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 5d04c40ee40a..5471422aa1ab 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/sto
Since commit 7fee72d5e8f1 ("uas: Always apply US_FL_NO_ATA_1X quirk to
Seagate devices"), the US_FL_NO_ATA_1X is always set for Seagate devices,
so the per device unusual_uas.h entries for Seagate devices can be
removed.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_
Hi,
On 15-11-17 10:06, Oliver Neukum wrote:
Am Dienstag, den 14.11.2017, 18:44 +0100 schrieb Hans de Goede:
Greg, please do no merge the 2 recent uas seagate quirks I send
then. I will submit a patch with the new approach right away.
Hi,
I am afraid in that case we will need a way to
We've been adding this as a quirk on a per device basis hoping that
newer disk enclosures would do better, but that has not happened,
so simply apply this quirk to all Seagate devices.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas-detect.h | 4
1 file changed, 4 inser
Hi,
On 11/14/2017 04:25 PM, Alan Stern wrote:
On Tue, 14 Nov 2017, Hans de Goede wrote:
Hi,
On 14-11-17 15:00, Hans de Goede wrote:
Just like all previous UAS capable Seagate disk enclosures, this
one needs a US_FL_NO_ATA_1X quirk.
Cc: sta...@vger.kernel.org # 3.16
Reported-by: Wido
Hi,
On 14-11-17 15:00, Hans de Goede wrote:
Just like all previous UAS capable Seagate disk enclosures, this
one needs a US_FL_NO_ATA_1X quirk.
Cc: sta...@vger.kernel.org # 3.16
Reported-by: Wido
Signed-off-by: Hans de Goede
So far we've been adding quirks for Seagate drives on a o
Just like all previous UAS capable Seagate disk enclosures, this
one needs a US_FL_NO_ATA_1X quirk.
Cc: sta...@vger.kernel.org # 3.16
Reported-by: Wido
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb
Hi,
On 13-11-17 07:14, Jérôme Carretero wrote:
On Mon, 13 Nov 2017 07:01:30 +0300
Andrey Astafyev <1...@246060.ru> wrote:
13.11.2017 00:42, Jérôme Carretero пишет:
Nov 12 16:20:59 Bidule kernel: sd 22:0:0:0: [sdaa] tag#2
uas_eh_abort_handler 0 uas-tag 3 inflight: CMD OUT
[...]
Do you see such
Just like all previous UAS capable Seagate disk enclosures, this
one needs a US_FL_NO_ATA_1X quirk.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Andrey Astafyev <1...@246060.ru>
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 inse
Hi,
On 08-05-17 11:06, Ricard Wanderlof wrote:
On Mon, 8 May 2017, David Woodhouse wrote:
On Mon, 8 May 2017, David Woodhouse wrote:
Our empirical testing trumps your "can never happen" theory :)
I'm sure it does. But what is the explanation then? Has anyone analyzed
what is going on using
Hi,
On 21-12-16 13:07, George Cherian wrote:
On 12/21/2016 05:12 PM, Oliver Neukum wrote:
On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote:
Hi Oliver,
I was working with this JMicron device and using the uas driver.
I am seeing the following 2 issues.
1) On connect I see the followi
Hi,
On 21-12-16 12:42, Oliver Neukum wrote:
On Wed, 2016-12-21 at 17:09 +0530, George Cherian wrote:
Hi Oliver,
I was working with this JMicron device and using the uas driver.
I am seeing the following 2 issues.
1) On connect I see the following messages.
Thanks. Do you want to submit it t
FUA | US_FL_NO_REPORT_OPCODES),
+/* Reported-by George Cherian */
+UNUSUAL_DEV(0x152d, 0x9561, 0x, 0x,
+"JMicron",
+"JMS56x",
+USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+US_FL_NO_REPORT_OPCODES),
+
/* Rep
Oliver Neukum is taking over uas maintainership from me and
Gerd Hoffmann.
Cc: Oliver Neukum
Cc: Gerd Hoffmann
Signed-off-by: Hans de Goede
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5c728d1..9c220f0 100644
--- a
Hi,
On 13-06-16 14:05, Oliver Neukum wrote:
On Tue, 2016-05-31 at 09:18 +0200, Hans de Goede wrote:
Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level")
removed the scsi_change_queue_depth() call from uas_slave_configure()
assuming that the slave would inherit
Hi Greg,
There was some discussion about this patch during its initial posting,
but the concensus seems to be that this patch, which is in essence a
partial revert of the patch causing the problem, is the best way to fix
this.
So I'm resending this to make sure it does not fall through the cracks
ct, without the scsi_change_queue_depth() call the slave's
queue_depth defaults to 1, introducing a performance regression.
This commit restores the call, fixing the performance regression.
Cc: sta...@vger.kernel.org
Fixes: 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level")
Reported-by: T
Hi,
On 24-05-16 14:44, James Bottomley wrote:
On Tue, 2016-05-24 at 08:53 +0200, Hans de Goede wrote:
Hi,
On 23-05-16 19:36, James Bottomley wrote:
On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote:
Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host
level")
r
Hi,
On 24-05-16 10:18, Tom Yan wrote:
In this commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/usb/storage/uas.c?id=198de51dbc3454d95b015ca0a055b673f85f01bb
There is the following comment:
1 tag is reserved for untagged commands
So my question is, what e
ng this is good:
Acked-by: Hans de Goede
Regards,
Hans
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 4d49fce..e03c490 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -848,7 +848,6 @@ static struct scsi_host_template uas_hos
Hi,
On 23-05-16 19:36, James Bottomley wrote:
On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote:
Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level")
removed the scsi_change_queue_depth() call from uas_slave_configure()
assuming that the slave would inherit
ct, without the scsi_change_queue_depth() call the slave's
queue_depth defaults to 1, introducing a performance regression.
This commit restores the call, fixing the performance regression.
Cc: sta...@vger.kernel.org
Fixes: 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level")
Reported-by: T
Hi,
On 22-05-16 12:39, Tom Yan wrote:
With commit 198de51dbc3454d95b015ca0a055b673f85f01bb, uas no longer
set `queue_depth` with scsi_change_queue_depth(), so now `queue_depth`
of UAS drives are 1. Even though `can_queue` is set to
`devinfo->qdepth - 2`, but apparently that does not help, since
Hi,
On 23-04-16 23:10, Johannes Stezenbach wrote:
Hi,
I bought a new backup disk which turned out to be UAS capable,
but when I plugged it in I got an order 7 page allocation failure.
My hunch is that the .can_queue = 65536 in drivers/usb/storage/uas.c
is much too large. Maybe 256 would be a p
Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with
an usb-id of: 0bc2:331a, as these will fail to respond to a
REPORT_LUNS command.
Cc: sta...@vger.kernel.org
Reported-and-tested-by: David Webb
Signed-off-by: Hans de Goede
---
Changes in v2:
-Document new j quirk in Documentation
1315013
Cc: sta...@vger.kernel.org # 4.4.x and 4.5.x
Signed-off-by: Hans de Goede
---
Changes in v2:
-Fix some spelling issues in the commit message and in a comment
---
drivers/usb/storage/uas.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/storage/uas.c b/d
Hi,
On 31-03-16 17:11, James Bottomley wrote:
On Thu, 2016-03-31 at 17:03 +0200, Hans de Goede wrote:
Hi,
On 31-03-16 16:48, James Bottomley wrote:
On Thu, 2016-03-31 at 14:22 +0200, Hans de Goede wrote:
Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with
an usb-id of: 0bc2
Hi,
On 31-03-16 16:48, James Bottomley wrote:
On Thu, 2016-03-31 at 14:22 +0200, Hans de Goede wrote:
Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with
an usb-id of: 0bc2:331a, as these will fail to respond to a
REPORT_LUNS command.
Actually, if we're sending them a r
Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with
an usb-id of: 0bc2:331a, as these will fail to respond to a
REPORT_LUNS command.
Cc: sta...@vger.kernel.org
Reported-and-tested-by: David Webb
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 14
Hi,
On 19-03-16 18:06, James Bottomley wrote:
On Sat, 2016-03-19 at 09:59 +0100, Hans de Goede wrote:
Commit 64d513ac31bd ("scsi: use host wide tags by default") causes
the scsi-core to queue more cmnds then we can handle on devices with
multiple LUNs, limit the qdepth at the scsi-
13
Cc: sta...@vger.kernel.org # 4.4.x and 4.5.x
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index c90a7e4..b5cb7ab 100644
--- a/drivers/usb/storage/uas.c
+++
Hi,
On 09-03-16 19:26, Christoph Hellwig wrote:
On Wed, Mar 09, 2016 at 06:58:48PM +0100, Hans de Goede wrote:
So my question is how do I tell the scsi layer to not submit more then X
commands with
scsi_init_shared_tag_map() gone ?
By setting ->can_queue in the Scsi_Host structure to
Hi Christoph,
I've received a bug report that uas is causing a 2-disk enclosure to
lookup with 4.4 and later:
https://bugzilla.redhat.com/show_bug.cgi?id=1315013
Looking at the dmesg this stands out:
Mar 09 01:55:21 larry kernel: sd 2:0:0:1: [sdc] tag#31 uas_eh_abort_handler 0
uas-tag 32 infl
"Page allocation
failure (order 7)" error on systems which have been running for a while
and thus have fragmented memory.
Cc: sta...@vger.kernel.org
Reported-and-tested-by: Yves-Alexis Perez
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 2 +-
1 file changed, 1 inser
Hi,
On 04-03-16 08:13, Yves-Alexis Perez wrote:
On mar., 2016-03-01 at 11:49 +0100, Hans de Goede wrote:
Hi,
On 01-03-16 10:42, Yves-Alexis Perez wrote:
Hi,
[sorry if this is not the right point for reporting bugs, I took the email
addresses from MAINTAINERS but please point me to the
Hi,
On 01-03-16 10:42, Yves-Alexis Perez wrote:
Hi,
[sorry if this is not the right point for reporting bugs, I took the email
addresses from MAINTAINERS but please point me to the correct place if needed]
I have an external USB drive (Samsung M3), which apparently uses the UAS code.
Starting
Testing has shown that ASM1053 devices do not work properly with transfers
larger than 240 sectors, so set max_sectors to 240 on these.
Cc: sta...@vger.kernel.org # 3.16
Reported-by: Steve Bangert
Signed-off-by: Hans de Goede
Tested-by: Steve Bangert
---
Changes in v2:
-Add Cc stable@vger
-Add
adds support
for US_FL_MAX_SECTORS_64 to uas.c.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
Changes in v2:
-Document new 'g' flag in kernel-parameters.txt
-Add Cc stable@vger
---
Documentation/kernel-parameters.txt | 2 ++
drivers/usb/storage/uas.c
...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
Changes in v2:
-Add Cc stable@vger
---
drivers/usb/storage/uas-detect.h | 6 +-
drivers/usb/storage/uas.c| 6 +++---
drivers/usb/storage/usb.c| 2 +-
3 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/usb
Testing has shown that ASM1053 devices do not work properly with transfers
larger than 240 sectors, so set max_sectors to 240 on these.
Reported-by: Steve Bangert
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas-detect.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
adds support for
US_FL_MAX_SECTORS_64 to uas.c.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 10 +-
drivers/usb/storage/usb.c | 6 +-
include/linux/usb_usual.h | 2 ++
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers
: Hans de Goede
---
drivers/usb/storage/uas-detect.h | 6 +-
drivers/usb/storage/uas.c| 6 +++---
drivers/usb/storage/usb.c| 2 +-
3 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h
index 9893d69
: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b/drivers/usb/storage/unusual_uas.h
index 8257042..c85ea53 100644
--- a/drivers/usb/storage/unusual_
Like the JMicron JMS567 enclosures with the JMS539 choke on report-opcodes,
so avoid it.
Tested-and-reported-by: Tom Arild Naess
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a
a
Cc: Hans de Goede
Cc: Tejun Heo
Cc: Christoph Hellwig
Cc: "James E.J. Bottomley"
Cc: linux-...@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Looks good to me:
Acked-by: Hans de Goede
Regards,
Hans
---
drivers/ata/libahci_platform.c | 14 --
include/linux/
Like some other uas devices these devices hang when a report-opcodes scsi
command is send to them.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1124119
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7
Just like all previous UAS capable Seagate disk enclosures, these need the
US_FL_NO_ATA_1X to not crash when udev probes them.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a
descriptors are not 100% identical, unlike the previous
models the ASM1153 has bMaxPower == 0, so use that to differentiate it.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas-detect.h | 33 -
drivers/usb/storage/unusual_uas.h | 8
2 files changed
On 11-12-14 20:01, Darrick J. Wong wrote:
The Apricorn SATA dongle will occasionally return "USBSUSBSUSB" in
response to SCSI commands when running in UAS mode. Therefore,
disable UAS mode on this dongle.
Signed-off-by: Darrick J. Wong
Looks good:
Acked-by: Hans de Goede
Gre
. Wong wrote:
On Wed, Dec 10, 2014 at 09:19:04AM +0100, Hans de Goede wrote:
Hi,
On 09-12-14 20:31, Darrick J. Wong wrote:
Hi,
I have an Apricorn USB 3 disk dongle thing that claims to support UAS.
However, the kernel crashes when I plug it in[1].
Yes there are some known issues with uas
Hi,
On 09-12-14 20:31, Darrick J. Wong wrote:
Hi,
I have an Apricorn USB 3 disk dongle thing that claims to support UAS.
However, the kernel crashes when I plug it in[1].
Yes there are some known issues with uas error handling which are fixed
in 3.18, can you try with a 3.18 kernel please ?
Like the JMicron JMS567 enclosures with the JMS566 choke on report-opcodes,
so avoid it.
Tested-and-reported-by: Takeo Nakayama
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a
This is yet another Seagate device which needs the US_FL_NO_ATA_1X quirk
Reported-by: Marcin Zajączkowski
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage
Logic controller for
myself to see if I can come up with a better fix then the big hammer, in
the mean time this will make uas devices work again (in usb-storage mode)
for FL1000G users.
Reported-by: Marcin Zajączkowski
Cc: sta...@vger.kernel.org # 3.15
Signed-off-by: Hans de Goede
---
drivers/usb/host
These disks have a broken uas implementation, the tag field of the status
iu-s is not set properly, so we need to fall-back to usb-storage for these.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions
These drives hang when receiving ATA12 commands, so set the US_FL_NO_ATA_1X
quirk to filter these out.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage
These drives hang when receiving ATA12 commands, so set the US_FL_NO_ATA_1X
quirk to filter these out.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/usb/storage
g.
While touching all involved code anyways also rename the uas_cmd_info stream
field to uas_tag, because when using uas over usb-2 streams are not used.
Cc: Christoph Hellwig
Reported-by: Douglas Gilbert
Signed-off-by: Hans de Goede
Reviewed-by: Christoph Hellwig
--
Changes in v2:
-Remove "
Just like some Seagate enclosures, these devices do not seem to grok ata
pass through commands.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b
Hi,
On 10/05/2014 11:10 AM, Christoph Hellwig wrote:
> On Sun, Oct 05, 2014 at 11:06:00AM +0200, Hans de Goede wrote:
>> This patch sits on top of a lot of other uas fixes which are already
>> in usb-next, so this needs to go in through usb-next.
>
> What is the actual c
Hi,
On 10/04/2014 04:46 PM, James Bottomley wrote:
> On Sat, 2014-10-04 at 10:53 +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 10/03/2014 11:47 PM, Greg Kroah-Hartman wrote:
>>> On Fri, Oct 03, 2014 at 12:08:57PM +0200, Hans de Goede wrote:
>>>> With uas ov
Hi,
On 10/03/2014 11:47 PM, Greg Kroah-Hartman wrote:
> On Fri, Oct 03, 2014 at 12:08:57PM +0200, Hans de Goede wrote:
>> With uas over usb-3 the tags inside the uas iu-s must match the usb-3 stream
>> ids, and those go from 1 - qdepth.
>>
>> Before blk-mq calling scs
g.
While touching all involved code anyways also rename the uas_cmd_info stream
field to uas_tag, because when using uas over usb-2 streams are not used.
Cc: Christoph Hellwig
Reported-by: Douglas Gilbert
Signed-off-by: Hans de Goede
Reviewed-by: Christoph Hellwig
--
Changes in v2:
-Remove "
The stream_id and pipe are already present in uas_cmd_info resp uas_dev_info,
so there is no need to pass a copy along.
Signed-off-by: Hans de Goede
Reviewed-by: Christoph Hellwig
---
drivers/usb/storage/uas.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions
t;
> The uas driver uses the block layer tag for USB3 stream IDs. With
> blk-mq we can get larger tag numbers that the queue depth, which breaks
> this assumption. A fix is under way for 3.18, but sits on top of
> large changes so can't easily be backported. Set the disable_blk_
Hi,
On 10/02/2014 03:25 PM, James Bottomley wrote:
> On Thu, 2014-10-02 at 15:18 +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 10/02/2014 03:12 PM, Christoph Hellwig wrote:
>>> On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote:
>>>> Yes, alt
Hi,
On 10/02/2014 03:12 PM, Christoph Hellwig wrote:
> On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote:
>> Yes, although that likely would need to go through stable, without
>> going into 3.18 .
>>
>> Greg, is this ok with you and how do I get a patch i
Hi,
On 10/02/2014 03:06 PM, Christoph Hellwig wrote:
> On Thu, Oct 02, 2014 at 02:35:10PM +0200, Hans de Goede wrote:
>> This patch sits on top of a whole bunch of uas cleanups / fixes which
>> are going into 3.18, and which are to big of a change to backport.
>
> C
Hi,
On 10/02/2014 01:26 PM, Christoph Hellwig wrote:
> Looks fine to me (and actually removes code..)
>
> Reviewed-by: Christoph Hellwig
>
> It's fairly late in 3.17 to get something like this in, but would you
> consider Ccing it to stable so we can get it into the first 3.17 stable
> release?
g.
While touching all involved code anyways also rename the uas_cmd_info stream
field to uas_tag, because when using uas over usb-2 streams are not used.
Cc: Christoph Hellwig
Reported-by: Douglas Gilbert
Signed-off-by: Hans de Goede
---
drivers/usb/
The stream_id and pipe are already present in uas_cmd_info resp uas_dev_info,
so there is no need to pass a copy along.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/drivers/usb
Hi,
On 10/01/2014 02:45 PM, Christoph Hellwig wrote:
> On Wed, Oct 01, 2014 at 10:17:41AM +0200, Hans de Goede wrote:
>> The problematic part here, which I believe is caused by scsi_mod.blk_mq=Y,
>> is the tag number 33. uas.c does the following in slave_configure:
>>
>
Hi Christoph,
Douglas Gilbert (in the CC), has been testing uas with
scsi_mod.blk_mq=Y and this fails. When it fails the following
messages appear in dmesg:
kernel: scsi host8: uas
kernel: blk-mq: reduced tag depth to 10240
mtp-probe: checking bus 2, device 3:
"/sys/devices/pci:00/:00:14
As most ASM1051 based devices, this one has unfixable issues with uas too.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b/drivers/usb/storage
https://bbs.archlinux.org/viewtopic.php?pid=1457492
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h
b/drivers/usb/storage/unusual_uas.h
index 3e62437..94fb09f 100644
--- a/drivers
so add a quirk
for this, and set it for the JMS567.
*) Which has become a non-issue since we've completely blacklisted uas on
the ASM1051 for other reasons
Cc: sta...@vger.kernel.org
Reported-and-tested-by: Claudio Bizzarri
Signed-off-by: Hans de Goede
---
Documentation/kernel-paramet
Hi Greg, et al,
Another day, another uas quirk. Although you may not see it that way, this
is
actually a good thing :) With the new uas error handling code (which users
are
testing through a stand-alone version of the uas driver), people are now
actually sending me logs with useful error messages
csi: add support for a blk-mq based I/O path.
> Reported-by: Hans de Goede
> Signed-off-by: Christoph Hellwig
> ---
> include/scsi/scsi_tcq.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h
> index
Hi,
On 09/15/2014 04:08 PM, Greg Kroah-Hartman wrote:
> On Mon, Sep 15, 2014 at 04:04:12PM +0200, Hans de Goede wrote:
>> And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one
>> seems to hang upon receiving an ATA_12 or ATA_16 command.
>>
>>
usb-storage
quirks.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
Changes in v3: Fix typo in documentation
Changes in v4: Also apply the quirk to (0bc2:3312)
Changes in v5: Rebased on 3.17-rc5, drop u
Hi,
On 09/15/2014 10:42 AM, David Laight wrote:
> From: Alan Stern
> ...
>>> p = quirks;
>>> while (*p) {
>>> @@ -543,6 +544,9 @@ void usb_stor_adjust_quirks(struct usb_device *udev,
>>> unsigned long *fflags)
>>> case 's':
>>> f |= US_FL_SINGLE_LUN;
>>>
Hi Greg,
Sorry for the high number of iterations on this one. After the documentation
issues pointed out during review, I've just received a report from a user
that (as I already suspected) another seagate disk enclosure also benifits
from this quirk. So this version sets the quirk for 2 different
usb-storage
quirks.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
Changes in v3: Fix typo in documentation
Changes in v4: Also apply the quirk to (0bc2:3312)
---
Documentation/kernel-parameters.txt | 3
Hi,
On 09/14/2014 12:29 PM, James Bottomley wrote:
> On Sun, 2014-09-14 at 11:26 +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 09/13/2014 09:31 PM, Sergei Shtylyov wrote:
>>> Hello.
>>>
>>> On 9/13/2014 1:26 PM, Hans de Goede wrote:
>>>
>
# 3.16
Signed-off-by: Hans de Goede
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
Changes in v3: Fix typo in documentation
---
Documentation/kernel-parameters.txt | 3 +++
drivers/usb/storage/uas.c | 13 +
drivers/usb/storage/unusual_uas.h
>>> https://bugzilla.kernel.org/show_bug.cgi?id=79511
>
>>> While at it also add missing documentation for the u value for usb-storage
>>> quirks.
>
>>> Cc: sta...@vger.kernel.org # 3.16
>>> Signed-off-by: Hans de Goede
>
>>> --
>>&
Hi,
On 09/13/2014 07:50 PM, Christoph Hellwig wrote:
> On Sat, Sep 13, 2014 at 12:28:41PM +0200, Hans de Goede wrote:
>> Yes this one does the trick and fixes things. Note the git tree I used for
>> testing also had your previous fix to split up the blk_tcq union in 2
>> se
Hi,
On 09/13/2014 09:31 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 9/13/2014 1:26 PM, Hans de Goede wrote:
>
>> The data urbs are all killed before calling zap_pending, and their completion
>> handler should have cleared their inflight flag.
>
>> Do not 0 t
# 3.16
Signed-off-by: Hans de Goede
--
Changes in v2: Add documentation for new t and u usb-storage.quirks flags
---
Documentation/kernel-parameters.txt | 3 +++
drivers/usb/storage/uas.c | 13 +
drivers/usb/storage/unusual_uas.h | 16 ++--
drivers/usb/storage
Factor out the mapping of scsi-tags -> uas-tags/stream-ids to a helper function
so that there is a single place where this "magic" happens.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 33 +
1 file changed, 21 insertions(+), 12 delet
Drop the whole dance with first moving cmnds to a dead-list. The resetting
flag ensures that no new cmds / urbs will be submitted, and that any urb
completions are short-circuited without trying to complete the scsi cmnd.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 43
usb-2 we may have never tried to submit the data urbs
when completing the scsi cmnd, because we never got a READ/WRITE_READY iu
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/usb/storage/uas.c b/dr
We've the same info doubled in both the inflight list and the cmnd array,
drop the list.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/driver
The status urb should not complete before the command has been submitted, nor
should we get a second status urb for the same tag after a IU_ID_STATUS.
Data urbs should not complete before the command has been submitted, but may
complete after the IU_ID_STATUS.
Signed-off-by: Hans de Goede
ownership to the scsi
midlayer without holding the lock due to the midlayer re-claiming ownership
through an abort (which will be handled by a future patch in this series).
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 48 ++-
1 file c
out doing any boundary checking
Instead keep our own list which maps tags -> inflight cmnds.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 39 ++-
1 file changed, 18 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/storage/uas.c b
Do not keep references around to a cmnd which is under error handling.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 47 ---
1 file changed, 44 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage
Now that we no longer drop our lock to unlink the data urbs, we can simply
free them on completion, making their handling consistent with the other urbs.
Signed-off-by: Hans de Goede
---
drivers/usb/storage/uas.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers
1 - 100 of 214 matches
Mail list logo
