Re: [RFC] SCSI EH document

2005-09-07 Thread James Bottomley
On Wed, 2005-09-07 at 20:22 +0900, Tejun Heo wrote: > If James agrees, I'll reformat it to DocBook and submit the patch. > James, what do you think? Certainly ... just submit it as a patch and I'll put it in. As far as docbook goes, that's fine ... it's just that docbook has to be built and it

Re: [RFC] SCSI EH document

2005-09-07 Thread Luben Tuikov
On 09/07/05 07:22, Tejun Heo wrote: > Hello, Jeff & James. > > Jeff Garzik wrote: > >>Tejun Heo wrote: >> >> >>> Hello, fellow SCSI/ATA developers. >>> >>> This is the first draft of SCSI EH document. This document tries to >>>describe how SCSI EH works and what choirs should be done to mainta

Re: [RFC] SCSI EH document

2005-09-07 Thread Tejun Heo
Hello, Jeff & James. Jeff Garzik wrote: Tejun Heo wrote: Hello, fellow SCSI/ATA developers. This is the first draft of SCSI EH document. This document tries to describe how SCSI EH works and what choirs should be done to maintain SCSI midlayer integrity. It's intended that this document

Re: [RFC] SCSI EH document

2005-09-07 Thread Jeff Garzik
Tejun Heo wrote: Hello, fellow SCSI/ATA developers. This is the first draft of SCSI EH document. This document tries to describe how SCSI EH works and what choirs should be done to maintain SCSI midlayer integrity. It's intended that this document can be used as reference for implementing ei

Re: [RFC] SCSI EH document

2005-08-30 Thread Luben Tuikov
On 08/30/05 06:47, Tejun Heo wrote: > Hi, Luben. > > Luben Tuikov wrote: > >>On 08/29/05 05:14, Tejun Heo wrote: >> >> Both all the list-heads need to be cleared, otherwise there may be list corruption next time the element is added to the list_head. >>> >>> >>> scmd->eh_entry is

Re: [RFC] SCSI EH document

2005-08-30 Thread Tejun Heo
Hi, Luben. Luben Tuikov wrote: On 08/29/05 05:14, Tejun Heo wrote: Both all the list-heads need to be cleared, otherwise there may be list corruption next time the element is added to the list_head. scmd->eh_entry is never used as list head. It's always used as list entry. So, techn

Re: [RFC] SCSI EH document

2005-08-29 Thread Jeff Garzik
Tejun Heo wrote: Hi, Jeff. Jeff Garzik wrote: Tejun Heo wrote: Both all the list-heads need to be cleared, otherwise there may be list corruption next time the element is added to the list_head. scmd->eh_entry is never used as list head. It's always used as list entry. So, technica

Re: [RFC] SCSI EH document

2005-08-29 Thread Tejun Heo
Hi, Jeff. Jeff Garzik wrote: Tejun Heo wrote: Both all the list-heads need to be cleared, otherwise there may be list corruption next time the element is added to the list_head. scmd->eh_entry is never used as list head. It's always used as list entry. So, technically, it needs not b

Re: [RFC] SCSI EH document

2005-08-29 Thread Jeff Garzik
Matthew Wilcox wrote: On Mon, Aug 29, 2005 at 02:50:35PM -0400, Jeff Garzik wrote: Every node is a list_head. You want all pointers for all nodes pointing to something useful, even if they are not actively present on a list, so that they may be easily and corrected added to a list at a later

Re: [RFC] SCSI EH document

2005-08-29 Thread Matthew Wilcox
On Mon, Aug 29, 2005 at 02:50:35PM -0400, Jeff Garzik wrote: > Every node is a list_head. You want all pointers for all nodes pointing > to something useful, even if they are not actively present on a list, so > that they may be easily and corrected added to a list at a later time. > Read list_

Re: [RFC] SCSI EH document

2005-08-29 Thread Jeff Garzik
Tejun Heo wrote: Both all the list-heads need to be cleared, otherwise there may be list corruption next time the element is added to the list_head. scmd->eh_entry is never used as list head. It's always used as list entry. So, technically, it needs not be cleared, I think. No? The pro

Re: [RFC] SCSI EH document

2005-08-29 Thread Luben Tuikov
On 08/29/05 05:14, Tejun Heo wrote: >>Both all the list-heads need to be cleared, otherwise there may be list >>corruption next time the element is added to the list_head. >> > > > scmd->eh_entry is never used as list head. It's always used as list > entry. So, technically, it needs not be

Re: [RFC] SCSI EH document

2005-08-29 Thread Tejun Heo
Hi, Jeff. Jeff Garzik wrote: Tejun Heo wrote: Hello, fellow SCSI/ATA developers. This is the first draft of SCSI EH document. This document tries to describe how SCSI EH works and what choirs should be done to maintain SCSI midlayer integrity. It's intended that this document can be use

Re: [RFC] SCSI EH document

2005-08-28 Thread Luben Tuikov
On 08/25/05 23:53, Tejun Heo wrote: > Hello, fellow SCSI/ATA developers. > > This is the first draft of SCSI EH document. This document tries to > describe how SCSI EH works and what choirs should be done to maintain > SCSI midlayer integrity. It's intended that this document can be used > as

Re: [RFC] SCSI EH document

2005-08-26 Thread Jeff Garzik
Tejun Heo wrote: Hello, fellow SCSI/ATA developers. This is the first draft of SCSI EH document. This document tries to describe how SCSI EH works and what choirs should be done to maintain SCSI midlayer integrity. It's intended that this document can be used as reference for implementing ei