On Mon, Mar 4, 2024 at 8:01 AM Jason Xing wrote:
>
> On Fri, Mar 1, 2024 at 1:10 AM Jason Xing wrote:
> >
> > From: Jason Xing
> >
> > When I reviewed other people's patch [1], I noticed that similar thing
> > also happens in tcp_event_skb class and tcp_event_sk_skb class. They
> > don't print
On Thu, Feb 29, 2024 at 6:10 PM Jason Xing wrote:
>
> From: Jason Xing
>
> Prio to this patch, the trace function doesn't print addresses
> which might be forgotten. As we can see, it already fetches
> those, use it directly and it will print like below:
>
> ...tcp_retransmit_skb: skbaddr=XXX
On Mon, Mar 4, 2024 at 4:24 PM Eric Dumazet wrote:
>
> On Thu, Feb 29, 2024 at 6:10 PM Jason Xing wrote:
> >
> > From: Jason Xing
> >
> > Prio to this patch, the trace function doesn't print addresses
> > which might be forgotten. As we can see, it already fetches
> > those, use it directly and
From: Jason Xing
Use the existing parameter and print the address of skbaddr
as other trace functions do.
Signed-off-by: Jason Xing
---
include/trace/events/tcp.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
From: Jason Xing
When I reviewed other people's patch [1], I noticed that similar things
also happen in tcp_event_skb class and tcp_event_sk_skb class. They
don't print those two addrs of skb/sk which already exist.
In this patch, I just do as other trace functions do, like
From: Jason Xing
Printing the addresses can help us identify the exact skb/sk
for those system in which it's not that easy to run BPF program.
As we can see, it already fetches those, then use it directly
and it will print like below:
...tcp_retransmit_skb: skbaddr=XXX skaddr=XXX
On Sat, 02 Mar 2024 06:02:22 +0900,
Geert Uytterhoeven wrote:
>
> arch/sh/boot/compressed/cache.c:2:5: warning: no previous prototype for
> ‘cache_control’ [-Wmissing-prototypes]
> arch/sh/boot/compressed/misc.c:115:6: warning: no previous prototype for
> ‘ftrace_stub’ [-Wmissing-prototypes]
>
