Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Fabio Estevam
On Tue, Jan 27, 2015 at 10:36 AM, robert.jarz...@free.fr wrote: - Mail original - De: Fabio Estevam feste...@gmail.com À: Robert Jarzmik robert.jarz...@free.fr Cc: Felipe Balbi ba...@ti.com, Linus Walleij linus.wall...@linaro.org, Philipp Zabel philipp.za...@gmail.com, USB list

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread robert . jarzmik
- Mail original - De: Fabio Estevam feste...@gmail.com À: Robert Jarzmik robert.jarz...@free.fr Cc: Felipe Balbi ba...@ti.com, Linus Walleij linus.wall...@linaro.org, Philipp Zabel philipp.za...@gmail.com, USB list linux-usb@vger.kernel.org Envoyé: Mardi 27 Janvier 2015 13:41:57 Objet:

[PATCH 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-01-27 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Add the binding documentation for the JZ47xx OHCI controller. Signed-off-by: Paul Burton paul.bur...@imgtec.com Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- The jz4740 is platform only at the moment. But DT support is being

[PATCH v2] chipidea: pci: register nop PHY

2015-01-27 Thread Andy Shevchenko
Since PHY for ChipIdea is optional (not all SoCs having PHY for ChipIdea should be programmed), we register 'nop' PHY for platforms that do not have programmable PHY. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- Since v1: - address Felipe's comment regarding the commit

[PATCH 3/3] usb: ohci: jz4740: prepare the clock before enabling it

2015-01-27 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com The clock must have been prepared before enabling it. Signed-off-by: Paul Burton paul.bur...@imgtec.com --- drivers/usb/host/ohci-jz4740.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-jz4740.c

[PATCH 0/3] usb: ohci: jz4740: Add DT support and a fix

2015-01-27 Thread Zubair Lutfullah Kakakhel
Hi, Here are a few simple patches for the jz4740. First adds a simple DT binding. Seconds adds DT support. Third is a minor fix in clock enabling. Patches are based on 3.19-rc6. Quite disjoint and stay within jz4740 so should apply easily on other trees. If you would like to have them rebased

[PATCH 2/3] usb: ohci: jz4740: add DT support

2015-01-27 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com This is a simple matter of providing a match table, the probe code needs no modification. Signed-off-by: Paul Burton paul.bur...@imgtec.com --- drivers/usb/host/ohci-jz4740.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH_V2 0/3] usb: ohci: jz4740: Add DT support and a fix

2015-01-27 Thread Zubair Lutfullah Kakakhel
Hi, Here are a few simple patches for the jz4740. First adds a simple DT binding. Seconds adds DT support. Third is a minor fix in clock enabling. Patches are based on 3.19-rc6. Quite disjoint and stay within jz4740 so should apply easily on other trees. If you would like to have them rebased

[PATCH_V2 2/3] usb: ohci: jz4740: add DT support

2015-01-27 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com This is a simple matter of providing a match table, the probe code needs no modification. Signed-off-by: Paul Burton paul.bur...@imgtec.com --- drivers/usb/host/ohci-jz4740.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH_V2 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-01-27 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com Add the binding documentation for the JZ47xx OHCI controller. Signed-off-by: Paul Burton paul.bur...@imgtec.com Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com --- The jz4740 is platform only at the moment. But DT support is being

[PATCH_V2 3/3] usb: ohci: jz4740: prepare the clock before enabling it

2015-01-27 Thread Zubair Lutfullah Kakakhel
From: Paul Burton paul.bur...@imgtec.com The clock must have been prepared before enabling it. Signed-off-by: Paul Burton paul.bur...@imgtec.com -- V2 changes. Add disable_unprepare as well --- drivers/usb/host/ohci-jz4740.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 4/4] usb: dwc3: remove reliance on dev_vdbg()

2015-01-27 Thread Felipe Balbi
By moving all dev_vdbg() to tracepoints, we can finally get rid of dev_vdbg() usage from dwc3. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/dwc3/Kconfig | 6 - drivers/usb/dwc3/Makefile | 1 - drivers/usb/dwc3/core.c | 2 +- drivers/usb/dwc3/gadget.c | 65

[PATCH 0/4] usb: dwc3: remove VERBOSE_DEBUG

2015-01-27 Thread Felipe Balbi
Hi, these patches move all dev_vdbg() messages to tracepoints. Below there's a sample output with all dwc3 tracepoints enabled. David, I've Cced you because you raised a concern about removing dev_* from dwc3. IMHO, traditional printk() changes the behavior way too much for any real USB3

[PATCH 3/4] usb: dwc3: trace: add trace logs for core and gadget

2015-01-27 Thread Felipe Balbi
Sometimes we want to just print a formatted string without passing any extra data. The following will be used for removing reliance on dev_vdbg() from dwc3. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/dwc3/trace.h | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH 2/4] usb: dwc3: gadget: WARN() in case of unknown IRQ

2015-01-27 Thread Felipe Balbi
if an unknown IRQ event is triggered, that means the HW is really misbehaving. Instead of printing a debug message, let's WARN() so users report when that happens. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] USB: cdc-acm: check for descriptors with invalid length

2015-01-27 Thread Oliver Neukum
On Fri, 2015-01-23 at 23:08 +0800, Adam Lee wrote: Hi, could you test and review this? Regards Oliver From 1ddabb5731135fe43f67f3b4645445c2de06dada Mon Sep 17 00:00:00 2001 From: Oliver Neukum oneu...@suse.de Date: Tue, 13 Jan 2015 16:55:52 +0100 Subject: [PATCH]

Re: [PATCH] usb: phy-generic: Don't fail on missing gpio reset

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 11:13:08AM -0800, Sören Brinkmann wrote: On Tue, 2015-01-27 at 09:20AM -0600, Felipe Balbi wrote: On Mon, Jan 26, 2015 at 05:45:29PM -0800, Soren Brinkmann wrote: A reset through a GPIO is optional. Don't fail probing when it is missing. Reported-by: Andreas

Re: [PATCH] usb: phy-generic: Don't fail on missing gpio reset

2015-01-27 Thread Sören Brinkmann
On Tue, 2015-01-27 at 09:20AM -0600, Felipe Balbi wrote: On Mon, Jan 26, 2015 at 05:45:29PM -0800, Soren Brinkmann wrote: A reset through a GPIO is optional. Don't fail probing when it is missing. Reported-by: Andreas Färber afaer...@suse.de Signed-off-by: Soren Brinkmann

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 05:42:02PM -0200, Fabio Estevam wrote: On Tue, Jan 27, 2015 at 12:16 PM, Fabio Estevam feste...@gmail.com wrote: On Tue, Jan 27, 2015 at 11:37 AM, robert.jarz...@free.fr wrote: Is in the right node, ie. the node that has compatible == usb-nop-xceiv ? Yes, it is

Re: [PATCH] usb: gadget: composite: Provide list of registered functions

2015-01-27 Thread Felipe Balbi
Hi, On Tue, Jan 27, 2015 at 08:20:58PM +0100, Krzysztof Opasiak wrote: -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, January 27, 2015 7:45 PM To: Krzysztof Opasiak Cc: ba...@ti.com; linux-usb@vger.kernel.org; gre...@linuxfoundation.org;

RE: [PATCH] usb: gadget: composite: Provide list of registered functions

2015-01-27 Thread Krzysztof Opasiak
-Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, January 27, 2015 7:45 PM To: Krzysztof Opasiak Cc: ba...@ti.com; linux-usb@vger.kernel.org; gre...@linuxfoundation.org; bige...@breakpoint.cc; s.wa...@samsung.com; k.lewando...@samsung.com;

[PATCH 1/4] usb: dwc3: gadget: avoid variable shadowing

2015-01-27 Thread Felipe Balbi
We already have both ret and dwc defined in this same function. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/dwc3/gadget.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 6c5e344822b9..944036d4c83d

Re: [PATCH] usb: gadget: composite: Provide list of registered functions

2015-01-27 Thread Felipe Balbi
Hi, On Tue, Jan 27, 2015 at 06:24:42PM +0100, Krzysztof Opasiak wrote: So I must have misunderstood something. I'm not sure if this is a good idea. Some userspace depends on assumption that sys/kernel/config directory is empty and it's default place for mounting configfs.

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Fabio Estevam
On Tue, Jan 27, 2015 at 12:16 PM, Fabio Estevam feste...@gmail.com wrote: On Tue, Jan 27, 2015 at 11:37 AM, robert.jarz...@free.fr wrote: Is in the right node, ie. the node that has compatible == usb-nop-xceiv ? Yes, it is correct since this commit:

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-27 Thread Heikki Krogerus
On Mon, Jan 26, 2015 at 11:23:37AM -0800, David Cohen wrote: On Mon, Jan 26, 2015 at 02:55:03PM +0200, Heikki Krogerus wrote: On Sat, Jan 24, 2015 at 03:58:11PM -0800, David Cohen wrote: +static int tusb1210_power_on(struct phy *phy) +{ + struct tusb1210 *tusb =

Re: XHCI, brain-dead scanner, and microframe rounding

2015-01-27 Thread Mike Mammarella
On Jan 22, 2015, at 7:23 AM, Mathias Nyman wrote: I was doing this on your ep_reset_halt_test branch, which has a lot of MATTU messages scrolling by, but I'm pretty sure that the microframe rounding message was not present when running with either of these changes. So that may be a red

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Fabio Estevam
Hi Robert, On Tue, Jan 27, 2015 at 3:36 AM, Robert Jarzmik robert.jarz...@free.fr wrote: Robert Jarzmik robert.jarz...@free.fr writes: I'm not convinced of the so many issues. So far I see the gpiod_get_optional() requirement, which is a one liner patch. Would you try the following patch to

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Fabio Estevam
On Tue, Jan 27, 2015 at 6:03 PM, Felipe Balbi ba...@ti.com wrote: wrong test, you should use IS_ERR(), NULL is a valid gpio descriptor. Ok, here we go: --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -218,11 +218,13 @@ int usb_phy_gen_create_phy(struct device *dev,

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 10:40:39PM +0100, Robert Jarzmik wrote: Felipe Balbi ba...@ti.com writes: diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index 9a826ff31951..34231c31cd1a 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Robert Jarzmik
Fabio Estevam feste...@gmail.com writes: On Tue, Jan 27, 2015 at 12:16 PM, Fabio Estevam feste...@gmail.com wrote: On Tue, Jan 27, 2015 at 11:37 AM, robert.jarz...@free.fr wrote: Is in the right node, ie. the node that has compatible == usb-nop-xceiv ? Yes, it is correct since this commit:

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Felipe Balbi
Hi, On Tue, Jan 27, 2015 at 07:29:49PM -0200, Fabio Estevam wrote: On Tue, Jan 27, 2015 at 7:20 PM, Robert Jarzmik robert.jarz...@free.fr wrote: From 4005a6abf519272267399ac4030a5671f7877ca4 Mon Sep 17 00:00:00 2001 From: Robert Jarzmik robert.jarz...@free.fr Date: Tue, 27 Jan 2015

[PATCH v3] usb: Retry port status check on resume to work around RH bugs

2015-01-27 Thread Julius Werner
The EHCI controller on the RK3288 SoC is violating basic parts of the USB spec and thereby unable to properly resume a suspended port. It does not start SOF generation within 3ms of finishing resume signaling, so the attached device will drop of the bus again. This is a particular problem with

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Fabio Estevam
On Tue, Jan 27, 2015 at 7:20 PM, Robert Jarzmik robert.jarz...@free.fr wrote: From 4005a6abf519272267399ac4030a5671f7877ca4 Mon Sep 17 00:00:00 2001 From: Robert Jarzmik robert.jarz...@free.fr Date: Tue, 27 Jan 2015 06:27:03 +0100 Subject: [PATCH] usb: phy: generic: fix the gpios to be

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 10:20:39PM +0100, Robert Jarzmik wrote: Fabio Estevam feste...@gmail.com writes: On Tue, Jan 27, 2015 at 12:16 PM, Fabio Estevam feste...@gmail.com wrote: On Tue, Jan 27, 2015 at 11:37 AM, robert.jarz...@free.fr wrote: Is in the right node, ie. the node that has

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Felipe Balbi
Hi, On Tue, Jan 27, 2015 at 07:17:57PM -0200, Fabio Estevam wrote: On Tue, Jan 27, 2015 at 6:03 PM, Felipe Balbi ba...@ti.com wrote: wrong test, you should use IS_ERR(), NULL is a valid gpio descriptor. Ok, here we go: --- a/drivers/usb/phy/phy-generic.c +++

Re: [PATCH] usb: phy: make GPIOs optional for the generic phy

2015-01-27 Thread Sören Brinkmann
On Fri, 2015-01-16 at 12:14PM +0100, Robert Jarzmik wrote: Paul Zimmerman paul.zimmer...@synopsys.com writes: From 47bd18e210fecf701d493c27884e13c69bc449ea Mon Sep 17 00:00:00 2001 From: Paul Zimmerman pa...@synopsys.com Date: Wed, 14 Jan 2015 18:15:58 -0800 Subject: [PATCH] usb: phy:

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Robert Jarzmik
Felipe Balbi ba...@ti.com writes: diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index 9a826ff31951..34231c31cd1a 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -219,11 +219,11 @@ int usb_phy_gen_create_phy(struct device *dev,

Re: [RFC PATCH 2/4] usb: chipidea: udc: add set_selfpowered gaget ops

2015-01-27 Thread Peter Chen
On Tue, Jan 27, 2015 at 11:27:57AM -0500, Alan Stern wrote: On Tue, 27 Jan 2015, Peter Chen wrote: The gadget power property will be used at get_status request. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/udc.c | 14 ++ 1 file changed,

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Fabio Estevam
On Tue, Jan 27, 2015 at 11:37 AM, robert.jarz...@free.fr wrote: Is in the right node, ie. the node that has compatible == usb-nop-xceiv ? Yes, it is correct since this commit:

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-27 Thread Heikki Krogerus
look at your patch again. In case DWC3_ULPI isn't enabled, this file won't be linked at all. You're using stubs, so taht's fine. In case it _is_ enabled, you're breaking out early if you can't register ulpi interface, meaning you're exitting probe() (which, in fact, seems wrong as I want to

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread robert . jarzmik
- Mail original - De: Fabio Estevam feste...@gmail.com À: Robert Jarzmik robert.jarz...@free.fr Cc: Felipe Balbi ba...@ti.com, Linus Walleij linus.wall...@linaro.org, Philipp Zabel philipp.za...@gmail.com, USB list linux-usb@vger.kernel.org Envoyé: Mardi 27 Janvier 2015 10:40:35 Objet:

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread Fabio Estevam
Hi Robert, On Tue, Jan 27, 2015 at 8:35 AM, robert.jarz...@free.fr wrote: - Mail original - De: Fabio Estevam feste...@gmail.com À: Robert Jarzmik robert.jarz...@free.fr Cc: Felipe Balbi ba...@ti.com, Linus Walleij linus.wall...@linaro.org, Philipp Zabel philipp.za...@gmail.com,

Re: XHCI, brain-dead scanner, and microframe rounding

2015-01-27 Thread Mathias Nyman
(Unless, ofcourse I blindly got it right at the first try and everthing works flawlessly:) ... which appears to have been the case, actually. I love it when code works the first time. :) Here's the dmesg log in case there's anything you need to know in there:

[PATCH 2/2] Fix force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-27 Thread Jim Keir
--- The FF2 driver (usbhid/hid-pidff.c) does not set the effect ID when uploading an effect. The result is that the initial upload works but subsequent uploads to modify effect parameters are all directed at the last-created effect. The targeted effect ID must be passed back to the device when

xhci_hcd: host died

2015-01-27 Thread Heinz Diehl
Hi, I'm not sure if this is the right place to report this, and would be glad if somebody could point me to the right one if I should be wrong. Anyway, since the main error message comes from xhci_hcd: When resuming from suspend to RAM, sometimes (= about every 4. or 5. suspend) my external

Re: XHCI, brain-dead scanner, and microframe rounding

2015-01-27 Thread Hans-Peter Jansen
Mathias Nyman mathias.nyman@... writes: Great, that's good news. Indeed! The patch is affecting others than just scanner so I'm going to run some basic tests with it before sending it further. It might even address some usbstick issues, some people have voiced with xhci. we're late for

Re: [RFC PATCH 0/4] usb: gadget: add is_selfpowered

2015-01-27 Thread Peter Chen
On Tue, Jan 27, 2015 at 10:37:30AM +0800, Peter Chen wrote: Hi Felipe, Hi Felipe, Except for Alan's comments, do you agree with this change for common struct, if you agree with it, I will send formal patch with other udc driver's cleanup. Peter We can use a common is_selfpowered flag at

[PATCh v4 3/3] usb: udc: add usb_udc_activation_handler

2015-01-27 Thread Peter Chen
During this API, the deactivation count will be update, and it will try to connect or disconnect gadget. It can be used to enable functions for gadget. Signed-off-by: Peter Chen peter.c...@freescale.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/gadget/udc/udc-core.c | 28

[PATCh v4 0/3] usb: udc: Unify dp control

2015-01-27 Thread Peter Chen
Hi Felipe, This is the follow-up: http://marc.info/?l=linux-usbm=140979297227434w=2. Sorry for late. In the first patch, we introduce an internal APIs which are used to find corresponding udc according to usb_gadget, it can simplify the code structure. In the 2nd patch, it maintains flag

[PATCh v4 2/3] usb: udc: add usb_udc_vbus_handler

2015-01-27 Thread Peter Chen
This commit updates udc core vbus status, and try to connect or disconnect gadget. Signed-off-by: Peter Chen peter.c...@freescale.com Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/gadget/udc/udc-core.c | 34 +- include/linux/usb/gadget.h|

[PATCh v4 1/3] usb: udc: add usb_gadget_find_udc

2015-01-27 Thread Peter Chen
This is an internal API, and is used to find corresponding udc according to gadget. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/udc/udc-core.c | 51 --- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git

RE: [RFC PATCH 0/4] usb: gadget: add is_selfpowered

2015-01-27 Thread Peter Chen
Hi Felipe, Except for Alan's comments, do you agree with this change for common struct, if you agree with it, I will send formal patch with other udc driver's cleanup. looks good to me. Will you provide patches to all other UDC drivers ? it's certainly not mandatory, and

Re: [RFC PATCH 0/4] usb: gadget: add is_selfpowered

2015-01-27 Thread Felipe Balbi
On Wed, Jan 28, 2015 at 04:32:59AM +, Peter Chen wrote: Hi Felipe, Except for Alan's comments, do you agree with this change for common struct, if you agree with it, I will send formal patch with other udc driver's cleanup. looks good to me. Will you provide

[PATCH v3 4/5] usb: serial: remove unused function for F81232

2015-01-27 Thread Peter Hung
remove unused function set_control_lines() Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c index 9a54f56..11a236b 100644 ---

[PATCH v3 5/5] usb: serial: implement CMSPAR for F81232

2015-01-27 Thread Peter Hung
This patch implement CMSPAR in set_termios, and fix some warnning from checkpatch.pl Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/usb/serial/f81232.c

[PATCH v3 2/5] usb: serial: fix callback wrong process for F81232

2015-01-27 Thread Peter Hung
Our int callback will return IIR, not LSR, and bulk-in callback will return [LSR+Data][LSR+Data], so need to rewrite it Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 82 + 1 file changed, 39 insertions(+), 43

[PATCH v3 1/5] usb: serial: add register map for F81232

2015-01-27 Thread Peter Hung
Add register map for F81232. and add some function to operating this device. etc. f81232_get_register()/f81232_set_register() to work with USB control point. and worker f81232_int_work_wq() to read MSR when IIR acquired. Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com ---

[PATCH v3 3/5] usb: serial: implement function for F81232

2015-01-27 Thread Peter Hung
This patch implement the following function: set_termios, tiocmset, tiocmget, dtr_rts Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 103 1 file changed, 84 insertions(+), 19 deletions(-) diff --git

RE: [PATCH] usb: gadget: composite: Provide list of registered functions

2015-01-27 Thread Krzysztof Opasiak
-Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, January 23, 2015 6:01 PM To: Krzysztof Opasiak Cc: ba...@ti.com; linux-usb@vger.kernel.org; gre...@linuxfoundation.org; bige...@breakpoint.cc; s.wa...@samsung.com; k.lewando...@samsung.com;

Re: [PATCH] usb: gadget: composite: Provide list of registered functions

2015-01-27 Thread Felipe Balbi
Hi, On Tue, Jan 27, 2015 at 05:51:30PM +0100, Krzysztof Opasiak wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, January 23, 2015 6:01 PM To: Krzysztof Opasiak Cc: ba...@ti.com; linux-usb@vger.kernel.org; gre...@linuxfoundation.org; bige...@breakpoint.cc;

Re: Fwd: USB device uses dma on its MMIO region?

2015-01-27 Thread Elena Ufimtseva
On Thu, Jan 22, 2015 at 3:41 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 22 Jan 2015, Elena Ufimtseva wrote: On Thu, Jan 22, 2015 at 1:10 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 22 Jan 2015, Elena Ufimtseva wrote: Hello While working on IOMMU related

Re: [PATCH 20/23] musb_virthub: use HUB_CHAR_*

2015-01-27 Thread Sergei Shtylyov
Hello. On 01/27/2015 06:35 PM, Felipe Balbi wrote: Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in linux/usb/ch11.h. Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com ---

Re: [PATCH 20/23] musb_virthub: use HUB_CHAR_*

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 07:06:14PM +0300, Sergei Shtylyov wrote: Hello. On 01/27/2015 06:35 PM, Felipe Balbi wrote: Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in linux/usb/ch11.h. Signed-off-by: Sergei

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-27 Thread Heikki Krogerus
Hi guys, I'm only using the init and exit hooks instead of just power_on/power_off because I'm not sure which the controllers will use. For example, now dwc3 calls phy_init() in it's resume routine and not phy_power_on() like I would expect. I know the problem has been pointed out by others,

Re: [PATCH v2 1/3] usb: phy: generic: migrate to gpio_desc

2015-01-27 Thread robert . jarzmik
- Mail original - De: Fabio Estevam feste...@gmail.com À: Robert Jarzmik robert.jarz...@free.fr Cc: Felipe Balbi ba...@ti.com, Linus Walleij linus.wall...@linaro.org, Philipp Zabel philipp.za...@gmail.com, USB list linux-usb@vger.kernel.org Envoyé: Mardi 27 Janvier 2015 12:23:43 Objet:

Re: XHCI, brain-dead scanner, and microframe rounding

2015-01-27 Thread Mathias Nyman
On 27.01.2015 13:57, Hans-Peter Jansen wrote: What about a stable backport? Do you think, it's feasible, too much work, or too risky? This should definitely be backported to 3.18 stable, which should be easy. Older longterms kernels are a bit tricky as the halt and reset code around this

Re: [PATCH] usb: gadget: ffs: add eventfd notification about ffs events

2015-01-27 Thread Felipe Balbi
On Fri, Jan 23, 2015 at 01:34:45PM +0100, Robert Baldyga wrote: On 01/23/2015 01:21 PM, Michał Nazarewicz wrote: 23 sty 2015 10:28 Robert Baldyga r.bald...@samsung.com mailto:r.bald...@samsung.com napisał(a): Add eventfd which notifies userspace about ep0 events and AIO completion events.

Re: [PATCH 6/8] usb: dwc3: add ULPI interface support

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 01:09:25PM +0200, Heikki Krogerus wrote: look at your patch again. In case DWC3_ULPI isn't enabled, this file won't be linked at all. You're using stubs, so taht's fine. In case it _is_ enabled, you're breaking out early if you can't register ulpi interface,

Re: [PATCH] usb: phy-generic: Don't fail on missing gpio reset

2015-01-27 Thread Arnd Bergmann
On Monday 26 January 2015 17:45:29 Soren Brinkmann wrote: diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index dd05254241fb..a73d4c738f0b 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -241,10 +241,8 @@ int

Re: [PATCH v3 3/3] usb: udc: add usb_udc_activation_handler

2015-01-27 Thread Felipe Balbi
On Mon, Jan 19, 2015 at 11:25:05AM -0500, Alan Stern wrote: On Mon, 19 Jan 2015, Peter Chen wrote: On Fri, Jan 16, 2015 at 11:11:56AM -0500, Alan Stern wrote: On Fri, 16 Jan 2015, Peter Chen wrote: During this API, the deactivation count will be update, and it will try to

Re: [PATCH 2/2] drivers: usb: dwc2: remove 'force' parameter from kill_all_requests()

2015-01-27 Thread Felipe Balbi
On Mon, Jan 05, 2015 at 10:31:35AM +0100, Robert Baldyga wrote: This patch fixes in simpler way the bug described in [1] and [2]. It looks like DWC2 is the only UDC driver that doesn't force usb requests to complete in ep_disable() function. This causes described problem, because we have no

Re: [PATCH v2] chipidea: pci: register nop PHY

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 03:50:18PM +0200, Andy Shevchenko wrote: Since PHY for ChipIdea is optional (not all SoCs having PHY for ChipIdea should be programmed), we register 'nop' PHY for platforms that do not have programmable PHY. Signed-off-by: Andy Shevchenko

Re: [PATCH v2] usb: gadget: composite: Provide list of registered functions

2015-01-27 Thread Felipe Balbi
Hi, On Fri, Jan 23, 2015 at 05:00:18PM +0100, Krzysztof Opasiak wrote: @@ -1558,13 +1559,63 @@ void unregister_gadget_item(struct config_item *item) } EXPORT_SYMBOL_GPL(unregister_gadget_item); +#ifdef CONFIG_PROC_FS why proc when I requested repeatedly to put this file under the same

Re: [PATCH v3 0/5] Add support for Fujitsu USB host controller

2015-01-27 Thread Felipe Balbi
Hi, On Sun, Jan 25, 2015 at 04:13:23PM +0800, Sneeker Yeh wrote: These patches add support for XHCI compliant Host controller found on Fujitsu Socs, and are based on http://lwn.net/Articles/629162/ The first patch is to add Fujitsu glue layer of Synopsis DesignWare USB3 driver and last four

Re: [PATCH 20/23] musb_virthub: use HUB_CHAR_*

2015-01-27 Thread Felipe Balbi
On Sun, Jan 25, 2015 at 07:51:49PM +0300, Sergei Shtylyov wrote: Hello. On 01/19/2015 01:57 AM, Sergei Shtylyov wrote: Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in linux/usb/ch11.h. Signed-off-by: Sergei

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-27 Thread Roger Quadros
Chanwoo, On 27/01/15 03:54, Chanwoo Choi wrote: Hi Roger, On 01/27/2015 01:27 AM, Roger Quadros wrote: Hi Chanwoo, All your comments are valid. Need some clarification on one comment. On 26/01/15 15:56, Chanwoo Choi wrote: Hi Roger, This patch looks good to me. But I add some comment.

Re: [PATCH] usb: phy-generic: Don't fail on missing gpio reset

2015-01-27 Thread Felipe Balbi
On Mon, Jan 26, 2015 at 05:45:29PM -0800, Soren Brinkmann wrote: A reset through a GPIO is optional. Don't fail probing when it is missing. Reported-by: Andreas Färber afaer...@suse.de Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com --- Hi Andreas, does this do the trick?

Re: [PATCH] usb: gadget: ffs: add eventfd notification about ffs events

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 09:25:30AM -0600, Felipe Balbi wrote: On Fri, Jan 23, 2015 at 01:34:45PM +0100, Robert Baldyga wrote: On 01/23/2015 01:21 PM, Michał Nazarewicz wrote: 23 sty 2015 10:28 Robert Baldyga r.bald...@samsung.com mailto:r.bald...@samsung.com napisał(a): Add eventfd

Re: [PATCH v1 00/13] usb: second series of updates for dwc2 driver

2015-01-27 Thread Felipe Balbi
On Thu, Jan 22, 2015 at 02:28:33AM +, John Youn wrote: From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] Sent: Wednesday, January 21, 2015 6:37 AM Hi, This patchset consists of some bug fixes, feature enhancements and cosmetic changes for the dwc2 driver. All the patches

Re: [PATCH v2] usb: Retry port status check on resume to work around RH bugs

2015-01-27 Thread Alan Stern
On Mon, 26 Jan 2015, Julius Werner wrote: The EHCI controller on the RK3288 SoC is violating basic parts of the USB spec and thereby unable to properly resume a suspended port. It does not start SOF generation within 3ms of finishing resume signaling, so the attached device will drop off the

RE: [PATCH] usb: gadget: composite: Provide list of registered functions

2015-01-27 Thread Krzysztof Opasiak
-Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, January 27, 2015 5:58 PM To: Krzysztof Opasiak Cc: ba...@ti.com; linux-usb@vger.kernel.org; gre...@linuxfoundation.org; bige...@breakpoint.cc; s.wa...@samsung.com; k.lewando...@samsung.com;

Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY

2015-01-27 Thread David Cohen
On Tue, Jan 27, 2015 at 11:28:56AM +0200, Heikki Krogerus wrote: On Mon, Jan 26, 2015 at 11:23:37AM -0800, David Cohen wrote: On Mon, Jan 26, 2015 at 02:55:03PM +0200, Heikki Krogerus wrote: On Sat, Jan 24, 2015 at 03:58:11PM -0800, David Cohen wrote: +static int

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-27 Thread Alan Stern
On Tue, 27 Jan 2015, Peter Chen wrote: Please fix this properly. I don't know the right way to fix this. Alan, has you any suggestion? It depends. How did the code before the adfa79d1c06a commit avoid this problem? By simply not enabling CONFIG_USB_EHCI_HCD? Hi Andy,

Re: [RFC PATCH 2/4] usb: chipidea: udc: add set_selfpowered gaget ops

2015-01-27 Thread Alan Stern
On Tue, 27 Jan 2015, Peter Chen wrote: The gadget power property will be used at get_status request. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/udc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/usb/chipidea/udc.c

Re: [PATCH 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-01-27 Thread Sergei Shtylyov
Hello. On 01/27/2015 04:47 PM, Zubair Lutfullah Kakakhel wrote: From: Paul Burton paul.bur...@imgtec.com Add the binding documentation for the JZ47xx OHCI controller. Signed-off-by: Paul Burton paul.bur...@imgtec.com Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com

Re: Kernel Ooops upon USB disconnect of a Western Digital My Passport 1TB drive

2015-01-27 Thread Alan Stern
On Tue, 27 Jan 2015, Athlion wrote: Hello all. On my Thunkpad T420i with 3.18.2 and 3.18.3 kernels, I can reproduce the following behaviour 100% of the time: 1. Connect one of my (NTFS-formatted) WD 1TB 'My Passport' drives via USB. 2. Disconnect the cable. 3. Kernel Ooops. For last

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-27 Thread Alan Stern
On Tue, 27 Jan 2015, Andy Shevchenko wrote: On Tue, 2015-01-27 at 11:21 -0500, Alan Stern wrote: On Tue, 27 Jan 2015, Peter Chen wrote: Please fix this properly. I don't know the right way to fix this. Alan, has you any suggestion? It depends. How did the code

Re: [PATCH_V2 0/3] usb: ohci: jz4740: Add DT support and a fix

2015-01-27 Thread Alan Stern
On Tue, 27 Jan 2015, Zubair Lutfullah Kakakhel wrote: Hi, Here are a few simple patches for the jz4740. First adds a simple DT binding. Seconds adds DT support. Third is a minor fix in clock enabling. Patches are based on 3.19-rc6. Quite disjoint and stay within jz4740 so should

RE: [PATCH v2] usb: gadget: composite: Provide list of registered functions

2015-01-27 Thread Krzysztof Opasiak
-Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, January 27, 2015 4:57 PM To: Krzysztof Opasiak Cc: ba...@ti.com; linux-usb@vger.kernel.org; gre...@linuxfoundation.org; bige...@breakpoint.cc; s.wa...@samsung.com; k.lewando...@samsung.com;

Re: USB autosuspend causing trouble with bluetooth

2015-01-27 Thread Oliver Neukum
On Mon, 2015-01-26 at 21:00 +0400, Kirill Elagin wrote: Things just got way worse with this hotplug thing. Is that a new test or did you update? When the host power/control is set to `auto`, as soon as I insert the Unifying receiver one of kworkers starts eating 100% of one of the But it

Re: [RFC PATCH 0/4] usb: gadget: add is_selfpowered

2015-01-27 Thread Felipe Balbi
Hi, On Wed, Jan 28, 2015 at 10:05:39AM +0800, Peter Chen wrote: On Tue, Jan 27, 2015 at 10:37:30AM +0800, Peter Chen wrote: Hi Felipe, Hi Felipe, Except for Alan's comments, do you agree with this change for common struct, if you agree with it, I will send formal patch with other

Re: [RFC PATCH 0/4] usb: gadget: add is_selfpowered

2015-01-27 Thread Felipe Balbi
On Tue, Jan 27, 2015 at 10:07:02PM -0600, Felipe Balbi wrote: Hi, On Wed, Jan 28, 2015 at 10:05:39AM +0800, Peter Chen wrote: On Tue, Jan 27, 2015 at 10:37:30AM +0800, Peter Chen wrote: Hi Felipe, Hi Felipe, Except for Alan's comments, do you agree with this change for

Re: [PATCH v2 1/7] extcon: usb-gpio: Introduce gpio usb extcon driver

2015-01-27 Thread Chanwoo Choi
Hi Roger, On 01/28/2015 12:38 AM, Roger Quadros wrote: Chanwoo, On 27/01/15 03:54, Chanwoo Choi wrote: Hi Roger, On 01/27/2015 01:27 AM, Roger Quadros wrote: Hi Chanwoo, All your comments are valid. Need some clarification on one comment. On 26/01/15 15:56, Chanwoo Choi wrote: Hi

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-27 Thread Peter Chen
On Tue, Jan 27, 2015 at 11:21:56AM -0500, Alan Stern wrote: On Tue, 27 Jan 2015, Peter Chen wrote: Please fix this properly. I don't know the right way to fix this. Alan, has you any suggestion? It depends. How did the code before the adfa79d1c06a commit avoid this

Re: [PATCH] USB: cdc-acm: check for descriptors with invalid length

2015-01-27 Thread Adam Lee
On Tue, Jan 27, 2015 at 08:36:07PM +0100, Oliver Neukum wrote: Hi, could you test and review this? $ git am ~/0001-cdc-acm-add-sanity-checks.patch Applying: cdc-acm: add sanity checks /home/adamlee/ubuntu-vivid/.git/rebase-apply/patch:26: trailing whitespace.