RE: [PATCH v2] usb: host: Implement workaround for Erratum A-009611

2017-12-11 Thread Yinbo Zhu
-Original Message- From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] Sent: Monday, December 11, 2017 4:52 PM To: Yinbo Zhu ; Greg Kroah-Hartman Cc: Mathias Nyman ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list ; Xiaobo Xie ; Jer

Re: Dual-role behavior with USB-C?

2017-12-11 Thread Takashi Matsuzawa
Hello. Thank you very much for your comment. > Since USB OTG FSM has not been accepted by industry during last ten years, we > decide > to give up maintaining OTG FSM at Linux kernel. For role switch use case, > please use > /sys/../role instead, see below commit for detail: > > > https://gi

[BUG] drivers/usb/host/isp116x-hcd: a possible sleep-in-atomic bug in isp116x_start

2017-12-11 Thread Jia-Ju Bai
According to drivers/usb/host/isp116x-hcd.c, the kernel module may sleep under a spinlock. The function call path is: isp116x_start (acquire the spinlock) device_init_wakeup device_wakeup_enable wakeup_source_register wakeup_source_create kmalloc(GFP_KERNEL) --> may

Re: [PATCH] USB: chipidea: msm: fix ulpi-node lookup

2017-12-11 Thread Peter Chen
On Mon, Nov 13, 2017 at 11:12:58AM +0100, Johan Hovold wrote: > Fix child-node lookup during probe, which ended up searching the whole > device tree depth-first starting at the parent rather than just matching > on its children. > > Note that the original premature free of the parent node has alre

Re: [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig

2017-12-11 Thread Peter Chen
On Mon, Dec 11, 2017 at 04:09:44PM +0300, Dmitry Osipenko wrote: > On 11.12.2017 13:04, Thierry Reding wrote: > > On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote: > >> UDC driver won't probe without Tegra's PHY, hence select it in the > >> Kconfig. > >> > >> Signed-off-by: Dmitry Os

RE: Dual-role behavior with USB-C?

2017-12-11 Thread Peter Chen
> > Hello. > > Just in case if you already have pointer or experience with this, any > suggestion is > highly appreciated. > > Some of the recent i.MX boards has USB-C socket for USB-OTG port, and I wonder > how I can try the following steps (Dual-role behavior testing) with USB-C > sockets.

Re: [PATCH 4.4 13/49] usb: dwc2: Fix UDC state tracking

2017-12-11 Thread alexander . levin
On Sat, Dec 09, 2017 at 06:12:56PM +0100, Greg Kroah-Hartman wrote: >On Fri, Dec 08, 2017 at 03:37:17AM +, Ben Hutchings wrote: >> On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote: >> > 4.4-stable review patch.  If anyone has any objections, please let me >> > know. >> > >> > ---

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-11 Thread Dave Chinner
On Mon, Dec 11, 2017 at 02:12:28PM -0800, Joe Perches wrote: > On Tue, 2017-12-12 at 08:43 +1100, Dave Chinner wrote: > > On Sat, Dec 09, 2017 at 09:00:18AM -0800, Joe Perches wrote: > > > On Sat, 2017-12-09 at 09:36 +1100, Dave Chinner wrote: > > > > 1. Using lockdep_set_novalidate_class()

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-11 Thread Joe Perches
On Mon, 2017-12-11 at 14:43 -0800, Matthew Wilcox wrote: > On Mon, Dec 11, 2017 at 02:12:28PM -0800, Joe Perches wrote: > > Completely reasonable. Thanks. > > If we're doing "completely reasonable" complaints, then ... > > - I don't understand why plain 'unsigned' is deemed bad. That was a Dav

Re: [PATCH] USB: serial: qcserial: add Sierra Wireless EM7565

2017-12-11 Thread Reinhard Speyerer
On Mon, Dec 11, 2017 at 09:48:00PM +0100, Bjørn Mork wrote: > Reinhard Speyerer writes: > > > Sierra Wireless EM7565 devices use the DEVICE_SWI layout for their > > serial ports > > > > T: Bus=01 Lev=03 Prnt=29 Port=01 Cnt=02 Dev#= 31 Spd=480 MxCh= 0 > > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=

Re: [PATCH v4 08/73] xarray: Add documentation

2017-12-11 Thread Randy Dunlap
On 12/05/2017 04:40 PM, Matthew Wilcox wrote: > From: Matthew Wilcox > > This is documentation on how to use the XArray, not details about its > internal implementation. > > Signed-off-by: Matthew Wilcox > --- > Documentation/core-api/index.rst | 1 + > Documentation/core-api/xarray.rst | 2

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-11 Thread Matthew Wilcox
On Mon, Dec 11, 2017 at 02:12:28PM -0800, Joe Perches wrote: > Completely reasonable. Thanks. If we're doing "completely reasonable" complaints, then ... - I don't understand why plain 'unsigned' is deemed bad. - The rule about all function parameters in prototypes having a name doesn't ma

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-11 Thread Joe Perches
On Tue, 2017-12-12 at 08:43 +1100, Dave Chinner wrote: > On Sat, Dec 09, 2017 at 09:00:18AM -0800, Joe Perches wrote: > > On Sat, 2017-12-09 at 09:36 +1100, Dave Chinner wrote: > > > 1. Using lockdep_set_novalidate_class() for anything other > > > than device->mutex will throw checkpatch warnin

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-11 Thread Dave Chinner
On Sun, Dec 10, 2017 at 08:23:15PM -0800, Matthew Wilcox wrote: > On Mon, Dec 11, 2017 at 10:57:45AM +1100, Dave Chinner wrote: > > i.e. the fact the cmpxchg failed may not have anything to do with a > > race condtion - it failed because the slot wasn't empty like we > > expected it to be. There c

Re: [PATCH] doc: usb: chipidea: Fix typo in 'enumerate'

2017-12-11 Thread Jonathan Corbet
On Fri, 8 Dec 2017 11:53:37 -0200 Fabio Estevam wrote: > Fix the spelling of 'enumerate' in this document. Applied to the docs tree, thanks. jon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] USB: core: only clean up what we allocated

2017-12-11 Thread Greg KH
From: Andrey Konovalov When cleaning up the configurations, make sure we only free the number of configurations and interfaces that we could have allocated. Reported-by: Andrey Konovalov Cc: stable Signed-off-by: Greg Kroah-Hartman diff --git a/drivers/usb/core/config.c b/drivers/usb/core/co

[PATCH] phy: rockchip-typec: Try to turn the PHY on several times

2017-12-11 Thread Douglas Anderson
Bind / unbind stress testing of the USB controller on rk3399 found that we'd often end up with lots of failures that looked like this: phy phy-ff80.phy.9: phy poweron failed --> -110 dwc3 fe90.dwc3: failed to initialize core dwc3: probe of fe90.dwc3 failed with error -110 Those

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

2017-12-11 Thread Dave Chinner
On Sat, Dec 09, 2017 at 09:00:18AM -0800, Joe Perches wrote: > On Sat, 2017-12-09 at 09:36 +1100, Dave Chinner wrote: > > 1. Using lockdep_set_novalidate_class() for anything other > > than device->mutex will throw checkpatch warnings. Nice. (*) > [] > > (*) checkpatch.pl is considered most

[PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

2017-12-11 Thread ssjoholm
From: Sebastian Sjoholm Sierra Wireless EM7565 is an Qualcomm MDM9x50 based M.2 modem. The USB id is added to qmi_wwan.c to allow QMI communication with the EM7565. Signed-off-by: Sebastian Sjoholm Acked-by: Bjørn Mork --- [The corresponding qcserial patch will be submitted by Reinhard Speyer

Re: [PATCH] USB: serial: qcserial: add Sierra Wireless EM7565

2017-12-11 Thread Bjørn Mork
Reinhard Speyerer writes: > Sierra Wireless EM7565 devices use the DEVICE_SWI layout for their > serial ports > > T: Bus=01 Lev=03 Prnt=29 Port=01 Cnt=02 Dev#= 31 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=1199 ProdID=9091 Rev= 0.06 > S: Manufac

Re: [PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

2017-12-11 Thread Bjørn Mork
ssjoh...@mac.com writes: > From: Sebastian Sjoholm > > From: Sebastian Sjoholm > > Sierra Wireless EM7565 is an Qualcomm MDM9x50 based M.2 modem. > The USB id is added to qmi_wwan.c to allow QMI communication with the EM7565. > > Signed-off-by: Sebastian Sjoholm > --- > [The corresponding qcser

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

2017-12-11 Thread Sebastian Sjoholm
Hi, Sorry for the re-email of the patch below, clearly a beginners mistake of me not to clear my tmp/ folder. Please disregard this. Regards, Sebastian > On Dec 11, 2017, at 21:12 , ssjoh...@mac.com wrote: > > From: Sebastian Sjoholm > > Quectel BG96 is an Qualcomm MDM9206 based IoT modem,

[PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

2017-12-11 Thread ssjoholm
From: Sebastian Sjoholm From: Sebastian Sjoholm Sierra Wireless EM7565 is an Qualcomm MDM9x50 based M.2 modem. The USB id is added to qmi_wwan.c to allow QMI communication with the EM7565. Signed-off-by: Sebastian Sjoholm --- [The corresponding qcserial patch will be submitted by Reinhard Spe

[PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

2017-12-11 Thread ssjoholm
From: Sebastian Sjoholm Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel development board (EVB). The USB id is added to qmi_wwan.c to allow QMI communication with the BG96. Signed-off-by: Sebastian Sjoholm ---

Re: [PATCH] USB: remove the URB_NO_FSBR flag

2017-12-11 Thread Alan Stern
On Mon, 11 Dec 2017, Shuah Khan wrote: > On 12/11/2017 09:58 AM, Alan Stern wrote: > > The URB_NO_FSBR flag has never really been used. It was introduced as > > a potential way for UHCI to minimize PCI bus usage (by not attempting > > full-speed bulk and control transfers more than once per frame

Re: [PATCH] USB: remove the URB_NO_FSBR flag

2017-12-11 Thread Shuah Khan
On 12/11/2017 09:58 AM, Alan Stern wrote: > The URB_NO_FSBR flag has never really been used. It was introduced as > a potential way for UHCI to minimize PCI bus usage (by not attempting > full-speed bulk and control transfers more than once per frame), but > the flag was not set by any drivers. >

Re: [PATCH] usb: xhci: fix incorrect memset()

2017-12-11 Thread Arnd Bergmann
On Mon, Dec 11, 2017 at 6:01 PM, Greg Kroah-Hartman wrote: > On Mon, Dec 11, 2017 at 02:59:13PM +0200, Mathias Nyman wrote: >> On 11.12.2017 13:27, Arnd Bergmann wrote: >> > gcc-8 warnings about the new driver using a memset with a bogus length: >> > >> > drivers/usb/host/xhci-dbgcap.c: In functio

Re: [PATCH] usb: xhci: fix incorrect memset()

2017-12-11 Thread Greg Kroah-Hartman
On Mon, Dec 11, 2017 at 02:59:13PM +0200, Mathias Nyman wrote: > On 11.12.2017 13:27, Arnd Bergmann wrote: > > gcc-8 warnings about the new driver using a memset with a bogus length: > > > > drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_eps_exit': > > drivers/usb/host/xhci-dbgcap.c:369:2:

[PATCH] USB: remove the URB_NO_FSBR flag

2017-12-11 Thread Alan Stern
The URB_NO_FSBR flag has never really been used. It was introduced as a potential way for UHCI to minimize PCI bus usage (by not attempting full-speed bulk and control transfers more than once per frame), but the flag was not set by any drivers. There's no point in keeping it around. This patch

Re: [PATCH] Revert "usb: gadget: allow to enable legacy drivers without USB_ETH"

2017-12-11 Thread Arnd Bergmann
On Mon, Dec 11, 2017 at 5:45 PM, Bart Van Assche wrote: > Romain Izard reported the following about commit 7a9618a22aad: > > As it reached Linus' tree with v4.15-rc3, I recently noticed the > following commit that triggered a Kconfig request. I believe that this > change does not make

[PATCH][usb-next] usb: xhci: make function xhci_dbc_free_req static

2017-12-11 Thread Colin King
From: Colin Ian King Function xhci_dbc_free_req is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'xhci_dbc_free_req' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/usb/host/xhci-dbgtty.c | 2 +

Re: [PATCH] ARM: dts: dra7: Disable USB metastability workaround for USB2

2017-12-11 Thread Tony Lindgren
* Felipe Balbi [171204 11:43]: > Roger Quadros writes: > > > The metastability workaround causes Erratic errors [1] > > on the HighSpeed USB PHY which can cause upto 2 seconds > > delay in enumerating to a USB host while in Gadget mode. > > > > Disable the Run/Stop metastability workaround to av

[PATCH] Revert "usb: gadget: allow to enable legacy drivers without USB_ETH"

2017-12-11 Thread Bart Van Assche
Romain Izard reported the following about commit 7a9618a22aad: As it reached Linus' tree with v4.15-rc3, I recently noticed the following commit that triggered a Kconfig request. I believe that this change does not make sense. 7a9618a22aa usb: gadget: allow to enable legacy driver

Re: Issues with 7a9618a22aa usb: gadget: allow to enable legacy drivers without USB_ETH

2017-12-11 Thread Romain Izard
2017-12-11 17:14 GMT+01:00 Bart Van Assche : > On Mon, 2017-12-11 at 12:24 +0100, Romain Izard wrote: >> As it reached Linus' tree with v4.15-rc3, I recently noticed the >> following commit that triggered a Kconfig request. I believe that this >> change does not make sense. >> >> 7a9618a22aa usb: g

Re: [PATCH 1/2] usb: gadget: restore tristate-choice for legacy gadgets

2017-12-11 Thread Arnd Bergmann
On Mon, Dec 11, 2017 at 5:09 PM, Bart Van Assche wrote: > On Mon, 2017-12-11 at 12:30 +0100, Arnd Bergmann wrote: >> One patch that was meant as a cleanup apparently did more than it intended, >> allowing all combinations of legacy gadget drivers to be built into the >> kernel, and leaving an empt

Re: [PATCH 1/2] usb: gadget: restore tristate-choice for legacy gadgets

2017-12-11 Thread Bart Van Assche
On Mon, 2017-12-11 at 12:30 +0100, Arnd Bergmann wrote: > One patch that was meant as a cleanup apparently did more than it intended, > allowing all combinations of legacy gadget drivers to be built into the > kernel, and leaving an empty 'choice' statement behind: > > drivers/usb/gadget/Kconfig:4

Re: Webcams not recognized on a Dell Latitude 5285 laptop

2017-12-11 Thread FRÉDÉRIC PARRENIN
> > > it looks like you need the experimental driver posted here > > > https://www.spinics.net/lists/linux-media/msg123268.html > > Thanks for the information. >> So, if I understand correctly, this driver will not be included in 4.15, will > > it? > > Any idea when this will be included in a

Re: dwc2 gadget driver does not generate DISABLE event on unplugging USB cable

2017-12-11 Thread Grigor Tovmasyan
Hi Jun Sun, On 12/8/2017 17:33, Jun Sun wrote: > Hi, all, > > I have a raspberry pi zero w board and I'm currently configuring the > device as USB gadget and connects it to PC. > > I'm using configfs/functionfs to send a vendor specific interface with > single buik in and bulk out endpoint each.

Re: Webcams not recognized on a Dell Latitude 5285 laptop

2017-12-11 Thread Oliver Neukum
Am Montag, den 11.12.2017, 15:33 +0100 schrieb FRÉDÉRIC PARRENIN : > > > > Am Montag, den 11.12.2017, 15:01 +0100 schrieb FRÉDÉRIC PARRENIN : > > > > > > Thank you for your answer. > > > The information is provided below. > > > > > Hi, > > > > > it looks like you need the experimental

Re: Webcams not recognized on a Dell Latitude 5285 laptop

2017-12-11 Thread FRÉDÉRIC PARRENIN
> Am Montag, den 11.12.2017, 15:01 +0100 schrieb FRÉDÉRIC PARRENIN : > > Thank you for your answer. > > The information is provided below. > Hi, > it looks like you need the experimental driver posted here > https://www.spinics.net/lists/linux-media/msg123268.html Thanks for the information. S

Re: Webcams not recognized on a Dell Latitude 5285 laptop

2017-12-11 Thread Oliver Neukum
Am Montag, den 11.12.2017, 15:01 +0100 schrieb FRÉDÉRIC PARRENIN : > Thank you for your answer. > The information is provided below. Hi, it looks like you need the experimental driver posted here https://www.spinics.net/lists/linux-media/msg123268.html HTH Oliver -- To

Re: [PATCH v1] usb: phy: tegra: Increase PHY clock stabilization timeout

2017-12-11 Thread Dmitry Osipenko
On 11.12.2017 12:53, Thierry Reding wrote: > On Mon, Dec 11, 2017 at 01:55:35AM +0300, Dmitry Osipenko wrote: >> This fixes "utmi_phy_clk_enable: timeout waiting for phy to stabilize" >> error message. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/usb/phy/phy-tegra-usb.c | 13 ---

Re: Webcams not recognized on a Dell Latitude 5285 laptop

2017-12-11 Thread FRÉDÉRIC PARRENIN
Thank you for your answer. The information is provided below. > > Multimedia controller: Intel Corporation Skylake Imaging Unit > Please provide at least > 1) dmesg $ dmesg [0.00] microcode: microcode updated early to revision 0x62, date = 2017-04-27 [0.00] Linux version 4.14.3

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-11 Thread Ladislav Michl
On Mon, Dec 11, 2017 at 12:52:46PM +0100, Johan Hovold wrote: > On Mon, Dec 11, 2017 at 12:32:49PM +0100, Ladislav Michl wrote: > > On Mon, Dec 11, 2017 at 11:10:35AM +0100, Johan Hovold wrote: [snip] > > > I'm afraid I don't consider this an improvement. I prefer using gotos > > > for error paths,

[PATCH] usb: typec: wcove: fix the sink capabilities

2017-12-11 Thread Heikki Krogerus
USB Power Delivery Specification (v3.0) dictates in ch. 6.4.1 - Capabilities Message - that the vSafe5V Fixed Supply Object shall always be the first object. tcpm.c now checks that this rule is obeyed (commit 5007e1b5db73 "typec: tcpm Validate source and sink caps"), and that makes the typec_wcove.

Re: [PATCH v1 1/2] usb: phy: tegra: Cleanup error messages

2017-12-11 Thread Dmitry Osipenko
On 11.12.2017 12:37, Thierry Reding wrote: > On Mon, Dec 11, 2017 at 02:07:37AM +0300, Dmitry Osipenko wrote: >> Tegra's PHY driver has a mix of pr_err() and dev_err(), let's switch to >> dev_err() and use common errors message formatting across the driver for >> consistency. >> >> Signed-off-by: D

Re: [PATCH v1 2/2] usb: tegra: Move UTMI-pads reset from ehci-tegra to tegra-phy

2017-12-11 Thread Dmitry Osipenko
On 11.12.2017 13:25, Thierry Reding wrote: > On Mon, Dec 11, 2017 at 02:07:38AM +0300, Dmitry Osipenko wrote: >> UTMI pads are shared by USB controllers and reset of UTMI pads is shared >> with the reset of USB1 controller. Currently reset of UTMI pads is done by >> the EHCI driver and ChipIdea UDC

Re: [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig

2017-12-11 Thread Dmitry Osipenko
On 11.12.2017 13:04, Thierry Reding wrote: > On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote: >> UDC driver won't probe without Tegra's PHY, hence select it in the >> Kconfig. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/usb/chipidea/Kconfig | 1 + >> 1 file changed, 1 i

Re: [PATCH v1 1/2] usb: phy: Add Kconfig entry for Tegra's PHY driver

2017-12-11 Thread Dmitry Osipenko
On 11.12.2017 13:02, Thierry Reding wrote: > On Mon, Dec 11, 2017 at 02:09:59AM +0300, Dmitry Osipenko wrote: >> Add Kconfig entry so that other drivers other than ehci-tegra >> (like ChipIdea) could add Tegra's PHY to build dependencies. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/usb

Re: [PATCH] usb: xhci: fix incorrect memset()

2017-12-11 Thread Mathias Nyman
On 11.12.2017 13:27, Arnd Bergmann wrote: gcc-8 warnings about the new driver using a memset with a bogus length: drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_eps_exit': drivers/usb/host/xhci-dbgcap.c:369:2: error: 'memset' used with length equal to number of elements without multiplic

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-11 Thread Johan Hovold
On Mon, Dec 11, 2017 at 12:32:49PM +0100, Ladislav Michl wrote: > On Mon, Dec 11, 2017 at 11:10:35AM +0100, Johan Hovold wrote: > > On Mon, Dec 11, 2017 at 12:09:19AM +0100, Ladislav Michl wrote: > > > Make status handling in bulk in callback function more compact, > > > which renders goto pointles

Re: Fwd: Issues with 7a9618a22aa usb: gadget: allow to enable legacy drivers without USB_ETH

2017-12-11 Thread Felipe Balbi
Hi, Romain Izard writes: > Once again, with the correct mail address. > > > -- Forwarded message -- > From: Romain Izard > Date: 2017-12-11 12:24 GMT+01:00 > Subject: Issues with 7a9618a22aa usb: gadget: allow to enable legacy > drivers without USB_ETH > To: Bart Van Assche , F

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-11 Thread Ladislav Michl
On Mon, Dec 11, 2017 at 11:10:35AM +0100, Johan Hovold wrote: > On Mon, Dec 11, 2017 at 12:09:19AM +0100, Ladislav Michl wrote: > > Make status handling in bulk in callback function more compact, > > which renders goto pointless. > > > > Signed-off-by: Ladislav Michl > > --- > > drivers/usb/seri

[PATCH 2/2] usb: gadget: webcam: fix V4L2 Kconfig dependency

2017-12-11 Thread Arnd Bergmann
Configuring the USB_G_WEBCAM driver as built-in leads to a link error when CONFIG_VIDEO_V4L2 is a loadable module: drivers/usb/gadget/function/f_uvc.o: In function `uvc_function_setup': f_uvc.c:(.text+0xfe): undefined reference to `v4l2_event_queue' drivers/usb/gadget/function/f_uvc.o: In function

[PATCH 1/2] usb: gadget: restore tristate-choice for legacy gadgets

2017-12-11 Thread Arnd Bergmann
One patch that was meant as a cleanup apparently did more than it intended, allowing all combinations of legacy gadget drivers to be built into the kernel, and leaving an empty 'choice' statement behind: drivers/usb/gadget/Kconfig:487:warning: choice default symbol 'USB_ETH' is not contained in t

[PATCH] usb: xhci: fix incorrect memset()

2017-12-11 Thread Arnd Bergmann
gcc-8 warnings about the new driver using a memset with a bogus length: drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_eps_exit': drivers/usb/host/xhci-dbgcap.c:369:2: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-s

Re: [PATCH] USB: serial: Avoid goto in bulk callbacks

2017-12-11 Thread Ladislav Michl
Hi Oliver, Johan, On Mon, Dec 11, 2017 at 11:58:21AM +0100, Oliver Neukum wrote: > Am Montag, den 11.12.2017, 00:11 +0100 schrieb Ladislav Michl: > > Refactor bulk callback functions to make use of goto pointless. > > > > > > Hi, > > you seem to assume that this is a good thing by itself which

Re: [PATCH] USB: serial: Avoid goto in bulk callbacks

2017-12-11 Thread Oliver Neukum
Am Montag, den 11.12.2017, 00:11 +0100 schrieb Ladislav Michl: > Refactor bulk callback functions to make use of goto pointless. > > Hi, you seem to assume that this is a good thing by itself which needs no further justification. I disagree. You duplicated code. Regards

Re: [PATCH] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2017-12-11 Thread Stefan Wahren
Hi Minas, Am 11.12.2017 um 11:45 schrieb Minas Harutyunyan: > Hi Stefan, > On 12/8/2017 8:25 PM, Stefan Wahren wrote: >> Hi Minas, >> >> Am 07.12.2017 um 17:51 schrieb Stefan Wahren: >>> Hi Minas, >>> >>> Am 07.12.2017 um 09:40 schrieb Stefan Wahren: Before flushing fifos required to check AH

Re: Webcams not recognized on a Dell Latitude 5285 laptop

2017-12-11 Thread Oliver Neukum
Am Montag, den 11.12.2017, 09:05 +0100 schrieb Frédéric Parrenin : > Multimedia controller: Intel Corporation Skylake Imaging Unit Please provide at least 1) dmesg 2) lsusb -v 3) lspci -vvk 4) lspci -vvnk There is no webcam shown on your USB bus. Without dmesg it is impossible to say whet

Re: [PATCH] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2017-12-11 Thread Minas Harutyunyan
Hi Stefan, On 12/8/2017 8:25 PM, Stefan Wahren wrote: > Hi Minas, > > Am 07.12.2017 um 17:51 schrieb Stefan Wahren: >> Hi Minas, >> >> Am 07.12.2017 um 09:40 schrieb Stefan Wahren: >>> Before flushing fifos required to check AHB master state and >>> flush when AHB master is in IDLE state. >>> >>>

Re: [PATCH] usb-core: Fix potential null pointer dereference in xhci-debugfs.c

2017-12-11 Thread Mathias Nyman
On 10.12.2017 00:38, Alexander Kappner wrote: Hi Mathias, thanks for the patch! The system now resumes cleanly from hibernate even with usbmuxd doing its thing. Tested-by: Alexander Kappner While testing this I hit some other issues with xhci-debugfs.c but I'll write these up in a separate

Re: [PATCH v1 2/2] usb: tegra: Move UTMI-pads reset from ehci-tegra to tegra-phy

2017-12-11 Thread Thierry Reding
On Mon, Dec 11, 2017 at 02:07:38AM +0300, Dmitry Osipenko wrote: > UTMI pads are shared by USB controllers and reset of UTMI pads is shared > with the reset of USB1 controller. Currently reset of UTMI pads is done by > the EHCI driver and ChipIdea UDC works because EHCI driver always happen > to be

Re: [PATCH] USB: serial: Avoid goto in bulk callbacks

2017-12-11 Thread Johan Hovold
On Mon, Dec 11, 2017 at 12:11:52AM +0100, Ladislav Michl wrote: > Refactor bulk callback functions to make use of goto pointless. > > Signed-off-by: Ladislav Michl > --- > drivers/usb/serial/generic.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/

Re: [PATCH] USB: serial: ti_usb_3410_5052: Avoid goto in bulk in callback

2017-12-11 Thread Johan Hovold
On Mon, Dec 11, 2017 at 12:09:19AM +0100, Ladislav Michl wrote: > Make status handling in bulk in callback function more compact, > which renders goto pointless. > > Signed-off-by: Ladislav Michl > --- > drivers/usb/serial/ti_usb_3410_5052.c | 36 > ++- > 1 file

Re: [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig

2017-12-11 Thread Thierry Reding
On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote: > UDC driver won't probe without Tegra's PHY, hence select it in the > Kconfig. > > Signed-off-by: Dmitry Osipenko > --- > drivers/usb/chipidea/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/chipidea/

Re: [PATCH v1 1/2] usb: phy: Add Kconfig entry for Tegra's PHY driver

2017-12-11 Thread Thierry Reding
On Mon, Dec 11, 2017 at 02:09:59AM +0300, Dmitry Osipenko wrote: > Add Kconfig entry so that other drivers other than ehci-tegra > (like ChipIdea) could add Tegra's PHY to build dependencies. > > Signed-off-by: Dmitry Osipenko > --- > drivers/usb/host/Kconfig | 2 +- > drivers/usb/phy/Kconfig |

Re: [PATCH v1] usb: phy: tegra: Increase PHY clock stabilization timeout

2017-12-11 Thread Thierry Reding
On Mon, Dec 11, 2017 at 01:55:35AM +0300, Dmitry Osipenko wrote: > This fixes "utmi_phy_clk_enable: timeout waiting for phy to stabilize" > error message. > > Signed-off-by: Dmitry Osipenko > --- > drivers/usb/phy/phy-tegra-usb.c | 13 - > 1 file changed, 4 insertions(+), 9 deletions

[RESEND PATCH v9] xhci : AMD Promontory USB disable port support

2017-12-11 Thread Joe Lee
From: Joe Lee For AMD Promontory xHCI host,although you can disable USB ports in BIOSsettings,those ports will be enabled anyway after you remove a device onthat port and re-plug it in again. It's a known limitation of the chip.As a workaround we can clear the PORT_WAKE_BITS. Signed-off-by: Joe

Re: [PATCH v1 1/2] usb: phy: tegra: Cleanup error messages

2017-12-11 Thread Thierry Reding
On Mon, Dec 11, 2017 at 02:07:37AM +0300, Dmitry Osipenko wrote: > Tegra's PHY driver has a mix of pr_err() and dev_err(), let's switch to > dev_err() and use common errors message formatting across the driver for > consistency. > > Signed-off-by: Dmitry Osipenko > --- > drivers/usb/phy/phy-tegr

RE: [PATCH v2] usb: host: Implement workaround for Erratum A-009611

2017-12-11 Thread Felipe Balbi
Hi, (please break your lines at 80-characters) Yinbo Zhu writes: >>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index >>> 5cb3f6795b0b..071e7cea8cbb 100644 >>> --- a/drivers/usb/dwc3/core.c >>> +++ b/drivers/usb/dwc3/core.c >>> @@ -1106,6 +1106,9 @@ static void dwc3_get_pro

RE: [PATCH v2] usb: host: Implement workaround for Erratum A-009611

2017-12-11 Thread Yinbo Zhu
-Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Friday, December 08, 2017 6:21 PM To: Yinbo Zhu Cc: Felipe Balbi ; Mathias Nyman ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list ; Xiaobo Xie ; Jerry

[PATCH] xhci: fixup incorrect memset size parameter when clearing up DbC on exit.

2017-12-11 Thread Mathias Nyman
Incorrect size was given to memset when zeroing the DbC endpoint structures on exit. Use element size * ARRAY_SIZE to fix it Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-dbgcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-dbgcap.c b/driver

RE: [PATCH v2] usb: host: Implement workaround for Erratum A-009611

2017-12-11 Thread Yinbo Zhu
-Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Monday, December 11, 2017 3:35 PM To: Yinbo Zhu Cc: Felipe Balbi ; Mathias Nyman ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list ; Xiaobo Xie ; Jerry

Webcams not recognized on a Dell Latitude 5285 laptop

2017-12-11 Thread Frédéric Parrenin
Dear all, I recently installed linux 4.14 on a Dell Latitude 5285 detachable laptop. The problem I have is that the webcams (both the rear one and the front one) are not recognized. There is no /dev/video* file. I am not sure what is the model of the webcam. The Dell support website for this

RE: [PATCH v2] usb: host: Implement workaround for Erratum A-007463

2017-12-11 Thread Yinbo Zhu
-Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Monday, December 11, 2017 3:34 PM To: Yinbo Zhu Cc: Felipe Balbi ; Mathias Nyman ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list:DESIGNWARE USB3 DRD IP DRIVER ; open list ; Xiaobo Xie ; Jerry

Re: [PATCH] usb: dwc2: host: Setting TOUTCAL and USBTRDTIM fields in host mode

2017-12-11 Thread Minas Harutyunyan
Hi Stefan, On 12/7/2017 9:04 PM, Stefan Wahren wrote: > Hi Minas, > > Am 07.12.2017 um 17:56 schrieb Stefan Wahren: >> Added missing GUSBCFG programming in host mode. >> >> These fields even if was programmed in device mode (in function >> dwc2_hsotg_core_init_disconnected()) will be resetting to

[PATCH] usb: dwc2: host: Fix transaction errors in host mode

2017-12-11 Thread Minas Harutyunyan
Added missing GUSBCFG programming in host mode, which fixes transaction errors issue on HiKey and Altera Cyclone V boards. These field even if was programmed in device mode (in function dwc2_hsotg_core_init_disconnected()) will be resetting to POR values after core soft reset applied. So, each tim