Re: [PATCH] usb: ulpi: Automatically set driver::owner with ulpi_driver_register()

plate detail and avoids common bugs > in the process. > > Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> Acked-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-u

Re: [PATCHv3 1/2] usb: USB Type-C connector class

SB PD, we will have to report "unknown" in it. Oliver, Guenter! How do you guys feel about those? Is there any use for them? > On Mon, Jun 27, 2016 at 3:21 PM, Heikki Krogerus > <heikki.kroge...@linux.intel.com> wrote: > > On Fri, Jun 24, 2016 at 07:54:12PM +0530, Rajaram R wro

Re: [PATCHv3 1/2] usb: USB Type-C connector class

Hi Roger, I'll fix all the typos you mention below... On Thu, Jun 23, 2016 at 02:53:11PM +0300, Roger Quadros wrote: > Hi Heikki, > > On 21/06/16 17:51, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user sp

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Thu, Jun 23, 2016 at 03:25:46PM +0300, Roger Quadros wrote: > Hi, > > On 23/06/16 15:00, Heikki Krogerus wrote: > > Hi Oliver, > > > > On Thu, Jun 23, 2016 at 10:38:58AM +0200, Oliver Neukum wrote: > >> On Thu, 2016-06-23 at 11:23 +0300, Heikki Krogerus wro

Re: [PATCHv3 1/2] usb: USB Type-C connector class

Hi Oliver, On Thu, Jun 23, 2016 at 10:38:58AM +0200, Oliver Neukum wrote: > On Thu, 2016-06-23 at 11:23 +0300, Heikki Krogerus wrote: > > On Wed, Jun 22, 2016 at 06:44:18PM +0200, Oliver Neukum wrote: > > > No it's not. DRP means a port that can operate as _either_ Source

Re: [PATCHv3 1/2] usb: USB Type-C connector class

Hi, On Wed, Jun 22, 2016 at 02:54:28PM -0700, Guenter Roeck wrote: > Hi, > > > + > > +static void typec_remove_partner(struct typec_port *port) > > +{ > > + WARN_ON(port->partner->alt_modes); > > You are setting partner->alt_modes in typec_register_altmodes(), > but you don't clear it in

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 22, 2016 at 06:44:18PM +0200, Oliver Neukum wrote: > On Wed, 2016-06-22 at 17:38 +0300, Heikki Krogerus wrote: > > On Wed, Jun 22, 2016 at 03:47:03PM +0200, Oliver Neukum wrote: > > > On Wed, 2016-06-22 at 14:44 +0300, Heikki Krogerus wrote: > > > > I

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 22, 2016 at 03:47:03PM +0200, Oliver Neukum wrote: > On Wed, 2016-06-22 at 14:44 +0300, Heikki Krogerus wrote: > > If our port is DRD (which would be DRP in the port controller spec), > > the supported_power_roles will list: > > > > device, host

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 22, 2016 at 12:14:55PM +0200, Oliver Neukum wrote: > On Wed, 2016-06-22 at 12:50 +0300, Heikki Krogerus wrote: > > On Tue, Jun 21, 2016 at 10:25:05PM +0200, Oliver Neukum wrote: > > > On Tue, 2016-06-21 at 17:51 +0300, Heikki Krogerus wrote: > > > > +W

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Wed, Jun 22, 2016 at 12:08:57PM +0200, Oliver Neukum wrote: > On Wed, 2016-06-22 at 12:31 +0300, Heikki Krogerus wrote: > > Hi, > > > > Now correct me, if I am misreading the spec. I am sure the system > > > will boot unless it needs ridiculous amounts of power,

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Wed, Jun 22, 2016 at 12:50:16PM +0300, Heikki Krogerus wrote: > On Tue, Jun 21, 2016 at 10:25:05PM +0200, Oliver Neukum wrote: > > On Tue, 2016-06-21 at 17:51 +0300, Heikki Krogerus wrote: > > > +What: /sys/class/typec//supported_data_roles > > >

Re: [PATCHv3 0/2] USB Type-C Connector class

Hi Guenter, On Tue, Jun 21, 2016 at 03:25:55PM -0700, Guenter Roeck wrote: > On Tue, Jun 21, 2016 at 05:51:49PM +0300, Heikki Krogerus wrote: > > Hi, > > > > I'm considering all the RFCs I send after v1 as v2 (I don't remember > > how many I send). Hope this is OK an

Re: [PATCHv3 1/2] usb: USB Type-C connector class

On Tue, Jun 21, 2016 at 10:25:05PM +0200, Oliver Neukum wrote: > On Tue, 2016-06-21 at 17:51 +0300, Heikki Krogerus wrote: > > +What: /sys/class/typec//supported_data_roles > > +Data: June 2016 > > +Contact: Heikki Krogerus <heikki.kroge...@linux.int

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

Hi Oliver, On Tue, Jun 21, 2016 at 10:43:05PM +0200, Oliver Neukum wrote: > On Tue, 2016-06-21 at 16:58 +0300, Heikki Krogerus wrote: > > On Tue, Jun 21, 2016 at 03:08:52PM +0200, Oliver Neukum wrote: > > > > > The firmware will surely want to display something. So it i

[PATCHv3 0/2] USB Type-C Connector class

about that. I'm including in this series a driver for the Broxton PMIC USB Type-C PHY. Changes since v2: - Notification on role and alternate mode changes - cleanups Changes since v1: - Completely rewrote alternate mode support - Patners, cables and cable plugs presented as devices. Heikki

[PATCHv3 1/2] usb: USB Type-C connector class

. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- Documentation/ABI/testing/sysfs-class-typec | 163 Documentation/usb/typec.txt | 101 +++ MAINTAINERS |9 + drivers/usb/Kconfig |2 + d

[PATCHv3 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY

This adds driver for the USB Type-C PHY on Intel WhiskeyCove PMIC which is available on some of the Intel Broxton SoC based platforms. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/typec/Kconfig | 14 ++ drivers/usb/typec/Makefile | 1 + d

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Tue, Jun 21, 2016 at 03:08:52PM +0200, Oliver Neukum wrote: > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > > The purpose of this class is to provide unified interface for user > > space to get the status and basic information about USB Type-C > > Connectors i

Re: [RFC PATCHv3] usb: USB Type-C Connector Class

On Sat, Jun 11, 2016 at 11:03:53AM -0700, Guenter Roeck wrote: > On 06/11/2016 12:05 AM, Oliver Neukum wrote: > > On Fri, 2016-06-10 at 17:34 +0300, Heikki Krogerus wrote: > > > +static ssize_t > > > +preferred_role_store(struct device *dev, struct d

Re: [RFC PATCHv3] usb: USB Type-C Connector Class

On Sat, Jun 11, 2016 at 09:05:46AM +0200, Oliver Neukum wrote: > On Fri, 2016-06-10 at 17:34 +0300, Heikki Krogerus wrote: > > +static ssize_t > > +preferred_role_store(struct device *dev, struct device_attribute > > *attr, > > +c

[RFC PATCHv3] usb: USB Type-C Connector Class

The purpose of this class is to provide unified interface for user space to get the status and basic information about USB Type-C Connectors in the system, control data role swapping, and when USB PD is available, also power role swapping and Alternate Modes. Signed-off-by: Heikki Krogerus

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Mon, Jun 06, 2016 at 03:35:35PM +0200, Oliver Neukum wrote: > On Mon, 2016-06-06 at 16:28 +0300, Heikki Krogerus wrote: > > > I would prefer lower case letters. I don't know the SIDs there are at > > them moment, other then Display Port. Do you know them? > > >

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

Hi, On Fri, Jun 03, 2016 at 10:20:01PM +0200, Pavel Machek wrote: > On Thu 2016-05-19 15:44:54, Heikki Krogerus wrote: > > The purpose of this class is to provide unified interface for user > > space to get the status and basic information about USB Type-C > > Connectors i

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Fri, Jun 03, 2016 at 11:39:27AM -0700, Guenter Roeck wrote: > On Fri, Jun 03, 2016 at 06:17:46PM +0300, Heikki Krogerus wrote: > [ ... ] > > > > > > > > > > In my test case, this gives me > > > > > /sys/class/type-c/usbc0/ > > &g

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Fri, Jun 03, 2016 at 06:51:54AM -0700, Guenter Roeck wrote: > On 06/03/2016 06:21 AM, Heikki Krogerus wrote: > > Hi, > > > > On Thu, Jun 02, 2016 at 09:12:19AM -0700, Guenter Roeck wrote: > > > On Thu, Jun 02, 2016 at 01:18:53PM +0300, Heikki Krogerus wrote: >

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

Hi, On Thu, Jun 02, 2016 at 09:12:19AM -0700, Guenter Roeck wrote: > On Thu, Jun 02, 2016 at 01:18:53PM +0300, Heikki Krogerus wrote: > > On Wed, Jun 01, 2016 at 04:29:26PM -0700, Guenter Roeck wrote: > > > On Wed, Jun 01, 2016 at 11:26:09AM +0200, Oliver Neukum wrote: > >

Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux

On Fri, Jun 03, 2016 at 03:41:13PM +0800, Peter Chen wrote: > On Thu, Jun 02, 2016 at 09:37:24AM +0800, Lu Baolu wrote: > > Several Intel platforms implement USB dual role by having completely > > separate xHCI and dwc3 IPs in PCH or SOC silicons. These two IPs share > > a single USB port. There

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Wed, Jun 01, 2016 at 04:29:26PM -0700, Guenter Roeck wrote: > On Wed, Jun 01, 2016 at 11:26:09AM +0200, Oliver Neukum wrote: > > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > > > Just noticed that the "active" file is for now read only, but it needs >

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Thu, Jun 02, 2016 at 08:30:57AM +0200, Oliver Neukum wrote: > On Wed, 2016-06-01 at 16:29 -0700, Guenter Roeck wrote: > > On Wed, Jun 01, 2016 at 11:26:09AM +0200, Oliver Neukum wrote: > > > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > > > > Just

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Wed, Jun 01, 2016 at 11:26:09AM +0200, Oliver Neukum wrote: > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > > Just noticed that the "active" file is for now read only, but it needs > > to be changed to writable. That file will of course provide means for

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Tue, May 31, 2016 at 10:20:34AM -0700, Guenter Roeck wrote: > On Tue, May 31, 2016 at 03:43:56PM +0300, Heikki Krogerus wrote: > > On Tue, May 31, 2016 at 03:09:01PM +0300, Heikki Krogerus wrote: > > > On Tue, May 31, 2016 at 10:48:29AM +0200, Oliver Neukum wrote: > >

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Tue, May 31, 2016 at 03:09:01PM +0300, Heikki Krogerus wrote: > On Tue, May 31, 2016 at 10:48:29AM +0200, Oliver Neukum wrote: > > On Tue, 2016-05-31 at 11:31 +0300, Heikki Krogerus wrote: > > > Hi Oliver, > > > > > > On Mon, May 30, 2016 at 0

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Tue, May 31, 2016 at 10:48:29AM +0200, Oliver Neukum wrote: > On Tue, 2016-05-31 at 11:31 +0300, Heikki Krogerus wrote: > > Hi Oliver, > > > > On Mon, May 30, 2016 at 03:59:27PM +0200, Oliver Neukum wrote: > > > On Mon, 2016-05-30 at 16:19 +0300, Heikki K

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

Hi Oliver, On Mon, May 30, 2016 at 03:59:27PM +0200, Oliver Neukum wrote: > On Mon, 2016-05-30 at 16:19 +0300, Heikki Krogerus wrote: > > Hi guys, > > > > I'm attaching a diff instead of full v3. I'm not yet adding attributes > > for the reset and cable_reset. I

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

Hi guys, I'm attaching a diff instead of full v3. I'm not yet adding attributes for the reset and cable_reset. I still don't understand what is the case where the userspace would need to be able to tricker reset? Why isn't it enough for the userspace to be able to enter/exit modes? Oliver! Can

Re: [RFC PATCH] usb: typec: Various API updates and fixes

Hi guys, On Fri, May 27, 2016 at 07:06:41AM -0700, Guenter Roeck wrote: > On 05/27/2016 12:55 AM, Heikki Krogerus wrote: > > I'll merge this into any case to v3, and I'll send on Monday. > > > Sounds good. > > Couple of additional comments. > > I don't really

Re: [PATCH 2/3] usb: dwc3: host: use build-in property instead of platform data

On Mon, May 30, 2016 at 11:12:40AM +0300, Felipe Balbi wrote: > > Hi, > > Heikki Krogerus <heikki.kroge...@linux.intel.com> writes: > > Hi Felipe, > > > > On Tue, Apr 19, 2016 at 02:10:45PM +0300, Heikki Krogerus wrote: > >> This should a

Re: [PATCH v9 7/7] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

Hi Baolu, On Mon, May 30, 2016 at 01:51:44PM +0800, Lu Baolu wrote: > Add a maintainer entry for Intel USB dual role mux drivers and > add myself as a maintainer. > > Signed-off-by: Lu Baolu > --- > MAINTAINERS | 10 ++ > 1 file changed, 10 insertions(+) > >

Re: [PATCH 2/3] usb: dwc3: host: use build-in property instead of platform data

Hi Felipe, On Tue, Apr 19, 2016 at 02:10:45PM +0300, Heikki Krogerus wrote: > This should allow xhci to remove handling of platform data. > > Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> > Cc: Felipe Balbi <ba...@ti.com> Is this OK now? > --- >

Re: [RFC PATCH] usb: typec: Various API updates and fixes

an empty string. > > Signed-off-by: Guenter Roeck <gro...@chromium.org> > Signed-off-by: Guenter Roeck <li...@roeck-us.net> > --- > This patch applies on top of '[RFC PATCHv2] usb: USB Type-C Connector Class' > from Heikki Krogerus. It provided the changes I made to get th

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Wed, May 25, 2016 at 08:19:47AM -0700, Guenter Roeck wrote: > On Wed, May 25, 2016 at 02:28:46PM +0300, Heikki Krogerus wrote: > > Hi, > > > > On Tue, May 24, 2016 at 02:51:40PM +0200, Oliver Neukum wrote: > > > On Thu, 2016-05-19 at 15:44 +0300, Heikki K

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Wed, May 25, 2016 at 07:59:57AM -0700, Guenter Roeck wrote: > On Wed, May 25, 2016 at 04:20:56PM +0200, Oliver Neukum wrote: > > On Wed, 2016-05-25 at 17:04 +0300, Heikki Krogerus wrote: > > > > > I'm not against leaving the responsibility of registering t

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Wed, May 25, 2016 at 06:21:54AM -0700, Guenter Roeck wrote: > On 05/25/2016 04:51 AM, Heikki Krogerus wrote: > > On Tue, May 24, 2016 at 12:28:26PM -0700, Guenter Roeck wrote: > > > On Thu, May 19, 2016 at 03:44:54PM +0300, Heikki Krogerus wrote: > > > > The purpo

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Tue, May 24, 2016 at 12:28:26PM -0700, Guenter Roeck wrote: > On Thu, May 19, 2016 at 03:44:54PM +0300, Heikki Krogerus wrote: > > The purpose of this class is to provide unified interface for user > > space to get the status and basic information about USB Type-C > > Con

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

Hi, On Tue, May 24, 2016 at 06:42:09AM -0700, Guenter Roeck wrote: > > +struct typec_capability { > > + enum typec_data_rolerole; > > + unsigned intusb_pd:1; > > + struct typec_altmode*alt_modes; > > + unsigned intaudio_accessory:1; > > + unsigned int

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

Hi, On Tue, May 24, 2016 at 02:51:40PM +0200, Oliver Neukum wrote: > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > > Hi, > > as this discussion seems to go in circles, I am starting anew > at the top. > > > Like I've told some of you guys, I'

Re: [PATCH v8 2/7] usb: mux: add generic code for dual role port mux

Hi Baolu, Sorry to comment this so late, but we got hardware that needs to configure the mux in OS, and I noticed some problem. We are missing means to bind a port to the correct mux on multiport systems. That we need to solve later in any case, but there is an other issue related to the fact

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Tue, May 24, 2016 at 12:18:38PM +0200, Oliver Neukum wrote: > On Tue, 2016-05-24 at 13:08 +0300, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Mon, May 23, 2016 at 09:52:12AM -0700, Guenter Roeck wrote: > > > On Mon, May 23, 2016 at 05:55:04PM +0200, Olive

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

Hi Guenter, On Mon, May 23, 2016 at 09:52:12AM -0700, Guenter Roeck wrote: > On Mon, May 23, 2016 at 05:55:04PM +0200, Oliver Neukum wrote: > > On Mon, 2016-05-23 at 07:43 -0700, Guenter Roeck wrote: > > > On 05/23/2016 06:58 AM, Oliver Neukum wrote: > > > > > > Now I am confused. Are you saying

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Mon, May 23, 2016 at 01:25:19PM +0200, Oliver Neukum wrote: > So for Alternate Modes we need on a high level the following features > > 1. discovery of available Alternate Modes > 2. selection of an Alternate Mode > 3. notification about entering an Alternate Mode > 4. triggering a reset > 5.

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Fri, May 20, 2016 at 10:02:28AM -0700, Guenter Roeck wrote: > On Fri, May 20, 2016 at 01:47:03PM +0300, Heikki Krogerus wrote: > > On Thu, May 19, 2016 at 10:53:04AM -0700, Guenter Roeck wrote: > > > Hello Heikki, > > > > > > On Thu, May 19, 2016 at 03:

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Thu, May 19, 2016 at 04:47:17PM +0200, Oliver Neukum wrote: > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > > The purpose of this class is to provide unified interface for user > > space to get the status and basic information about USB Type-C > > Connectors i

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Thu, May 19, 2016 at 08:43:27AM -0700, Greg KH wrote: > On Thu, May 19, 2016 at 04:48:46PM +0200, Oliver Neukum wrote: > > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: > > > + ret = typec_register_altmodes(dev, partner->alt_mo

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Thu, May 19, 2016 at 10:53:04AM -0700, Guenter Roeck wrote: > Hello Heikki, > > On Thu, May 19, 2016 at 03:44:54PM +0300, Heikki Krogerus wrote: > > The purpose of this class is to provide unified interface for user > > space to get the status and basic informa

[RFC PATCHv2] usb: USB Type-C Connector Class

The purpose of this class is to provide unified interface for user space to get the status and basic information about USB Type-C Connectors in the system, control data role swapping, and when USB PD is available, also power role swapping and Alternate Modes. Signed-off-by: Heikki Krogerus

Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI

Hi, On Wed, May 11, 2016 at 07:47:18AM -0700, Guenter Roeck wrote: > Hi, > > On Wed, May 11, 2016 at 12:40:11PM +0300, Heikki Krogerus wrote: > > On Tue, May 10, 2016 at 08:14:34PM -0700, Guenter Roeck wrote: > > > Heikki, > > > > > > On 05/06/2016 0

Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI

On Tue, May 10, 2016 at 08:14:34PM -0700, Guenter Roeck wrote: > Heikki, > > On 05/06/2016 01:08 AM, Heikki Krogerus wrote: > > Hi, > > > [ ... ] > > > > I don't have not made any new code for the class driver yet, but I'm > > attempting to prepar

Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI

On Fri, May 06, 2016 at 01:05:05AM -0700, Guenter Roeck wrote: > Felipe, > > On 05/05/2016 11:50 PM, Felipe Balbi wrote: > > > > Hi Guenter, > > > > Guenter Roeck <li...@roeck-us.net> writes: > > > On Tue, Feb 09, 2016 at 07:

Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI

On Fri, May 06, 2016 at 09:50:00AM +0300, Felipe Balbi wrote: > > Hi Guenter, > > Guenter Roeck <li...@roeck-us.net> writes: > > On Tue, Feb 09, 2016 at 07:01:20PM +0200, Heikki Krogerus wrote: > >> Hi, > >> > >> The OS, or more precisely the

Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI

Hi, On Wed, May 04, 2016 at 08:05:44PM -0700, Guenter Roeck wrote: > On Tue, Feb 09, 2016 at 07:01:20PM +0200, Heikki Krogerus wrote: > > Hi, > > > > The OS, or more precisely the user space, needs to be able to control > > a few things regarding USB Type-C ports

Re: [PATCHv3] usb: Add driver for UCSI

Hi Greg, On Thu, Apr 28, 2016 at 12:53:24PM -0700, Greg Kroah-Hartman wrote: > On Thu, Apr 21, 2016 at 03:43:40PM +0300, Heikki Krogerus wrote: > > USB Type-C Connector System Software Interface (UCSI) is > > specification that defines the registers and data structures >

Re: [RESEND PATCH v2 6/7] usb: xhci: plat: add generic PHY support

Hi, On Tue, Apr 26, 2016 at 08:57:39PM +0800, Jisheng Zhang wrote: > @@ -232,22 +265,44 @@ static int xhci_plat_probe(struct platform_device *pdev) > if (HCC_MAX_PSA(xhci->hcc_params) >= 4) > xhci->shared_hcd->can_do_streams = 1; > > + hcd->phy = devm_phy_get(>dev,

Re: [PATCH] usb: xhci-plat: properly handle probe deferral for devm_clk_get()

Hi, One nitpick.. On Fri, Apr 22, 2016 at 03:16:45PM +0200, Thomas Petazzoni wrote: > On some platforms, the clocks might be registered by a platform > driver. When this is the case, the clock platform driver may very well > be probed after xhci-plat, in which case the first probe() invocation >

[PATCHv2 4/4] usb: dwc3: remove handling of platform data

No more users for it. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/dwc3/core.c | 35 -- drivers/usb/dwc3/platform_data.h | 53 2 files changed, 88 deletions(-) delete mode

[PATCHv2 3/4] usb: dwc3: pci: use build-in properties instead of platform data

This should allow the core driver to drop handling of platform data and expect the platform specific details to always come from properties. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Cc: Huang Rui <ray.hu...@amd.com> CC: John Youn <john.y...@synopsys.com>

[PATCHv2 0/4] usb: dwc3: get rid of platform data

Changes since v1: - Slit the refactoring and cleanup into separate patches Heikki Krogerus (4): usb: dwc3: pci: make build-in device properties available usb: dwc3: pci: pass the platform device as a parameter to dwc3_pci_quirks() usb: dwc3: pci: use build-in properties instead

[PATCHv2 1/4] usb: dwc3: pci: make build-in device properties available

in cases where also ACPI companion exists. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/dwc3/dwc3-pci.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index adc1e8a..e444e9a

[PATCHv2 2/4] usb: dwc3: pci: pass the platform device as a parameter to dwc3_pci_quirks()

For convenience, passing the dwc3 platform device as a parameter to dwc3_pci_quirks() function. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/dwc3/dwc3-pci.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/usb/dwc

[PATCHv3] usb: Add driver for UCSI

. The UCSI specification is public can be obtained from here: http://www.intel.com/content/www/us/en/io/universal-serial-bus/usb-type-c-ucsi-spec.html Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/misc/Kconfig | 26 +++ drivers/usb/misc/Makefile | 1 + drive

Re: [PATCH 0/3] xhci: get rid of platform data

On Thu, Apr 21, 2016 at 02:02:38PM +0300, Felipe Balbi wrote: > > Hi, > > Heikki Krogerus <heikki.kroge...@linux.intel.com> writes: > > Hi, > > > > This depends on API change the device property framework in Rafael's > > linux-pm tree. > > >

Re: [PATCH 1/2] usb: dwc3: pci: use build-in properties instead of platform data

On Thu, Apr 21, 2016 at 02:01:47PM +0300, Felipe Balbi wrote: > > @@ -169,20 +161,21 @@ static int dwc3_pci_probe(struct pci_dev *pci, > > return ret; > > } > > > > - pci_set_drvdata(pci, dwc3); > > - ret = dwc3_pci_quirks(pci); > > - if (ret) > > - goto err; > >

Re: [PATCH 0/2] usb: dwc3: remove platform data

On Thu, Apr 21, 2016 at 01:58:43PM +0300, Felipe Balbi wrote: > > Hi, > > Heikki Krogerus <heikki.kroge...@linux.intel.com> writes: > > Hi, > > > > The API changes to the device property framework that I've been > > waiting are now part of Rafael's linux

Re: [PATCHv2] usb: Add driver for UCSI

On Thu, Apr 21, 2016 at 11:37:34AM +0300, Mathias Nyman wrote: > >+static void ucsi_acpi_notify(acpi_handle handle, u32 event, void *data) > >+{ > >+struct ucsi *ucsi = data; > >+struct ucsi_cci *cci; > >+ > >+spin_lock(>dev_lock); > >+ > >+ucsi->status = UCSI_IDLE; > >+cci =

[PATCHv2] usb: Add driver for UCSI

. The UCSI specification is public can be obtained from here: http://www.intel.com/content/www/us/en/io/universal-serial-bus/usb-type-c-ucsi-spec.html Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/misc/Kconfig | 26 +++ drivers/usb/misc/Makefile | 1 + drive

[PATCH 1/3] xhci: plat: adapt to unified device property interface

Requesting the only property that the driver needs using the unified device property interface so it will be available for all types of platforms, not just the ones using DT. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/host/xhci-plat.c | 5 ++---

[PATCH 3/3] xhci: get rid of platform data

No more users for it. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/host/xhci-plat.c | 5 + include/linux/usb/xhci_pdriver.h | 27 --- 2 files changed, 1 insertion(+), 31 deletions(-) delete mode 100644 include/lin

[PATCH 0/3] xhci: get rid of platform data

Hi, This depends on API change the device property framework in Rafael's linux-pm tree. Branch linux-next in git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git Heikki Krogerus (3): xhci: plat: adapt to unified device property interface usb: dwc3: host: use build-in property

[PATCH 2/3] usb: dwc3: host: use build-in property instead of platform data

This should allow xhci to remove handling of platform data. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Cc: Felipe Balbi <ba...@ti.com> --- drivers/usb/dwc3/host.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/usb

[PATCH 1/2] usb: dwc3: pci: use build-in properties instead of platform data

setting the companion before dwc3_pci_quirks() is called. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Cc: Huang Rui <ray.hu...@amd.com> CC: John Youn <john.y...@synopsys.com> --- drivers/usb/dwc3/dwc3-pci.c | 85 +

[PATCH 2/2] usb: dwc3: remove handling of platform data

No more users for it. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> --- drivers/usb/dwc3/core.c | 35 -- drivers/usb/dwc3/platform_data.h | 53 2 files changed, 88 deletions(-) delete mode

[PATCH 0/2] usb: dwc3: remove platform data

Hi, The API changes to the device property framework that I've been waiting are now part of Rafael's linux-pm tree: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git So these depend on, I guess linux-next branch of that tree. Heikki Krogerus (2): usb: dwc3: pci: use build

Re: [PATCH] usb: Add driver for UCSI

On Tue, Apr 12, 2016 at 06:12:04AM -0700, Greg KH wrote: > On Tue, Apr 12, 2016 at 02:43:36PM +0300, Heikki Krogerus wrote: > > + ucsi.usb_data_role= > > Ick, this isn't the 1990's anymore, please don't use module parameters > for anything that is required for a driver.

Re: [PATCH] usb: Add driver for UCSI

On Tue, Apr 12, 2016 at 03:10:01PM +0200, Oliver Neukum wrote: > On Tue, 2016-04-12 at 14:43 +0300, Heikki Krogerus wrote: > > > +static int ucsi_init(struct ucsi *ucsi) > > +{ > > + struct ucsi_connector *con; > > + struct ucsi_control ctrl;

[PATCH] usb: Add driver for UCSI

extensive USB Type-C port control that UCSI offers, for example Power Role swapping, Alternate Mode control etc. The UCSI specification is public can be obtained from here: http://www.intel.com/content/www/us/en/io/universal-serial-bus/usb-type-c-ucsi-spec.html Signed-off-by: Heikki Krogerus <

[PATCH] pci: Add definition for USB Device Controller PCI Class ID

PCI-SIG has defined Interface FEh for Base Class 0Ch, Sub-Class 03h as "USB Device (not host controller)". It is already being used in various USB device controller drivers for matching, so converting those to use the definition. Signed-off-by: Heikki Krogerus <heikki.kroge...@li

Re: [PATCH 1/3] usb: USB Type-C Connector Class

Hi Oliver, I've missed couple of your questions.. > > > Furthermore, do these files support poll? > > At least the current role and mode can change, so in principle > poll() makes sense. Yes I agree. I'll add support for polling. > > > And lastly we can get "Attention" as a message connected

Re: [PATCH 1/3] usb: USB Type-C Connector Class

On Thu, Feb 18, 2016 at 02:44:25PM +0100, Oliver Neukum wrote: > On Thu, 2016-02-18 at 15:25 +0200, Heikki Krogerus wrote: > > Hi, > > > > > We have port directories for port power switching. How is > > > the connector directory linked to them? > > &g

Re: [PATCH 1/3] usb: USB Type-C Connector Class

Hi, On Thu, Feb 18, 2016 at 10:35:41AM +0100, Oliver Neukum wrote: > On Thu, 2016-02-18 at 10:47 +0200, Heikki Krogerus wrote: > > Hi, > > > P.S. That reminds me, here's my current draft for the > > Documentation/ABI/. Could you take a look? > > And I am afr

Re: [PATCH 1/3] usb: USB Type-C Connector Class

On Thu, Feb 18, 2016 at 10:21:48AM +0100, Oliver Neukum wrote: > On Thu, 2016-02-18 at 10:47 +0200, Heikki Krogerus wrote: > > Hi, > > > The modes that can actually be selected have to be supported by both > > the connector and the partner, and this is wh

Re: [PATCHv2 1/2] usb: dwc3: pci: use build-in properties instead of platform data

On Thu, Feb 18, 2016 at 01:27:28PM +0200, Felipe Balbi wrote: > Heikki Krogerus <heikki.kroge...@linux.intel.com> writes: > > > On Wed, Feb 17, 2016 at 04:24:26PM +0200, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Heikki Krogerus <he

Re: [PATCHv2 1/2] usb: dwc3: pci: use build-in properties instead of platform data

On Wed, Feb 17, 2016 at 04:24:26PM +0200, Felipe Balbi wrote: > > Hi, > > Heikki Krogerus <heikki.kroge...@linux.intel.com> writes: > > This should allow the core driver to drop handling of > > platform data and expect the platform specific details to &

Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI

Hi Rajaram, On Thu, Feb 18, 2016 at 01:04:48AM +0530, Rajaram R wrote: > On Tue, Feb 9, 2016 at 10:31 PM, Heikki Krogerus > <heikki.kroge...@linux.intel.com> wrote: > > Hi, > > > > The OS, or more precisely the user space, needs to be able to control > > a f

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

On Thu, Feb 18, 2016 at 04:07:54PM +0530, Rajaram R wrote: > On Wed, Feb 17, 2016 at 7:58 PM, Heikki Krogerus > <heikki.kroge...@linux.intel.com> wrote: > > On Wed, Feb 17, 2016 at 03:36:46PM +0200, Felipe Balbi wrote: > >> > >> Hi, > >> > >

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

Hi Peter, On Thu, Feb 18, 2016 at 05:07:04PM +0800, Peter Chen wrote: > On Wed, Feb 17, 2016 at 04:28:16PM +0200, Heikki Krogerus wrote: > > On Wed, Feb 17, 2016 at 03:36:46PM +0200, Felipe Balbi wrote: > > > IIRC mode and role negotiation goes via CC pins using the power deliv

Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI

On Wed, Feb 17, 2016 at 07:53:47PM +0100, Oliver Neukum wrote: > On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote: > > Hi, > > > > The OS, or more precisely the user space, needs to be able to control > > a few things regarding USB Type-C ports. The first thi

Re: [PATCH 1/3] usb: USB Type-C Connector Class

Hi Oliver, On Wed, Feb 17, 2016 at 03:07:27PM +0100, Oliver Neukum wrote: > On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote: > > 1. connected - Connection status of the connector > > 2. alternate_mode - The current Alternate Mode > > 3. alternate_modes - List

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

On Wed, Feb 17, 2016 at 03:36:46PM +0200, Felipe Balbi wrote: > > Hi, > > Heikki Krogerus <heikki.kroge...@linux.intel.com> writes: > > On Wed, Feb 17, 2016 at 11:36:52AM +0100, Oliver Neukum wrote: > >> On Wed, 2016-02-17 at 12:29 +0200, Felipe Balbi wrote:

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

On Wed, Feb 17, 2016 at 11:36:52AM +0100, Oliver Neukum wrote: > On Wed, 2016-02-17 at 12:29 +0200, Felipe Balbi wrote: > > Hi, > > > > Oliver Neukum <oneu...@suse.com> writes: > > > On Wed, 2016-02-17 at 09:58 +0200, Heikki Krogerus wrote: > > >>

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

On Tue, Feb 16, 2016 at 02:39:47PM +0100, Oliver Neukum wrote: > On Tue, 2016-02-16 at 11:22 +0200, Heikki Krogerus wrote: > > > That question has not been answered. It would be awkward for the OS > > > to find itself in the slave role, which it is ill equipped for. So >

Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface

Hi, On Mon, Feb 15, 2016 at 04:30:18PM +0100, Oliver Neukum wrote: > On Thu, 2016-02-11 at 15:50 +0200, Heikki Krogerus wrote: > > Because USB Type-C ports (DRP ones) will select the data role randomly > > when you connect (to an other DRP port). USB Type-C spec defines that >

<    2   3   4   5   6   7   8   9   10   >