Lukas Wunner wrote:
> On Tue, Apr 09, 2019 at 09:28:16AM +, Minas Harutyunyan wrote:
>> Am 09.04.19 um 08:54 schrieb Jisheng Zhang:
>>> The second one: 8000 usb interrupts per second when idle.
>>> This is abnormal. any idea? Is it due to the lan78xx?
>>
>> dwc2 in host mode enable SOF interrup
Hi Felipe,
Felipe Balbi writes:
< snip >
> thinking about this a little more. This extra list_empty() check is
> not wrong at all :-) I've amended this series with the 3 patches
> below. I'll resend the series once I've given more time for people to
> test. Patches have been updated to the bran
Forgot to CC linux-usb.
Forwarded Message
Subject: Re: howto debug xhci driver?
Date: Tue, 20 Mar 2018 13:56:21 -0700
From: Paul Zimmerman
To: Bin Liu
CC: Felipe Balbi
Hi,
Bin Liu writes:
Bin Liu writes:
BTY, the issue I am trying to debug is when reading
bulk IN data
On Tue, 13 Mar 2018 06:22:30 +, Minas Harutyunyan
wrote:
> Hi Paul,
>
> On 3/13/2018 6:26 AM, Paul Zimmerman wrote:
> > Hi Minas,
> >
> > While looking at the QH queuing in the DWC2 driver, I think I've found
> > some places where the QH struct may n
On Tue, 13 Mar 2018 06:11:06 +, Minas Harutyunyan
wrote:
> Hi Paul,
>
> On 3/13/2018 2:39 AM, Paul Zimmerman wrote:
> > On Mon, 12 Mar 2018 12:06:55 +, Minas Harutyunyan
> > wrote:
> >
> >> Hi Paul,
> >>
> >> Nice to hear you ag
Hi Minas,
While looking at the QH queuing in the DWC2 driver, I think I've found
some places where the QH struct may not be freed. Normally, the sequence is:
dwc2_hcd_qh_unlink();
< other stuff >
dwc2_hcd_qh_free();
or else:
dwc2_hcd_qh_unlink();
< other
On Mon, 12 Mar 2018 12:06:55 +, Minas Harutyunyan
wrote:
> Hi Paul,
>
> Nice to hear you again! Hope you are doing well.
Thanks, same to you.
> On 3/8/2018 1:51 PM, Paul Zimmerman wrote:
> > On 03/06/2018 09:09 AM, Minas Harutyunyan wrote:
> >> Driver debug l
On 03/06/2018 09:09 AM, Minas Harutyunyan wrote:
> Hi,
>
> On 3/6/2018 10:45 AM, Minas Harutyunyan wrote:
>> Hi,
>>
>> On 3/5/2018 11:14 PM, Marek Vasut wrote:
>>> On 02/20/2018 06:51 AM, Minas Harutyunyan wrote:
>>> [...]
>>> Is there a way to reduce that or is that the absolute minimum in HS
andy_purc...@keysight.com wrote:
>>>
>>> I have a second issue with a functionfs USB-device implementation.
>>>
>>> The scenario is this:
>>> 1) USB-device app starts up, runs fine
>>> 2) ssh to the device, kill the app with CTRL-C
>>> 3) try to start the USB-device app 2nd time
>>>
>>> PANIC
>>>
>
Alan Robertson wrote:
> On Sat, Jul 8, 2017 at 4:52 PM, Alan Stern wrote:
>> On Sat, 8 Jul 2017, Alan Robertson wrote:
>>
>>> On Sat, Jul 8, 2017 at 2:04 AM, Alan Stern
>>> wrote:
< snip >
>>> > Did you try enabling verbose debugging in g_mass_storage? This
>>> > requires setting CONFIG_USB_
On Tue, 13 Jun 2017 21:57:42 +, John Youn wrote:
> On 6/13/2017 2:39 PM, Paul Zimmerman wrote:
> > On Tue, 13 Jun 2017 18:33:09 +, John Youn
> > wrote:
> >
> >> On 6/13/2017 12:32 AM, Felipe Balbi wrote:
> >>>
> >>> Hi,
> >&
On Tue, 13 Jun 2017 18:33:09 +, John Youn wrote:
> On 6/13/2017 12:32 AM, Felipe Balbi wrote:
> >
> > Hi,
> >
> > Thinh Nguyen writes:
> this could be, I don't remember if I checked this or not :-)
>
> Really, the best way here, IMHO, would be to re-ver
Forgot to CC linux-usb, doing that now
On Fri, 2 Jun 2017 16:27:56 -0700, Paul Zimmerman wrote:
> Felipe Balbi writes:
> > Thinh Nguyen writes:
> >>>>>> this could be, I don't remember if I checked this or not :-)
> >>>>>>
> >>&
Felipe Balbi writes:
> instead of having infinite loop and always checking
> timeout value as a break condition, we can just
> decrement timeout inside while's condition.
>
> Signed-off-by: Felipe Balbi
> ---
> drivers/usb/dwc3/gadget.c | 18 ++
> 1 file changed, 6 insertions(+
Felipe Balbi writes:
> If we're going to issue a Update Transfer command,
> let's clear LST bit from previous TRB. This will let
> us continue processing TRBs and convert previous IRQ
> into XferInProgress, instead of XferComplete.
>
> Signed-off-by: Felipe Balbi
> ---
> drivers/usb/dwc3/gadge
Sorry, resending as plain text.
On Fri, Oct 9, 2015, Mathias Nyman wrote:
> + handling_skipped_tds = ep->skip &&
> + (trb_comp_code != COMP_MISSED_INT ||
^^
I think this should be &&, shouldn't it?
> + trb_comp_code != COMP_PING_ERR);
--
Paul
--
To unsubscribe from this list: send the line
On Tue, Oct 6, 2015 at 10:01 AM, Alan Stern wrote:
> On Tue, 6 Oct 2015, Felipe Balbi wrote:
>
>> >> In my experience, you need to do at least the following to get max
>> >> performance from the mass storage gadget:
>> >>
>> >> - Use Windows 8 or higher on the host. It's much faster than Linux.
>
On Mon, 5 Oct 2015, Alan Stern wrote:
> On Mon, 5 Oct 2015, Paul Jones wrote:
>
>>> Increasing the max_sectors_kb value, on the other hand, might remove
>>> overhead by allowing a higher percentage of the transfer to consist of
>>> real data as opposed to CBW and CSW packets. This depends to some
Yep, that's the one.
--
Paul
On Thu, Sep 24, 2015 at 2:37 PM, Steinar H. Gunderson
wrote:
> On Thu, Sep 24, 2015 at 02:33:06PM -0700, Paul Zimmerman wrote:
>> IIRC, at least some of the Intel controllers require the bandwidth
>> calculations to be done by the xHCI driver,
IIRC, at least some of the Intel controllers require the bandwidth
calculations to be done by the xHCI driver, instead of doing it
themselves in hardware. Perhaps you're tripping over a bug in the xHCI
driver? Mathias is probably best the one to comment on this.
--
Paul
--
To unsubscribe from thi
Update the MAINTAINERS entry for the dwc2 driver to show John Youn
as the new maintainer
Signed-off-by: Paul Zimmerman
---
Resending with linux-usb and linux-kernel in CC
MAINTAINERS |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Adding linux-usb and linux-kernel to CC.
--
Paul
> -Original Message-
> From: Paul Zimmerman
> Sent: Thursday, January 15, 2015 11:44 AM
> To: gre...@linuxfoundation.org; ba...@ti.com; John Youn
> (johny...@synopsys.com)
> Cc: 'r.bald...@samsung.com'; &#x
/resume on platforms where it does work correctly.
Signed-off-by: Paul Zimmerman
---
Based on Felipe's testing/next branch.
drivers/usb/dwc2/hcd.c | 88 ++--
1 files changed, 11 insertions(+), 77 deletions(-)
diff --git a/drivers/usb/dwc2/hc
>From 47bd18e210fecf701d493c27884e13c69bc449ea Mon Sep 17 00:00:00 2001
From: Paul Zimmerman
Date: Wed, 14 Jan 2015 18:15:58 -0800
Subject: [PATCH] usb: phy: make GPIOs optional for the generic phy
The use of GPIOs should be optional for the generic phy, otherwise
the Altera SOCFPGA platform
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Wednesday, January 14, 2015 2:50 PM
>
> On Wed, Jan 14, 2015 at 10:45:26PM +, Paul Zimmerman wrote:
> > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > Sent: Wednesday, January 14, 2015 2:40 PM
> > >
&
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Wednesday, January 14, 2015 2:40 PM
>
> On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote:
> > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > Sent: Wednesday, January 14, 2015 1:46 PM
> > >
&
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Wednesday, January 14, 2015 1:46 PM
>
> On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote:
> > > > > This is really, really odd. Register accesses are atomic, so the lock
> > > > > isn't really doing anything. Besides, you're calling
> >
's issue, it's
certainly a harmless patch, so
Acked-by: Paul Zimmerman
But I suspect Felipe will want a better changelog, I don't think just
a URL is good enough.
--
Paul
> ---
>
> Changelog:
>
> v2:
> - fixed comment from Paul Zimmerman
>
> v1: https://l
> From: Robert Baldyga [mailto:r.bald...@samsung.com]
> Sent: Tuesday, January 13, 2015 2:58 AM
>
> This patch fixes bug described here:
> https://lkml.org/lkml/2014/12/22/185
>
> Signed-off-by: Robert Baldyga
> ---
> drivers/usb/dwc2/core_intr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 d
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
> Sent: Monday, January 12, 2015 5:02 PM
>
> On Mon, Jan 12, 2015 at 11:14:54PM +, Paul Zimmerman wrote:
> > Hi everyone,
> >
> > I will be leaving Synopsys on Friday, Jan 16th, so the d
> From: Paul Zimmerman
> Sent: Saturday, January 10, 2015 3:52 PM
>
> > From: Yunzhi Li [mailto:l...@rock-chips.com]
> > Sent: Saturday, January 10, 2015 8:07 AM
> >
> > 在 2015/1/9 10:15, Paul Zimmerman 写道:
> > >> [...]
> > >>
Hi everyone,
I will be leaving Synopsys on Friday, Jan 16th, so the dwc2 driver
will need a new maintainer.
I am recommending John Youn as the new
maintainer.
On the plus side, John has quite a bit of experience with the dwc2
controller, and has previous experience submitting kernel patches (fo
> From: Robert Baldyga [mailto:r.bald...@samsung.com]
> Sent: Monday, December 22, 2014 6:13 AM
>
> I have recently noticed problem with DWC2 driver in latest linux-next. I
> use it in gadget only mode at Samsung platform (Odroid U3) but I believe
> the bug can be reproduced at another platforms.
> usb: dwc2: gadget: report disconnection after reset
>
> Documentation/devicetree/bindings/usb/dwc2.txt | 4 +
> drivers/usb/dwc2/core.h | 46 +-
> drivers/usb/dwc2/gadget.c | 792
> -
> drivers/usb/dwc2
> From: Yunzhi Li [mailto:l...@rock-chips.com]
> Sent: Saturday, January 10, 2015 8:07 AM
>
> 在 2015/1/9 10:15, Paul Zimmerman 写道:
> >> [...]
> >>/*
> >> - * Attempt to find a generic PHY, then look for an old style
> >> - * USB PHY, finally
CCing more of the Samsung folks and linux-kernel.
Robert, Marek, can you test this series on your platform, please? If
I don't hear from you soon, I'll just ack it and we can deal with any
breakage later.
--
Paul
> From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com]
> Sent: Friday, Januar
> From: Yunzhi Li [mailto:l...@rock-chips.com]
> Sent: Friday, December 12, 2014 7:10 AM
>
> Get PHY parameters from devicetree and power off usb PHY during
> system suspend.
>
> Signed-off-by: Yunzhi Li
> Acked-by: Paul Zimmerman
>
> ---
>
> Chang
/patch/5325111/
>
> Thanks,
>
> - Kever
> On 01/06/2015 09:23 AM, Paul Zimmerman wrote:
> >> From: Kever Yang [mailto:kever.y...@rock-chips.com]
> >> Sent: Wednesday, November 12, 2014 4:42 PM
> >>
> >> On 11/13/2014 07:22 AM, Doug Anderson wrote:
>
gt;> We also update the lx_state for hsotg state.
> >>
> >> This patch has tested on rk3288 with suspend/resume.
> >>
> >> Signed-off-by: Kever Yang
> >> Acked-by: Paul Zimmerman
> >> ---
> >>
> >> Changes in v3:
> &g
; s3c_hsotg_core_init_disconnected(hsotg);
> s3c_hsotg_core_connect(hsotg);
> @@ -2588,7 +2581,7 @@ static int s3c_hsotg_ep_disable(struct usb_ep *ep)
>
> spin_lock_irqsave(&hsotg->lock, flags);
> /* terminate a
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> Sent: Wednesday, December 17, 2014 5:50 AM
>
> DWC2 module on Exynos SoCs is used only as peripheral controller (UDC),
> so add support for selecting default initial state for dual-role mode. The
> default init mode can be overridden by
Adding Dinh to CC.
Robert, Dinh, I would like to have your tested-bys for this series, please.
--
Paul
> From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com]
> Sent: Friday, January 02, 2015 6:42 AM
>
> Hi,
> This patchset consists of various bug fixes and feature enhancements for the
> d
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of sundeep subbaraya
> Sent: Friday, December 12, 2014 9:13 PM
>
> Hi Felipe,
>
> In DWC3 driver, for three stage Control OUT transfer there is a check:
>
>else if (!IS_ALIGNED(req->request.length,
> * @ep: The endpoint to check.
> @@ -2933,7 +2937,7 @@ static int s3c_hsotg_udc_stop(struct usb_gadget *gadget,
>
> /* all endpoints should be shutdown */
> for (ep = 1; ep < hsotg->num_of_eps; ep++)
> - s3c_hsotg_ep_disable(&hsotg->eps[ep].ep);
> + s3c_hsotg_ep_disable_force(&hsotg->eps[ep].ep, true);
>
> spin_lock_irqsave(&hsotg->lock, flags);
>
Acked-by: Paul Zimmerman
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
+ } else {
> + if (dwc2->lx_state == DWC2_L0)
> + return 0;
> + phy_exit(dwc2->phy);
> + phy_power_off(dwc2->phy);
> +
> + }
> return ret;
> }
>
> @@ -241,8 +268,13 @@ static int __maybe_unused dwc2_resume(struc
> From: Yunzhi Li [mailto:l...@rock-chips.com]
> Sent: Sunday, December 07, 2014 7:58 PM
>
> On 2014/12/6 3:04, Paul Zimmerman wrote:
> >> From: Yunzhi Li [mailto:l...@rock-chips.com]
> >> Sent: Friday, December 05, 2014 4:52 AM
> >>
> >> Get PHY
> From: Yunzhi Li [mailto:l...@rock-chips.com]
> Sent: Friday, December 05, 2014 4:52 AM
>
> Get PHY parameters from devicetree and power off usb PHY during
> system suspend.
>
> Signed-off-by: Yunzhi Li
> ---
>
> drivers/usb/dwc2/gadget.c | 33 -
> drivers/us
> From: Sebastian Andrzej Siewior [mailto:bige...@linutronix.de]
> Sent: Tuesday, November 25, 2014 9:22 AM
>
> The max packet size within the FS descriptor has to be highest possible
> value and _not_ the one that is (or will be) used on FS.
> The way the code works (since day 1) is that usb_ep_a
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> Sent: Tuesday, November 18, 2014 12:47 PM
>
> On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote:
> >
> > notice that the original PLX driver was still far from the theo
c_hsotg_suspend(struct platform_device
> *pdev, pm_message_t state)
> clk_disable(hsotg->clk);
> }
>
> + mutex_unlock(&hsotg->init_mutex);
> +
> return ret;
> }
>
> @@ -3683,7 +3699,9 @@ static int s3c_hsotg_resume(struct platform_d
TS);
> + /*
> + * Report disconnect if there is any previous session
> established
> + */
> + s3c_hsotg_disconnect(hsotg);
> }
>
> if (gintsts & GINTSTS_ENUMDONE) {
> writel(GINTSTS_ENUMDONE, hsotg->
> From: Paul Zimmerman
> Sent: Friday, November 14, 2014 1:21 PM
>
> > From: linux-usb-ow...@vger.kernel.org
> > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> > Sent: Friday, November 14, 2014 11:05 AM
> >
> > On Fri, Nov 14, 2014 at
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> Sent: Friday, November 14, 2014 11:05 AM
>
> On Fri, Nov 14, 2014 at 07:01:37PM +, Paul Zimmerman wrote:
> > > -Original Message-
>
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com]
> Sent: Tuesday, November 11, 2014 9:14 AM
>
> From: Dinh Nguyen
>
> Since the dwc2 hcd driver is currently not looking for a clock node during
> init, we should not completely fail if there isn't a clock provided.
>
> @@ -157,9 +157,6 @@ static int dwc2_driver_probe(struct platform_device *dev)
> int retval;
> int irq;
>
> - if (usb_disabled())
> - return -ENODEV;
> -
> match = of_match_device(dwc2_of_match_table, &dev->dev);
>
67b..3552602 100644
> --- a/drivers/usb/dwc2/platform.c
> +++ b/drivers/usb/dwc2/platform.c
> @@ -196,6 +196,14 @@ static int dwc2_driver_probe(struct platform_device *dev)
> return irq;
> }
>
> + dev_dbg(hsotg->dev, "registering common handler for irq%d\n",
> + irq);
> + retval = devm_request_irq(hsotg->dev, irq,
> + dwc2_handle_common_intr, IRQF_SHARED,
> + dev_name(hsotg->dev), hsotg);
> + if (retval)
> + return retval;
> +
> res = platform_get_resource(dev, IORESOURCE_MEM, 0);
> hsotg->regs = devm_ioremap_resource(&dev->dev, res);
> if (IS_ERR(hsotg->regs))
Acked-by: Paul Zimmerman
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.driver = {
> .name = dwc2_driver_name,
> .of_match_table = dwc2_of_match_table,
> + .pm = &dwc2_dev_pm_ops,
> },
> .probe = dwc2_driver_probe,
> .remove = dwc2_driver_remove,
> - .suspend = dwc2_suspend,
> -
> From: jwer...@google.com [mailto:jwer...@google.com] On Behalf Of Julius
> Werner
> Sent: Thursday, November 13, 2014 8:50 PM
>
> > I will figure out how to make dwc2 detect the device connect after auto
> > suspend,
> > or disable the auto suspend feature for the dwc2 hcd.
>
> I think auto-su
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> Sent: Friday, November 14, 2014 1:19 AM
>
> On 2014-11-13 21:55, Paul Zimmerman wrote:
> >> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> >> Sent: Thursday, November 13, 2014 7:18 AM
>
> -Original Message-
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> Sent: Friday, November 14, 2014 4:20 AM
>
> This patch adds a call to s3c_hsotg_disconnect() from 'end session'
> interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem
> about unplugged usb cab
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> Sent: Thursday, November 13, 2014 7:18 AM
>
> On 2014-10-31 19:46, Paul Zimmerman wrote:
> >> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> >> Sent: Friday, October 31, 2014 3:13 AM
> >
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> Sent: Thursday, November 13, 2014 5:40 AM
>
> On 2014-10-31 19:15, Paul Zimmerman wrote:
> >> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> >> Sent: Friday, October 31, 2014 1:04 AM
> >&g
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Haibo Zhang
> Sent: Tuesday, November 11, 2014 6:37 AM
>
> We know that dwc2 is the USB2.0 driver for DesignWare IP. But it only
> has host’s code without device’s code. So I have two questions:
> 1.
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Thursday, November 06, 2014 9:40 AM
>
> On Thu, Nov 06, 2014 at 06:21:42PM +0100, Romain Perier wrote:
> >
> > 2014-11-06 2:30 GMT+01:00 Kever Yang :
> > >
> > > +static int _dwc2_hcd_suspend(struct usb_hcd *hcd)
> > > +{
> > > + struct dwc2
e interrupt conditions that was in gadget, as those are
> > handled
> > by dwc2 common interrupt handler.
> >
> > Signed-off-by: Dinh Nguyen
> > Acked-by: Paul Zimmerman
> > ---
> > v5: remove individual devm_request_irq from gadget and hcd, and plac
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> Sent: Friday, October 31, 2014 3:13 AM
>
> This patch adds mutex, which protects initialization and
> deinitialization procedures against suspend/resume methods.
>
> Signed-off-by: Marek Szyprowski
> ---
> drivers/usb/dwc2/core.h |
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> Sent: Friday, October 31, 2014 1:04 AM
> To: linux-usb@vger.kernel.org; linux-samsung-...@vger.kernel.org
> Cc: Marek Szyprowski; Kyungmin Park; Robert Baldyga; Paul Zimmerman;
> Krzysztof Kozlowski; Felipe Balbi
>
> From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang
> Sent: Friday, October 31, 2014 7:03 AM
>
> This patch adds suspend/resume for dwc2 hcd controller.
>
> Signed-off-by: Kever Yang
> ---
>
> drivers/usb/dwc2/hcd.c | 74
> ++---
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com]
> Sent: Tuesday, October 28, 2014 4:26 PM
>
> Since the dwc2 hcd driver is currently not looking for a clock node during
> init, we should not completely fail if there isn't a clock provided.
> For dual-role mode, we wi
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com]
> Sent: Tuesday, October 28, 2014 4:26 PM
>
> Now that platform.c will get built for both Host and Gadget, if we leave the
> usb_disabled() call in platform.c, it results in the following build error
> when (!USB && USB
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Tuesday, October 28, 2014 12:01 PM
>
> On Tue, Oct 28, 2014 at 06:55:50PM +, Paul Zimmerman wrote:
> > > From: Felipe Balbi [mailto:ba...@ti.com]
> > > Sent: Tuesday, October 28, 2014 11:51 AM
> > >
&
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Tuesday, October 28, 2014 11:51 AM
>
> On Tue, Oct 28, 2014 at 06:47:08PM +, Paul Zimmerman wrote:
> > > From: Huang Rui [mailto:ray.hu...@amd.com]
> > > Sent: Tuesday, October 28, 2014 4:54 AM
> > &
> From: Huang Rui [mailto:ray.hu...@amd.com]
> Sent: Tuesday, October 28, 2014 4:54 AM
>
> It enables hibernation if the function is set in coreConsultant.
>
> Suggested-by: Felipe Balbi
> Signed-off-by: Huang Rui
> ---
> drivers/usb/dwc3/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> dif
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> Sent: Monday, October 20, 2014 3:46 AM
>
> This patch adds a call to s3c_hsotg_disconnect() from 'end session'
> interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem
> about unplugged usb cable. 'disconnected' interrupt (
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com]
> Sent: Monday, October 20, 2014 3:46 AM
>
> Suspend/resume code assumed that the gadget was always enabled and
> connected to usb bus. This means that the actual state of the gadget
> (soft-enabled/disabled or connected/disconnected) was
s3c_hsotg_phy_enable(hsotg);
> +
> + spin_lock_irqsave(&hsotg->lock, flags);
> s3c_hsotg_core_init_disconnected(hsotg);
> s3c_hsotg_core_connect(hsotg);
> spin_unlock_irqrestore(&hsotg->lock, flags);
Acked-by: Paul Zimmerman
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
s3c_hsotg_pullup(struct usb_gadget *gadget,
> int is_on)
> spin_lock_irqsave(&hsotg->lock, flags);
> if (is_on) {
> clk_enable(hsotg->clk);
> - s3c_hsotg_core_init_disconnected(hsotg);
> s3c_hsotg_core_connect(hsotg);
> } els
> s3c_hsotg_core_connect(hsotg);
> } else {
> clk_disable(hsotg->clk);
> - s3c_hsotg_phy_disable(hsotg);
> }
>
> hsotg->gadget.speed = USB_SPEED_UNKNOWN;
Acked-by: Paul Zimmerman
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
sotg->clk);
> s3c_hsotg_phy_disable(hsotg);
> @@ -3668,7 +3679,8 @@ static int s3c_hsotg_resume(struct platform_device
> *pdev)
>
> spin_lock_irqsave(&hsotg->lock, flags);
> s3c_hsotg_phy_enable(hsotg);
> - s3c_hsotg_core_init(hsotg);
>
d driver %s\n", driver->driver.name);
> return 0;
>
> @@ -3667,7 +3667,6 @@ static int s3c_hsotg_resume(struct platform_device
> *pdev)
> }
>
> spin_lock_irqsave(&hsotg->lock, flags);
> - hsotg->last_rst = jiffies;
> s3c_hsotg_phy_enable(hsotg);
status = readl(hsotg->regs + GOTGCTL);
>
> - dev_info(hsotg->dev, "%s: USBRst\n", __func__);
> + dev_dbg(hsotg->dev, "%s: USBRst\n", __func__);
> dev_dbg(hsotg->dev, "GNPTXSTS=%08x\n",
>
> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com]
> Sent: Wednesday, October 22, 2014 5:26 AM
>
> On Monday, October 20, 2014 01:52:06 PM dingu...@opensource.altera.com wrote:
> > From: Dinh Nguyen
> >
> > config USB_DWC2_PLATFORM
> > bool "DWC2 Platform"
> > - depends on
ectly with both registering/unregistering gadgets
> > and enabling/disabling gadgets by writing to
> > /sys/class/udc/*hsotg/soft_connect interface.
> >
> > Signed-off-by: Marek Szyprowski
>
> Also here. In fact, this is much more important :-)
Acked-by: Paul Zimmerman
Are
e turned off as the last element in
> > the device shutdown procedure.
> >
> > Signed-off-by: Marek Szyprowski
>
> Paul, can I have your Acked-by here so I can send this to v3.18-rc1 ?
Sorry, I've been working on a really hot issue at $work and didn't have
time ye
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Greg KH
> Sent: Wednesday, October 22, 2014 7:19 AM
>
> On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote:
> > On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote:
> > > On Sa
> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com]
> Sent: Wednesday, October 22, 2014 4:16 AM
>
> On Monday, October 20, 2014 01:52:01 PM dingu...@opensource.altera.com wrote:
> > From: Dinh Nguyen
> >
> > This patch will aggregate the probing of gadget/hcd driver into platform.
> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com]
> Sent: Tuesday, October 21, 2014 1:48 PM
>
> diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig
> index f93807b..1ea702e 100644
> --- a/drivers/usb/dwc2/Kconfig
> +++ b/drivers/usb/dwc2/Kconfig
> @@ -1,5 +1,5 @@
> config US
+++ b/drivers/usb/dwc2/Kconfig
> @@ -1,6 +1,6 @@
> config USB_DWC2
> bool "DesignWare USB2 DRD Core Support"
> - depends on USB
> + depends on USB || USB_GADGET
> help
> Say Y here if your system has a Dual Role Hi-Speed USB
> control
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of David Laight
> Sent: Monday, October 20, 2014 2:48 AM
>
> From: Felipe Balbi
> > According to Section 8.5.3.2 of the USB 2.0 specification,
> > a USB device must terminate a Data Phase with either a
>
if (hsotg->driver) {
> - /* should have been done already by driver model core */
> - usb_gadget_unregister_driver(hsotg->driver);
> - }
> -
> clk_disable_unprepare(hsotg->clk);
>
> return 0;
Looks good to me.
Acked-by: Pa
> From: Huang Rui [mailto:ray.hu...@amd.com]
> Sent: Monday, October 20, 2014 2:01 AM
>
> On Mon, Oct 20, 2014 at 04:41:54PM +0800, Huang Rui wrote:
> > On Fri, Oct 17, 2014 at 01:48:19PM -0500, Felipe Balbi wrote:
> > > Hi,
> > >
> > > On Fri, Oct
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Friday, October 17, 2014 11:52 AM
>
> On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote:
> > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> > > Sent: Thursday, October 16, 2014 9:44 PM
>
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> Sent: Thursday, October 16, 2014 9:44 PM
>
> modified the function to have a single return statement at the end
> instead of multiple return statement in the middle of the function
> to improve the readability of the code.
>
> This pat
t; }
>
> /* for non control endpoints, set PID to D0 */
> @@ -2579,6 +2581,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> /* enable the endpoint interrupt */
> s3c_hsotg_ctrl_epint(hsotg, index, dir_in, 1);
>
> +error:
> spin_unlock_irqres
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Friday, October 17, 2014 8:00 AM
>
> On Fri, Oct 17, 2014 at 04:53:41PM +0800, Huang Rui wrote:
> > AMD NL needs to suspend usb3 ss phy, but this doesn't enable on simulation
> > board.
> >
> > Signed-off-by: Huang Rui
> > ---
> > drivers/usb/dw
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> Sent: Friday, October 17, 2014 3:03 AM
>
> On Fri, Oct 17, 2014 at 09:02:00AM +, David Laight wrote:
> > From: Of Sudip Mukherjee
> > > modified the function to have a single return statement at the end
> > > instead of multiple ret
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of John Crispin
> Sent: Thursday, October 16, 2014 1:34 PM
>
> We need this for dwc2 to work on older ralink SoC like the rt3052. Without, we
> see the following when loading the driver:
>
> [0.76000
; The sparse warning was fixed by releasing the spinlock before return.
> > >
> > > This patch depends on the previous patch of the series.
> > >
> > > Signed-off-by: Sudip Mukherjee
> >
> > this should be patch one so it can be backported to stable kern
> From: linux-usb-ow...@vger.kernel.org
> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Daniel Karling
> Sent: Wednesday, October 15, 2014 2:08 PM
>
> Hi,
>
> I noticed that the macro for extracting the number of scratchpad
> buffers to allocate from the HCSPARAMS2 register differs from
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
> Sent: Friday, October 10, 2014 6:10 AM
>
> sparse was giving the following warning:
> warning: context imbalance in 's3c_hsotg_ep_enable'
> - different lock contexts for basic block
>
> we were returning ENOMEM while still
1 - 100 of 618 matches
Mail list logo
