Re: [PATCH v2 2/2] clk: at91: Fix for PLL set_rate changes not being actually written to PLL peripheral bits

Hi Marcin, On Mon, 9 Apr 2018 20:16:49 -0400 Marcin Ziemianowicz wrote: > When a USB device is connected to the USB host port on the SAM9N12 then > you get "-62" error which seems to indicate USB replies from the device > are timing out. Looking around, I saw the USB

Re: [PATCH v2 1/2] clk: at91: Added more information logging.

Hi Marcin, On Mon, 9 Apr 2018 20:16:21 -0400 Marcin Ziemianowicz wrote: > I noticed that when debugging some USB clocking issue that there weren't > many ways to tell what the state of the USB clocking system was. This > adds a few logging statements to see what the

Re: [PATCH v2 0/2] clk: at91: Added more information logging

Hi Marcin On Mon, 9 Apr 2018 20:15:51 -0400 Marcin Ziemianowicz wrote: > This is a series of patches which resolves set_rate() for the PLL not > having any effect and therefore the USB Host port not working. Also, a > few messages were added which may be helpful in the

Re: [PATCH 00/47] arch-removal: device drivers

the mtd patches through the MTD tree. As you've probably noticed, nand code has been moved around and it's easier for me to carry those 2 simple changes in my tree than creating an immutable branch. Let me know if this is a problem. Regards, Boris -- Boris Brezillon, Bootlin (formerly Fr

Re: [PATCH v4 4/8] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

On Thu, 28 Sep 2017 11:46:23 +0200 Romain Izard wrote: > During backup mode, the contents of all registers will be cleared as the > SoC will be completely powered down. For a product that boots on NAND > Flash memory, the bootloader will obviously use the related

Re: [PATCH v3 4/8] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

On Wed, 27 Sep 2017 10:35:51 +0200 Romain Izard wrote: > During backup mode, the contents of all registers will be cleared as the > SoC will be completely powered down. For a product that boots on NAND > Flash memory, the bootloader will obviously use the related

Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors

Hi Romain, On Fri, 15 Sep 2017 16:04:07 +0200 Romain Izard wrote: > It is not normal for the PMECC to fail when trying to fix ECC errors. > Report these cases as errors. I'm not sure we want to have ECC error messages at this level. ECC errors are rather unusual but

Re: [PATCH v2 4/9] mtd: nand: atmel: Avoid ECC errors when leaving backup mode

Hi Romain, On Fri, 15 Sep 2017 16:04:06 +0200 Romain Izard wrote: > During backup mode, the contents of all registers will be cleared as the > SoC will be completely powered down. For a product that boots on NAND > Flash memory, the bootloader will obviously use the

Re: [PATCH 06/15] mtd: make device_type const

Le Sat, 19 Aug 2017 13:52:17 +0530, Bhumika Goyal a écrit : > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > Applied to l2-mtd/master. Thanks, Boris > Signed-off-by: Bhumika Goyal

Re: [PATCH] usb: gadget: udc: atmel: Fix check in usba_ep_enable()

On Tue, 6 Dec 2016 22:59:43 +0100 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK is not necessarily > equal to ep->index and that's perfectly fine. The usba endpoint index is > just an internal identifier u

Re: [PATCH] usb: gadget: udc: atmel: Fix check in usba_ep_enable()

Hi Felipe, I realize I sent this patch to your old @ti.com email address. Do you want me to resend it? Regards, Boris On Tue, 6 Dec 2016 22:59:43 +0100 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK is not nec

[PATCH] usb: gadget: udc: atmel: Fix check in usba_ep_enable()

s, but can also lead to errors since nothing guarantees that the endpoint number and index are matching when an endpoint is selected for a specific descriptor, thus leading to errors at ->enable() time when it's already too late to choose another endpoint. Signed-off-by: Boris Brezillon <bori

[PATCH] usb: gadget: atmel_usba_udc: Expose correct device speed

driver then the mass storage gadget worked (but probably at a lower speed than it should have). Signed-of-by: Douglas Gilbert <dgilb...@interlog.com> Reviewed-by: Boris Brezillon <boris.brezil...@free-electrons.com> Cc: <sta...@vger.kernel.org> #4.0+ Fixes: 9870d895ad87 ("usb

Re: at91sam9x5: USB mass storage gadget problems

Hi Felipe, On Mon, 16 Nov 2015 11:17:56 -0600 Felipe Balbi <ba...@ti.com> wrote: > > Hi, > > Boris Brezillon <boris.brezil...@free-electrons.com> writes: > > Hi Douglas, > > > > On Sat, 14 Nov 2015 14:15:30 -0500 > > Douglas Gilbert <dgilb...

Re: at91sam9x5: USB mass storage gadget problems

onvenience. > > If I don't hear anything on this issue then I can produce > a patch. Does it go through the ARM or USB (or both) trees? You can go ahead and send a patch to the ARM and USB MLs (+ appropriate maintainers), unless you want me to do it. > > If my patch is sufficient,

Re: [BUG] usb/at91: usb hub does not work

Hi Jiri, On Tue, 16 Jun 2015 10:51:55 +0200 Jiří Prchal jiri.prc...@aksignal.cz wrote: On 13.6.2015 13:13, Boris Brezillon wrote: On Sat, 13 Jun 2015 13:09:56 +0200 Boris Brezillon boris.brezil...@free-electrons.com wrote: Hi Jiri, On Fri, 12 Jun 2015 11:30:20 +0200 Jiří

Re: [BUG] usb/at91: usb hub does not work

. This prototype mismatch was supposed to be fixed by commit 76723e7ed589998384a080e29204df4659c67cf2, which fix the bug on 3.19 kernels, but the -determine_rate() has also changed between 3.18 and 3.19. Hopefully this patch will definitely fix the prototype mismatch for 3.18. Signed-off-by: Boris Brezillon

Re: [BUG] usb/at91: usb hub does not work

On Sat, 13 Jun 2015 13:09:56 +0200 Boris Brezillon boris.brezil...@free-electrons.com wrote: Hi Jiri, On Fri, 12 Jun 2015 11:30:20 +0200 Jiří Prchal jiri.prc...@aksignal.cz wrote: On 11.6.2015 15:53, Alan Stern wrote: On Thu, 11 Jun 2015, Jiří Prchal wrote: Hi all, I

Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

? depends on AVR32 || (ARCH_AT91 COMMON_CLK_AT91) And I wonder why you need that. I though this option was selected by all at91 platforms ? Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send

Re: [PATCHv6 4/5] USB: gadget: atmel_usba_udc: Prepare for IRQ single edge support

On Sat, 7 Feb 2015 20:37:23 +0100 Sylvain Rochet sylvain.roc...@finsecur.com wrote: Hello Nicolas, On Thu, Feb 05, 2015 at 06:19:55PM +0100, Nicolas Ferre wrote: Le 22/01/2015 18:14, Boris Brezillon a écrit : On Thu, 22 Jan 2015 17:56:44 +0100 Sylvain Rochet sylvain.roc

Re: [PATCHv6 4/5] USB: gadget: atmel_usba_udc: Prepare for IRQ single edge support

: irq_single_edge_support, boolean, set to true if the board supports IRQ_TYPE_EDGE_FALLING and IRQ_TYPE_EDGE_RISING, otherwise set to false. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com Acked-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget/udc/atmel_usba_udc.c | 25

Re: [PATCHv5 4/4] USB: gadget: atmel_usba_udc: Add suspend/resume with wakeup support

to this driver and make this specific edge change dependent on the SoC capability. Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCHv5 0/4] USB: gadget: atmel_usba_udc: Driver improvements

add my: Acked-by: Boris Brezillon boris.brezil...@free-electrons.com to the whole series. Thanks for your patience. Best Regards, Boris Changes since v4: * Now using IRQ_NOAUTOEN flag to remove the unused check for udc-driver is not NULL in the Vbus IRQ. * Reworked the start

Re: [PATCHv4 2/3] USB: gadget: atmel_usba_udc: Enable Vbus signal IRQ in UDC start instead of UDC probe

by the AIC looked like error-prone if defaults flags change at some point in the future. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com Suggested-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget/udc/atmel_usba_udc.c | 64 - 1

Re: [PATCHv6 0/6] USB: host: Atmel OHCI and EHCI drivers improvements

) and MEM(wake-up disabled) sleep targets. To the whole series: Acked-by: Boris Brezillon boris.brezil...@free-electrons.com Changes since v5: * Don't overwrite device wakeup flag with device_init_wakeup(), now using a private wakeup bool instead. Changes since v4: * Re-add

Re: [PATCHv3 2/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change

rid of this !udc-driver test, and thus drop the locking around it ;-). Best Regards, Boris [1]http://lxr.free-electrons.com/source/kernel/irq/manage.c#L432 [2]http://lxr.free-electrons.com/source/kernel/irq/manage.c#L92 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering

Re: [PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support

commit subject anyway ;-)). Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 01/12] mfd: syscon: Add atmel-matrix registers definition

Hi Lee, On Sun, 18 Jan 2015 12:52:59 + Lee Jones lee.jo...@linaro.org wrote: On Wed, 14 Jan 2015, Alexandre Belloni wrote: From: Boris Brezillon boris.brezil...@free-electrons.com AT91 SoCs have a memory range reserved for internal bus configuration. Expose those registers so

Re: [PATCH 2/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change

is taken in irq context (usba_udc_irq) and this handler is not called in irq context anymore you should use spin_lock_irqsave/unlock_irqrestore here. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line

Re: [PATCH 2/2] USB: gadget: atmel_usba_udc: Enable/disable USB PLL on Vbus change

, + gpio_to_irq(udc-vbus_pin), NULL, + usba_vbus_irq_thread, IRQF_NO_SUSPEND | IRQF_ONESHOT, You should drop the IRQF_NO_SUSPEND flag. If you want to wakeup on VBUS change you should use enable_irq_wake instead. -- Boris Brezillon, Free

Re: [PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct

to clearly state that this series depends on another one: [1]. Anyway, thanks for removing these global variables. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com To the whole series: Acked-by: Boris Brezillon boris.brezil...@free-electrons.com [1]https://www.mail-archive.com/linux

Re: [PATCHv2 1/2] USB: host: ehci_atmel: Add suspend/resume support

...@finsecur.com Acked-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/host/ehci-atmel.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c index 56a8850..2e0043b 100644 --- a/drivers

Re: [PATCHv2 2/2] USB: host: ohci_at91: Stop/start USB PLL for all sleep modes

the power save induced by this PLL deactivation. The resume penalty is about 500 us, which is not negligible but acceptable considering the amount of power we are saving. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com Reported-by: Boris Brezillon boris.brezil...@free-electrons.com

[PATCH v4 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling

implementation to attach it to the at91sam9rl-udc compatible string. Add new compatible strings to avoid executing at91sam9rl erratum handling on other SoCs. Reported-by: Paul Bolle pebo...@tiscali.nl Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Alexandre Belloni

[PATCH v3 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling

removed. Rework the toggle_bias implementation to attach it to the at91sam9rl-udc compatible string. Add new compatible strings to avoid executing at91sam9rl erratum handling on other SoCs. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Alexandre Belloni alexandre.bell

[PATCH v3 4/5] usb: atmel_usba_udc: Mask status with enabled irqs

Avoid interpreting useless status flags when we're not waiting for such events by masking the status variable with the interrupt enabled register value. Reported-by: Patrice VILCHEZ patrice.vilc...@atmel.com Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Alexandre

[PATCH v3 0/5] usb: atmel_usba_udc: Rework errata handling

not apply cleanly on those stable branches. I'll send a backport of this series once it is merged in mainline. Regards, Boris Changes since v2: - remove UTF8 character in commit message of patch 2 Changes since v1: - cache INT_ENB value to speedup INT_ENB read operations Boris Brezillon (5): usb

[PATCH v3 2/5] usb: atmel_usba_udc: Add at91sam9g45 and at91sam9x5 errata handling

at91sam9g45 and at91sam9x5 SoCs have an hardware bug forcing us to generate a pulse on the BIAS signal on USB end of reset and USB end of resume events. Reported-by: Patrice VILCHEZ patrice.vilc...@atmel.com Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Alexandre

[PATCH v3 3/5] ARM: at91/dt: update udc compatible strings

at91sam9g45, at91sam9x5 and sama5 SoCs should not use atmel,at91sam9rl-udc for their USB device compatible property since this compatible is attached to a specific hardware bug fix. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Alexandre Belloni alexandre.bell

Re: [PATCH v3 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling

Hi Paul, On Mon, 12 Jan 2015 13:15:58 +0100 Paul Bolle pebo...@tiscali.nl wrote: On Mon, 2015-01-12 at 11:57 +0100, Boris Brezillon wrote: at91sam9rl SoC has an erratum forcing us to toggle the BIAS on USB suspend/resume events. This specific handling is only activated when

Re: [PATCH v3 3/5] ARM: at91/dt: update udc compatible strings

Hi Felipe, On Mon, 12 Jan 2015 12:23:49 -0600 Felipe Balbi ba...@ti.com wrote: On Mon, Jan 12, 2015 at 11:57:56AM +0100, Boris Brezillon wrote: at91sam9g45, at91sam9x5 and sama5 SoCs should not use atmel,at91sam9rl-udc for their USB device compatible property since this compatible

Re: [PATCH v3 3/5] ARM: at91/dt: update udc compatible strings

On Mon, 12 Jan 2015 13:31:26 -0600 Felipe Balbi ba...@ti.com wrote: On Mon, Jan 12, 2015 at 08:18:16PM +0100, Boris Brezillon wrote: Hi Felipe, On Mon, 12 Jan 2015 12:23:49 -0600 Felipe Balbi ba...@ti.com wrote: On Mon, Jan 12, 2015 at 11:57:56AM +0100, Boris Brezillon wrote

[PATCH v2 5/5] usb: gadget: atmel_usba: Cache INT_ENB register value

Cache INT_ENB register value in order to avoid uncached iomem access, and thus improve access time to INT_ENB value. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget/udc/atmel_usba_udc.c | 52 ++--- drivers/usb/gadget/udc

[PATCH v2 0/5] usb: atmel_usba_udc: Rework errata handling

not apply cleanly on those stable branches. I'll send a backport of this series once it is merged in mainline. Regards, Boris Changes since v1: - cache INT_ENB value to speedup INT_ENB read operations Boris Brezillon (5): usb: atmel_usba_udc: Rework at91sam9rl errata handling usb: atmel_usba_udc

[PATCH v2 3/5] ARM: at91/dt: update udc compatible strings

at91sam9g45, at91sam9x5 and sama5 SoCs should not use atmel,at91sam9rl-udc for their USB device compatible property since this compatible is attached to a specific hardware bug fix. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- arch/arm/boot/dts/at91sam9g45.dtsi | 2

[PATCH v2 1/5] usb: atmel_usba_udc: Rework at91sam9rl errata handling

removed. Rework the toggle_bias implementation to attach it to the at91sam9rl-udc compatible string. Add new compatible strings to avoid executing at91sam9rl erratum handling on other SoCs. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- .../devicetree/bindings/usb/atmel

[PATCH v2 2/5] usb: atmel_usba_udc: Add at91sam9g45 and at91sam9x5 errata handling

at91sam9g45 and at91sam9x5 SoCs have an hardware bug forcing us to generate a pulse on the BIAS signal on USB end of reset” and “USB end of resume events. Reported-by: Patrice VILCHEZ patrice.vilc...@atmel.com Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb

[PATCH v2 4/5] usb: atmel_usba_udc: Mask status with enabled irqs

Avoid interpreting useless status flags when we're not waiting for such events by masking the status variable with the interrupt enabled register value. Reported-by: Patrice VILCHEZ patrice.vilc...@atmel.com Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget

[PATCH 0/4] usb: atmel_usba_udc: Rework errata handling

not apply cleanly on those stable branches. I'll send a backport of this series once it is merged in mainline. Regards, Boris Boris Brezillon (4): usb: atmel_usba_udc: Rework at91sam9rl errata handling usb: atmel_usba_udc: Add at91sam9g45 and at91sam9x5 errata handling ARM: at91/dt: update udc

[PATCH 1/4] usb: atmel_usba_udc: Rework at91sam9rl errata handling

removed. Rework the toggle_bias implementation to attach it to the at91sam9rl-udc compatible string. Add new compatible strings to avoid executing at91sam9rl erratum handling on other SoCs. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- .../devicetree/bindings/usb/atmel

[PATCH 2/4] usb: atmel_usba_udc: Add at91sam9g45 and at91sam9x5 errata handling

at91sam9g45 and at91sam9x5 SoCs have an hardware bug forcing us to generate a pulse on the BIAS signal on USB end of reset” and “USB end of resume events. Reported-by: Patrice VILCHEZ patrice.vilc...@atmel.com Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb

[PATCH 4/4] usb: atmel_usba_udc: mask status with enabled irqs

Avoid interpreting useless status flags when we're not waiting for such events by masking the status variable with the interrupt enabled register value. Reported-by: Patrice VILCHEZ patrice.vilc...@atmel.com Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget

[PATCH 3/4] ARM: at91/dt: update udc compatible strings

at91sam9g45, at91sam9x5 and sama5 SoCs should not use atmel,at91sam9rl-udc for their USB device compatible property since this compatible is attached to a specific hardware bug fix. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- arch/arm/boot/dts/at91sam9g45.dtsi | 2

Re: [PATCH 4/4] usb: atmel_usba_udc: mask status with enabled irqs

On Mon, 15 Dec 2014 13:34:56 + David Laight david.lai...@aculab.com wrote: From: Sergei Shtylyov Hello. On 12/15/2014 4:03 PM, Boris Brezillon wrote: Avoid interpreting useless status flags when we're not waiting for such events by masking the status variable

Re: [PATCH 4/4] usb: atmel_usba_udc: mask status with enabled irqs

Hi David, On Mon, 15 Dec 2014 13:34:56 + David Laight david.lai...@aculab.com wrote: From: Sergei Shtylyov Hello. On 12/15/2014 4:03 PM, Boris Brezillon wrote: Avoid interpreting useless status flags when we're not waiting for such events by masking the status variable

Re: [PATCH 4/4] usb: atmel_usba_udc: mask status with enabled irqs

On Mon, 15 Dec 2014 17:22:04 + David Laight david.lai...@aculab.com wrote: From: Boris Brezillon Hi David, On Mon, 15 Dec 2014 13:34:56 + David Laight david.lai...@aculab.com wrote: From: Sergei Shtylyov Hello. On 12/15/2014 4:03 PM, Boris Brezillon wrote

[PATCH 11/11] ARM: at91/dt: fix at91 udc compatible strings

The at91rm9200, at91sam9260, at91sam9261 and at91sam9263 SoCs have slightly different UDC IPs. Those differences were previously handled with cpu_is_at91xx macro which are about to be dropped for multi-platform support, thus we need to change compatible strings. Signed-off-by: Boris Brezillon

[PATCH 10/11] ARM: at91/dt: declare matrix node as a syscon device

Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- arch/arm/boot/dts/at91sam9261.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi index 7119f1f..e52ae97 100644 --- a/arch/arm/boot

[PATCH 09/11] usb: gadget: at91_udc: Allocate udc instance

Allocate udc structure instead of relying on the statically declared object. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget/udc/at91_udc.c | 101 ++ 1 file changed, 27 insertions(+), 74 deletions(-) diff --git

[PATCH 08/11] usb: gadget: at91_udc: Update DT binding documentation

Three compatible strings have been added to the at91_udc driver. Update the documentation accordingly. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- Documentation/devicetree/bindings/usb/atmel-usb.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH 07/11] usb: gadget: at91_udc: Rework for multi-platform kernel support

cpu_is_at91xxx are a set of macros defined in mach/cpu.h and are here used to detect the SoC we are booting on. Use compatible string + a caps structure to replace those cpu_is_xxx tests. Remove all mach and asm headers (which are now unused). Signed-off-by: Boris Brezillon boris.brezil...@free

[PATCH 00/11] usb: gadget: at91_udc: Rework for multi-platform support

/lkml/2014/12/3/230 Boris Brezillon (11): usb: gadget: at91_udc: Fix clock names usb: gadget: at91_udc: Drop uclk clock usb: gadget: at91_udc: Document DT clocks and clock-names property ARM: at91/dt: at91sam9261: fix clocks and clock-names in udc definition usb: gadget: at91_udc

[PATCH 06/11] usb: gadget: at91_udc: Simplify probe and remove functions

Make use of devm_ functions to simplify probe and remove code. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget/udc/at91_udc.c | 116 +- 1 file changed, 39 insertions(+), 77 deletions(-) diff --git a/drivers/usb/gadget

[PATCH 04/11] ARM: at91/dt: at91sam9261: fix clocks and clock-names in udc definition

Peripheral clock is named pclk and system clock is named hclk (those are the names expected by the at91_udc driver). Drop the deprecated usb_clk (formerly used to configure the usb clock rate which is now directly configurable through hclk). Signed-off-by: Boris Brezillon boris.brezil...@free

[PATCH 05/11] usb: gadget: at91_udc: Remove non-DT handling code

Since non-DT board support has been removed from the at91 architecture we can safely remove non-DT handling code. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget/udc/Kconfig| 1 + drivers/usb/gadget/udc/at91_udc.c | 16 ++-- 2 files

[PATCH 03/11] usb: gadget: at91_udc: Document DT clocks and clock-names property

The at91_udc driver request 2 clocks, and thus need them to be defined in the device tree. Document the clocks and clock-names properties so that everybody use the correct names. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- Documentation/devicetree/bindings/usb/atmel

[PATCH 02/11] usb: gadget: at91_udc: Drop uclk clock

Now that at91 system clocks forward set_rate request to their parent we can remove the uclk clock and directly call clk_set_rate on fclk. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/usb/gadget/udc/at91_udc.c | 27 +++ drivers/usb/gadget

[PATCH 01/11] usb: gadget: at91_udc: Fix clock names

The driver is requesting clock by their global name (those declared in the clk_lookup list), but this only works with !CCF kernels. Now that all SoCs have moved to CCF, fix the driver to use local names (hclk and pclk). Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com

Re: [PATCH v4] usb: gadget: at91_udc: move prepare clk into process context

rate is unsafe to call from there for the same reason. Move clock preparation and setting clock rate into process context (at91udc_probe). Signed-off-by: Ronald Wahl ronald.w...@raritan.com Acked-by: Boris Brezillon boris.brezil...@free-electrons.com --- v3 - v4: - no code changes

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

Adding USB and Atmel Maintainers in Cc. On Thu, 7 Aug 2014 09:52:31 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: Hi Ronald, On Wed, 6 Aug 2014 15:11:42 +0200 Ronald Wahl ronald.w...@raritan.com wrote: Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock

Re: [PATCH v2] usb: gadget: at91_udc: move prepare clk into process context

On Thu, 07 Aug 2014 14:43:32 +0200 Ronald Wahl ronald.w...@raritan.com wrote: On 07.08.2014 09:59, Boris BREZILLON wrote: On Thu, 7 Aug 2014 09:52:31 +0200 Boris BREZILLON boris.brezil...@free-electrons.com wrote: On Wed, 6 Aug 2014 15:11:42 +0200 Ronald Wahl ronald.w...@raritan.com

Re: ohci-at91 mismerge build error

changes that resulted in missing opening braces. Thanks for fixing this: I was about to propose the same patch to resolve the issue introduced by this merge (reported by Olof yesterday). Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Boris BREZILLON b.brezil...@overkiz.com --- Please

Re: [PATCH v5 1/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_ioremap_resource

Hello Olof, On 06/01/2014 19:08, Olof Johansson wrote: Boris, On Mon, Dec 9, 2013 at 12:51 AM, Boris BREZILLON b.brezil...@overkiz.com wrote: Replace the request_mem_region + ioremap calls by the devm_ioremap_resource call which does the same things but with device managed resources. Signed

Re: [PATCH v4] usb: ohci-at91: fix irq and iomem resource retrieval

platforms. Best Regards, Boris On 08/12/2013 15:59, Boris BREZILLON wrote: When using dt resources retrieval (interrupts and reg properties) there is no predefined order for these resources in the platform dev resources table. Retrieve resources using platform_get_resource and platform_get_irq

[PATCH v5 2/3] usb: ohci-at91: use dev variable instead of pdev-dev

Make use of the dev variable instead of referencing the dev field of the pdev struct. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-at91.c | 18

[PATCH v5 1/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_ioremap_resource

Replace the request_mem_region + ioremap calls by the devm_ioremap_resource call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu

[PATCH v5 3/3] usb: ohci-at91: use device managed clk retrieval

Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-at91.c | 30 +++--- 1 file changed, 7

[PATCH v5 0/3] usb: ohci-at91: various improvements

this function) Changes since v3: - replace devm_request_and_ioremap call by devm_ioremap_resource Changes since v2: - split urgent fix and resource retrieval improvements Boris BREZILLON (3): usb: ohci-at91: replace request_mem_region + ioremap by devm_ioremap_resource usb: ohci-at91: use

[PATCH v4 0/3] usb: ohci-at91: various improvements

retrieval improvements Boris BREZILLON (3): usb: ohci-at91: replace request_mem_region + ioremap by devm_ioremap_resource usb: ohci-at91: use dev variable instead of pdev-dev usb: ohci-at91: use device managed clk retrieval drivers/usb/host/ohci-at91.c | 68

[PATCH v4 1/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_ioremap_resource

Replace the request_mem_region + ioremap calls by the devm_ioremap_resource call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu

[PATCH v4 2/3] usb: ohci-at91: use dev variable instead of pdev-dev

Make use of the dev variable instead of referencing the dev field of the pdev struct. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-at91.c | 18

[PATCH v4 3/3] usb: ohci-at91: use device managed clk retrieval

Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-at91.c | 30 +++--- 1 file changed, 7

[PATCH v4] usb: ohci-at91: fix irq and iomem resource retrieval

mismatch. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu Reviewed-by: Tomasz Figa tomasz.f...@gmail.com --- Changes since v3: - replace platform_get_resource call with IORESOURCE_IRQ argument

Re: [PATCH v4 1/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_ioremap_resource

Hello, Le 08/12/2013 19:31, Sergei Shtylyov a écrit : Hello. On 12/08/2013 06:02 PM, Boris BREZILLON wrote: Replace the request_mem_region + ioremap calls by the devm_ioremap_resource call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON

[PATCH v3] usb: ohci-at91: fix irq and iomem resource retrieval

-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu --- Changes since v2: - split the patch series to isolate the urgent fix provided by this patch Changes since v1: - none drivers/usb/host/ohci-at91.c

[PATCH v3 1/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap

Replace the request_mem_region + ioremap calls by the devm_request_and_ioremap call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st

[PATCH v3 2/3] usb: ohci-at91: use dev variable instead of pdev-dev

Make use of the dev variable instead of referencing the dev field of the pdev struct. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-at91.c | 18

[PATCH v3 3/3] usb: ohci-at91: use device managed clk retrieval

Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ohci-at91.c | 30 +++--- 1 file changed, 7

Re: [PATCH 3/3] usb: ohci-at91: use device managed clk retrieval

Hello Alan, On 03/12/2013 16:32, Alan Stern wrote: On Tue, 3 Dec 2013, Nicolas Ferre wrote: On 03/12/2013 15:07, Boris BREZILLON : Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com Acked

[PATCH 3/3] usb: ohci-at91: use device managed clk retrieval

Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com --- drivers/usb/host/ohci-at91.c | 32 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/drivers

[PATCH 2/3] usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap

Replace the request_mem_region + ioremap calls by the devm_request_and_ioremap call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com --- drivers/usb/host/ohci-at91.c | 24

[PATCH 1/3] usb: ohci-at91: fix irq and iomem resource retrieval

-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com --- drivers/usb/host/ohci-at91.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 418444e..7aec6ca

[PATCH 0/3] usb: ohci-at91: various fixes and improvements

, Boris Boris BREZILLON (3): usb: ohci-at91: fix irq and iomem resource retrieval usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap usb: ohci-at91: use device managed clk retrieval drivers/usb/host/ohci-at91.c | 75

Re: [PATCH 3/3] usb: ohci-at91: use device managed clk retrieval

Hello Sergei, On 03/12/2013 19:01, Sergei Shtylyov wrote: Hello. On 12/03/2013 05:07 PM, Boris BREZILLON wrote: Replace clk_get calls by devm_clk_get calls. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Tested-by: Robert Nelson robertcnel...@gmail.com --- drivers/usb/host/ohci

[PATCH v2 1/4] usb: ohci-at91: fix irq and iomem resource retrieval

-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/host/ohci-at91.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index 418444e

[PATCH v2 3/4] usb: ohci-at91: use dev variable instead of pdev-dev

Make use of the dev variable instead of referencing the dev field of the pdev struct. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/host/ohci-at91.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions

[PATCH v2 2/4] usb: ohci-at91: replace request_mem_region + ioremap by devm_request_and_ioremap

Replace the request_mem_region + ioremap calls by the devm_request_and_ioremap call which does the same things but with device managed resources. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/host/ohci-at91.c | 24

[PATCH v2 0/4] usb: ohci-at91: various fixes and improvements

, Boris Changes since v1: - split PATCH 3 in 2 different patches: one to remove references to pdev-dev, the other to make use of devm_clk_get - replace forgotten pdev-dev references in usb_hcd_at91_probe Boris BREZILLON (4): usb: ohci-at91: fix irq and iomem resource retrieval usb: ohci

Re: [PATCH v6 00/16] ARM: at91: move to common clk framework

Hi Mike, Le 01/12/2013 00:05, Mike Turquette a écrit : Quoting Boris BREZILLON (2013-11-28 04:36:24) Hello, This patch series is the 5th version of the at91 clk implementations using the Common Clk Framework. Oops, I just replied to v5 of this series. Thanks for the fixes. Which tree do you

Re: [PATCH v6 00/16] ARM: at91: move to common clk framework

On 02/12/2013 12:43, boris brezillon wrote: Hi Mike, Le 01/12/2013 00:05, Mike Turquette a écrit : Quoting Boris BREZILLON (2013-11-28 04:36:24) Hello, This patch series is the 5th version of the at91 clk implementations using the Common Clk Framework. Oops, I just replied to v5

  1   2   >