[PATCH] Fix wrong pointer when remap UTMI pad

2013-11-18 Thread Chris Ruehl
Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk Acked-by: Venu Byravarasu vbyravar...@nvidia.com --- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index 82232ac..bbe4f8e

[PATCH] fsl/usb: Add FSL USB Gadget entry in platform device id

2013-11-18 Thread Suresh Gupta
Add FSL USB Gadget entry in platform device id table Signed-off-by: Suresh Gupta suresh.gu...@freescale.com --- drivers/usb/gadget/fsl_udc_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c index

[PATCH] fsl/usb: Set dma_ops for FSL USB Gadget Device

2013-11-18 Thread Suresh Gupta
Signed-off-by: Suresh Gupta suresh.gu...@freescale.com --- drivers/usb/gadget/fsl_udc_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c index 0b0a871..0217c46 100644 --- a/drivers/usb/gadget/fsl_udc_core.c +++

Re: [PATCH 32/68] uas: Use proper packet size when submitting reponse urbs

2013-11-18 Thread Hans de Goede
Hi, On 11/18/2013 08:05 AM, Gerd Hoffmann wrote: On Fr, 2013-11-15 at 16:06 +0100, Hans de Goede wrote: task management commands expect a response_iu rather then a sense_iu, and these have different sizes. Make the urb we submit to get the reply the right size. I think that doesn't work for

RE: [PATCH 01/68] xhci: fix usb3 streams

2013-11-18 Thread David Laight
On 11/15/2013 04:46 PM, David Laight wrote: From: Hans de Goede Sent: 15 November 2013 15:06 To: Sarah Sharp Cc: linux-usb@vger.kernel.org; Gerd Hoffmann; Alan Stern; Hans de Goede Subject: [PATCH 01/68] xhci: fix usb3 streams From: Gerd Hoffmann kra...@redhat.com xhci maintains

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-18 Thread David Laight
But the minimum fragment size is (probably) 4k. For the network stack an OUT transfer might have a lot (and I mean lots) of fragments (there may be constraints, and linearising the skb is a option). [...] The maximum number of fragments in the skb is going to be 17 (including the

[PATCH] usb: gadget: fix pxa25x compilation problems

2013-11-18 Thread Linus Walleij
In commit 88f718e3fa4d67f3a8dbe79a2f97d722323e4051 ARM: pxa: delete the custom GPIO header we removed the implicit inclusion of mach/gpio.h from linux/gpio.h. The pxa25x_udc was not using that, but it was relying on linux/gpio.h to implictly include mach/gpio.h which in turn implicitly included

Re: [PATCH] USB: chipidea: i.MX: Probe usbmisc early

2013-11-18 Thread Michael Grzeschik
Hi Marek, On Sun, Nov 17, 2013 at 11:59:10PM +0100, Marek Vasut wrote: Dear Peter Chen, Probe the usbmisc driver earlier, otherwise the ci_hdrc_imx.c will get -EPROBE_DEFER from usbmisc when both are compiled into the kernel and thus USB gadget mode won't work. Hi Marek, you know

DT: ISP1504 init ulpi hook to phy-generic

2013-11-18 Thread Chris Ruehl
This is my idea to hook the ulpi for my board. This patch includes to support gpio-chipselect for the ISP1504 (pin29) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index fce3a9e..2b7bdf3 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c

Re: Testing glue layer for DWC3 device controller

2013-11-18 Thread Amit Virdi
Dear Felipe, On 11/15/2013 11:04 PM, Felipe Balbi wrote: please send your glue layer sources and any logs you might have. PHY drivers are loading at subsys_initcall and gadget drivers are loading at module_init(). I don't see how that could happen :-s Thanks for your inputs. I was using

Re: [RFCv5-corrected subject] USB: kill #undef VERBOSE_DEBUG

2013-11-18 Thread Oliver Neukum
On Sat, 2013-11-16 at 06:26 +0900, Greg KH wrote: On Fri, Nov 15, 2013 at 03:36:53PM +0100, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de It is useless now. Straight removal. Signed-off-by: Oliver Neukum oneu...@suse.de Ok, I think these have all moved beyond RFC

Re: [RFCv5 13/21] uhci: change dependency for debug parameter

2013-11-18 Thread Oliver Neukum
On Fri, 2013-11-15 at 13:36 -0500, Alan Stern wrote: On Fri, 15 Nov 2013 oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de To allow a full switch to dynamic debugging make the debug parameter conditional on defined(DEBUF) || defined(CONFIG_DYNAMIC_DEBUG)

[finished PATCH 05/21] ehci: no conditional compilation for interestingness

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de Simple elemination of the conditional compilation Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/ehci-hub.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c

[finished PATCH 17/21] fusbh200: always compile debugfs support

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de This is a step in the conversion to only use dynamic debugging. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/fusbh200-hcd.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/fusbh200-hcd.c

[finished PATCH 09/21] fotg210: change dbg_port() to evaluate parameters only if needed

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de For dynamic debug the overhead for evaluating parameters must be sacrificed only if the message is actually printed Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/fotg210-hcd.c | 10 +- 1 file changed, 5 insertions(+), 5

[finished PATCH 01/21] ohci: remove conditional compilation

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de Conditional compilation for debugging is removed in favor of dynamic debugging. To do so 1. the support for debugfs is always compiled 2. the support for the ancient print_urb debugging aid is removed Signed-off-by: Oliver Neukum oneu...@suse.de ---

[finished PATCH 15/21] fusbh200: unconditionally compile debugging helpers

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de These helpers are used only during setup of a HCD. A small overhead is no problem. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/fusbh200-hcd.c | 14 -- 1 file changed, 14 deletions(-) diff --git

[finished PATCH 10/21] fotg210: remove conditional compilation

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de The decision what is interesting is made in user space. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/fotg210-hcd.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c

[finished PATCH 13/21] uhci: change dependency for debug parameter

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de To allow a full switch to dynamic debugging make the debug parameter conditional on defined(DEBUF) || defined(CONFIG_DYNAMIC_DEBUG) Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/uhci-hcd.c | 44 +---

[finished PATCH 08/21] fotg210: always compile the support for debugfs

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de Simply remove the conditional compilation and remove the empty stubs. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/fotg210-hcd.c | 47 -- 1 file changed, 47 deletions(-) diff --git

[finished PATCH 16/21] fusb200h: don't log on every interrupt

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de That logging is overkill. Simply remove it. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/fusbh200-hcd.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c index

[finished PATCH 11/21] fotg210: kill fotg210_vdbg()

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de The decision what is interesting is shifted to user space by dynamic debugging. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/fotg210-hcd.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git

[finished PATCH 18/21] fusb200h: always compile in debugfs support

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de This allows removal of much conditional compilation. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/fusbh200-hcd.c | 20 drivers/usb/host/fusbh200.h | 4 2 files changed, 4 insertions(+), 20 deletions(-) diff

[finished PATCH 04/21] ohci: no conditional debugging in root hub hadling

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de With dynamic debugging the selection is done in user space Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/ohci-hub.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ohci-hub.c

[finished PATCH 02/21] ohci: kill ohci_vdbg

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de With the introduction of dynamic debugging it has become redundant. Collapse it with ohci_dbg() Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/ohci-hcd.c | 4 ++-- drivers/usb/host/ohci-q.c | 8 drivers/usb/host/ohci.h | 6

[finished PATCH 03/21] ohci:always register debug files

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de Just remove the conditional compilation. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/ohci-hcd.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index 501ecea..de0e3e4

[finished PATCH 19/21] fusbh200: kill fusbh200_vdbg

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de With dynamic debugging this log level is no longer supported. The decision which messages are interesting is done in user space. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/fusbh200-hcd.c | 16 +--- 1 file changed, 5

[finished PATCH 14/21] uhci: compile debugfs conditional on CONFIG_DYNAMIC_DEBUG || DEBUG

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de This makes sure the header files are all there Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/uhci-debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c

[finished PATCH 12/21] fusbh200: always build debugfs support

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de This gets rid of conditional compilation. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/fusbh200-hcd.c | 31 --- drivers/usb/host/fusbh200.h | 8 2 files changed, 39 deletions(-) diff --git

[finished PATCH 07/21] fotg210: remove conditional compilation

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de Always compile in the debugfs support --- drivers/usb/host/fotg210-hcd.c | 8 drivers/usb/host/fotg210.h | 8 2 files changed, 16 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index

[finished PATCH 06/21] ehci: Remove debugging at every interrupt

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de This is overkill. Just removeit. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/ehci-hcd.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index e8ba4c4..b57e997 100644 ---

[finished PATCH 21/21] USB: kill #undef VERBOSE_DEBUG

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de It is useless now. Straight removal. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/usb/host/ehci-hcd.c | 1 - drivers/usb/host/fotg210-hcd.c | 1 - drivers/usb/host/fusbh200-hcd.c | 1 - drivers/usb/host/ohci-hcd.c | 2 -- 4 files changed,

[finished PATCH 20/21] usb: kill DEBUG compile option

2013-11-18 Thread oliver
From: Oliver Neukum oneu...@suse.de In the drivers that no longer need it, it is removed. It is removed from the Makefile. Drivers not fully converted to dynamic debug have it shifted down into the individual drivers. Signed-off-by: Oliver Neukum oneu...@suse.deusb: kill DEBUG compile option

Re: [PATCH v4 10/15] usb: phy: msm: Add device tree support and binding information

2013-11-18 Thread Ivan T. Ivanov
Hi Mark, On Fri, 2013-11-15 at 16:38 +, Mark Rutland wrote: On Tue, Nov 12, 2013 at 02:51:45PM +, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Allows MSM OTG controller to be specified via device tree. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com Cc:

Re: [PATCH v4 12/15] usb: phy: msm: Add support for secondary PHY control

2013-11-18 Thread Ivan T. Ivanov
Hi Mark, On Fri, 2013-11-15 at 16:42 +, Mark Rutland wrote: On Tue, Nov 12, 2013 at 02:51:47PM +, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Allow support to use 2nd HSPHY with USB2 Core. Some platforms may have configuration to allow USB controller work

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

2013-11-18 Thread Ulf Hansson
In any case, although Bjørn made a good point about latency, the main reason for having the sysfs interface was to cope with buggy devices. Linux started using runtime PM before Windows did. At that time, many devices did not support runtime suspend very well -- they didn't have to since

Re: Check device use before detaching?

2013-11-18 Thread Greg KH
On Mon, Nov 18, 2013 at 07:10:45AM +, Luke-Jr wrote: On Monday, November 18, 2013 6:07:37 AM Greg KH wrote: I want my software to ignore devices that are already in use by other software. The other software might be accessing it via the kernel drivers, or perhaps libusb. My software

RE: chipidea on mx28-evk: irq 237: nobody cared

2013-11-18 Thread Peter Chen
What your otg port looks like? It is a Micro-B-Female port? If ID pin is low, it will be considered as host role, when you connect to another machine's host port, both sides are host, it can't be enumerated. Yes, I know, both sides are in the host role. Granted my fault, but

[GIT pull for 3.14 v3] xhci streams and uas fixes + usbfs streams support

2013-11-18 Thread Hans de Goede
Hi Sarah et al, Here is v3 of my patch-series / pull-req for you to pull into your xhci tree for 3.14. New this version is that the uas: Use proper packet size when submitting reponse urbs patch has been dropped. As Gerd rightfully pointed out we won't know if we get a sense or response iu on

Re: Check device use before detaching?

2013-11-18 Thread Alan Stern
On Mon, 18 Nov 2013, Luke-Jr wrote: Is there a way to tell if a USB device is in use or not before requesting the kernel detach drivers? I'd define in use as either an interface claimed on usbfs or tty/etc provided by a kernel driver being opened. And not in use including kernel driver

Re: [PATCH] USB: chipidea: i.MX: Probe usbmisc early

2013-11-18 Thread Marek Vasut
Hi Michael, Hi Marek, On Sun, Nov 17, 2013 at 11:59:10PM +0100, Marek Vasut wrote: Dear Peter Chen, Probe the usbmisc driver earlier, otherwise the ci_hdrc_imx.c will get -EPROBE_DEFER from usbmisc when both are compiled into the kernel and thus USB gadget mode won't work.

Re: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-18 Thread Ben Hutchings
On Mon, 2013-11-18 at 09:48 +, David Laight wrote: But the minimum fragment size is (probably) 4k. For the network stack an OUT transfer might have a lot (and I mean lots) of fragments (there may be constraints, and linearising the skb is a option). [...] The maximum number

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-18 Thread Alan Stern
On Sat, 16 Nov 2013, Vishal Annapurve wrote: Hi, Here are the updated patches: [PATCH 1/3] usb: storage: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command result whenever US_FLIDX_TIMED_OUT bit is set. This change is made to bring USB storage

Re: [RFC PATCH] PM / Runtime: Allow to inactivate devices during system suspend

2013-11-18 Thread Alan Stern
On Mon, 18 Nov 2013, Ulf Hansson wrote: I favour the pm_runtime_no_prevent_suspend API approach, since it would mean a change in behaviour of the PM core. That's exactly why I don't favor it! :-) I also think that in some cases it could make runtime PM better understandable, for those

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-18 Thread David Laight
-Original Message- From: Ben Hutchings [mailto:bhutchi...@solarflare.com] Sent: 18 November 2013 15:03 To: David Laight Cc: Alan Stern; Sarah Sharp; net...@vger.kernel.org; linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

[RESEND PATCH v3 2/4] usb: musb: Bugfix of_node assignment

2013-11-18 Thread Markus Pargmann
It is not safe to assign the of_node to a device without driver. The device is matched against a list of drivers and the of_node could lead to a DT match with the parent driver. Signed-off-by: Markus Pargmann m...@pengutronix.de --- drivers/usb/musb/musb_core.c | 12 +++-

[RESEND PATCH v3 3/4] usb: musb: dsps, debugfs files

2013-11-18 Thread Markus Pargmann
debugfs files to show the contents of important dsps registers. Signed-off-by: Markus Pargmann m...@pengutronix.de --- drivers/usb/musb/musb_dsps.c | 55 1 file changed, 55 insertions(+) diff --git a/drivers/usb/musb/musb_dsps.c

[RESEND PATCH v3 4/4] usb: musb: dsps, use devm_kzalloc

2013-11-18 Thread Markus Pargmann
Signed-off-by: Markus Pargmann m...@pengutronix.de --- drivers/usb/musb/musb_dsps.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 06debf8..058d611 100644 --- a/drivers/usb/musb/musb_dsps.c +++

[RESEND PATCH v3 1/4] usb: musb: gadget, stay IDLE without gadget driver

2013-11-18 Thread Markus Pargmann
If there is no gadget driver musb should stay in B_IDLE state. Signed-off-by: Markus Pargmann m...@pengutronix.de --- drivers/usb/musb/musb_core.c | 3 --- drivers/usb/musb/musb_gadget.c | 14 -- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git

[RESEND PATCH v3 0/4] usb: musb bugfixes

2013-11-18 Thread Markus Pargmann
Hi, I rebased this series onto Felipe's next branch. There are no other changes. The series contains two bugfixes and some debugfs file operations for dsps similar to the musb core regdump debugfs file. Regards, Markus Pargmann Changes in v3: - Using debugfs_reg32 for regdump debug file -

Re: Testing glue layer for DWC3 device controller

2013-11-18 Thread Felipe Balbi
Hi, On Mon, Nov 18, 2013 at 05:32:32PM +0530, Amit Virdi wrote: On 11/15/2013 11:04 PM, Felipe Balbi wrote: please send your glue layer sources and any logs you might have. PHY drivers are loading at subsys_initcall and gadget drivers are loading at module_init(). I don't see how that could

Re: some question about EXDEV status in period schedule

2013-11-18 Thread Alan Stern
Please use Reply-To-All so that your message gets sent to the mailing list as well as to me. On Sat, 16 Nov 2013, yoma sophian wrote: hi alan: There are other examples in the log like this one. To fix the problem you could put more packets in each URB, or use more URBs, or eliminate

Re: [PATCH v4] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2013-11-18 Thread Yann E. MORIN
Dirk, All, On 2013-11-07 15:05 +0100, Dirk Gouders spake thusly: If choices consist of choice_values that depend on symbols set to 'm', those choice_values are not set to 'n' if the choice is changed from 'm' to 'y' (in which case only one active choice_value is allowed). Those values are

Re: [RFC v2] xhci: fix incorrect type in assignment in xhci_address_device()

2013-11-18 Thread Sarah Sharp
Applied to for-usb-linus to be queued for 3.13. (I changed my mind about some of the big endian sparse fixes, and marked them to be queued for the stable tree, so some of your patches have migrated from for-usb-next-queue to for-usb-linus-queue.) Sarah Sharp On Fri, Nov 15, 2013 at 03:18:07AM

Re: [RFC v2] xhci: remove conversion from generic to pci device in xhci_mem.c

2013-11-18 Thread Sarah Sharp
Applied to for-usb-next-queue to be queued for 3.13. Thanks, Sarah Sharp On Fri, Nov 15, 2013 at 03:18:08AM +0200, Xenia Ragiadakou wrote: This patch removes the to_pci_dev() conversion performed to generic struct device since it is not actually useful (the pointer to the generic device can

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-18 Thread Julius Werner
I'm not sure if it's worth it further looking into this for the SUSPENDED state (Sarah's post sounds like that shouldn't happen)... but at any rate, that would be orthogonal to my patch, right? I'm really only interested in the NOTATTACHED case, which solves a real issue on my system. Do you still

RE: Query: DWC3: PHY Suspend bit behavior

2013-11-18 Thread Paul Zimmerman
From: Pratyush Anand [mailto:pratyush.an...@st.com] Sent: Sunday, November 17, 2013 8:24 PM Hi Paul/Felipe, Any comment? Regards Pratyush On Fri, Nov 15, 2013 at 09:34:44AM +0530, Pratyush Anand wrote: Hi, Patch usb: dwc3: gadget: drop dwc3 manual phy control says Recent

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-18 Thread Govindarajulu Varadarajan
Hi Dave Did you have a chance to look at this? Let me know how you want me to fix this. //govind On Mon, 11 Nov 2013, Govindarajulu Varadarajan wrote: On Mon, 4 Nov 2013, David Miller wrote: From: Govindarajulu Varadarajan govindarajul...@gmail.com Date: Sat, 2 Nov 2013 19:17:43 +0530

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-18 Thread Johannes Berg
Please don't top-post. You're making a lot of obvious mistakes, to the likely effect that soon enough people won't even read your email. Did you have a chance to look at this? Let me know how you want me to fix this. By not fixing anything? Is is quite unlikely thats skb is NULL. So it

RE: [PATCH 31/68] uas: Pack iu struct definitions

2013-11-18 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of David Laight Sent: Monday, November 18, 2013 1:36 AM It doesn't look like the networking subsystem (which seems to be the code you're most familiar with) uses packed, but plenty of other

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-18 Thread David Miller
From: Govindarajulu Varadarajan govindarajul...@gmail.com Date: Tue, 19 Nov 2013 00:56:48 +0530 (IST) Did you have a chance to look at this? Let me know how you want me to fix this. I said clearly that I don't want this change to be made, because in many cases the = NULL assignment in the

Re: Check device use before detaching?

2013-11-18 Thread Luke-Jr
On Monday, November 18, 2013 1:37:23 PM Greg KH wrote: On Mon, Nov 18, 2013 at 07:10:45AM +, Luke-Jr wrote: On Monday, November 18, 2013 6:07:37 AM Greg KH wrote: I want my software to ignore devices that are already in use by other software. The other software might be accessing it

Re: Check device use before detaching?

2013-11-18 Thread Greg KH
On Mon, Nov 18, 2013 at 08:19:38PM +, Luke-Jr wrote: My software does not interface with keyboards under any condition. Some specific devices I'm working with include: FTDI: Avalon, Butterfly Labs BitFORCE BitFORCE SC, The Chili CP210X: Bitfountain Block Erupter Emerald/Sapphire

Re: Check device use before detaching?

2013-11-18 Thread Luke-Jr
On Monday, November 18, 2013 8:29:24 PM Greg KH wrote: On Mon, Nov 18, 2013 at 08:19:38PM +, Luke-Jr wrote: My software does not interface with keyboards under any condition. Some specific devices I'm working with include: FTDI: Avalon, Butterfly Labs BitFORCE BitFORCE SC, The Chili

Re: Check device use before detaching?

2013-11-18 Thread Greg KH
On Mon, Nov 18, 2013 at 08:38:39PM +, Luke-Jr wrote: On Monday, November 18, 2013 8:29:24 PM Greg KH wrote: On Mon, Nov 18, 2013 at 08:19:38PM +, Luke-Jr wrote: My software does not interface with keyboards under any condition. Some specific devices I'm working with include:

Re: Check device use before detaching?

2013-11-18 Thread Luke-Jr
On Monday, November 18, 2013 9:25:49 PM Greg KH wrote: Ok, this is making no sense. As you really aren't saying exactly what you are trying to do, I'm going to just give up and say you can't do it. As I said before, I want to use devices only if they aren't already in use. With hidapi's hidraw

Re: Query: DWC3: PHY Suspend bit behavior

2013-11-18 Thread Felipe Balbi
Hi, On Mon, Nov 18, 2013 at 07:12:36PM +, Paul Zimmerman wrote: From: Pratyush Anand [mailto:pratyush.an...@st.com] Sent: Sunday, November 17, 2013 8:24 PM Hi Paul/Felipe, Any comment? Regards Pratyush On Fri, Nov 15, 2013 at 09:34:44AM +0530, Pratyush Anand wrote:

Re: [RFC 14/23] USB: ehci-omap: raw read and write endian fix

2013-11-18 Thread Felipe Balbi
On Sat, Nov 16, 2013 at 02:01:17AM +0200, Taras Kondratiuk wrote: From: Victor Kamensky victor.kamen...@linaro.org All OMAP IP blocks expect LE data, but CPU may operate in BE mode. Need to use endian neutral functions to read/write h/w registers. I.e instead of __raw_read[lw] and

RE: [PATCH net v3 1/4] r8152: fix tx/rx memory overflow

2013-11-18 Thread hayeswang
David Miller [mailto:da...@davemloft.net] Sent: Saturday, November 16, 2013 6:40 AM To: Hayeswang Cc: net...@vger.kernel.org; nic_swsd; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org Subject: Re: [PATCH net v3 1/4] r8152: fix tx/rx memory overflow From: Hayes Wang

[PATCH net v4 0/4] r8152 bug fixes

2013-11-18 Thread Hayes Wang
For the patch #1, I modify the type of the variable pkt_len from unsigned to unsigned int. Hayes Wang (4): r8152: fix tx/rx memory overflow r8152: modify the tx flow r8152: support stopping/waking tx queue r8152: fix incorrect type in assignment drivers/net/usb/r8152.c | 109

[PATCH net v4 1/4] r8152: fix tx/rx memory overflow

2013-11-18 Thread Hayes Wang
The tx/rx would access the memory which is out of the desired range. Modify the method of checking the end of the memory to avoid it. For r8152_tx_agg_fill(), the variable remain may become negative. However, the declaration is unsigned, so the while loop wouldn't break when reaching the end of

[PATCH net v4 3/4] r8152: support stopping/waking tx queue

2013-11-18 Thread Hayes Wang
The maximum packet number which a tx aggregation buffer could contain is the buffer size / (packet size + descriptor size). If the tx buffer is empty and the tx queue length is more than the maximum value which is defined above, stop the tx queue. Wake the tx queue after any queued packet is

[PATCH net v4 4/4] r8152: fix incorrect type in assignment

2013-11-18 Thread Hayes Wang
The data from the hardware should be little endian. Correct the declaration. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index

[PATCH net v4 2/4] r8152: modify the tx flow

2013-11-18 Thread Hayes Wang
Remove the code for sending the packet in the rtl8152_start_xmit(). Let rtl8152_start_xmit() to queue the packet only, and schedule a tasklet to send the queued packets. This simplify the code and make sure all the packet would be sent by the original order. Signed-off-by: Hayes Wang

Re: Query: DWC3: PHY Suspend bit behavior

2013-11-18 Thread Pratyush Anand
On Tue, Nov 19, 2013 at 03:12:36AM +0800, Paul Zimmerman wrote: From: Pratyush Anand [mailto:pratyush.an...@st.com] Sent: Sunday, November 17, 2013 8:24 PM Hi Paul/Felipe, Any comment? Regards Pratyush On Fri, Nov 15, 2013 at 09:34:44AM +0530, Pratyush Anand wrote: Hi,