On Fri, 19 Sep 2003, David Brownell wrote:
> Alan Stern wrote:
> >
> > I wanted to distinguish between two types of suspended states. One is
> > where the bus is suspended because no devices are attached, the other is
> > where the PM software has told us to suspend. It's necessary to make this
On Thu, Sep 18, 2003 at 06:24:42PM -0700, David Brownell wrote:
> Greg KH wrote:
> >On Mon, Sep 15, 2003 at 03:42:05PM -0700, David Brownell wrote:
> >
> >> * Use device_del() not device_unregister(), which matches
> >> with using device_add() to create the devices instead of
> >> d
On Fri, Sep 19, 2003 at 09:41:59AM -0500, Doug Maxey wrote:
>
> Howdy,
>
> Did the complete dump of /proc/bus/usb that illustrates the device
> tree that is giving me fits ever make it to this list? I can resend
> if needed.
>
> It seems that we have another device, in addition to the T
On Fri, Sep 19, 2003 at 09:33:49PM -0400, jtholmes wrote:
> >Greg :
> >David :
> >
> Greg's patch with -R worked so I did not try yours David, thanks to
> you both.
>
> Two questions for Greg
>
> 1 Mind telling me how you whipped that patch up s fast?
It was the last patch to the uhci dr
--- a/drivers/usb/net/usbnet.c 2003-09-18 23:17:47.034477496 -0400
+++ b/drivers/usb/net/usbnet.c 2003-09-18 23:18:05.760630688 -0400
@@ -301,6 +301,7 @@
/*-*/
static struct ethtool_ops usbnet_ethtool_ops;
+static void us
Greg :
David :
Greg's patch with -R worked so I did not try yours David, thanks to
you both.
Two questions for Greg
1 Mind telling me how you whipped that patch up s fast?
2 I have more USB items to test with my Tecra 9100 and want to know
much more about the Innards of USB, is all
On Sun, Sep 14, 2003 at 01:50:08PM -0500, John Wright wrote:
>
> Greg, I got this wrong earlier. This is a USB HID device that follows
> the HID v 1.1
> specs. It plugs in and is recognized as an HID device (lsusb gives all of
> the information
> for the device). I am getting a couple of e
ChangeSet 1.1315.8.3, 2003/09/16 11:17:37-07:00, [EMAIL PROTECTED]
[PATCH] USB speedtouch: use multiple urbs by default
drivers/usb/misc/speedtch.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/speedtch.c
--- a/dri
ChangeSet 1.1315.8.10, 2003/09/16 11:40:50-07:00, [EMAIL PROTECTED]
[PATCH] USB: fix up missing in usb documentation.
This fixes build problem.
Documentation/DocBook/writing_usb_driver.tmpl |1 +
1 files changed, 1 insertion(+)
diff -Nru a/Documentation/DocBook/writing_usb_driver.tmpl
ChangeSet 1.1315.8.27, 2003/09/18 14:33:14-07:00, [EMAIL PROTECTED]
[PATCH] USB: Changes to core/config.c (7 of 9)
This patch changes the usb_parse_interface() routine so that it only
handles a single interface/altsetting descriptor at a time, rather than
trying to handle all the altsettings for
ChangeSet 1.1315.8.13, 2003/09/17 12:20:18-07:00, [EMAIL PROTECTED]
[PATCH] USB: Remove modules.txt: usb serial & storage
drivers/usb/Kconfig | 12 +---
drivers/usb/serial/Kconfig | 121 ++--
drivers/usb/storage/Kconfig |6 --
3 files chan
ChangeSet 1.1315.8.5, 2003/09/16 11:18:08-07:00, [EMAIL PROTECTED]
[PATCH] USB speedtouch: neater sanity check
Biscuit for Greg.
drivers/usb/misc/speedtch.c | 17 ++---
1 files changed, 10 insertions(+), 7 deletions(-)
diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/
ChangeSet 1.1315.8.22, 2003/09/17 17:09:04-07:00, [EMAIL PROTECTED]
[PATCH] USB: Changes to core/config.c (3 of 9)
This patch includes a bunch of little local improvements to the code,
listed in the patch comments. There are only two notable changes. If a
device has more configurations than our
ChangeSet 1.1315.8.28, 2003/09/18 14:33:32-07:00, [EMAIL PROTECTED]
[PATCH] USB: Changes to core/config.c (8 of 9)
This patch adds some extra error checking. The patch-comments list most
it. Particularly worth noting is the check on the endpoint addresses.
Since these addresses are used as inde
ChangeSet 1.1315.8.2, 2003/09/16 10:53:37-07:00, [EMAIL PROTECTED]
[PATCH] USB: fix oops in ipaq driver
Should fix bug number 1227
drivers/usb/serial/ipaq.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -Nru a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
--- a/drive
ChangeSet 1.1315.8.15, 2003/09/17 14:18:13-07:00, [EMAIL PROTECTED]
[PATCH] USB: Debug code fixes for usblp
When compiling usblp with debug info, a compile error occurs. I presume
this is because this part of the code has not been updated since the 2.4
kernels. This patch fixes this.
I also enha
ChangeSet 1.1315.8.14, 2003/09/17 14:17:50-07:00, [EMAIL PROTECTED]
[PATCH] USB: Debug code fixes for vicam
When compiling vicam with debug info, a compile error occurs. I presume
this is because this part of the code has not been updated since the 2.4
kernels. This patch fixes this.
drivers/
ChangeSet 1.1315.8.17, 2003/09/17 14:20:32-07:00, [EMAIL PROTECTED]
[PATCH] USB: Changes to core/config.c (1 of 9)
This first patch makes only trivial changes. Excess whitespace at the end
of lines is removed and return codes are altered from -1 to symbolic error
values. The only significant di
ChangeSet 1.1315.8.26, 2003/09/18 14:15:11-07:00, [EMAIL PROTECTED]
[PATCH] USB: unusual device fixup for the Y-E floppy drive.
drivers/usb/storage/unusual_devs.h |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -Nru a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unu
ChangeSet 1.1315.8.30, 2003/09/19 16:28:31-07:00, [EMAIL PROTECTED]
[PATCH] USB: ethtool_ops and ax8817x fixes for usbnet
This is a resend of all of my recent usbnet additions which
center on adding ethtool_ops support. All have been re-diffed
against the latest usbnet from BK.
Changes:
* Add e
ChangeSet 1.1315.8.20, 2003/09/17 17:06:26-07:00, [EMAIL PROTECTED]
[PATCH] USB: psdocs fails for usbgadget
It updates the "gadget" kerneldoc, removing some (new) warnings, and
showing some fields it hadn't previously been showing (due to
limitations in docproc). Plus it adds a bit of informatio
ChangeSet 1.1315.8.18, 2003/09/17 16:54:30-07:00, [EMAIL PROTECTED]
[PATCH] USB: make sure we never reference a usbserial port after it has been
unregistered.
drivers/usb/serial/usb-serial.c |4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
diff -Nru a/drivers/usb/serial/usb-seria
ChangeSet 1.1315.8.1, 2003/09/16 10:47:50-07:00, [EMAIL PROTECTED]
[PATCH] USB: fix oops when trying to suspend and resume.
Thanks to Pavel for the original version of this patch.
drivers/usb/core/usb.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff -Nru a/drivers/u
ChangeSet 1.1315.8.16, 2003/09/17 14:20:01-07:00, [EMAIL PROTECTED]
[PATCH] [PATCH] drivers/usb version/include cleanup
Remove unneeded version.h and doubley included header.
Test compiled on 2.6.0-test5-bk3.
drivers/usb/gadget/inode.c |1 -
drivers/usb/media/usbvideo.c |1 -
2 files
ChangeSet 1.1315.8.8, 2003/09/16 11:28:17-07:00, [EMAIL PROTECTED]
[PATCH] USB: usb/gadget/Kconfig, use right PXA2xx symbols
I just noticed that Linus' tree is using the wrong CONFIG_* symbols
for kicking in the PXA 2xx support (except for "gadgetfs"). It
should use USB_PXA2XX not USB_PXA250, si
ChangeSet 1.1315.8.7, 2003/09/16 11:28:01-07:00, [EMAIL PROTECTED]
[PATCH] USB: Drop debounce printout for 2.6
This seems to work well enough, we do not need the printout anymore.
drivers/usb/core/hub.c |3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -Nru a/drivers/usb/core/
ChangeSet 1.1315.8.19, 2003/09/17 17:06:09-07:00, [EMAIL PROTECTED]
[PATCH] USB: Debug code fixes for dabusb
drivers/usb/media/dabusb.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff -Nru a/drivers/usb/media/dabusb.c b/drivers/usb/media/dabusb.c
--- a/drivers/usb/media/da
ChangeSet 1.1315.8.12, 2003/09/17 12:18:01-07:00, [EMAIL PROTECTED]
[PATCH] USB: Remove modules.txt: usb_media, usb_input
drivers/usb/input/Kconfig | 48
drivers/usb/media/Kconfig | 61 --
2 files changed, 38 i
Hi,
Here are some USB fixes for 2.6.0-test5. The USB config logic was
reworked a lot by Alan Stern to handle errors and odd devices much
better, ending up with a smaller code path, and less memory allocated
for every USB device. There are also a number of other small fixups in
here, fixes for oo
ChangeSet 1.1315.8.11, 2003/09/16 13:42:41-07:00, [EMAIL PROTECTED]
[PATCH] USB: Use num_altsetting in usbnet and usbtest
This patch fixes usbnet and usbtest. When checking endpoints, they
iterate through all interfaces out to intf->max_altsetting, but they
should only go up to intf->num_altsett
ChangeSet 1.1315.8.6, 2003/09/16 11:18:25-07:00, [EMAIL PROTECTED]
[PATCH] USB speedtouch: bump the version number
drivers/usb/misc/speedtch.c |4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/speedtch.c
--- a/drivers/usb/m
ChangeSet 1.1315.8.9, 2003/09/16 11:40:17-07:00, [EMAIL PROTECTED]
[PATCH] USB: make pdfdocs problem
The `make pdfdocs' target still fails for me on the
`writing_usb_drivers' document. There's one small bug in it, and one
problem I haven't figured out yet.
There is a malformed b
ChangeSet 1.1315.8.24, 2003/09/17 17:59:40-07:00, [EMAIL PROTECTED]
[PATCH] USB: Changes to core/config.c (5 of 9)
This patch centralizes the error checking for invalid descriptor lengths
and unexpected descriptor types. Instead of doing it in three different
places -- while parsing configuratio
ChangeSet 1.1315.8.25, 2003/09/17 17:59:57-07:00, [EMAIL PROTECTED]
[PATCH] USB: Changes to core/config.c (6 of 9)
This patch removes the home-brewed resizeable arrays used to store
altsetting structures, along with the now-unneeded max_altsetting field.
Since we are already making a preliminary
ChangeSet 1.1315.8.21, 2003/09/17 17:08:46-07:00, [EMAIL PROTECTED]
[PATCH] USB: Changes to core/config.c (2 of 9)
This patch fixes the most blatant problems that can happen when an error
is encountered during descriptor parsing.
The struct device embedded within a struct usb_interface i
ChangeSet 1.1315.8.23, 2003/09/17 17:09:21-07:00, [EMAIL PROTECTED]
[PATCH] USB: Changes to core/config.c (4 of 9)
Although it's hard to tell from reading the patch, this just moves one
section of code to a slightly different spot. Currently the code that
skips over the extra class- and vendor-s
ChangeSet 1.1315.8.4, 2003/09/16 11:17:53-07:00, [EMAIL PROTECTED]
[PATCH] USB: New email address for duncan
CREDITS |2 +-
MAINTAINERS |2 +-
drivers/usb/misc/speedtch.c |4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff -Nru a/CRED
ChangeSet 1.1315.8.29, 2003/09/18 14:33:50-07:00, [EMAIL PROTECTED]
[PATCH] USB: Changes to core/config.c (9 of 9)
This patch implements the change discussed last weekend. Rather than
allocating separate memory areas for the "extra" descriptors and copying
the descriptor contents, it simply make
On Fri, Sep 19, 2003 at 04:28:34PM -0700, David Brownell wrote:
> Greg KH wrote:
>
> >David, care to make those changes, test it, and resubmit it to me?
>
> Sure, with just the interface refcounting fixed. Device refcounting
> issues can be fixed separately.
That's fine, as long as your patch d
On Thu, Sep 18, 2003 at 11:51:08PM -0400, David T Hollis wrote:
> This is a resend of all of my recent usbnet additions which
> center on adding ethtool_ops support. All have been re-diffed
> against the latest usbnet from BK.
>
> Changes:
> * Add ethtool_ops support to usbnet
> * Add GPIO bit
Greg KH wrote:
David, care to make those changes, test it, and resubmit it to me?
Sure, with just the interface refcounting fixed. Device refcounting
issues can be fixed separately.
Mind if I also change the interface bus_id strings so they include the
configuration number too? That'll help hotp
On Fri, Sep 19, 2003 at 06:35:19PM -0400, Alan Stern wrote:
> On Fri, 19 Sep 2003, Greg KH wrote:
>
> > On Fri, Sep 19, 2003 at 05:17:22PM -0400, Alan Stern wrote:
> > >
> > > = config.c 1.25 vs edited =
> > > --- 1.25/drivers/usb/core/config.cMon Sep 15 10:14:46 2003
> > > +++ ed
if so I've to to suspect that's because there's an extra
get_device() ... like the one in "config.c". Isn't the
object initialized to count == 1, so that get_device() makes
usbcore track count == 2 for just one copy of that pointer?
That's right, and you're also right that there's an extra get_dev
Greg KH wrote:
On Thu, Sep 18, 2003 at 06:24:42PM -0700, David Brownell wrote:
Since usbcore is still keeping the config[i]->interface[j]
reference, dropping the refcount then would lead to oopsing
later when it got re-used. I got tired of oopsing. :)
Ok, doing that for the interfaces is fine
This patch is bad.
The US_PR_FREECOM and freecom_init are for the USB 1.1. Freecom adaptors,
which use a proprietary protocol. Freecom was kind enough to provide
documentation on that protocol for us to write the driver.
The USB 2.0 devices, however, use the class-standard protocol.
So this pat
On Fri, Sep 19, 2003 at 09:36:49AM -0400, jtholmes wrote:
> I don't take the Distribution, and don't need email copy of
> answer, just answer in LKML and I will see it.
>
> If I knew how to turn on more debugging I would gladly do so
> as I need to figure out the Kernel debugging scheme.
>
>
On Fri, 19 Sep 2003, Philipp H. Poll wrote:
> Sorry,
> unfortunately I wasn't able to revive the system I had and with which
> that drive worked. I know, that makes ist harder for you guys, so don't
> feel bothered to ask me if you still need information or something else.
> Something I can tell
On Fri, 19 Sep 2003, Greg KH wrote:
> On Fri, Sep 19, 2003 at 05:17:22PM -0400, Alan Stern wrote:
> >
> > = config.c 1.25 vs edited =
> > --- 1.25/drivers/usb/core/config.c Mon Sep 15 10:14:46 2003
> > +++ edited/drivers/usb/core/config.cFri Sep 19 17:07:29 2003
> > @@ -237,9 +23
Alan Stern wrote:
On Wed, 17 Sep 2003, David Brownell wrote:
I see them as different in the following way: switching configurations
retains the same "struct usb_device". Morphing the device, after a
DFU style firmware update (host-initiated reset) or an EZ-USB style
one ("Renumeration(tm)", de
On Fri, Sep 19, 2003 at 06:14:29PM -0400, Alan Stern wrote:
>
> P.S.: Greg, what on Earth does "GREG: gregindex = 0" mean?
Heh, using the linuxusb.bkbits.net/usb-2.5 tree are ya? :)
It's some debugging code left in by me for some module loading code
changes I've been working on in my spare time
Here's a piece from my system log, when I did "apm --suspend". The
usb_device_suspend/resume messages are things I added for debugging.
Sep 19 17:02:35 ida kernel: uhci-hcd :00:07.2: suspend to state 3
Sep 19 17:02:35 ida kernel: drivers/usb/host/uhci-hcd.c: 6400: suspend_hc
Sep 19 17:02:35
On Fri, Sep 19, 2003 at 05:17:22PM -0400, Alan Stern wrote:
> On Thu, 18 Sep 2003, David Brownell wrote:
>
> > You might be right that another put_device() is needed, but
> > if so I've to to suspect that's because there's an extra
> > get_device() ... like the one in "config.c". Isn't the
> > ob
On Thu, Sep 18, 2003 at 11:51:08PM -0400, David T Hollis wrote:
> This is a resend of all of my recent usbnet additions which
> center on adding ethtool_ops support. All have been re-diffed
> against the latest usbnet from BK.
David B, any thoughts on these patches?
David H, try adding each ch
On Fri, 19 Sep 2003, David Brownell wrote:
> Alan Stern wrote:
>
> > But for the other "device-morphed" case we don't need to do all that
> > stuff. There's no need to get rid of the current struct usb_device and
> > allocate a new one; just re-use the existing one. Re-enumeration can pick
>
On Thu, 18 Sep 2003, David Brownell wrote:
> You might be right that another put_device() is needed, but
> if so I've to to suspect that's because there's an extra
> get_device() ... like the one in "config.c". Isn't the
> object initialized to count == 1, so that get_device() makes
> usbcore tra
Greg KH wrote:
Hm, can you apply this patch with -R and see if it fixes your problem?
Or this one _without_ "-R".
--- 1.44/drivers/usb/host/uhci-hcd.cFri Jul 18 06:22:32 2003
+++ edited/drivers/usb/host/uhci-hcd.c Fri Sep 19 12:23:54 2003
@@ -1960,8 +1960,9 @@
{
unsigned int io_add
On Thu, Sep 18, 2003 at 01:18:50AM +, zhihua Li wrote:
> Hi,
> I am really a freshman of Linux USB. If my question looks like silly,
> please do not laugh at me.
>
> Now I am trying to make my USB device can work on Linux, SO
> 1. I will develop a USB driver
> 2. An application to function my
Alan Stern wrote:
On Tue, 16 Sep 2003, David Brownell wrote:
uhci->state = UHCI_SUSPENDED_PM;
+ uhci->hcd.state = USB_STATE_SUSPENDED;
I meant to ask ... why don't you just use uhci->hcd.state
exclusively?
That's a good question.
I wanted to distinguish between two
--- a/drivers/usb/net/usbnet.c 2003-09-12 13:53:44.022426336 -0400
+++ b/drivers/usb/net/usbnet.c 2003-09-12 13:55:02.947427912 -0400
@@ -252,6 +252,8 @@
/* for new devices, use the descriptor-reading code instead */
int in; /* rx endpoint */
int
--- a/drivers/usb/net/usbnet.c 2003-09-18 23:09:49.569063272 -0400
+++ b/drivers/usb/net/usbnet.c 2003-09-18 23:10:52.005571480 -0400
@@ -298,6 +298,8 @@
/*-*/
+static struct ethtool_ops usbnet_ethtool_ops;
+
/* mostly
Howdy,
Did the complete dump of /proc/bus/usb that illustrates the device
tree that is giving me fits ever make it to this list? I can resend
if needed.
It seems that we have another device, in addition to the TEAC floppy
that has had an unusual_dev entry, this time for the ISC-200.
I have locking for all versions of source for SL811HS and found this all
2.4.4 hc_sl811.c (Original from Cypress)
2.4.20 hc_sl811.c (Same as Cypress)
2.4.22 sl811.c (new from Yinah) !-)
2.5.75 hc_sl811.c (Same as Cypress)
2.6.0 hc_sl811.c (Same as Cypress)
Best driver comes from Yinah.
Q: But w
--- a/drivers/usb/net/usbnet.c 2003-09-18 23:33:11.079001376 -0400
+++ b/drivers/usb/net/usbnet.c 2003-09-18 23:41:39.314737800 -0400
@@ -455,11 +455,11 @@
static void ax8817x_async_cmd_callback(struct urb *urb, struct pt_regs *regs)
{
struct usb_ctrlrequest *req = (struct usb_ctrlreque
Greg KH wrote:
On Mon, Sep 15, 2003 at 03:42:05PM -0700, David Brownell wrote:
* Use device_del() not device_unregister(), which matches
with using device_add() to create the devices instead of
device_register() ... resolves one refcounting problem.
Hm, how does it do that?
If
On Wed, Sep 17, 2003 at 08:33:33AM +0200, Vojtech Pavlik wrote:
> On Tue, Sep 16, 2003 at 05:14:51PM -0700, Paul Stewart wrote:
> > Looks like a straightforward fix, but if you need a patch from me,
> > for hiddev, Vojtech, let me know what to base it off.
>
> I'll fix it myself, thanks.
Done.
-
On Fri, Sep 19, 2003 at 09:41:59AM -0500, Doug Maxey wrote:
> Did the complete dump of /proc/bus/usb that illustrates the device
> tree that is giving me fits ever make it to this list? I can resend
> if needed.
We can see the problem, but there isn't any workaround. You have two
devices w
This is a resend of all of my recent usbnet additions which
center on adding ethtool_ops support. All have been re-diffed
against the latest usbnet from BK.
Changes:
* Add ethtool_ops support to usbnet
* Add GPIO bit toggling upon initialization of ax8817x devices
so that xmit works properly
David T Hollis wrote:
This patch adds Wake On LAN (WOL) and eeprom dumping support via ethtool
to the ax8817x portion of usbnet. This only permits the configuration
of WOL for the device, actual operation of WOL would seem to be handled
at lower levels of the USB subsystem. It also serves as a
68 matches
Mail list logo