Re: [linux-usb-devel] compiling your last tree

2007-01-25 Thread Oliver Neukum
Am Freitag, 26. Januar 2007 00:59 schrieb Greg KH: > > --- a/fs/sysfs/group.c2006-06-18 03:49:35.0 +0200 > > +++ b/fs/sysfs/group.c2007-01-24 10:28:38.0 +0100 > > @@ -13,6 +13,7 @@ > >  #include > >  #include > >  #include > > +#include > >  #include "sysfs.h" >

Re: [linux-usb-devel] designs... (Re: [patch, attach, RFC] usb-serial: ti_usb removing firmware)

2007-01-25 Thread Oleg Verych
25-01-2007, Oleg Verych: [] > (shame on me, but i only have read USB-in-a- nutshell.pdf [by Copyright > 2002, Craig Peacock <[EMAIL PROTECTED]> Third Release] back > in summer and adopted request_firmare() to one usb-serial driver). [] > That doc., i have mensioned, pages 19-20 describes _interface

Re: [linux-usb-devel] Bug in USB core - discussion over usb-serial

2007-01-25 Thread Greg KH
On Thu, Jan 25, 2007 at 10:25:34AM +0100, Nathael Pajani wrote: > Hi again! > > Greg KH a ??crit : > > > >>- usb_serial_probe() is not laid out in a way wich pleases me, and > >>this may be useful for others: > >> the call to type->calc_num_ports(serial); is done before the > >>

Re: [linux-usb-devel] compiling your last tree

2007-01-25 Thread Greg KH
On Thu, Jan 25, 2007 at 11:30:21AM +0100, Oliver Neukum wrote: > Hi, > > I need this patch to compile your 2.6.20-rc5 tree on UP x86_64. > > HTH > Oliver > > Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> > > > --- a/fs/sysfs/group.c2006-06-18 03:49:35.000

[linux-usb-devel] designs... (Re: [patch, attach, RFC] usb-serial: ti_usb removing firmware)

2007-01-25 Thread Oleg Verych
On Thu, Jan 25, 2007 at 02:42:17PM -0500, Alan Stern wrote: > On Thu, 25 Jan 2007, Oleg Verych wrote: > > > On Thu, Jan 25, 2007 at 11:39:33AM -0500, Alan Stern wrote: > > > On Thu, 25 Jan 2007, Oleg Verych wrote: > > > > 0. Here i will mean first ever driver's job -- setting up device. Was it >

Re: [linux-usb-devel] g_serial small error

2007-01-25 Thread Greg KH
On Tue, Jan 23, 2007 at 12:01:39AM +, Bryan O'Donoghue wrote: > Greetings. > > I was getting a weird non-acked control request using g_serial which > I was assuming was a bug with some of my stuff. > > Looking in gs_setup_class however > > case USB_CDC_SET_LINE_CODING: > > Appears to

Re: [linux-usb-devel] [PATCH] small kernel driver to charge USB Blackberrys

2007-01-25 Thread Greg KH
On Wed, Jan 24, 2007 at 02:57:35PM -0500, Chris Frey wrote: > On Wed, Jan 24, 2007 at 11:05:10AM -0800, Greg KH wrote: > > Thanks to the work of the "Barry" project > > > > I've created a simple little kernel driver to automatically switch a >

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Greg KH
On Thu, Jan 25, 2007 at 05:28:35PM +, Oleg Verych wrote: > > > AFAIK, this is standard USB firmware update logic. Greg even > > > co-authored a standard for this. For the record, the standard I helped author is the Device Firmware Update for USB at: http://www.usb.org/developers/devcla

Re: [linux-usb-devel] introduction of blacklist for autosuspend

2007-01-25 Thread Oliver Neukum
Am Donnerstag, 25. Januar 2007 20:55 schrieb Alan Stern: > Remember, this doesn't have to be an absolutely perfect solution.  We want > the kernel to do the correct thing for the vast majority of devices, and > for the odd exception we want the kernel to be conservative -- do no harm > -- and allow

Re: [linux-usb-devel] introduction of blacklist for autosuspend

2007-01-25 Thread Alan Stern
On Thu, 25 Jan 2007, Oliver Neukum wrote: > Am Donnerstag, 25. Januar 2007 18:20 schrieb Alan Stern: > > > This seems contradictory. If you want a generic blacklisting, you cannot > > > limit the information to autosuspending. > > > > It isn't contradictory.  Autosuspend requests come exclusively

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Alan Stern
On Thu, 25 Jan 2007, Oleg Verych wrote: > On Thu, Jan 25, 2007 at 11:39:33AM -0500, Alan Stern wrote: > > On Thu, 25 Jan 2007, Oleg Verych wrote: > > 0. Here i will mean first ever driver's job -- setting up device. Was it >bound by user or not -- doesn't mater. > > 1. USB defines interfaces

Re: [linux-usb-devel] Philips USB ISP1161A and ISP1760 Host USB Controller Support

2007-01-25 Thread David Brownell
On Thursday 25 January 2007 11:22 am, Arvind Agrawal wrote: > Thanks Dave ! > > Unfortunately I could not find TI TUSB6010 on TI, is it possible that it's > not supported by TI anymore.. It's a newish part, that's why I said "contact TI". > Do you know of anyother embedded USB Host Controllers

Re: [linux-usb-devel] Philips USB ISP1161A and ISP1760 Host USB Controller Support

2007-01-25 Thread Arvind Agrawal
Thanks Dave ! Unfortunately I could not find TI TUSB6010 on TI, is it possible that it's not supported by TI anymore.. Do you know of anyother embedded USB Host Controllers fully supporte by Linux? Thanks again, Arvind - Original Message - From: "David Brownell" <[EMAIL PROTECTED]> To:

Re: [linux-usb-devel] [patch]fix needless failure under certain conditions

2007-01-25 Thread Alan Stern
On Thu, 25 Jan 2007, Oliver Neukum wrote: > Am Donnerstag, 25. Januar 2007 17:15 schrieb Alan Stern: > > > How about moving the kmalloc() call (and test for failure) before the > > lock_kernel()?  That removes the possibility of dropping the BKL, even > > though it might make other things a li

Re: [linux-usb-devel] introduction of blacklist for autosuspend

2007-01-25 Thread Oliver Neukum
Am Donnerstag, 25. Januar 2007 18:20 schrieb Alan Stern: > > This seems contradictory. If you want a generic blacklisting, you cannot > > limit the information to autosuspending. > > It isn't contradictory.  Autosuspend requests come exclusively from within > usbcore, and we can easily prevent our

Re: [linux-usb-devel] introduction of blacklist for autosuspend

2007-01-25 Thread Alan Stern
On Thu, 25 Jan 2007, Oliver Neukum wrote: > > I think this patch could be generalized. We may have other quirks to > > worry about besides PM/autosuspend. This should become a general USB > > blacklist mechanism. > > If you want the grand solution, you shall get it. Thank you. If only the r

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Oleg Verych
On Thu, Jan 25, 2007 at 11:39:33AM -0500, Alan Stern wrote: > On Thu, 25 Jan 2007, Oleg Verych wrote: 0. Here i will mean first ever driver's job -- setting up device. Was it bound by user or not -- doesn't mater. 1. USB defines interfaces and configurations of them. > > On Thu, Jan 25, 2007

Re: [linux-usb-devel] [patch]fix needless failure under certain conditions

2007-01-25 Thread Oliver Neukum
Am Donnerstag, 25. Januar 2007 17:15 schrieb Alan Stern: > How about moving the kmalloc() call (and test for failure) before the > lock_kernel()?  That removes the possibility of dropping the BKL, even > though it might make other things a little more awkward. In this case, if you want the gre

Re: [linux-usb-devel] Two revisions with identical descriptors, one buggy, the other not

2007-01-25 Thread Oliver Neukum
Am Donnerstag, 25. Januar 2007 17:46 schrieb Alan Stern: > On Thu, 25 Jan 2007, Oliver Neukum wrote: > > > > > The capacity is incorrect. Mishandling a compliant device is not really > > > > acceptable and for existing disks repartitioning is not an option. > > > > > > Can you provide more detail

Re: [linux-usb-devel] Two revisions with identical descriptors, one buggy, the other not

2007-01-25 Thread Alan Stern
On Thu, 25 Jan 2007, Oliver Neukum wrote: > > > The capacity is incorrect. Mishandling a compliant device is not really > > > acceptable and for existing disks repartitioning is not an option. > > > > Can you provide more details? For each of the two devices, what are: > > > > The apparent

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Alan Stern
On Thu, 25 Jan 2007, Oleg Verych wrote: > On Thu, Jan 25, 2007 at 04:17:03PM +0100, Oliver Neukum wrote: > [] > > > > > > It is relatively new. As comment states, it doesn't guarantee > > > anything, caller hangs in air... > > > > Yes, unfortunately this is true. However, as I understand it, you

Re: [linux-usb-devel] [patch]fix needless failure under certain conditions

2007-01-25 Thread Alan Stern
On Thu, 25 Jan 2007, Oliver Neukum wrote: > Am Donnerstag, 25. Januar 2007 11:49 schrieb Ville Syrjälä: > > On Thu, Jan 25, 2007 at 11:22:24AM +0100, Oliver Neukum wrote: > > > Hi, > > > > > > in devices.c we have a piece of code for dealing with losing in a race. > > > If we indeed lose the race

Re: [linux-usb-devel] [PATCH]switching off autosuspend through sysfs

2007-01-25 Thread Alan Stern
On Wed, 24 Jan 2007, David Brownell wrote: > > > > > I don't know, it just really annoys me to see that power directory there > > > > with no use for it for a lot of devices :) > > > > > > Would it help to add a flag somewhere in struct device (or struct > > > dev_pm_info) for indicating that th

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Oliver Neukum
Am Donnerstag, 25. Januar 2007 15:28 schrieb Oleg Verych: > When i've known how USB defines firmware updates: > -- device appears with one firmware-loading ID; > - after loading it disconnects, and reconnects; > -- new bus connect event, new ID, same hardware-device still plugged; > -- (TI USB) i

Re: [linux-usb-devel] [linux-pm] [PATCH]switching off autosuspend through sysfs

2007-01-25 Thread Scott E. Preece
| From: Greg KH<[EMAIL PROTECTED]> | | ... | > > | > > Would it help to add a flag somewhere in struct device (or struct | > > dev_pm_info) for indicating that the device is not cognizant of PM? For | > > instance, all those USB endpoint pseudo-devices we create -- it's a waste | > > of time to

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Oleg Verych
On Thu, Jan 25, 2007 at 04:17:03PM +0100, Oliver Neukum wrote: [] > > > > It is relatively new. As comment states, it doesn't guarantee > > anything, caller hangs in air... > > Yes, unfortunately this is true. However, as I understand it, you are > helpless if you are called with the wrong config

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Oliver Neukum
Am Donnerstag, 25. Januar 2007 16:16 schrieb Oleg Verych: > On Thu, Jan 25, 2007 at 03:53:58PM +0100, Oliver Neukum wrote: > [] > > Yes, there is something wrong with the design of this device. > > For these cases there's > > int usb_driver_set_configuration(struct usb_device *udev, int config) >

Re: [linux-usb-devel] [linux-pm] [PATCH]switching off autosuspend through sysfs

2007-01-25 Thread Alan Stern
On Wed, 24 Jan 2007, Greg KH wrote: > > > Would it help to add a flag somewhere in struct device (or struct > > > dev_pm_info) for indicating that the device is not cognizant of PM? For > > > instance, all those USB endpoint pseudo-devices we create -- it's a waste > > > of time to try doing powe

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Oliver Neukum
Am Donnerstag, 25. Januar 2007 16:54 schrieb Oleg Verych: > On Thu, Jan 25, 2007 at 04:17:03PM +0100, Oliver Neukum wrote: > [] > > > > > > It is relatively new. As comment states, it doesn't guarantee > > > anything, caller hangs in air... > > > > Yes, unfortunately this is true. However, as I u

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Oleg Verych
On Thu, Jan 25, 2007 at 03:53:58PM +0100, Oliver Neukum wrote: [] > Yes, there is something wrong with the design of this device. > For these cases there's > int usb_driver_set_configuration(struct usb_device *udev, int config) > > You check the current configuration probe() is called with, call

Re: [linux-usb-devel] Two revisions with identical descriptors, one buggy, the other not

2007-01-25 Thread Oliver Neukum
Am Donnerstag, 25. Januar 2007 16:49 schrieb Alan Stern: > On Wed, 24 Jan 2007, Oliver Neukum wrote: > > > Am Mittwoch, 24. Januar 2007 17:57 schrieb Alan Stern: > > > On Wed, 24 Jan 2007, Oliver Neukum wrote: > > > > > > > Hi, > > > > > > > > I have a report about a device that will show an err

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Alan Stern
On Thu, 25 Jan 2007, Oleg Verych wrote: > On Thu, Jan 25, 2007 at 03:53:58PM +0100, Oliver Neukum wrote: > [] > > Yes, there is something wrong with the design of this device. > > For these cases there's > > int usb_driver_set_configuration(struct usb_device *udev, int config) > > > > You check

Re: [linux-usb-devel] [PATCH 30/34] USB: fix to usbfs_snoop logging of user defined control urbs

2007-01-25 Thread Alan Stern
On Wed, 24 Jan 2007, Chris Frey wrote: > On Tue, Jan 02, 2007 at 05:32:25PM -0800, Greg KH wrote: > > On Wed, Dec 20, 2006 at 11:05:44PM -0500, Alan Stern wrote: > > > On Wed, 20 Dec 2006, Greg KH wrote: > > > > > > > From: Chris Frey <[EMAIL PROTECTED]> > > > > > > > > When sending CONTROL URB'

Re: [linux-usb-devel] Two revisions with identical descriptors, one buggy, the other not

2007-01-25 Thread Alan Stern
On Wed, 24 Jan 2007, Oliver Neukum wrote: > Am Mittwoch, 24. Januar 2007 17:57 schrieb Alan Stern: > > On Wed, 24 Jan 2007, Oliver Neukum wrote: > > > > > Hi, > > > > > > I have a report about a device that will show an error with the > > > FIX_CAPACITY > > > quirk and another device that needs

Re: [linux-usb-devel] [patch]a bit more coding style

2007-01-25 Thread Oleg Verych
On 2007-01-25, Oliver Neukum wrote: > Hi, > > I was sitting in a train threatened to be blocked by ice. I took this > as a hint to do some more boring work for the common good. Here's > a bit more for coding style. It will be good, to have such patches with any kind of "strip-trailing-whitespace"

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Oleg Verych
On 2007-01-25, Oliver Neukum wrote: > Am Donnerstag, 25. Januar 2007 01:21 schrieb Oleg Verych: [] >> Ehh... USB, Devices are designed to change configurations, linux-usb isn't. >> Without much technical details -- this is a bed design. No? > > It is designed to change configurations through sysfs

Re: [linux-usb-devel] [linux-pm] [PATCH]switching off autosuspend through sysfs

2007-01-25 Thread David Brownell
On Wednesday 24 January 2007 6:15 pm, David Brownell wrote: > > So, what kind of devices do support these files? I can think of: > > PCI > > Actually, PCI still doesn't because of strangeness in the init > sequencing on at least PPC ... I can forward the patch that makes > X86 init the wakeu

Re: [linux-usb-devel] [patch]fix needless failure under certain conditions

2007-01-25 Thread Ville Syrjälä
On Thu, Jan 25, 2007 at 12:01:32PM +0100, Oliver Neukum wrote: > Am Donnerstag, 25. Januar 2007 11:49 schrieb Ville Syrjälä: > > On Thu, Jan 25, 2007 at 11:22:24AM +0100, Oliver Neukum wrote: > > > Hi, > > > > > > in devices.c we have a piece of code for dealing with losing in a race. > > > If we

Re: [linux-usb-devel] [patch]fix needless failure under certain conditions

2007-01-25 Thread Oliver Neukum
Am Donnerstag, 25. Januar 2007 11:49 schrieb Ville Syrjälä: > On Thu, Jan 25, 2007 at 11:22:24AM +0100, Oliver Neukum wrote: > > Hi, > > > > in devices.c we have a piece of code for dealing with losing in a race. > > If we indeed lose the race we don't care whether our own memory allocation > > wo

Re: [linux-usb-devel] [patch]fix needless failure under certain conditions

2007-01-25 Thread Ville Syrjälä
On Thu, Jan 25, 2007 at 11:22:24AM +0100, Oliver Neukum wrote: > Hi, > > in devices.c we have a piece of code for dealing with losing in a race. > If we indeed lose the race we don't care whether our own memory allocation > worked. The check for that is so early that we return early even if we > d

[linux-usb-devel] compiling your last tree

2007-01-25 Thread Oliver Neukum
Hi, I need this patch to compile your 2.6.20-rc5 tree on UP x86_64. HTH Oliver Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> --- a/fs/sysfs/group.c 2006-06-18 03:49:35.0 +0200 +++ b/fs/sysfs/group.c 2007-01-24 10:28:38.0 +0100 @@ -13,6 +13,7 @@

[linux-usb-devel] [patch]fix needless failure under certain conditions

2007-01-25 Thread Oliver Neukum
Hi, in devices.c we have a piece of code for dealing with losing in a race. If we indeed lose the race we don't care whether our own memory allocation worked. The check for that is so early that we return early even if we don't have to. Regards Oliver Signed-off-by: Olive

[linux-usb-devel] [patch]a bit more coding style

2007-01-25 Thread Oliver Neukum
Hi, I was sitting in a train threatened to be blocked by ice. I took this as a hint to do some more boring work for the common good. Here's a bit more for coding style. Regards Oliver Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> --- a/drivers/usb/core/buffer.c 2

Re: [linux-usb-devel] introduction of blacklist for autosuspend

2007-01-25 Thread Oliver Neukum
Am Freitag, 19. Januar 2007 16:31 schrieb Alan Stern: > On Fri, 19 Jan 2007, Oliver Neukum wrote: > > > Hi, > > > > I did the dirty deed. Could you please tell me which quirky devices > > you know of? I am afraid this list needs to be populated and there > > are outstanding regressions in Adrian'

[linux-usb-devel] [PATCH] USB: In init_endpoint_class, use PTR_ERR to obtain an errno value, not IS_ERR

2007-01-25 Thread Josh Triplett
init_endpoint_class calls class_create, and checks the result for an error with IS_ERR; however, if true, it then returns the result of IS_ERR (a boolean) rather than PTR_ERR (the actual errno). Signed-off-by: Josh Triplett <[EMAIL PROTECTED]> --- drivers/usb/core/endpoint.c |2 +- 1 files ch

Re: [linux-usb-devel] Bug in USB core - discussion over usb-serial

2007-01-25 Thread Nathael Pajani
Hi again! Greg KH a écrit : > >> - usb_serial_probe() is not laid out in a way wich pleases me, and >> this may be useful for others: >> the call to type->calc_num_ports(serial); is done before the >> serial->num_bulk_in = num_bulk_in; >> serial->num_b

Re: [linux-usb-devel] [patch, attach, RFC] usb-serial: ti_usb removing firmware

2007-01-25 Thread Oliver Neukum
Am Donnerstag, 25. Januar 2007 01:21 schrieb Oleg Verych: > On 12/15/06, Alan Stern <[EMAIL PROTECTED]> wrote: > > It isn't exported because, generally speaking, drivers can't use it. If > > your driver called usb_set_configuration() from within its probe routine, > > it would hang. That's becau