On Wed, 2005-08-24 at 14:42 -0700, David Brownell wrote:
What I'd like to do is have NDP used only in ohci_hub_status()
(e.g. the workaround for those early AMD-756 chips) and have the
rest of the driver reference some field in struct ohci_hcd which
is initialized by OHCI core code -- iff it
Feel like spinning a patch that looks like that?
This email will be followed by a patch along these lines.
Looks pretty decent; thanks. I'll look at it later when I
have some time. Ditto the other patches.
The one thing
I'm unsure of is the point at which you can read the NDP value.
I've been experimenting with the OHCI interface on the Zaurus SL-C3000
(Spitz) and have found a few things I wouldn't mind opinions on.
I'll even correlate them to your questions. :)
Firstly, the NDP register in roothub.a on the PXA270 isn't standard and
the number of ports is really the
On Tue, 2005-08-23 at 12:43 +0200, Bernd Petrovitsch wrote:
Just C-specific ones - God knows what people will pass as argument:
+#ifdef CONFIG_PXA27x
+#define OHCI_GETPORTNUM(x) ((x RH_A_NDP) + 1)
+#define OHCI_GETPORTNUM(x) (((x) RH_A_NDP) + 1)
+#else
+#define OHCI_GETPORTNUM(x)
On Tue, 2005-08-23 at 11:37 +0100, Richard Purdie wrote:
[...]
which corrects this - I'm not sure if this is the right way to do it and
am open to comments.
Just C-specific ones - God knows what people will pass as argument:
+#ifdef CONFIG_PXA27x
+#define OHCI_GETPORTNUM(x) ((x RH_A_NDP)
