[linux-usb-devel] Re: compile error when building multiple EHCI host controllers as modules

2006-03-23 Thread Craig W. Nadler
Kumar, If I understand you correctly you have both an embedded/localbus EHCI core and EHCI on the PCI bus. If this is the case then you could clone ehci-hcd.c and use it as the basis for a driver for the embedded EHCI core. Instead of including ehci-pci.c in the cloned code you would include the p

[linux-usb-devel] Re: compile error when building multiple EHCI host controllers as modules

2006-03-23 Thread Kumar Gala
On Mar 23, 2006, at 7:11 PM, Craig W. Nadler wrote: Kumar, If I understand you correctly you have both an embedded/localbus EHCI core and EHCI on the PCI bus. If this is the case then you could clone ehci-hcd.c and use it as the basis for a driver for the embedded EHCI core. Instead of includi

[linux-usb-devel] Re: compile error when building multiple EHCI host controllers as modules

2006-03-23 Thread Craig W. Nadler
Kumar, This past summer I proposed some restructuring of the EHCI driver to allow for OTG drivers that use EHCI for host mode. It would also handle your situation. Instead of including other *.c files into ehci-hcd.c the C files would be included into the platform specific file. So for example ehc

[linux-usb-devel] Re: compile error when building multiple EHCI host controllers as modules

2006-03-23 Thread Craig W. Nadler
Kumar, I've attached a patch file that demonstrates the changes to the EHCI code that I described. Please note that while the patched code compiles cleanly it is completely untested. Also the text in drivers/usb/host/Kconfig could use some more work. The patch file is for the 2.6.16 kernel. Best

[linux-usb-devel] Re: compile error when building multiple EHCI host controllers as modules

2006-03-28 Thread Matthieu CASTET
Hi, Le Fri, 24 Mar 2006 14:32:57 -0600, Kumar Gala a écrit : > + > +static int __init ehci_hcd_init(void) > +{ > + int retval = 0; > + > + pr_debug("%s: block sizes: qh %Zd qtd %Zd itd %Zd sitd %Zd\n", > + hcd_name, > + sizeof(struct ehci_qh), sizeof(struct ehci