AMPDU stalls with brcmfmac4366b-pcie.bin triggering WARNINGs

Hi, Even with the most recent brcmfmac code ppl keep seeing WARNINGs from brcmf_netdev_wait_pend8021x [0]. Hante suggested using CONSOLE for debugging some firmware crash so I decided to see I it could also help understanding WARNINGs. I believe it did. First of all, I can't reproduce these

[PATCH 2/5] wlcore: sdio: Populate config firmware data

Configure the config firmware names and make it available in platform data. Signed-off-by: Tony Lindgren --- drivers/net/wireless/ti/wlcore/sdio.c | 76 ++- 1 file changed, 47 insertions(+), 29 deletions(-) diff --git

[PATCH 3/5] wlcore: sdio: Populate config firmware data

Configure the config firmware names and make it available in platform data. Let's also fix the order of the struct wilink_family_data while at it. Signed-off-by: Tony Lindgren --- drivers/net/wireless/ti/wlcore/spi.c | 42 1 file changed,

[PATCH 4/5] wlcore: Fix config firmware loading issues

Booting multiple wl12xx and wl18xx devices using the same rootfs is a pain. You currently have to symlink the right nvs file depending on the wl12xx type. For example, with wl1271-nvs.bin being a symlink to wl127x-nvs.bin by default and trying to bring up a wl128x based device: wlcore: ERROR nvs

[PATCH 1/5] wlcore: Prepare family to fix nvs file handling

Move struct wilink_family_data to be available for all TI WLAN variants. And fix familiy typo, it should be just family. Looks like wl12xx use two different nvs.bin files and wl18xx uses a different conf.bin file. Signed-off-by: Tony Lindgren ---

[PATCH 5/5] wlcore: wl18xx: Use chip specific configuration firmware

Use the wl18xx specific config firmware we now have available. Signed-off-by: Tony Lindgren --- drivers/net/wireless/ti/wl18xx/main.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ti/wl18xx/main.c

[PATCH 0/5] Fix wlcore config firwmare annoyances

Hi all, Here are some patches to fix the firmware loading for wl12xx/wl18xx when the same rootfs is used on multiple WLAN chip variants. Regards, Tony Tony Lindgren (5): wlcore: Prepare family to fix nvs file handling wlcore: sdio: Populate config firmware data wlcore: sdio: Populate

[PATCH] ath10k: cache calibration data when the core is stopped.

Caching calibration data allows it to be accessed when the device is not active. Signed-off-by: Marty Faltesek --- drivers/net/wireless/ath/ath10k/core.c | 47 ++ drivers/net/wireless/ath/ath10k/core.h | 2 ++

pull-request: mac80211 2016-09-13

Hi Dave, We found a few more issues, I'm sending you small fixes here. The diffstat would be even shorter, but one of Felix's patches has to move about 30 lines of code, which makes it seem much bigger than it really is. Let me know if there's any problem. Thanks, johannes The following

[PATCH 0/1] Fix problem with rtl8192eu firmware reload

From: Jes Sorensen Hi, This one goes on top of my previous patches, albeit it probably applies out of order. It resolves the issue where firmware wouldn't load correctly if reloading the driver module. Cheers, Jes Jes Sorensen (1): rtl8xxxu: Implment 8192e

[PATCH 1/1] rtl8xxxu: Implement 8192e specific power down sequence

From: Jes Sorensen This powers down the 8192e correctly, or at least to the point where the firmware will load again, when reloading the driver module. Signed-off-by: Jes Sorensen --- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 144

Re: ath10k mesh + ap + encryption?

Hi Simon, On Tue, Sep 13, 2016 at 1:13 PM, Simon Wunderlich wrote: > On Tuesday, September 13, 2016 10:59:31 AM CEST Valo, Kalle wrote: >> Simon Wunderlich writes: >> > we have done some experiments last week on ath10k, trying to run mesh >> >

Re: [PATCH v4] cfg80211: Add support to configure a beacon data rate

Hi, Thanks for the new version. I was going to apply it but while changing something small - see below - found what I think is another issue? > +static int validate_beacon_tx_rate(struct cfg80211_ap_settings > *params) > +{ > + u32 rate, count_ht, count_vht, i; > + enum nl80211_band

[PATCH] cfg80211: allow connect keys only with default (TX) key

From: Johannes Berg There's no point in allowing connect keys when one of them isn't also configured as the TX key, it would just confuse drivers and probably cause them to pick something for TX. Disallow this confusing and erroneous configuration. Signed-off-by:

Re: brcmfmac43430-sdio.bin in linux-firmware

Hi Arend, On Wed, Aug 24, 2016 at 4:22 PM, Arend Van Spriel wrote: > I could, but this is handled by Cypress now. I have asked for firmware > release tag so I can release it. Have you had a chance to release brcmfmac43430-sdio.bin? Thanks!

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

> Yeah so apparently the overhead involved in 256-QAM 5/6 (MCS 9) > results in lower effective bitrate than just using MCS 8 (unless > you're using 3 spatial streams). Ah. I took a - very brief - look at why this one is invalid and couldn't figure it out. > Sounds like a rate control or

Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8

On Mon, 2016-09-12 at 08:43 +0200, Johannes Berg wrote: > On Wed, 2016-09-07 at 18:20 +, Pedersen, Thomas wrote: > > > > On 09/06/2016 12:07 PM, Ben Greear wrote: > > > > > > > > > On 09/06/2016 12:00 PM, Thomas Pedersen wrote: > > > > > > > > > > > > Some drivers (ath10k) report MCS 9 @

Re: ath10k mesh + ap + encryption?

On Tue, 2016-09-13 at 14:30 +0200, Simon Wunderlich wrote: > On Tuesday, September 13, 2016 11:25:21 AM CEST Valo, Kalle wrote: > > > > Simon Wunderlich writes: > > > > > > On Tuesday, September 13, 2016 10:59:31 AM CEST Valo, Kalle > > > wrote: > > > > > > > > Simon

Re: pull-request mwifiex-firmware 2015-09-12

On Mon, Sep 12, 2016 at 12:40:23PM +, Amitkumar Karwar wrote: > The following changes since commit e92f8b3f65443764297b947b1843955d9a65dde7: > > linux-firmware: update Marvell USB8797-B0 firmware image (2015-11-02 > 06:25:05 -0500) > > are available in the git repository at: > >

[PATCH 3/6] nl80211: only allow WEP keys during connect command

From: Johannes Berg This was already documented that way in nl80211.h, but the parsing code still accepted other key types. Change it to really only accept WEP keys as documented. Signed-off-by: Johannes Berg --- net/wireless/nl80211.c | 13

Re: Support of rtl8723bs

On 09/13/2016 02:47 AM, Hanno Zulla wrote: Hi, The issues I am aware of is to start out changing the register access macros into function pointers and stick them all into the fileops structure. Provide a set of SDIO ones to match the USB ones. Then you will need some code to detect the device,

[PATCH 4/6] cfg80211: wext: only allow WEP keys to be configured before connected

From: Johannes Berg When not connected, anything but WEP keys shouldn't be allowed to be configured for later - only static WEP keys make sense at this point. Change wext to reject anything else just like nl80211 does. Signed-off-by: Johannes Berg

[PATCH 5/6] cfg80211: validate key index better

From: Johannes Berg Don't accept it if a key_idx < 0 snuck through, reject WEP keys with key index 4 and 5 (which are used for IGTKs) and don't allow IGTKs with key indices other than 4 and 5. This makes the key data match expectations better. Signed-off-by: Johannes

[PATCH 2/6] nl80211: fix connect keys range check

From: Johannes Berg Only key index 0-3 should be accepted, 4/5 are for IGTKs and cannot be used as connect keys. Fix the range checking to not allow such erroneous configurations. Signed-off-by: Johannes Berg --- net/wireless/nl80211.c | 2 +-

[PATCH 1/6] cfg80211: disallow shared key authentication with key index 4

From: Johannes Berg Key index 4 can only be used for an IGTK, so the range checks for shared key authentication should treat 4 as an error, fix that in the code. Signed-off-by: Johannes Berg --- net/wireless/mlme.c| 2 +-

[PATCH 6/6] cfg80211: reduce connect key caching struct size

From: Johannes Berg After the previous patches, connect keys can only (correctly) be used for storing static WEP keys. Therefore, remove all the data for dealing with key index 4/5 and reduce the size of the key material to the maximum for WEP keys. Signed-off-by:

[PATCH] cfg80211: disallow shared key authentication with key index 4

From: Johannes Berg Key index 4 can only be used for an IGTK, so the range checks for shared key authentication should treat 4 as an error, fix that in the code. Signed-off-by: Johannes Berg --- net/wireless/mlme.c| 2 +-

Re: [PATCH 2/2] ath10k: add platform regulatory domain support

On 12 September 2016 at 17:35, Valo, Kalle wrote: [...] > > +#ifdef CONFIG_ACPI > > +#define WRD_METHOD "WRDD" > > +#define WRDD_WIFI (0x07) > > + > > +static u32 ath10k_mac_wrdd_get_mcc(struct ath10k *ar, union acpi_object > > *wrdd) > > +{ > > I don't think the ifdef

[PATCH] nl80211: validate number of probe response CSA counters

From: Johannes Berg Due to an apparent copy/paste bug, the number of counters for the beacon configuration were checked twice, instead of checking the number of probe response counters. Fix this to check the number of probe response counters before parsing those.

[PATCH] mac80211: remove useless open_count check

From: Johannes Berg __ieee80211_suspend() checks early on if there's anything to do by checking open_count, so there's no need to check again later in the function. Remove the useless check. Signed-off-by: Johannes Berg --- net/mac80211/pm.c |

FW: {SOLVED }RE: Only one of two Intel Wireless 7260 PCI Cards are assigned a logical name (ubuntu 16.04 :: 4.7.0-040700-generic )

From: Merchut, Addison Sent: Tuesday, September 13, 2016 7:51 AM To: 'linuxw...@intel.com' ; 'linux-wireless@vger.kernel.org' Cc: Nudo, Al ; Unetich, Rich ; DeCarlo, Bob Subject:

Re: [PATCH] ath10k: Spelling and miscellaneous neatening

Joe Perches writes: > Correct some trivial comment typos. > Remove unnecessary parentheses in a long line. > Convert a return; before the end of a void function definition to just ; > > Signed-off-by: Joe Perches [...] > ---

Re: ath10k mesh + ap + encryption?

On Tuesday, September 13, 2016 11:25:21 AM CEST Valo, Kalle wrote: > Simon Wunderlich writes: > > On Tuesday, September 13, 2016 10:59:31 AM CEST Valo, Kalle wrote: > >> Simon Wunderlich writes: > >> > we have done some experiments last week on

Re: [3/3] ath10k: Improve logging message.

Ben Greear wrote: > From: Ben Greear > > Helps to know the sta pointer. > > Signed-off-by: Ben Greear Thanks, 1 patch applied to ath-next branch of ath.git: 3040420158c1 ath10k: improve logging message -- Sent by

[ANNOUNCE] netdev 1.2 tokyo weekly update (13th September, 2016)

Hello folks, I hope you're fine and ready to trip to Tokyo. Here is an weekly update of Netdev 1.2 Tokyo. == Keynote talk == We confirmed that David Miller will give a keynote titled "Fast Programmable Networks & Encapsulated Protocols". == Newly accepted sessions == We also accepted one

Re: ath10k: remove unused variable ar_pci

Chaehyun Lim wrote: > Trival fix to remove unused variable ar_pci in ath10k_pci_tx_pipe_cleanup > when building with W=1: > drivers/net/wireless/ath/ath10k/pci.c:1696:21: warning: variable > 'ar_pci' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Chaehyun

Re: ath10k: enable peer stats by default

"Pedersen, Thomas" wrote: > IFTYPE_MESH_POINT need to rely on these for accurate path > selection metrics. Other modes will probably also find > them useful. Enabling peer stats has the side effect of > reducing max number of STAs from 128 to 118. There should > be

Re: [V2] ath10k: fix memory leak on caldata on error exit path

Colin Ian King wrote: > From: Colin Ian King > > caldata is not being free'd on the error exit path, causing > a memory leak and data definitely should not be freed. Free > caldata instead of data. > > Thanks to Kalle Valo for spotting that

FW: Only one of two Intel Wireless 7260 PCI Cards are assigned a logical name (ubuntu 16.04 :: 4.7.0-040700-generic )

From: Merchut, Addison Sent: Monday, September 12, 2016 3:21 PM To: 'linuxw...@intel.com' ; 'linux-wireless@vger.kernel.org' Cc: Nudo, Al ; Unetich, Rich ; DeCarlo, Bob Subject:

Re: ath10k mesh + ap + encryption?

Am 13.09.2016 um 13:25 schrieb Valo, Kalle: Simon Wunderlich writes: On Tuesday, September 13, 2016 10:59:31 AM CEST Valo, Kalle wrote: Simon Wunderlich writes: we have done some experiments last week on ath10k, trying to run mesh (802.11s)

Re: ath10k mesh + ap + encryption?

Simon Wunderlich writes: > On Tuesday, September 13, 2016 10:59:31 AM CEST Valo, Kalle wrote: >> Simon Wunderlich writes: >> > we have done some experiments last week on ath10k, trying to run mesh >> > (802.11s) and access point at the same

Re: ath10k mesh + ap + encryption?

On Tuesday, September 13, 2016 10:59:31 AM CEST Valo, Kalle wrote: > Simon Wunderlich writes: > > we have done some experiments last week on ath10k, trying to run mesh > > (802.11s) and access point at the same time, both encrypted. > > > > We have tested a recent LEDE

Re: ath10k mesh + ap + encryption?

Simon Wunderlich writes: > we have done some experiments last week on ath10k, trying to run mesh > (802.11s) and access point at the same time, both encrypted. > > We have tested a recent LEDE (reboot-1519-g42f559e) but with > firmware-5.bin_10.2.4.70.42-2 and the

[PATCH v4] cfg80211: Add support to configure a beacon data rate

This allows an option to configure a single beacon tx rate (u8) for an AP. Signed-off-by: Purushottam Kushwaha --- include/net/cfg80211.h | 25 +-- net/wireless/nl80211.c | 504 +++-- 2 files changed, 296 insertions(+), 233

RE: [PATCH v3] cfg80211: Add support to configure a beacon data rate

Hi Johannes, > All of these just move around, right? Yes, just moved around. > I think it would be good to split out this "single rate" thing into a helper > function. sure, will raise a new patchset with this change. Thanks, Purushottam

ath10k mesh + ap + encryption?

Hi, we have done some experiments last week on ath10k, trying to run mesh (802.11s) and access point at the same time, both encrypted. We have tested a recent LEDE (reboot-1519-g42f559e) but with firmware-5.bin_10.2.4.70.42-2 and the included wpa_supplicant, which gave us a working encrypted

Re: Support of rtl8723bs

Hi, > The issues I am aware of is to start out changing the register access > macros into function pointers and stick them all into the fileops > structure. Provide a set of SDIO ones to match the USB ones. Then you > will need some code to detect the device, as that part will obviously be >

Re: [PATCH v6 1/3] Documentation: dt: net: add ath9k wireless device binding

Am 09.09.2016 um 22:57 schrieb Martin Blumenstingl: > On Fri, Sep 9, 2016 at 9:48 AM, Oleksij Rempel wrote: >>> +Optional properties: >>> +- reg: Address and length of the register set for the device. >>> +- qca,clk-25mhz: Defines that a 25MHz clock is used >> >> Some SoCs

Re: [PATCH v3] mac80211: Re-structure aqm debugfs output and keep CoDel stats per txq

On Mon, 2016-09-12 at 15:55 +0200, Toke Høiland-Jørgensen wrote: > Currently the 'aqm' stats in mac80211 only keeps overlimit drop > stats, > not CoDel stats. This moves the CoDel stats into the txqi structure > to > keep them per txq in order to show them in debugfs. > > In addition, the aqm

[PATCH] mac80211: simplify TDLS RA lookup

From: Johannes Berg smatch pointed out that the second check of "tdls_auth" was pointless since if it was true, we returned from the function already. We can further simplify the code by moving the first check (if it's a TDLS peer at all) into the outer if, to only