Re: [PATCH 08/16] wireless: Replace spin_is_locked() with lockdep

2018-10-03 Thread Lance Roy
On Wed, Oct 03, 2018 at 12:06:48PM +0300, Kalle Valo wrote: > Lance Roy writes: > > > lockdep_assert_held() is better suited to checking locking requirements, > > since it won't get confused when someone else holds the lock. This is > > also a step towards possibly removing spin_is_locked(). > > >

Re: pull request: mt76 2018-10-01

2018-10-03 Thread Kalle Valo
Felix Fietkau writes: > Here's another large batch of mt76 code cleanup / deduplication / fixes > > - Felix > > The following changes since commit 93ed990e3a6e722b7b1e1d59b3ceb8d91e36e682: > > qtnfmac: remove set but not used variable 'vif' (2018-09-20 15:12:13 +0300) > > are available in the G

[PATCH] mac80211: support FTM responder configuration/statistics

2018-10-03 Thread Pradeep Kumar Chitrapu
New bss param ftm_responder is used to notify the driver to enable fine timing request (FTM) responder role in AP mode. Plumb the new cfg80211 API for FTM responder statistics through to the driver API in mac80211. Signed-off-by: David Spinadel Signed-off-by: Johannes Berg Signed-off-by: Pradee

Re: Tool to debug wifi pkt sniffs?

2018-10-03 Thread Dave Taht
On Wed, Oct 3, 2018 at 1:16 PM Toke Høiland-Jørgensen wrote: > > Ben Greear writes: > > > Hello, > > > > I often find myself wanting to figure out what equipment is to blame (and > > why) > > in a wifi environment. > > > > I am thinking writing a tool that would parse a pcap file and look at fra

Re: [PATCH] ssb: chipcommon: fix fall-through annotation

2018-10-03 Thread Michael Büsch
On Wed, 3 Oct 2018 14:01:02 +0200 "Gustavo A. R. Silva" wrote: > Replace "Fallthough" with a proper "fall through" annotation. > > This fix is part of the ongoing efforts to enabling > -Wimplicit-fallthrough > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/ssb/driver_chipcommon.c | 2 +-

Re: Tool to debug wifi pkt sniffs?

2018-10-03 Thread Toke Høiland-Jørgensen
Ben Greear writes: > Hello, > > I often find myself wanting to figure out what equipment is to blame (and why) > in a wifi environment. > > I am thinking writing a tool that would parse a pcap file and look at frames > in enough detail to flag block-ack bugs, rate-ctrl bugs, guess at the > sniff

Tool to debug wifi pkt sniffs?

2018-10-03 Thread Ben Greear
Hello, I often find myself wanting to figure out what equipment is to blame (and why) in a wifi environment. I am thinking writing a tool that would parse a pcap file and look at frames in enough detail to flag block-ack bugs, rate-ctrl bugs, guess at the sniffer's capture ability, etc. Does an

[PATCHi v2] rtw88: Add firmware file for new driver

2018-10-03 Thread Larry Finger
This file contains the firmware for the new driver rtw88 for Realtek RTL8822BE and RTL8822CE devices. It was provided by the Realtek developer. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger --- v2 - removed redundant information from subject --- WHENCE| 9 ++

[PATCH] rtw88: Add firmware file for driver rtw88

2018-10-03 Thread Larry Finger
This file contains the firmware for the new driver rtw88 for Realtek RTL8822BE and RTL8822CE devices. It was provided by the Realtek developer. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Larry Finger --- WHENCE| 9 + rtw88/rtw8822b_fw.bin | Bin 0 -> 150984 bytes 2

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Marcel Holtmann
Hi Kai-Heng, >> I think Canonical were facing some wifi fw load error from some 8260 >> earlier module during the BT still loading the fw. >> I believe we had later 8260 sku that fixed this issue. > > But there are already 8260 that is affected by this bug in the wild. > > Search "Bluetooth: hci

Re: [RFC v2 00/12] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips

2018-10-03 Thread Larry Finger
On 10/3/18 11:57 AM, Sid Hayn wrote: On Wed, Oct 3, 2018 at 12:52 PM Larry Finger wrote: On 10/3/18 11:15 AM, Sid Hayn wrote: Is there a public repository where I can track development for this driver? For the moment, this is it. Once the driver is accepted into the wireless-drivers-next tr

Re: [RFC v2 00/12] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips

2018-10-03 Thread Sid Hayn
On Wed, Oct 3, 2018 at 12:52 PM Larry Finger wrote: > > On 10/3/18 11:15 AM, Sid Hayn wrote: > > Is there a public repository where I can track development for this driver? > > For the moment, this is it. Once the driver is accepted into the > wireless-drivers-next tree, I will create a new rtw88

Re: [RFC v2 00/12] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips

2018-10-03 Thread Larry Finger
On 10/3/18 11:15 AM, Sid Hayn wrote: Is there a public repository where I can track development for this driver? For the moment, this is it. Once the driver is accepted into the wireless-drivers-next tree, I will create a new rtw88 branch in http://github.com/lwfinger.git with this driver to

[PATCH v4] brcmsmac: AP mode: update beacon when TIM changes

2018-10-03 Thread Ali MJ Al-Nasrawy
Beacons are not updated to reflect TIM changes. This is not compliant with power-saving client stations as the beacons do not have valid TIM and can cause the network to stall at random occasions and to have highly variable latencies. Fix it by updating beacon templates on mac80211 set_tim callback

Re: [RFC v2 00/12] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips

2018-10-03 Thread Sid Hayn
Is there a public repository where I can track development for this driver? Thanks, Zero On Wed, Oct 3, 2018 at 4:04 AM wrote: > > From: Yan-Hsuan Chuang > > This is a new mac80211 driver for Realtek 802.11ac wireless network chips. > rtwlan supports 8822BE and 8822CE chips, and will be able to

Re: new mt76 usb crashes on device removal

2018-10-03 Thread Lorenzo Bianconi
> > On Wed, Oct 03, 2018 at 04:09:06PM +0200, Lorenzo Bianconi wrote: > > > It still crashes. You can not reproduce the problem ? > > > It's 100% reproducible for me, when I unplug mt76x0u or mt76x2 device. > > > > Hi Stanislaw, > > > > any news about the latest patchset I sent to fix that issue? >

Re: new mt76 usb crashes on device removal

2018-10-03 Thread Stanislaw Gruszka
On Wed, Oct 03, 2018 at 04:09:06PM +0200, Lorenzo Bianconi wrote: > > It still crashes. You can not reproduce the problem ? > > It's 100% reproducible for me, when I unplug mt76x0u or mt76x2 device. > > Hi Stanislaw, > > any news about the latest patchset I sent to fix that issue? It fixed the p

Re: new mt76 usb crashes on device removal

2018-10-03 Thread Lorenzo Bianconi
> On Wed, Oct 03, 2018 at 11:15:37AM +0200, Lorenzo Bianconi wrote: > > > After > > > > > > b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to > > > mt76x0_alloc_device signature" > > > > > > I have new crashs when remove mt76x0u and mt76x2u devices. > > > I can not provide calltrace becaus

[PATCH] net: wireless: iwlegacy: Fix possible data races in il4965_send_rxon_assoc()

2018-10-03 Thread Jia-Ju Bai
CPU0: il4965_configure_filter mutex_lock() line 6183: il->staging.filter_flags &= ... [WRITE] line 6184: il->staging.filter_flags |= ... [WRITE] CPU1: il4965_send_rxon_assoc line 1301: rxon1->filter_flags, rxon1->filter_flags [READ] line 1314: il->staging.fi

Re: [PATCH 06/10] mt76x2: move mt76x2_dev in mt76x02_util.h

2018-10-03 Thread Stanislaw Gruszka
On Wed, Oct 03, 2018 at 03:51:32PM +0200, Felix Fietkau wrote: > >> > } > >> > > >> > put them into mt76xN_dev and still remove dupicated code ? > >> Quite often, mt76_dev would be needed as well for register access, which > >> means extra parameters for a lot of functions. > >> I think Lorenzo’s

Re: [PATCH 06/10] mt76x2: move mt76x2_dev in mt76x02_util.h

2018-10-03 Thread Felix Fietkau
On 2018-10-03 15:32, Stanislaw Gruszka wrote: > On Wed, Oct 03, 2018 at 01:49:23PM +0200, Felix Fietkau wrote: >> >> >> > On 3. Oct 2018, at 13:12, Stanislaw Gruszka wrote: >> > >> > On Wed, Oct 03, 2018 at 01:01:40PM +0200, Lorenzo Bianconi wrote: >> >>> >> >>> On Tue, Oct 02, 2018 at 12:19:0

Re: [PATCH 06/10] mt76x2: move mt76x2_dev in mt76x02_util.h

2018-10-03 Thread Stanislaw Gruszka
On Wed, Oct 03, 2018 at 01:49:23PM +0200, Felix Fietkau wrote: > > > > On 3. Oct 2018, at 13:12, Stanislaw Gruszka wrote: > > > > On Wed, Oct 03, 2018 at 01:01:40PM +0200, Lorenzo Bianconi wrote: > >>> > >>> On Tue, Oct 02, 2018 at 12:19:04AM +0200, Lorenzo Bianconi wrote: > Move mt76x2_d

[PATCH] ssb: chipcommon: fix fall-through annotation

2018-10-03 Thread Gustavo A. R. Silva
Replace "Fallthough" with a proper "fall through" annotation. This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough Signed-off-by: Gustavo A. R. Silva --- drivers/ssb/driver_chipcommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ssb/driver_

Re: [PATCH 06/10] mt76x2: move mt76x2_dev in mt76x02_util.h

2018-10-03 Thread Felix Fietkau
> On 3. Oct 2018, at 13:12, Stanislaw Gruszka wrote: > > On Wed, Oct 03, 2018 at 01:01:40PM +0200, Lorenzo Bianconi wrote: >>> >>> On Tue, Oct 02, 2018 at 12:19:04AM +0200, Lorenzo Bianconi wrote: Move mt76x2_dev in mt76x02_util.h and rename it in mt76x02_dev in order to be shared b

[RFC v3 09/12] rtw88: chip files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang chip files Realtek 802.11ac wireless network chips 8822B & 8822C series files Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 1593 drivers/net/wireless/realtek/rtw88/rtw8822b.h | 271 .../net/wirel

[RFC v3 08/12] rtw88: debug files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang debug files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/debug.c | 652 + drivers/net/wireless/realtek/rtw88/debug.h | 45 ++ 2 files changed, 697 insertions(+) create mod

[RFC v3 03/12] rtw88: hci files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang hci files for Realtek 802.11ac wireless network chips For now there is only PCI bus supported by rtwlan, in the future it will also have USB/SDIO Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/hci.h | 212 ++ drivers/net/wireless/realtek/rtw

[RFC v3 04/12] rtw88: trx files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang trx files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/rx.c | 144 + drivers/net/wireless/realtek/rtw88/rx.h | 30 drivers/net/wireless/realtek/rtw88/tx.c | 271 ++

[RFC v3 00/12] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang This is a new mac80211 driver for Realtek 802.11ac wireless network chips. rtwlan supports 8822BE and 8822CE chips, and will be able to support multi-vif combinations in run-time. For now, only PCI bus is supported, but rtwlan was originally designed to optionally support

[RFC v3 05/12] rtw88: mac files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang mac files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/mac.c | 1045 ++ drivers/net/wireless/realtek/rtw88/mac.h | 35 + 2 files changed, 1080 insertions(+) create mode 1

[RFC v3 02/12] rtw88: core files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang core files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/ps.c | 198 + drivers/net/wireless/realtek/rtw88/ps.h | 21 ++ drivers/net/wireless/realtek/rtw88/regd.c | 462 +

[RFC v3 11/12] rtw88: 8822C init table

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang 8822C init table for chip files Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- .../net/wireless/realtek/rtw88/rtw8822c_table.c| 4150 1 file changed, 4150 insertions(+) create mode 100644 drivers/net/wireless/realtek

[RFC v3 01/12] rtw88: main files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang main files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/mac80211.c | 482 ++ drivers/net/wireless/realtek/rtw88/main.c | 1133 +++ drivers/net/wireless/realtek/rtw88/ma

[RFC v3 12/12] rtw88: Kconfig & Makefile

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang Kconfig & Makefile for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/Kconfig| 1 + drivers/net/wireless/realtek/Makefile | 1 + drivers/net/wireless/realtek/rtw88/Kconfig | 57 +++

[RFC v3 07/12] rtw88: phy files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang phy files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/phy.c | 1675 ++ drivers/net/wireless/realtek/rtw88/phy.h | 125 +++ 2 files changed, 1800 insertions(+) create mode

[RFC v3 06/12] rtw88: fw and efuse files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang fw and efuse files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/efuse.c | 150 +++ drivers/net/wireless/realtek/rtw88/efuse.h | 53 +++ drivers/net/wireless/realtek/rtw88/fw.c| 638 +++

Re: [PATCH 06/10] mt76x2: move mt76x2_dev in mt76x02_util.h

2018-10-03 Thread Stanislaw Gruszka
On Wed, Oct 03, 2018 at 01:01:40PM +0200, Lorenzo Bianconi wrote: > > > > On Tue, Oct 02, 2018 at 12:19:04AM +0200, Lorenzo Bianconi wrote: > > > Move mt76x2_dev in mt76x02_util.h and rename it in mt76x02_dev > > > in order to be shared between mt76x2 and mt76x0 driver > > > > > +struct mt76x02_de

Re: [PATCH 06/10] mt76x2: move mt76x2_dev in mt76x02_util.h

2018-10-03 Thread Lorenzo Bianconi
> > On Tue, Oct 02, 2018 at 12:19:04AM +0200, Lorenzo Bianconi wrote: > > Move mt76x2_dev in mt76x02_util.h and rename it in mt76x02_dev > > in order to be shared between mt76x2 and mt76x0 driver > > > +struct mt76x02_dev { > > + struct mt76_dev mt76; /* must be first */ > > + > > + struct

[PATCH] ath10k: Fill the channel survey results for WCN3990 correctly

2018-10-03 Thread Rakesh Pillai
The host driver currently expects the channel info event to be received in pairs for all the channels, i.e. the first chan_info event for a particular channel will not have the COMPLETE flag set and the second chan_info event for the same channel will have the COMPLETE flag set. The HL2.0 firmware

[PATCH 3/3] mt76x0: usb: stop cal/mac workqueues at hw stop

2018-10-03 Thread Lorenzo Bianconi
Stop mac and calibration work stopping the hw even if the device has been removed Fixes: b11e19694dc9 ("mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device signature") Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x0/usb.c | 6 +++--- 1 file changed, 3 inse

[PATCH 0/3] fix mt76x0u driver hw stop sequence

2018-10-03 Thread Lorenzo Bianconi
Fix two issue introduced in mt76x0u driver with latest rework to share hw initialization between mt760 and mt76x2 drivers Lorenzo Bianconi (2): mt76: usb: fix hw initialization sequence mt76x0: usb: stop cal/mac workqueues at hw stop Stanislaw Gruszka (1): mt76: fix frag length allocation f

[PATCH 1/3] mt76: fix frag length allocation for usb

2018-10-03 Thread Lorenzo Bianconi
From: Stanislaw Gruszka This is correct fix for c12128ce44b0 ("mt76: use a per rx queue page fragment cache"). We use wrong length when we allocate segments for MCU transmissions, which require bigger segment size than e->buf_size. Commit 481bb0432414 ("mt76: usb: make rx page_frag_cache access

[PATCH 2/3] mt76: usb: fix hw initialization sequence

2018-10-03 Thread Lorenzo Bianconi
mt76u_alloc_queues need to be called before mt76u_mcu_init_rx since it initializes rx_page_lock spinlock used in mt76u_buf_alloc routine. Fixes: b11e19694dc9 ("mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device signature") Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/

Re: [RFC 2/2] mt76: make frag_cache global per cpu structure

2018-10-03 Thread Felix Fietkau
> On 3. Oct 2018, at 11:17, Stanislaw Gruszka wrote: > > Make mt76 frag cache similar to netdev frag cache. This should > make frag allocation safe regarding concurrent access and also > be more efficient since we will use pages that most likely are > hot on particular cpu. > > And we don't ne

Re: [PATCH 06/10] mt76x2: move mt76x2_dev in mt76x02_util.h

2018-10-03 Thread Stanislaw Gruszka
On Tue, Oct 02, 2018 at 12:19:04AM +0200, Lorenzo Bianconi wrote: > Move mt76x2_dev in mt76x02_util.h and rename it in mt76x02_dev > in order to be shared between mt76x2 and mt76x0 driver > +struct mt76x02_dev { > + struct mt76_dev mt76; /* must be first */ > + > + struct mac_address macad

Re: new mt76 usb crashes on device removal

2018-10-03 Thread Lorenzo Bianconi
On Oct 03, Stanislaw Gruszka wrote: > On Wed, Oct 03, 2018 at 11:15:37AM +0200, Lorenzo Bianconi wrote: > > > After > > > > > > b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to > > > mt76x0_alloc_device signature" > > > > > > I have new crashs when remove mt76x0u and mt76x2u devices. > >

Re: [PATCH] mt76: fix frag length allocation for usb

2018-10-03 Thread Lorenzo Bianconi
> > > > Hi Stanislaw, > > > > I agree that we should use len in page_frag_alloc() instead of q->buf_size, > > so > > > > Acked-by: Lorenzo Bianconi > > > > but reviewing the code I guess the real issue is not q->buf_size (since it > > should > > be bigger than MCU_RESP_URB_SIZE) but it is th

Re: new mt76 usb crashes on device removal

2018-10-03 Thread Stanislaw Gruszka
On Wed, Oct 03, 2018 at 11:15:37AM +0200, Lorenzo Bianconi wrote: > > After > > > > b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device > > signature" > > > > I have new crashs when remove mt76x0u and mt76x2u devices. > > I can not provide calltrace because some other war

Re: [RFC 2/2] mt76: make frag_cache global per cpu structure

2018-10-03 Thread Stanislaw Gruszka
On Wed, Oct 03, 2018 at 11:38:54AM +0200, Lorenzo Bianconi wrote: > > +static DEFINE_PER_CPU(struct page_frag_cache, mt76_frag_cache); > > + > > +void *mt76_alloc_frag(unsigned int fragsz) > > +{ > > + struct page_frag_cache *fc; > > + unsigned long flags; > > + void *data; > > + > > + loca

Re: [PATCH] mt76: fix frag length allocation for usb

2018-10-03 Thread Stanislaw Gruszka
On Wed, Oct 03, 2018 at 11:12:07AM +0200, Lorenzo Bianconi wrote: > > This is correct fix for c12128ce44b0 ("mt76: use a per rx queue page > > fragment cache"). We use wrong length when we allocate segments for > > MCU transmissions, which require bigger segment size than e->buf_size. > > > > Comm

Re: [RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Kalle Valo
+ linux-bluetooth "Grumbach, Emmanuel" writes: >> >> > On Oct 3, 2018, at 5:10 PM, Kalle Valo wrote: >> > >> > Kai-Heng Feng writes: >> > >> >> To avoid the firmware loading race between Bluetooth and WiFi on >> >> Intel 8260, load firmware exclusively when BT_INTEL is enabled. >> >> >> >> Si

RE: [RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Grumbach, Emmanuel
> > > On Oct 3, 2018, at 5:10 PM, Kalle Valo wrote: > > > > Kai-Heng Feng writes: > > > >> To avoid the firmware loading race between Bluetooth and WiFi on > >> Intel 8260, load firmware exclusively when BT_INTEL is enabled. > >> > >> Signed-off-by: Kai-Heng Feng > > > > Still the commit log te

Re: [RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Kalle Valo
Kalle Valo writes: > Kai Heng Feng writes: > >>> On Oct 3, 2018, at 5:10 PM, Kalle Valo wrote: >>> >>> Kai-Heng Feng writes: >>> To avoid the firmware loading race between Bluetooth and WiFi on Intel 8260, load firmware exclusively when BT_INTEL is enabled. Signed-off-by

Re: [RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Kalle Valo
Kai Heng Feng writes: >> On Oct 3, 2018, at 5:10 PM, Kalle Valo wrote: >> >> Kai-Heng Feng writes: >> >>> To avoid the firmware loading race between Bluetooth and WiFi on Intel >>> 8260, load firmware exclusively when BT_INTEL is enabled. >>> >>> Signed-off-by: Kai-Heng Feng >> >> Still th

Re: [RFC 2/2] mt76: make frag_cache global per cpu structure

2018-10-03 Thread Lorenzo Bianconi
> +static DEFINE_PER_CPU(struct page_frag_cache, mt76_frag_cache); > + > +void *mt76_alloc_frag(unsigned int fragsz) > +{ > + struct page_frag_cache *fc; > + unsigned long flags; > + void *data; > + > + local_irq_save(flags); I like this approach since we will avoid a cache miss fo

Re: [RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Kai Heng Feng
> On Oct 3, 2018, at 5:10 PM, Kalle Valo wrote: > > Kai-Heng Feng writes: > >> To avoid the firmware loading race between Bluetooth and WiFi on Intel >> 8260, load firmware exclusively when BT_INTEL is enabled. >> >> Signed-off-by: Kai-Heng Feng > > Still the commit log tells nothing abou

[RFC 2/2] mt76: make frag_cache global per cpu structure

2018-10-03 Thread Stanislaw Gruszka
Make mt76 frag cache similar to netdev frag cache. This should make frag allocation safe regarding concurrent access and also be more efficient since we will use pages that most likely are hot on particular cpu. And we don't need to clean up the cache up during device removal. Signed-off-by: Stan

[RFC 1/2] mt76: remove rx_page_lock

2018-10-03 Thread Stanislaw Gruszka
Extra serializaion for protecting q->rx_page is not needed, we stop rx_tasklet before we nulify it in mt76u_free_rx(). Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/mediatek/mt76/mt76.h | 1 - drivers/net/wireless/mediatek/mt76/usb.c | 8 +--- 2 files changed, 1 insertion(+), 8

Re: new mt76 usb crashes on device removal

2018-10-03 Thread Lorenzo Bianconi
> After > > b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device > signature" > > I have new crashs when remove mt76x0u and mt76x2u devices. > I can not provide calltrace because some other warning/traces > show up instantly after the problem happen and mask prints > for i

Re: [PATCH] mt76: fix frag length allocation for usb

2018-10-03 Thread Lorenzo Bianconi
> This is correct fix for c12128ce44b0 ("mt76: use a per rx queue page > fragment cache"). We use wrong length when we allocate segments for > MCU transmissions, which require bigger segment size than e->buf_size. > > Commit 481bb0432414 ("mt76: usb: make rx page_frag_cache access atomic") > parti

Re: [RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Kalle Valo
Kai-Heng Feng writes: > To avoid the firmware loading race between Bluetooth and WiFi on Intel > 8260, load firmware exclusively when BT_INTEL is enabled. > > Signed-off-by: Kai-Heng Feng Still the commit log tells nothing about the actual problem which makes review impossible. -- Kalle Valo

Re: [PATCH v2] ath10k: Add support for configuring management packet rate

2018-10-03 Thread Kalle Valo
Sriram R writes: > On 2018-10-01 20:18, Kalle Valo wrote: >> Sriram R wrote: >> >>> By default the firmware uses 1Mbps and 6Mbps rate for management >>> packets >>> in 2G and 5G bands respectively. But when the user selects different >>> basic rates from the userspace, we need to send the manage

Re: [PATCH 08/16] wireless: Replace spin_is_locked() with lockdep

2018-10-03 Thread Kalle Valo
Lance Roy writes: > lockdep_assert_held() is better suited to checking locking requirements, > since it won't get confused when someone else holds the lock. This is > also a step towards possibly removing spin_is_locked(). > > Signed-off-by: Lance Roy > Cc: Daniel Drake > Cc: Ulrich Kunitz > C

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Kalle Valo
Luciano Coelho writes: >> +#if IS_ENABLED(CONFIG_BT_INTEL) >> +if (firmware_unlock_func) { >> +firmware_unlock_func(); >> +symbol_put(btintel_firmware_lock); >> +firmware_lock_func = NULL; >> +symbol_put(b

Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-03 Thread Toke Høiland-Jørgensen
Rajkumar Manoharan writes: > On 2018-10-02 16:07, Rajkumar Manoharan wrote: >> On 2018-10-02 12:00, Toke Høiland-Jørgensen wrote: >>> Rajkumar Manoharan writes: I noticed a race condition b/w sta cleanup and kick_airtime tasklet. >> How do you plan to exit kick_airtime gracefully during

new mt76 usb crashes on device removal

2018-10-03 Thread Stanislaw Gruszka
After b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device signature" I have new crashs when remove mt76x0u and mt76x2u devices. I can not provide calltrace because some other warning/traces show up instantly after the problem happen and mask prints for initall problem. Th

[PATCH] mt76: fix frag length allocation for usb

2018-10-03 Thread Stanislaw Gruszka
This is correct fix for c12128ce44b0 ("mt76: use a per rx queue page fragment cache"). We use wrong length when we allocate segments for MCU transmissions, which require bigger segment size than e->buf_size. Commit 481bb0432414 ("mt76: usb: make rx page_frag_cache access atomic") partially solved

[RFC v2 12/12] rtw88: Kconfig & Makefile

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang Kconfig & Makefile for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/Kconfig| 1 + drivers/net/wireless/realtek/Makefile | 1 + drivers/net/wireless/realtek/rtw88/Kconfig | 57 +++

[RFC v2 05/12] rtw88: mac files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang mac files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/mac.c | 1045 ++ drivers/net/wireless/realtek/rtw88/mac.h | 35 + 2 files changed, 1080 insertions(+) create mode 1

[RFC v2 11/12] rtw88: 8822C init table

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang 8822C init table for chip files Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- .../net/wireless/realtek/rtw88/rtw8822c_table.c| 4150 1 file changed, 4150 insertions(+) create mode 100644 drivers/net/wireless/realtek

[RFC v2 06/12] rtw88: fw and efuse files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang fw and efuse files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/efuse.c | 150 +++ drivers/net/wireless/realtek/rtw88/efuse.h | 53 +++ drivers/net/wireless/realtek/rtw88/fw.c| 638 +++

[RFC v2 01/12] rtw88: main files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang main files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/mac80211.c | 482 ++ drivers/net/wireless/realtek/rtw88/main.c | 1133 +++ drivers/net/wireless/realtek/rtw88/ma

[RFC v2 03/12] rtw88: hci files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang hci files for Realtek 802.11ac wireless network chips For now there is only PCI bus supported by rtwlan, in the future it will also have USB/SDIO Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/hci.h | 212 ++ drivers/net/wireless/realtek/rtw

[RFC v2 04/12] rtw88: trx files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang trx files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/rx.c | 144 + drivers/net/wireless/realtek/rtw88/rx.h | 30 drivers/net/wireless/realtek/rtw88/tx.c | 271 ++

[RFC v2 08/12] rtw88: debug files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang debug files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/debug.c | 652 + drivers/net/wireless/realtek/rtw88/debug.h | 45 ++ 2 files changed, 697 insertions(+) create mod

[RFC v2 00/12] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang This is a new mac80211 driver for Realtek 802.11ac wireless network chips. rtwlan supports 8822BE and 8822CE chips, and will be able to support multi-vif combinations in run-time. For now, only PCI bus is supported, but rtwlan was originally designed to optionally support

[RFC v2 07/12] rtw88: phy files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang phy files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/phy.c | 1675 ++ drivers/net/wireless/realtek/rtw88/phy.h | 125 +++ 2 files changed, 1800 insertions(+) create mode

[RFC v2 09/12] rtw88: chip files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang chip files Realtek 802.11ac wireless network chips 8822B & 8822C series files Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 1593 drivers/net/wireless/realtek/rtw88/rtw8822b.h | 271 .../net/wirel

[RFC v2 02/12] rtw88: core files

2018-10-03 Thread yhchuang
From: Yan-Hsuan Chuang core files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/ps.c | 198 + drivers/net/wireless/realtek/rtw88/ps.h | 21 ++ drivers/net/wireless/realtek/rtw88/regd.c | 462 +

[RFC 7/9] mt76: move tx_tasklet management in mt76x02-lib moudle

2018-10-03 Thread Lorenzo Bianconi
Move tx_tasklet management in mt76x02_mmio.c in order to be reused by mt76x0 driver and remove duplicated code Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/mt76/mt76x0/pci.c | 2 +- .../net/wireless/mediatek/mt76/mt76x02_dma.h | 1 + .../net/wireless/mediatek/mt76/mt76x02_m

[RFC 9/9] mt76x0: pci: add mt76x0_register_device in mt76x0e_register_device

2018-10-03 Thread Lorenzo Bianconi
Run mt76x0_register_device routine in mt76x0e_register_device in order to register the device to the mac80211 layer. Moreover init mt76_driver_ops data structure and register interrupt line Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/mt76/mt76x0/pci.c | 20 ++-

[RFC 8/9] mt76: move irq handler in mt76x02-lib moudle

2018-10-03 Thread Lorenzo Bianconi
Move mt76x02_irq_handler handler in mt76x02_mmio.c in order to be reused in mt76x0 driver. Move mt76x02_rx_poll_complete routine in mt76x02-lib module. Moreover remove pci_core.c and mt76x2/trace.{c,h} since are empty files Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/m

[RFC 5/9] mt76: move mt76x02_tx_complete in mt76x02-lib module

2018-10-03 Thread Lorenzo Bianconi
Move mt76x02_tx_complete mt76x02-lib module in order to be reused by mt76x0 drivers for irq unification. Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/mt76/mt76x02_mac.c | 29 +++ .../net/wireless/mediatek/mt76/mt76x02_mac.h | 19 .../wireless/media

[RFC 6/9] mt76: use mt76x02_dev instead of mt76_dev in mt76x02_mmio.c

2018-10-03 Thread Lorenzo Bianconi
Use mt76x02_dev data structure as reference in mt76x02_mmio.c instead of mt76_dev Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76.h | 4 +- .../net/wireless/mediatek/mt76/mt76x0/pci.c | 6 +- drivers/net/wireless/mediatek/mt76/mt76x02.h | 8 +-- .../net/wire

[RFC 2/9] mt76: move mt76x02_tx_prepare_skb in mt76x02_txrx.c

2018-10-03 Thread Lorenzo Bianconi
Move mt76x02_tx_prepare_skb routine in mt76x02-lib module in order to be reused by mt76x0 driver in tx datapath Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x02.h | 4 +++ .../net/wireless/mediatek/mt76/mt76x02_txrx.c | 32 +++ .../wireless/mediate

[RFC 3/9] mt76: usb: move mt76x02u_tx_complete_skb in mt76x02_usb_core.c

2018-10-03 Thread Lorenzo Bianconi
Move mt76x02u_tx_complete_skb and mt76x02u_remove_dma_hdr since they are used just by usb code Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/mt76/mt76x0/usb.c| 2 +- drivers/net/wireless/mediatek/mt76/mt76x02.h | 2 -- .../net/wireless/mediatek/mt76/mt76x02_txrx.c | 18 -

[RFC 1/9] mt76: move tpc routines in mt76x02-lib module

2018-10-03 Thread Lorenzo Bianconi
Move mt76x02_tx_get_txpwr_adj and mt76x02_tx_set_txpwr_auto routines in mt76x02-lib module since they are shared between mt76x0 and mt76x2 drivers. Moreover remove get_txpwr_adj function pointer Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76.h | 2 - drivers/net

[RFC 4/9] mt76: move mt76x02_mac_poll_tx_status in mt76x02-lib moudle

2018-10-03 Thread Lorenzo Bianconi
Move mt76x02_mac_poll_tx_status in mt76x02_mac.c in order to be reused by mt76x0 drivers for irq unification. Moreover introduce mt76x02_trace source file to define mt76x02 trace points Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/Makefile | 3 +- .../net/wireless/me

[RFC 0/9] unify rx datapath between mt76x0 and mt76x2 drivers

2018-10-03 Thread Lorenzo Bianconi
Move mt76x02_irq_handler irq handler in mt76x02-lib module in order to unify rx datapath between mt76x0 and mt76x2 drivers and remove duplicated code Lorenzo Bianconi (9): mt76: move tpc routines in mt76x02-lib module mt76: move mt76x02_tx_prepare_skb in mt76x02_txrx.c mt76: usb: move mt76x0

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Kai Heng Feng
> On Oct 3, 2018, at 3:29 PM, Matt Chen wrote: > > I think Canonical were facing some wifi fw load error from some 8260 > earlier module during the BT still loading the fw. > I believe we had later 8260 sku that fixed this issue. But there are already 8260 that is affected by this bug in the

[RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Kai-Heng Feng
To avoid the firmware loading race between Bluetooth and WiFi on Intel 8260, load firmware exclusively when BT_INTEL is enabled. Signed-off-by: Kai-Heng Feng --- .../net/wireless/intel/iwlwifi/pcie/trans.c | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Matt Chen
I think Canonical were facing some wifi fw load error from some 8260 earlier module during the BT still loading the fw. I believe we had later 8260 sku that fixed this issue. Hi Kai-Heng, Can you check with OEM for which SKU they are reporting the issue ? Kai Heng Feng 於 2018年10月3日 週三 下午3:28寫道:

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Kai Heng Feng
> On Oct 3, 2018, at 3:24 PM, Luciano Coelho wrote: > > On Wed, 2018-10-03 at 15:15 +0800, Kai-Heng Feng wrote: >> To avoid the firmware loading race between Bluetooth and WiFi on Intel >> 8260, load firmware exclusively when BT_INTEL is enabled. >> >> Signed-off-by: Kai-Heng Feng >> --- >

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Luciano Coelho
On Wed, 2018-10-03 at 15:15 +0800, Kai-Heng Feng wrote: > To avoid the firmware loading race between Bluetooth and WiFi on Intel > 8260, load firmware exclusively when BT_INTEL is enabled. > > Signed-off-by: Kai-Heng Feng > --- Where is this coming from? Can you explain what "the firmware loadin

pull-request: iwlwifi firmwares update 2018-10-03

2018-10-03 Thread Luca Coelho
Hi, We have updated all the firmwares we currently support. Please pull or let me know if there are any issues. Cheers, Luca. The following changes since commit 7c81f23ad903f72e87e2102d8f52408305c0f7a2: ti-connectivity: add firmware for CC2560(A) Bluetooth (2018-10-01 10:08:30 -0400) are

[PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2018-10-03 Thread Kai-Heng Feng
To avoid the firmware loading race between Bluetooth and WiFi on Intel 8260, load firmware exclusively when BT_INTEL is enabled. Signed-off-by: Kai-Heng Feng --- .../net/wireless/intel/iwlwifi/pcie/trans.c | 37 ++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/