Re: [PATCH 06/10] rtlwifi: Fix VHT NSS in RC

2018-01-28 Thread Pkshih
On Sat, 2018-01-27 at 13:39 -0600, Larry Finger wrote: > On 01/26/2018 01:46 AM, pks...@realtek.com wrote: > > From: Ping-Ke Shih > >  > > NSS is a argument of highest rate in RC, and it occupies bit 4-7 so use > > ieee80211_rate_set_vht() to fill the values. Since it got correct rate > > index, w

Re: [PATCH 09/10] rtlwifi: btcoex: add routine to set default port id

2018-01-28 Thread Pkshih
On Sat, 2018-01-27 at 13:22 -0600, Larry Finger wrote: > On 01/26/2018 01:46 AM, pks...@realtek.com wrote: > > From: Ping-Ke Shih > >  > > Tell wifi and BT firmware the default port ID to set multiports' state > > properly, but only 8822be needs this function currently. > >  > > Signed-off-by: Pin

[PATCH 08/10] rtlwifi: add efuse ops for other components

2018-01-25 Thread pkshih
From: Ping-Ke Shih The new component phydm need to access efuse content, so we prepare ops for reference. Signed-off-by: Tsang-Shian Lin Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/efuse.c | 13 + drivers/net/wireless/realtek/rtlwifi/efuse.h | 2 +- drive

[PATCH 05/10] rtlwifi: Add rate section and its related definition and comment

2018-01-25 Thread pkshih
From: Ping-Ke Shih Add comments to make it to be easier to understand, and add compile time assertions. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 3 +++ drivers/net/wireless/realtek/rtlwifi/wifi.h | 7 --- 2 files changed, 7 insertions(+), 3 deletions(-)

[PATCH 01/10] rtlwifi: enable mac80211 fast-tx support

2018-01-25 Thread pkshih
From: Ping-Ke Shih Enable the mac80211 fast-tx feature, since our driver already support hw_flags required by fast-tx and is able to let mac80211 stack to transmit packet through fast-xmit path. Signed-off-by: Yan-Hsuan Chuang Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwi

[PATCH 10/10] rtlwifi: btcoex: Add 8822be btcoex supported files for wifi only

2018-01-25 Thread pkshih
From: Ping-Ke Shih The wifi only btcoex is used to solo card (without BT), and it is also useful to exclude the interference with BT to make debug easier. There are only four ops for wifi only btcoex to initialze antenna and switch the settings while band is changed. Signed-off-by: Ping-Ke Shih

[PATCH 07/10] rtlwifi: add definition radio_mask for RF and maximum bandwidth

2018-01-25 Thread pkshih
From: Ping-Ke Shih Add rf mask definition (BIT 0, BIT 1, BIT 2, ...) that is different from rf path definition (0, 1, 2, ...), and then combinations of rf path are possible. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/wifi.h | 8 1 file changed, 8 insertions(+

[PATCH 02/10] rtlwifi: Add Support VHT to spec_ver

2018-01-25 Thread pkshih
From: Ping-Ke Shih We are going to add 8822be, which is a VHT 2x2 wifi chip, so add VHT flag to replace enumeration of chips. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 6 -- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c | 1 + drivers/net/w

[PATCH 04/10] rtlwifi: Extend tx_power_by_rate_offset size for newer IC

2018-01-25 Thread pkshih
From: Ping-Ke Shih In older design, the TX power is grouped into rate section (smaller array size), but new design groups them into rate (larger array size). Thus, we extend the size for both cases, and add compile time assertion. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rt

[PATCH 00/10] rtlwifi: add more materials for 8822be

2018-01-25 Thread pkshih
From: Ping-Ke Shih I continue to submit more materials needed by 8822be. A special patch is "PATCH 10/10" that add new files to support 8822be btcoex in case wifi only. In my plan, 8822be btcoex for combo card will be sumitted in next patchset. Ping-Ke Shih (10): rtlwifi: enable mac80211 fast-

[PATCH 06/10] rtlwifi: Fix VHT NSS in RC

2018-01-25 Thread pkshih
From: Ping-Ke Shih NSS is a argument of highest rate in RC, and it occupies bit 4-7 so use ieee80211_rate_set_vht() to fill the values. Since it got correct rate index, we don't need to check chips to assign NSS in set function anymore. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/real

[PATCH 09/10] rtlwifi: btcoex: add routine to set default port id

2018-01-25 Thread pkshih
From: Ping-Ke Shih Tell wifi and BT firmware the default port ID to set multiports' state properly, but only 8822be needs this function currently. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 22 ++ drivers/net/wireless/realtek/rtlwif

[PATCH 03/10] rtlwifi: Use 6 bits as sequence number of TX report

2018-01-25 Thread pkshih
From: Ping-Ke Shih In new design, SW_DEFINE[1:0] of tx desc are used by firmware, and the TX report only contains SW_DEFINE[7:0]. To satisfy with all cases, driver uses SW_DEFINE[7:2] as sequence number. Besides, the format of tx report have been changed, so a new flag RTL_SPEC_EXT_C2H is used to

Re: [mac80211-next:master 3/5] net//wireless/wext-compat.c:1351:9: warning: function returns address of local variable

2018-01-24 Thread Pkshih
On Mon, 2018-01-22 at 13:00 +, kbuild test robot wrote: > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.gi > t master > head:   076dc671ee9fa374e77c3d05925dafb75b23a74c > commit: c179e91512cab01e83be35a60eaeda0f170a9101 [3/5] cfg80211: wext: don't > use static stru

[PATCH v2] rtlwifi: btcoex: Fix some static warnings from Sparse

2018-01-24 Thread pkshih
From: Ping-Ke Shih Add 'static' or declaration to resolve the warnings, and remove two unused functions halbtc_set_macreg() and halbtc_get_macreg() exposed when they were made static. Signed-off-by: Ping-Ke Shih --- The original subject of this patch is '[PATCH 07/10]' in previous patchset, and

Re: [PATCH 10/10] rtlwifi: Add spec_ver to check whether use new rate-id or not

2018-01-22 Thread Pkshih
On Mon, 2018-01-22 at 13:10 -0600, Larry Finger wrote: > On 01/19/2018 12:45 AM, pks...@realtek.com wrote: > >  > > From: Ping-Ke Shih > >  > > The field spec_ver is IC's specification mask for common code to do proper > > process to specified IC. This commit add a field new rate ID for new > > ge

RE: [PATCH 07/10] rtlwifi: btcoex: Fix some static warnings from Sparse

2018-01-21 Thread Pkshih
> -Original Message- > From: linux-wireless-ow...@vger.kernel.org > [mailto:linux-wireless-ow...@vger.kernel.org] On Behalf > Of Larry Finger > Sent: Saturday, January 20, 2018 6:46 AM > To: Pkshih; kv...@codeaurora.org > Cc: linux-wireless@vger.kernel.org > S

[PATCH 09/10] rtlwifi: Add ratr_table for newer IC

2018-01-18 Thread pkshih
From: Ping-Ke Shih New generation ICs will support 11ac, 5G, n-NSS, etc, so we define a set of rate ID. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/wifi.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/wifi.

[PATCH 01/10] rtlwifi: btcoex: extend get_wifi_bw to support bandwidth 80M

2018-01-18 Thread pkshih
From: Ping-Ke Shih The rtlwifi newer ICs support 80M bandwidth in 5G band, so extend get_wifi_bw() to know bandwidth 80M that helps btcoex to make correct decisions. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 37 +- .../realtek/rtlw

[PATCH 08/10] rtlwifi: 8822be has to report vht capability to mac80211

2018-01-18 Thread pkshih
From: Ping-Ke Shih 8822be is 2x2 11ac wifi chip, so report VHT capability to mac80211. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wi

[PATCH 10/10] rtlwifi: Add spec_ver to check whether use new rate-id or not

2018-01-18 Thread pkshih
From: Ping-Ke Shih The field spec_ver is IC's specification mask for common code to do proper process to specified IC. This commit add a field new rate ID for new generation IC. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 126 +--- driv

[PATCH 03/10] rtlwifi: btcoex: Add variable ant_div_cfg to support antenna diversity

2018-01-18 Thread pkshih
From: Ping-Ke Shih The variable will be used by btcoex of 8822be, so we prepare this variable in advance. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 1 + drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 1 + 2 files changed, 2

[PATCH 07/10] rtlwifi: btcoex: Fix some static warnings from Sparse

2018-01-18 Thread pkshih
From: Ping-Ke Shih Add 'static' or declaration to resolve the warnings. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 36 +++--- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 4 +++ 2 files changed, 15 insertions(+), 25 deletions(-

[PATCH 04/10] rtlwifi: btcoex: add scan_notify within ips_notify if RFON

2018-01-18 Thread pkshih
From: Ping-Ke Shih Three steps of connection procedure are scan, enter/leave IPS, auth. There is no scan between leaving IPS and sending auth, but btcoex use scan as an important clue that indicates user is going to connect. So add scan notifications in ips_notify to correct btcoex's state. Sign

[PATCH 00/10] rtlwifi: add btcoex materials for 8822be

2018-01-18 Thread pkshih
From: Ping-Ke Shih In order to support rtl8822be, btcoex needs more information to control rtl8822be, and common code needs to add more materials as well. Ping-Ke Shih (10): rtlwifi: btcoex: extend get_wifi_bw to support bandwidth 80M rtlwifi: btcoex: Add switch band notify for btc rtlwifi

[PATCH 06/10] rtlwifi: btcoex: add boolean variables dbg_mode

2018-01-18 Thread pkshih
From: Ping-Ke Shih In files halbtc8822b1ant.c and halbtc8822b2ant.c that I will submit later, two undesired directives named BT_8822B_1ANT_COEX_DBG and BT_8822B_2ANT_COEX_DBG will be replaced by boolean variables. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/h

[PATCH 05/10] rtlwifi: btcoex: Add wifi_only series ops to control solo card

2018-01-18 Thread pkshih
From: Ping-Ke Shih Originally, btcoex controls the antenna of combo card, but solo card is also needed to setup properly. The new ops are named with suffix '_wifi_only' opposited to original btc_ops, and new structures and definitions are also introduced. The wifi_only oly contains four ops that

[PATCH 02/10] rtlwifi: btcoex: Add switch band notify for btc

2018-01-18 Thread pkshih
From: Ping-Ke Shih BT shares 2.4G band but not 5G band, so inform current band to btcoex to setup antenna properly. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 13 +++ .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 9 .../wireles

Re: [PATCH v2 05/10] rtlwifi: enable mac80211 fast-tx support

2018-01-18 Thread Pkshih
On Thu, 2018-01-18 at 11:09 +0100, Johannes Berg wrote: > On Thu, 2018-01-18 at 09:05 +0000, Pkshih wrote: > > > > > > > > > > /* fast-xmit doesn't handle fragmentation at all */ > > > if (local->hw.wiphy->frag_threshold != (u

Re: [PATCH v2 05/10] rtlwifi: enable mac80211 fast-tx support

2018-01-18 Thread Pkshih
On Tue, 2018-01-16 at 23:24 +0100, Johannes Berg wrote: > On Tue, 2018-01-16 at 21:12 +0100, Arend van Spriel wrote: > > > > > > When I saw this flying by I had the same feeling. This is clearly > > not  > > how it was intended although you could interpret the comments of > > the  > > .set_frag_t

[PATCH] rtlwifi: Support A-MSDU in A-MPDU capability

2018-01-17 Thread pkshih
From: Ping-Ke Shih Due to the fact that A-MSDU deaggregation is done in software, we set this flag to support the A-MSDU in A-MPDU Signed-off-by: Steven Ting Signed-off-by: Ping-Ke Shih --- Rebase to resolve conflict due to the patch 'fast-tx' is dropped. --- drivers/net/wireless/realtek/rtlw

Re: [PATCH] cfg80211: wext: don't use static struct

2018-01-17 Thread Pkshih
On Tue, 2018-01-16 at 23:11 +0100, Johannes Berg wrote: > From: Johannes Berg > > There's no point in persistently allocating memory for these, > they're small enough to live on the stack. > > Signed-off-by: Johannes Berg > --- >  net/wireless/wext-compat.c | 9 ++--- >  1 file changed, 2 in

[PATCH v3 03/10] rtlwifi: unlink bss when un-association

2018-01-16 Thread pkshih
From: Tsang-Shian Lin When AP change bandwidth setting from 20M to 40M, STA may use old 20M AP information to association with AP. Driver unlink bss in the .bss_info_changed of ieee80211_ops to make sure that later scan can get correct AP bandwidth capability. Signed-off-by: Tsang-Shian Lin Sig

[PATCH v3 02/10] rtlwifi: fix scan channel 1 fail after IPS

2018-01-16 Thread pkshih
From: Ping-Ke Shih If there is no connection, driver will enter IPS state. Meanwhile, it fails to scan channel 1 by the command 'iw dev wlan0 scan freq 2412', because hardware channel setting lose after IPS. Thus, restore channel setting from hw->conf.channel set by last rtl_op_config(). Signed-

[PATCH v3 04/10] rtlwifi: enable mac80211 fast-tx support

2018-01-16 Thread pkshih
From: Ping-Ke Shih To enable the mac80211 fast-tx feature, the hw/driver needs to support dynamic power saving and fragmentation. Since our driver does not need to fragment packet into smaller pieces, we just hook an empty callback of set_frag_threshold to avoid fragmentation in mac80211. After

[PATCH v3 01/10] rtlwifi: Use mutex to replace spin_lock to protect IPS and LPS

2018-01-16 Thread pkshih
From: Ping-Ke Shih Enter/leavel IPS and LPS are large critical section, and they can't use sleep function because running in atomic-context, which own a spin_lock. In commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save"), it moves LPS functions to thread-context, so this commit can simply ch

[PATCH v3 06/10] rtlwifi: btcoex: Add power_on_setting routine

2018-01-16 Thread pkshih
From: Ping-Ke Shih After mac power-on sequence, wifi will start to work so notify btcoex the event to configure registers especially related to antenna. This will not only help to assign antenna but also to yield better user experience. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/real

[PATCH v3 07/10] rtlwifi: btcoex: Remove global variables from btcoex

2018-01-16 Thread pkshih
From: Ping-Ke Shih Remove global variables, so btcoexist can support multiple instances simultaneously. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 79 - .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 21 +-- .../wireless/realtek/rtlwifi

[PATCH v3 10/10] rtlwifi: btcoex: add rfe_type parameter to btcoex

2018-01-16 Thread pkshih
From: Ping-Ke Shih btcoex configure antenna by rfe_type that is RF type programmed in efuse. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 10 ++ drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 2 ++ 2 files changed, 12

[PATCH v3 00/10] rtlwifi: fix some bugs and add btcoex functions

2018-01-16 Thread pkshih
From: Ping-Ke Shih Fix some bugs reported by QC, and continue to submit btcoex patches for further use. v3: * remove the commit that adds sta_statistics op, because Johannes fixes it in cfg80211 (Thanks!) * for 'typedef' comment, add a commit to resolve old typedef, and remove typede

[PATCH v3 05/10] rtlwifi: Support A-MSDU in A-MPDU capability

2018-01-16 Thread pkshih
From: Steven Ting Due to the fact that A-MSDU deaggregation is done in software, we set this flag to support the A-MSDU in A-MPDU Signed-off-by: Steven Ting Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

[PATCH v3 08/10] rtlwifi: btcoex: Remove typedef statements

2018-01-16 Thread pkshih
From: Larry Finger Each of these typedefs are only referenced in a single location later in this header. Thus, they are easily removed. Signed-off-by: Larry Finger Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 98 +++--- 1 file changed, 3

[PATCH v3 09/10] rtlwifi: btcoex: Add common function for qeurying BT information

2018-01-16 Thread pkshih
From: Ping-Ke Shih This commit implement the common function to sort old features, and add more new features that are get_supported_feature, get_supported_version, get_ant_det_val, ble_scan_type, ble_scan_para, bt_dev_info, forbidden_slot_val, afh_map and etc. Signed-off-by: Ping-Ke Shih --- .

Re: [PATCH v2 07/10] rtlwifi: btcoex: Add power_on_setting routine

2018-01-15 Thread Pkshih
On Mon, 2018-01-15 at 13:19 -0600, Larry Finger wrote: > On 01/11/2018 01:09 AM, pks...@realtek.com wrote: > > > > From: Ping-Ke Shih > > > > After mac power-on sequence, wifi will start to work so notify > > btcoex the > > event to configure registers especially related to antenna. This > > wil

Re: [PATCH v2 09/10] rtlwifi: btcoex: Add common function for qeurying BT information

2018-01-15 Thread Pkshih
On Mon, 2018-01-15 at 13:15 -0600, Larry Finger wrote: > On 01/11/2018 01:09 AM, pks...@realtek.com wrote: > > > > From: Ping-Ke Shih > > > > This commit implement the common function to sort old features, and > > add > > more new features that are get_supported_feature, > > get_supported_versio

[PATCH v2 07/10] rtlwifi: btcoex: Add power_on_setting routine

2018-01-10 Thread pkshih
From: Ping-Ke Shih After mac power-on sequence, wifi will start to work so notify btcoex the event to configure registers especially related to antenna. This will not only help to assign antenna but also to yield better user experience. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/real

[PATCH v2 05/10] rtlwifi: enable mac80211 fast-tx support

2018-01-10 Thread pkshih
From: Ping-Ke Shih To enable the mac80211 fast-tx feature, the hw/driver needs to support dynamic power saving and fragmentation. Since our driver does not need to fragment packet into smaller pieces, we just hook an empty callback of set_frag_threshold to avoid fragmentation in mac80211. After

[PATCH v2 02/10] rtlwifi: fix scan channel 1 fail after IPS

2018-01-10 Thread pkshih
From: Ping-Ke Shih If there is no connection, driver will enter IPS state. Meanwhile, it fails to scan channel 1 by the command 'iw dev wlan0 scan freq 2412', because hardware channel setting lose after IPS. Thus, restore channel setting from hw->conf.channel set by last rtl_op_config(). Signed-

[PATCH v2 01/10] rtlwifi: Use mutex to replace spin_lock to protect IPS and LPS

2018-01-10 Thread pkshih
From: Ping-Ke Shih Enter/leavel IPS and LPS are large critical section, and they can't use sleep function because running in atomic-context, which own a spin_lock. In commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save"), it moves LPS functions to thread-context, so this commit can simply ch

[PATCH v2 04/10] rtlwifi: unlink bss when un-association

2018-01-10 Thread pkshih
From: Tsang-Shian Lin When AP change bandwidth setting from 20M to 40M, STA may use old 20M AP information to association with AP. Driver unlink bss in the .bss_info_changed of ieee80211_ops to make sure that later scan can get correct AP bandwidth capability. Signed-off-by: Tsang-Shian Lin Sig

[PATCH v2 10/10] rtlwifi: btcoex: add rfe_type parameter to btcoex

2018-01-10 Thread pkshih
From: Ping-Ke Shih btcoex configure antenna by rfe_type that is RF type programmed in efuse. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 10 ++ drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 2 ++ 2 files changed, 12

[PATCH v2 00/10] rtlwifi: fix some bugs and add btcoex functions

2018-01-10 Thread pkshih
From: Ping-Ke Shih Fix some bugs reported by QC, and continue to submit btcoex patches for further use. v2: add my sob to commit log if missing, and remove trivial comments. Ping-Ke Shih (8): rtlwifi: Use mutex to replace spin_lock to protect IPS and LPS rtlwifi: fix scan channel 1 fail aft

[PATCH v2 09/10] rtlwifi: btcoex: Add common function for qeurying BT information

2018-01-10 Thread pkshih
From: Ping-Ke Shih This commit implement the common function to sort old features, and add more new features that are get_supported_feature, get_supported_version, get_ant_det_val, ble_scan_type, ble_scan_para, bt_dev_info, forbidden_slot_val, afh_map and etc. Signed-off-by: Ping-Ke Shih --- .

[PATCH v2 08/10] rtlwifi: btcoex: Remove global variables from btcoex

2018-01-10 Thread pkshih
From: Ping-Ke Shih Remove global variables, so btcoexist can support multiple instances simultaneously. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 79 - .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 21 +-- .../wireless/realtek/rtlwifi

[PATCH v2 03/10] rtlwifi: Add sta_statistics of mac80211's op, and set filled=0 by default

2018-01-10 Thread pkshih
From: Ping-Ke Shih When using iwconfig to check wifi status, wext uses 'static struct' of sinfo to get station info so sinfo->filled will be persistent. Since the commit 2b9a7e1bac24 ("mac80211: allow drivers to provide most station statistics") assumes driver initializes sinfo->filled to declare

[PATCH v2 06/10] rtlwifi: Support A-MSDU in A-MPDU capability

2018-01-10 Thread pkshih
From: Steven Ting Due to the fact that A-MSDU deaggregation is done in software, we set this flag to support the A-MSDU in A-MPDU Signed-off-by: Steven Ting Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

RE: [PATCH 02/10] rtlwifi: fix scan channel 1 fail after IPS

2018-01-10 Thread Pkshih
> -Original Message- > From: Arend van Spriel [mailto:arend.vanspr...@broadcom.com] > Sent: Wednesday, January 10, 2018 10:08 PM > To: Pkshih; kv...@codeaurora.org > Cc: larry.fin...@lwfinger.net; 莊彥宣; linux-wireless@vger.kernel.org > Subject: Re: [PATCH 02/10] rtlwifi:

RE: [PATCH 02/10] rtlwifi: fix scan channel 1 fail after IPS

2018-01-10 Thread Pkshih
> -Original Message- > From: Arend van Spriel [mailto:arend.vanspr...@broadcom.com] > Sent: Wednesday, January 10, 2018 4:13 PM > To: Pkshih; kv...@codeaurora.org > Cc: larry.fin...@lwfinger.net; 莊彥宣; linux-wireless@vger.kernel.org > Subject: Re: [PATCH 02/10] rtlwifi:

[PATCH 02/10] rtlwifi: fix scan channel 1 fail after IPS

2018-01-09 Thread pkshih
From: Ping-Ke Shih If there is no connection, driver will enter IPS state. Meanwhile, it fails to scan channel 1 by the command 'iw dev wlan0 scan freq 2412', because hardware channel setting lose after IPS. Thus, restore channel setting from hw->conf.channel set by last rtl_op_config(). Signed-

[PATCH 05/10] rtlwifi: enable mac80211 fast-tx support

2018-01-09 Thread pkshih
From: Ping-Ke Shih To enable the mac80211 fast-tx feature, the hw/driver needs to support dynamic power saving and fragmentation. Since our driver does not need to fragment packet into smaller pieces, we just hook an empty callback of set_frag_threshold to avoid fragmentation in mac80211. After

[PATCH 06/10] rtlwifi: Support A-MSDU in A-MPDU capability

2018-01-09 Thread pkshih
From: Steven Ting Due to the fact that A-MSDU deaggregation is done in software, we set this flag to support the A-MSDU in A-MPDU Signed-off-by: Steven Ting --- drivers/net/wireless/realtek/rtlwifi/base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/

[PATCH 07/10] rtlwifi: btcoex: Add power_on_setting routine

2018-01-09 Thread pkshih
From: Ping-Ke Shih After mac power-on sequence, wifi will start to work so notify btcoex the event to configure registers especially related to antenna. This will not only help to assign antenna but also to yield better user experience. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/real

[PATCH 10/10] rtlwifi: btcoex: add rfe_type parameter to btcoex

2018-01-09 Thread pkshih
From: Ping-Ke Shih btcoex configure antenna by rfe_type that is RF type programmed in efuse. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 10 ++ drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 2 ++ 2 files changed, 12

[PATCH 04/10] rtlwifi: unlink bss when un-association

2018-01-09 Thread pkshih
From: Tsang-Shian Lin When AP change bandwidth setting from 20M to 40M, STA may use old 20M AP information to association with AP. Driver unlink bss in the .bss_info_changed of ieee80211_ops to make sure that later scan can get correct AP bandwidth capability. Signed-off-by: Tsang-Shian Lin Sig

[PATCH 08/10] rtlwifi: btcoex: Remove global variables from btcoex

2018-01-09 Thread pkshih
From: Ping-Ke Shih Remove global variables, so btcoexist can support multiple instances simultaneously. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 79 - .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 21 +-- .../wireless/realtek/rtlwifi

[PATCH 01/10] rtlwifi: Use mutex to replace spin_lock to protect IPS and LPS

2018-01-09 Thread pkshih
From: Ping-Ke Shih Enter/leavel IPS and LPS are large critical section, and they can't use sleep function because running in atomic-context, which own a spin_lock. In commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save"), it moves LPS functions to thread-context, so this commit can simply ch

[PATCH 00/10] rtlwifi: fix some bugs and add btcoex functions

2018-01-09 Thread pkshih
From: Ping-Ke Shih Fix some bugs reported by QC, and continue to submit btcoex patches for further use. Ping-Ke Shih (8): rtlwifi: Use mutex to replace spin_lock to protect IPS and LPS rtlwifi: fix scan channel 1 fail after IPS rtlwifi: Add sta_statistics of mac80211's op, and set filled=0

[PATCH 03/10] rtlwifi: Add sta_statistics of mac80211's op, and set filled=0 by default

2018-01-09 Thread pkshih
From: Ping-Ke Shih When using iwconfig to check wifi status, wext uses 'static struct' of sinfo to get station info so sinfo->filled will be persistent. Since the commit 2b9a7e1bac24 ("mac80211: allow drivers to provide most station statistics") assumes driver initializes sinfo->filled to declare

[PATCH 09/10] rtlwifi: btcoex: Add common function for qeurying BT information

2018-01-09 Thread pkshih
From: Ping-Ke Shih This commit implement the common function to sort old features, and add more new features that are get_supported_feature, get_supported_version, get_ant_det_val, ble_scan_type, ble_scan_para, bt_dev_info, forbidden_slot_val, afh_map and etc. Signed-off-by: Ping-Ke Shih --- .

[PATCH 03/11] rtlwifi: fix parenthesis alignment

2017-12-29 Thread pkshih
From: Ping-Ke Shih This is merged by Ping-Ke Shih from commit 688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment"), and original commit log is reserved below. Checkpatch emits multiple warnings of type CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis Fix parenthesis

[PATCH 05/11] rtlwifi: Remove unnecessary 'out of memory' message

2017-12-29 Thread pkshih
From: Shreeya Patel This is merged by Ping-Ke Shih from commit 596e0559d61a ("Staging: rtlwifi: Remove unnecessary 'out of memory' message."), and commit log is reserved below. Logging messages that show some type of "out of memory" error are generally unnecessary as there is a generic message a

[PATCH 00/11] rtlwifi: change rtlwifi maintainer and merge commits from staging

2017-12-29 Thread pkshih
From: Ping-Ke Shih Hello Kalle, This patchset contain a patch written by Larry to change maintainer. Since I'm a newbie maintainer, need your comments on my mistakes in the future. Second part is the commits existed in staging's rtlwifi, and most of them fix coding style issues so I merge them t

[PATCH 02/11] rtlwifi: check for array overflow

2017-12-29 Thread pkshih
From: Dan Carpenter This is merged by Ping-Ke Shih from commit dc33bd4309d2 ("staging: rtlwifi: check for array overflow"), and the original commit log is reserved below. Smatch is distrustful of the "capab" value and marks it as user controlled. I think it actually comes from the firmware? An

[PATCH 04/11] rtlwifi: use kcalloc instead of multiply

2017-12-29 Thread pkshih
From: "Tobin C. Harding" This is merged by Ping-Ke Shih from commit 85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply"), and original commit log is reserved below. checkpatch emits multiple warnings of type WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply R

[PATCH 01/11] MAINTAINERS: Change maintainer for rtlwifi

2017-12-29 Thread pkshih
From: Larry Finger This section is also modified to include the entire rtlwifi family, not just RTL8192CE. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger --- MAINTAINERS | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 129c591e

[PATCH 06/11] rtlwifi: mark expected switch fall-through in rtl_make_smps_action

2017-12-29 Thread pkshih
From: "Gustavo A. R. Silva" This is merged by Ping-Ke Shih from commit 640019bba419 ("staging: rtlwifi: mark expected switch fall-through in rtl_make_smps_action"), and original commit log is reserved below. In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expect

[PATCH 07/11] rtlwifi: Remove unnecessary parentheses

2017-12-29 Thread pkshih
From: "Frank A. Cancio Bello" This is merged by Ping-Ke Shih from commit a221cb0911b8 ("staging: rtlwifi: Remove unnecessary parentheses"), and original commit log is reserved below. Remove unnecessary parentheses to comply with preferred coding style for the linux kernel and avoid the following

[PATCH 10/11] rtlwifi: btcoex: Use seq_file to dump btcoex status

2017-12-29 Thread pkshih
From: Ping-Ke Shih We use seq_file to replace RT_TRACE to dump status, then we can use 'cat' to access btcoex's status through debugfs. (i.e. /sys/kernel/debug/rtlwifi/00-11-22-33-44-55-66/btcoex) Other related changes are 1. implement btc_disp_dbg_msg() to access btcoex's common status. 2. remov

[PATCH 11/11] rtlwifi: fill FW version and subversion

2017-12-29 Thread pkshih
From: Ping-Ke Shih This commit fills FW version information of RTL8188EE and RTL8723, so the btcoex can cooperate with FW correctly. Also, we can display this version in debugfs. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/fw.c | 2 ++ drivers/net/wir

[PATCH 08/11] rtlwifi: rtl8723: Add error handling to no existing firmware

2017-12-29 Thread pkshih
From: Ping-Ke Shih Without firmware, driver wastes time to download and wait for MCU bootup, and then kernel core dump finally. If request_firmware fails, the value max_fw_size=0 is set, so we check the value before downloading firmware. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/rea

[PATCH 09/11] rtlwifi: Improve debugging by using debugfs

2017-12-29 Thread pkshih
From: Ping-Ke Shih Use debugfs to dump register and btcoex status, and also write registers and h2c. We create topdir in /sys/kernel/debug/rtlwifi/, and use the MAC address as subdirectory with several entries to dump mac_reg, bb_reg, rf_reg etc. An example is /sys/kernel/debug/rtlwifi/00-11

[RFC] rtlwifi: Add two components (kernel modules) to rtlwifi

2017-11-24 Thread Pkshih
Hello Johannes and Kalle, In order to reduce effort to maintain the MAC/BB/RF functions and keep them to be up-to-date, we introduce two new components that are phydm and halmac maintained by Realtek's MAC/BB/RF teams. The components are similar to existing component btcoexist that used by variou

[PATCH 1/3] rtlwifi: Reduce IO in RX interrupt to boost throughput

2017-11-13 Thread pkshih
From: Ping-Ke Shih Check remaining count of RX packets cost a lot of CPU time, so only update when the counter decreases to zero. In old flow, the counter was updated once a RX packet is received. Signed-off-by: Steven Ting Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/

[PATCH 2/3] rtlwifi: fix the wrong size to calculate fifo space

2017-11-13 Thread pkshih
From: Ping-Ke Shih Give correct fifo size to calculate fifo space. Fortunately, the values of RTL_PCI_MAX_RX_COUNT and TX_DESC_NUM_92E are the same in old code, so it still works. Signed-off-by: Steven Ting Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/pci.h |

[PATCH 3/3] rtlwifi: cleanup the code that check whether TX ring is available

2017-11-13 Thread pkshih
From: Ping-Ke Shih Remove the duplicate checking of TX ring's available number, and remove the variable to store available number that can be calculated by read/write pointers. Signed-off-by: Steven Ting Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/pci.c | 8 -

[PATCH 0/3] rtlwifi: Refactor TX/RX flow to improve throughput

2017-11-13 Thread pkshih
From: Ping-Ke Shih This patchset is aim to reduce IO to improve TX/RX performance, and also I cleanup the code to make it easier and simpler. Ping-Ke Shih (3): rtlwifi: Reduce IO in RX interrupt to boost throughput rtlwifi: fix the wrong size to calculate fifo space rtlwifi: cleanup the co

[PATCH] rtlwifi: Remove seq_number from rtl_tid_data

2017-10-23 Thread pkshih
From: Ping-Ke Shih Since mac80211 maintains the sequence number for each STA/TID, driver doesn't need to maintain a copy. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/base.c | 6 ++ drivers/net/wireless/realtek/rtlwifi/pci.c | 17 - drivers/net/wir

RE: Two rtlwifi drivers?

2017-10-16 Thread Pkshih
> -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Monday, October 16, 2017 9:23 PM > To: Pkshih > Cc: Larry Finger; Greg Kroah-Hartman; Dan Carpenter; 莊彥宣; Johannes Berg; > Souptick Joarder; > de...@driverdev.osuosl.org; linux-wir

RE: Two rtlwifi drivers?

2017-10-16 Thread Pkshih
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Monday, October 16, 2017 3:50 PM > To: Pkshih > Cc: Larry Finger; Kalle Valo; Dan Carpenter; 莊彥宣; Johannes Berg; Souptick > Joarder; > de...@driverdev.osuosl.org; linux-wir

RE: Two rtlwifi drivers?

2017-10-15 Thread Pkshih
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Thursday, October 12, 2017 6:35 PM > To: Kalle Valo > Cc: Larry Finger; Dan Carpenter; Pkshih; 莊彥宣; Johannes Berg; Souptick Joarder; > de...@driverdev.osuosl.org; linux-wirele

<    1   2   3