Re: powerpc problem with .data.page_aligned - __page_aligned_data conversion

2009-10-15 Thread Tim Abbott
by PAGE_SIZE. However, I am not sure how to reconcile that with using the word break above... -Tim Abbott ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: powerpc problem with .data.page_aligned - __page_aligned_data conversion

2009-10-15 Thread Tim Abbott
. Since most code that has page-aligned data structures is architecture-specific, there's a good chance that any new code that would break will be at least looked at by you (and given how few places it is used currently, this seems pretty unlikely to actually come up). -Tim Abbott

From: Tim Abbott tabb...@ksplice.com

2009-10-13 Thread Tim Abbott
There is already an architecture-independent __page_aligned_data macro for this purpose, so removing the powerpc-specific macro should be harmless. Signed-off-by: Tim Abbott tabb...@ksplice.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc

Re: From: Tim Abbott tabb...@ksplice.com

2009-10-13 Thread Tim Abbott
Well, I think I just found a bug in git-send-email. I'll resend with the actual subject line. -Tim Abbott On Tue, 13 Oct 2009, Tim Abbott wrote: There is already an architecture-independent __page_aligned_data macro for this purpose, so removing the powerpc-specific macro should

[PATCH v2 09/11] powerpc: Cleanup linker script using new linker script macros.

2009-09-24 Thread Tim Abbott
Signed-off-by: Tim Abbott tabb...@ksplice.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-...@ozlabs.org Acked-by: Sam Ravnborg s...@ravnborg.org --- arch/powerpc/kernel/vmlinux.lds.S | 69 - 1 files

[PATCH] powerpc: Cleanup linker script using new linker script macros.

2009-09-22 Thread Tim Abbott
Signed-off-by: Tim Abbott tabb...@ksplice.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-...@ozlabs.org Cc: Sam Ravnborg s...@ravnborg.org --- arch/powerpc/kernel/vmlinux.lds.S | 69 - 1 files changed

[PATCH v2] Linker script cleanup for powerpc

2009-09-22 Thread Tim Abbott
the kernel with -ffunction-sections -fdata-sections, which is a prerequisite for Ksplice. -Tim Abbott Tim Abbott (1): powerpc: Cleanup linker script using new linker script macros. arch/powerpc/kernel/vmlinux.lds.S | 69 - 1 files changed, 15

[PATCH] powerpc: Cleanup linker script using new linker script macros.

2009-09-06 Thread Tim Abbott
Signed-off-by: Tim Abbott tabb...@ksplice.com Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-...@ozlabs.org Cc: Sam Ravnborg s...@ravnborg.org --- arch/powerpc/kernel/vmlinux.lds.S | 69 - 1 files changed

Re: [PATCH v2 1/6] Add new macros for page-aligned data and bss sections.

2009-05-01 Thread Tim Abbott
On Fri, 1 May 2009, Sam Ravnborg wrote: On Thu, Apr 30, 2009 at 03:54:08PM -0400, Tim Abbott wrote: +#define __PAGE_ALIGNED_DATA.section .data.page_aligned, aw, @progbits +#define __PAGE_ALIGNED_BSS .section .bss.page_aligned, aw, @nobits It is my understanding that the linker

[PATCH 6/6] Add support for __read_mostly to linux/cache.h

2009-04-30 Thread Tim Abbott
Signed-off-by: Tim Abbott tabb...@mit.edu --- include/linux/cache.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/linux/cache.h b/include/linux/cache.h index 97e2488..99d8a6f 100644 --- a/include/linux/cache.h +++ b/include/linux/cache.h @@ -13,7 +13,13

[PATCH 2/6] Add new NOSAVE_DATA linker script macro.

2009-04-30 Thread Tim Abbott
with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org --- include/asm-generic/vmlinux.lds.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff

[PATCH 5/6] Add new READ_MOSTLY_DATA(align) linker script macro.

2009-04-30 Thread Tim Abbott
with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org --- include/asm-generic/vmlinux.lds.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff

[PATCH 3/6] Add new CACHELINE_ALIGNED_DATA linker script macro.

2009-04-30 Thread Tim Abbott
with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org --- include/asm-generic/vmlinux.lds.h |4 1 files changed, 4 insertions(+), 0 deletions

[PATCH 0/6] macros for section name cleanup

2009-04-30 Thread Tim Abbott
Abbott Tim Abbott (6): Add new macros for page-aligned data and bss sections. Add new NOSAVE_DATA linker script macro. Add new CACHELINE_ALIGNED_DATA linker script macro. Add new INIT_TASK_DATA() linker script macro. Add new READ_MOSTLY_DATA(align) linker script macro. Add support

[PATCH 1/6] Add new macros for page-aligned data and bss sections.

2009-04-30 Thread Tim Abbott
to those that are compatible with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org Acked-by: David Howells dhowe...@redhat.com --- include/asm-generic

[PATCH 4/6] Add new INIT_TASK_DATA() linker script macro.

2009-04-30 Thread Tim Abbott
with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org --- include/asm-generic/vmlinux.lds.h |4 include/linux/init_task.h |3 +++ 2 files

[PATCH v2 4/6] Add new INIT_TASK_DATA() linker script macro.

2009-04-30 Thread Tim Abbott
with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org --- include/asm-generic/vmlinux.lds.h |4 include/linux/init_task.h |3 +++ 2 files

[PATCH v2 3/6] Add new CACHELINE_ALIGNED_DATA linker script macro.

2009-04-30 Thread Tim Abbott
with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org --- include/asm-generic/vmlinux.lds.h |4 1 files changed, 4 insertions(+), 0 deletions

[PATCH v2 6/6] Add support for __read_mostly to linux/cache.h

2009-04-30 Thread Tim Abbott
Signed-off-by: Tim Abbott tabb...@mit.edu --- include/linux/cache.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/linux/cache.h b/include/linux/cache.h index 97e2488..99d8a6f 100644 --- a/include/linux/cache.h +++ b/include/linux/cache.h @@ -13,7 +13,13

[PATCH v2 2/6] Add new NOSAVE_DATA linker script macro.

2009-04-30 Thread Tim Abbott
with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org --- include/asm-generic/vmlinux.lds.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff

[PATCH v2 1/6] Add new macros for page-aligned data and bss sections.

2009-04-30 Thread Tim Abbott
to those that are compatible with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org Acked-by: David Howells dhowe...@redhat.com --- include/asm-generic

[PATCH v2 5/6] Add new READ_MOSTLY_DATA(align) linker script macro.

2009-04-30 Thread Tim Abbott
with -ffunction-sections -fdata-sections. This requires renaming all magic sections with names of the form .data.foo. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Sam Ravnborg s...@ravnborg.org --- include/asm-generic/vmlinux.lds.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff

[PATCH v2 0/6] macros for section name cleanup

2009-04-30 Thread Tim Abbott
to send one patch series for each of the architectures updating those architectures to use these new macros (and otherwise cleaning up section names on those architectures). -Tim Abbott Tim Abbott (6): Add new macros for page-aligned data and bss sections. Add new NOSAVE_DATA linker

[PATCH 1/8] powerpc: Remove unused __page_aligned macro.

2009-04-30 Thread Tim Abbott
Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/include/asm/page_64.h |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/include

[PATCH 2/8] powerpc: share .data output section definition between 32 and 64 bits.

2009-04-30 Thread Tim Abbott
Since upcoming changes will add several more common pieces of code between the 32-bit and 64-bit powerpc architectures, it seems best to unify these two blocks. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 0/8] section name cleanup for powerpc

2009-04-30 Thread Tim Abbott
(); /* -ffunction-sections places in .text.head */ Note that these patches have not been boot-tested (aside from testing the analogous changes on x86), since I don't have access to the appropriate hardware. -Tim Abbott Tim Abbott (8): powerpc: Remove unused __page_aligned macro. powerpc

[PATCH 4/8] powerpc: use NOSAVE_DATA macro for .data.nosave section.

2009-04-30 Thread Tim Abbott
.data.nosave should not need a separate output section; this change moves it into the .data section. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/kernel/vmlinux.lds.S

[PATCH 7/8] powerpc: use new macro for .data.read_mostly section.

2009-04-30 Thread Tim Abbott
.data.read_mostly should not need a separate output section; this change moves it into the .data section. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/kernel

[PATCH 8/8] powerpc: convert to new generic read_mostly support.

2009-04-30 Thread Tim Abbott
Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/Kconfig |3 +++ arch/powerpc/include/asm/cache.h |4 2 files changed, 3 insertions(+), 4

[PATCH 5/8] powerpc: use new macro for .data.cacheline_aligned section.

2009-04-30 Thread Tim Abbott
is the correct alignment here. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/kernel/vmlinux.lds.S |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff

[PATCH 6/8] powerpc: use new macros for .data.init_task.

2009-04-30 Thread Tim Abbott
that it should be that way. One of the powerpc maintainers should confirm that this is correct, otherwise we can go back to the #ifdef. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@ozlabs.org --- arch

Re: [PATCH 2/8] powerpc: share .data output section definition between 32 and 64 bits.

2009-04-30 Thread Tim Abbott
On Fri, 1 May 2009, Michael Ellerman wrote: On Thu, 2009-04-30 at 19:56 -0400, Tim Abbott wrote: +#ifndef CONFIG_PPC32 This would be clearer in the positive, as in #ifdef CONFIG_PPC64. Good point. New version below. -Tim Abbott powerpc: share .data output section definition

Re: [PATCH 11/14] powerpc: Use macros for .data.page_aligned section.

2009-04-28 Thread Tim Abbott
to that message that replace PATCH 11/14. -Tim Abbott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Please revert edada399 and 9203fc9c

2009-04-28 Thread Tim Abbott
commit edada399. Can someone who has a 64-bit powerpc machine confirm? -Tim Abbott -- powerpc: Revert switch to TEXT_TEXT in linker script Commit edada399 broke the build on 64-bit powerpc because it moved the __ftr_alt_* sections of a file away from the .text section, causing link

[PATCH v2 10/15] powerpc: Remove unused __page_aligned macro.

2009-04-28 Thread Tim Abbott
Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/include/asm/page_64.h |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/include

[PATCH v2 12/15] powerpc: Use macros for .data.page_aligned section.

2009-04-28 Thread Tim Abbott
data, I suspect having page-aligned data outside _edata was a bug. Please comment if it is not. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/kernel/vdso.c

[PATCH v2 11/15] powerpc: share .data output section definition between 32 and 64 bits.

2009-04-28 Thread Tim Abbott
Since upcoming changes will add several more common pieces of code between the 32-bit and 64-bit powerpc architectures, it seems best to unify these two blocks. Signed-off-by: Tim Abbott tabb...@mit.edu Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc