Re: [PATCH] powerpc: stop_this_cpu: remove the cpu from the online map.

2009-12-07 Thread Valentine
Ben, is this OK? Other architectures do the same thing. Thanks, Val. Valentine Barshak wrote: Remove the CPU from the online map to prevent smp_call_function from sending messages to a stopped CPU. Signed-off-by: Valentine Barshak --- arch/powerpc/kernel/smp.c |3 +++ 1 file changed, 3

[PATCH] powerpc: stop_this_cpu: remove the cpu from the online map.

2009-11-25 Thread Valentine Barshak
Remove the CPU from the online map to prevent smp_call_function from sending messages to a stopped CPU. Signed-off-by: Valentine Barshak --- arch/powerpc/kernel/smp.c |3 +++ 1 file changed, 3 insertions(+) diff -pruN linux-2.6.orig/arch/powerpc/kernel/smp.c linux-2.6/arch/powerpc/kernel

Re: [PATCH v3] powerpc/ppc64: Use preempt_schedule_irq instead of preempt_schedule

2009-10-28 Thread Valentine
Benjamin Herrenschmidt wrote: On Thu, 2009-10-29 at 00:28 +0300, Valentine wrote: Benjamin Herrenschmidt wrote: On Wed, 2009-10-28 at 22:19 +0300, Valentine wrote: I'm just not sure that we need to clear HARDIRQEN here, since we don't really hard-disable the the interrupts. We do,

Re: [PATCH v3] powerpc/ppc64: Use preempt_schedule_irq instead of preempt_schedule

2009-10-28 Thread Valentine
Use preempt_schedule_irq instead of preempt_schedule Based on an original patch by Valentine Barshak Use preempt_schedule_irq to prevent infinite irq-entry and eventual stack overflow problems with fast-paced IRQ sources. This kind of problems has been observed on the PASemi Electra IDE controlle

Re: [PATCH v3] powerpc/ppc64: Use preempt_schedule_irq instead of preempt_schedule

2009-10-28 Thread Valentine
Benjamin Herrenschmidt wrote: On Wed, 2009-10-28 at 22:19 +0300, Valentine wrote: I'm just not sure that we need to clear HARDIRQEN here, since we don't really hard-disable the the interrupts. We do, or rather, we come in with the interrupts hard disabled, no ? Yes, look

[PATCH] [RFC] PowerPC64: Use preempt_schedule_irq instead of preempt_schedule when returning from exceptions

2009-10-19 Thread Valentine Barshak
interrupts after that to avoid unrecoverable exceptions. This patch also moves the "clrrdi r9,r1,THREAD_SHIFT" out of the #ifdef CONFIG_PPC_BOOK3E scope, since r9 is clobbered and has to be restored in both cases. Signed-off-by: Valentine Barshak --- arch/powerpc/kernel/entry_6

Re: Regression detecting memory size on PPC440EPx

2009-10-05 Thread Valentine
AFAIK, u-boot just writes pre-defined values to the memory controller registers. It doesn't do any chiptype/memsize detection. These values are set for Sequoia and may not suite your board. So you probably need to adjust the u-boot to make linux detect the memory size correctly. Thanks, Val.

[PATCH] pasemi_mac: ethtool set settings support

2009-10-05 Thread Valentine Barshak
Add ethtool set settings to pasemi_mac_ethtool. Signed-off-by: Valentine Barshak --- drivers/net/pasemi_mac_ethtool.c | 14 ++ 1 file changed, 14 insertions(+) diff -pruN linux-2.6.orig/drivers/net/pasemi_mac_ethtool.c linux-2.6/drivers/net/pasemi_mac_ethtool.c --- linux-2.6

[PATCH] pasemi_mac: ethtool get settings fix

2009-10-05 Thread Valentine Barshak
Not all pasemi mac interfaces can have a phy attached. For example, XAUI has no phy and phydev is NULL for it. In this case ethtool get settings causes kernel crash. Fix it by returning -EOPNOTSUPP if there's no PHY attached. Signed-off-by: Valentine Barshak --- drivers/net/pasemi_mac_etht

Re: [PATCH] pasemi_mac: ethtool get settings fix

2009-10-05 Thread Valentine
Resending pasemi_mac ethtool patches... Valentine Barshak wrote: Not all pasemi mac interfaces can have a phy attached. For example, XAUI has no phy and phydev is NULL for it. In this case ethtool get settings causes kernel crash. Fix it by returning -EOPNOTSUPP if there's no PHY att

[PATCH] pasemi_mac: ethtool get settings fix

2009-10-01 Thread Valentine Barshak
Not all pasemi mac interfaces can have a phy attached. For example, XAUI has no phy and phydev is NULL for it. In this case ethtool get settings causes kernel crash. Fix it by returning -EOPNOTSUPP if there's no PHY attached. Signed-off-by: Valentine Barshak --- drivers/net/pasemi_mac_etht

Re: Simple question about powerpc asm.

2009-07-18 Thread Valentine
Wolfgang Denk wrote: Dear Valentine, In message <4a61a48d.8060...@ru.mvista.com> you wrote: PowerPC instructions are 32-bit long. So, there are only 16 bits available within the instruction for constant values. Since address can be up to 64 bits, we have to load it a piece at a tim

Re: Simple question about powerpc asm.

2009-07-18 Thread Valentine
HongWoo Lee wrote: Hi all, I was reading kernel level source and found this macro. #define SET_REG_TO_LABEL(reg, label)\ lis reg,(label)@highest;\ ori reg,reg,(label)@higher; \ rldicr reg,reg,32,31; \

[PATCH] PowerPC 44x: ibm4xx_denali_fixup_memsize fix

2009-04-23 Thread Valentine Barshak
memory controller register DDR0_10 otherwise. It also fixes another error in the way ibm4xx_denali_fixup_memsize calculates memory size. When testing the DDR_REDUC bit, the polarity is backwards. A "1" implies 32-bit wide memory while a "0" implies 64-bit wide memory. Sign

Re: [PATCH] PowerPC: 440EPx/GRx Sequoia/Rainier U-Boot incorrect chipselect number workaround

2009-04-23 Thread Valentine
Thanks Steven, Yes, both patches have to be applied. Sorry, I missed a trailing space in the comment. I'll resubmit another one in a bit. Thanks, Val. Steven A. Falco wrote: Thanks for doing this so quickly! I applied your patch plus my patch - my custom board reports the correct memory size.

[PATCH] PowerPC: 440EPx/GRx Sequoia/Rainier U-Boot incorrect chipselect number workaround

2009-04-23 Thread Valentine Barshak
memory controller register DDR0_10 otherwise. Signed-off-by: Valentine Barshak --- arch/powerpc/boot/4xx.c | 52 +-- 1 files changed, 41 insertions(+), 11 deletions(-) diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c index 5c87843

Re: [PATCH] PPC440EPx SDRAM width

2009-04-23 Thread Valentine Barshak
as. Either we never came to a resolution, or I have just forgotten what it was. Stefan, Valentine, do either of you remember? The patch will break sequia/rainier since u-boot doesn't set the number of chipselects correctly for them. IIRC, the last conversation didn't come to any co

Re: [PATCH] PPC440EPx SDRAM width

2009-04-23 Thread Valentine Barshak
Josh Boyer wrote: On Thu, Apr 23, 2009 at 06:40:48PM +0400, Valentine Barshak wrote: Stefan Roese wrote: On Thursday 23 April 2009, Josh Boyer wrote: On Thu, Apr 23, 2009 at 09:36:12AM -0400, Steven A. Falco wrote: There is an error in the way ibm4xx_denali_fixup_memsize calculates memory

Re: [PATCH] PowerPC 440EPx/GRx fix memory size calculation

2009-03-11 Thread Valentine
Josh Boyer wrote: On Wed, Mar 11, 2009 at 10:06:11PM +0300, Valentine Barshak wrote: Josh Boyer wrote: On Tue, Mar 10, 2009 at 10:50:13PM +0300, Valentine Barshak wrote: I was just going to submit a patch for that too. Indeed, the denali_fixup_memsize() miscalculated a couple of address field

Re: [PATCH] PowerPC 440EPx/GRx fix memory size calculation

2009-03-11 Thread Valentine Barshak
Josh Boyer wrote: On Tue, Mar 10, 2009 at 10:50:13PM +0300, Valentine Barshak wrote: I was just going to submit a patch for that too. Indeed, the denali_fixup_memsize() miscalculated a couple of address field widths. We were lucky to eventually get the right result, because the effect of the

Re: [PATCH] PowerPC 440EPx/GRx fix memory size calculation

2009-03-10 Thread Valentine
Mikhail Zolotaryov wrote: Valentine Barshak wrote: According to the AMCC 440EPX/GRX user manual, the Chip Select width is always fixed at 1 bit no matter what is actually read from register DDR_10. Well, from my point of view original kernel code is correct in this part. Adding one bit into

[PATCH] PowerPC 440EPx/GRx fix memory size calculation

2009-03-10 Thread Valentine Barshak
: Valentine Barshak Signed-off-by: Mikhail Zolotaryov --- a/arch/powerpc/boot/4xx.c 2008-04-26 02:18:34.0 +0400 +++ b/arch/powerpc/boot/4xx.c 2008-10-26 01:40:27.0 +0400 @@ -173,15 +173,20 @@ void ibm4xx_denali_fixup_memsize(void) max_col = DDR_GET_VAL(val

Re: Strange behavior with I2C on Sequoia board

2008-08-21 Thread Valentine Barshak
ity-mapped on ppc 44x? Thanks, Valentine. Best regards, Stefan ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev ___ Linuxppc-dev mailing lis

Re: [PATCH 0/9] Rework PowerPC 44x board support

2008-08-20 Thread Valentine Barshak
rms/44x/Kconfig for these boards at all. Just enable all board-specific stuff under "config PPC44x_SIMPLE". Otherwise we probably should have a configurable char *board[] array. Thanks, Valentine. ___ Linuxppc-dev mailing list Linu

Re: platforms/44x/warp-nand.c bogosity

2008-08-01 Thread Valentine Barshak
one done in the next few days I'll included it as well. josh The current community ndfc driver won't build for arch/powerpc. It still uses ioremap64 and includes stuff. Valentine. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

[PATCH] PowerPC 44x: Adjust warp-nand resource end address

2008-07-09 Thread Valentine Barshak
Adjust the NDFC resource end value (resource size = end - start + 1). Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/platforms/44x/warp-nand.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) --- a/arch/powerpc/platforms/44x/warp-nand.c2008-07-01

Re: [PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling

2008-07-07 Thread Valentine Barshak
compatible = "ibm,emac-405ex", "ibm,emac4"; + compatible = "ibm,emac-405ex", "ibm,emac4sync"; interrupt-parent = <&EMAC1>; interrupts = <0 1>;

[PATCH] PowerPC 44x: small warp-nand fix

2008-06-05 Thread Valentine Barshak
The "ndfc-chip" device doesn't need any resources. All resources are handled by the "ndfc-nand" device. Registering the same memory resource twice causes "cat /proc/iomem" to go into an infinite loop displaying NDFC memory addresses. Signed-off-by: Valentine Ba

Re: [PATCH] PowerPC 44x: Add NOR flash entry to Canyonlands DTS.

2008-04-18 Thread Valentine Barshak
Stefan Roese wrote: On Friday 18 April 2008, Valentine Barshak wrote: Right, I forgot to add this. But the partition names and sizes are a little different from those we used before (e.g. kilauea). I'll send a patch to update the Canyonlands & Glacier dts files in a short while. I

Re: [PATCH] PowerPC 44x: Add NOR flash entry to Canyonlands DTS.

2008-04-18 Thread Valentine Barshak
Stefan Roese wrote: On Thursday 17 April 2008, Valentine Barshak wrote: This patch adds NOR flash entry to the PowerPC 460EX Canyonlands DTS. Right, I forgot to add this. But the partition names and sizes are a little different from those we used before (e.g. kilauea). I'll send a pat

[PATCH] PowerPC 44x: Add NOR flash entry to Canyonlands DTS.

2008-04-17 Thread Valentine Barshak
This patch adds NOR flash entry to the PowerPC 460EX Canyonlands DTS. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/canyonlands.dts | 36 ++ 1 files changed, 36 insertions(+) diff -pruN powerpc/arch/powerpc/bo

Re: [PATCH 3/4] PowerPC: Add PCI entry to 440EPx Sequoia DTS.

2008-04-07 Thread Valentine Barshak
Sergei Shtylyov wrote: Valentine Barshak wrote: This adds PCI entry to PowerPC 440EPx Sequoia DTS. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- linux-2.6.orig/arch/powerpc/boot/dts/sequoia.dts2007-12-21 17:14:17.0 +0300 +++ linux-2.6/arch/powerpc/bo

[PATCH] PowerPC 44x: use machine_device_initcall() instead of device_initcall() for warp_nand

2008-04-04 Thread Valentine Barshak
devices are registered if we run on a warp only. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/platforms/44x/warp-nand.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.orig/arch/powerpc/platforms/44x/warp-nand.c 2008-03-06

[PATCH] PowerPC: MPIC ack interrupts at mpic_teardown_this_cpu()

2008-04-03 Thread Valentine Barshak
We really need to ack interrupts at mpic_teardown, since not all platforms reset mpic at kernel start-up. For example, kexec'ed kernel hangs on P.A. Semi if mpic_eoi() isn't called. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/mpic.c |6 +-

[PATCH 1/2] ibm_newemac: PowerPC 440GX EMAC PHY clock workaround

2008-03-27 Thread Valentine Barshak
n the SDR0_MFR register. This patch does the same for "ibm,emac-440gx" compatible chips. The workaround forces clock on -all- EMACs, so we select clock under global emac_phy_map_lock. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c | 16

[PATCH 2/2] ibm_newemac: PowerPC 440EP/440GR EMAC PHY clock workaround

2008-03-27 Thread Valentine Barshak
ction for 440GX. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c | 34 -- drivers/net/ibm_newemac/core.h |6 +- 2 files changed, 37 insertions(+), 3 deletions(-) diff -pruN linux-2.6.orig/drivers/net/ibm_new

[PATCH] ibm_newemac: emac_tx_csum typo fix

2008-03-27 Thread Valentine Barshak
Move the "&& skb->ip_summed == CHECKSUM_PARTIAL" part out of emac_has_feature parameters. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -pruN linux-2.6.o

Re: [PATCH 2/2] ibm_newemac: PowerPC 440EP/440GR EMAC PHY clock workaround

2008-03-27 Thread Valentine Barshak
Josh Boyer wrote: On Tue, 25 Mar 2008 10:22:15 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: On Thu, 2008-03-06 at 16:43 +0300, Valentine Barshak wrote: This patch adds ibm_newemac PHY clock workaround for 440EP/440GR EMAC attached to a PHY which doesn't generate RX clo

Re: [PATCH 2/2] pasemi_mac: Netpoll support

2008-03-26 Thread Valentine Barshak
n.irq, mac->tx); + enable_irq(mac->tx->chan.irq); + + disable_irq(mac->rx->chan.irq); + pasemi_mac_rx_intr(mac->rx->chan.irq, dev); Shouldn't this actually be pasemi_mac_rx_intr(mac->rx->chan.irq, mac->rx)? Thanks, Valentine.

Re: [PATCH] net: NEWEMAC: Support for Pause packets in EMAC driver

2008-03-18 Thread Valentine Barshak
g/linuxppc/patch?id=17214 (not EMAC related) Thanks, Valentine. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] PowerPC 4xx: Use dcri_clrset() for PCIe indirect dcr read/modify/write access

2008-03-06 Thread Valentine Barshak
Use dcri_clrset() for PCIe SDR0 read/modify/write access. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/ppc4xx_pci.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff -pruN linux-2.6.orig/arch/powerpc/sysdev/ppc4xx_pci.c linux-2.

Re: [PATCH] PowerPC 4xx: Use dcri_clrset() for PCIe indirect dcr read/modify/write access

2008-03-06 Thread Valentine Barshak
Oops, sorry, please discard this one. There's a typo in it. The fixed patch is coming right away. Thanks. Valentine. Valentine Barshak wrote: > Use dcri_clrset() for PCIe SDR0 read/modify/write access. > > Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> > ---

[PATCH] PowerPC 4xx: Use dcri_clrset() for PCIe indirect dcr read/modify/write access

2008-03-06 Thread Valentine Barshak
Use dcri_clrset() for PCIe SDR0 read/modify/write access. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/ppc4xx_pci.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff -pruN linux-2.6.orig/arch/powerpc/sysdev/ppc4xx_pci.c linux-2.

[PATCH 2/2] ibm_newemac: PowerPC 440EP/440GR EMAC PHY clock workaround

2008-03-06 Thread Valentine Barshak
ction for 440GX. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c | 34 -- drivers/net/ibm_newemac/core.h |6 +- 2 files changed, 37 insertions(+), 3 deletions(-) diff -pruN linux-2.6.orig/drivers/net/ibm_new

[PATCH 1/2] ibm_newemac: PowerPC 440GX EMAC PHY clock workaround

2008-03-06 Thread Valentine Barshak
n the SDR0_MFR register. This patch does the same for "ibm,emac-440gx" compatible chips. The workaround forces clock on -all- EMACs, so we select clock under global emac_phy_map_lock. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c | 16

Re: [PATCH] PowerPC 4xx: Add dcri_clrset() for locked read/modify/write functionality

2008-03-06 Thread Valentine Barshak
Josh Boyer wrote: > On Thu, 06 Mar 2008 11:06:18 +1100 > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > >> On Wed, 2008-03-05 at 21:38 +0300, Valentine Barshak wrote: >>> This adds dcri_clrset() macro which does read/modify/write >>> on indirect dcr re

[PATCH] PowerPC 4xx: Add dcri_clrset() for locked read/modify/write functionality

2008-03-05 Thread Valentine Barshak
This adds dcri_clrset() macro which does read/modify/write on indirect dcr registers while holding indirect dcr lock. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- include/asm-powerpc/dcr-native.h | 17 + 1 files changed, 17 insertions(+) --- linux-2.6.orig/i

Re: [RFC][PATCH] ibm_newemac: PowerPC 440EP/440GR EMAC PHY clock workaround

2008-03-05 Thread Valentine Barshak
lead to its misuse. I'll submit the patch shortly. Thanks, Valentine. > > Cheers, > Ben. > > > ___ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] PowerPC 44x: add missing define TARGET_4xx and TARGET_440GX to cuboot-taishan.c

2008-02-26 Thread Valentine Barshak
-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/cuboot-taishan.c |2 ++ 1 files changed, 2 insertions(+) diff -pruN linux-2.6.orig/arch/powerpc/boot/cuboot-taishan.c linux-2.6/arch/powerpc/boot/cuboot-taishan.c --- linux-2.6.orig/arch/powerpc/boot/cuboot-taishan.c 2008

Re: [RFC][PATCH] ibm_newemac: PowerPC 440EP/440GR EMAC PHY clock workaround

2008-02-26 Thread Valentine Barshak
Josh Boyer wrote: > On Fri, 22 Feb 2008 22:28:17 +0300 > Valentine Barshak <[EMAIL PROTECTED]> wrote: > >> This patch adds ibm_newemac phy clock workaround for 440EP/440GR emacs. >> The code is based on the previous ibm_emac driver stuff. The 440EP/440GR >> a

[RFC][PATCH] ibm_newemac: PowerPC 440EP/440GR EMAC PHY clock workaround

2008-02-22 Thread Valentine Barshak
This patch adds ibm_newemac phy clock workaround for 440EP/440GR emacs. The code is based on the previous ibm_emac driver stuff. The 440EP/440GR allows controlling each EMAC clock spearately as opposed to global clock selection for 440GX. Signed-off-by: Valentine Barshak <[EMAIL PROTEC

[RFC][PATCH] ibm_newemac: PowerPC 440GX EMAC PHY clock workaround

2008-02-22 Thread Valentine Barshak
patch does the same for "ibm,emac-440gx" compatible chips. The workaround forces clock on -all- EMACs, so we select clock under global emac_phy_map_lock. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c | 16 +++- drivers/n

[PATCH] ibm_newemac: emac_tx_csum typo fix.patch

2008-02-22 Thread Valentine Barshak
Move the "&& skb->ip_summed == CHECKSUM_PARTIAL" part out of emac_has_feature parameters. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -pruN linux-2.6.o

Re: [RFC][PATCH] PowerPC 4xx: ibm_newemac 440GX phy clock workaround.

2008-02-22 Thread Valentine Barshak
Benjamin Herrenschmidt wrote: > On Thu, 2008-02-21 at 17:46 +0300, Valentine Barshak wrote: >> The PowerPC 440GX Taishan board fails to reset EMAC3 (reset timeout error) >> and because of that it can't find PHY chip. The older ibm_emac driver had >> a workaround for t

[RFC][PATCH] PowerPC 4xx: ibm_newemac 440GX phy clock workaround.

2008-02-21 Thread Valentine Barshak
patch does the same for "ibm,emac-440gx" compatible chips. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c | 16 +++- drivers/net/ibm_newemac/core.h |8 ++-- 2 files changed, 21 insertions(+), 3 deletions(-) diff

[PATCH] PowerPC 44x: add missing define TARGET_4xx to cuboot-taishan.c

2008-02-21 Thread Valentine Barshak
In order to get the proper bd_info structure for PowerPC 440, both TARGET_4xx and TARGET_44x should be defined. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/cuboot-taishan.c |1 + 1 files changed, 1 insertion(+) diff -pruN linux-2.6.orig/arch/powerp

Re: [PATCH] MTD support for the AMCC Taishan

2008-02-07 Thread Valentine Barshak
Imre Kaloz wrote: > On Thu, 07 Feb 2008 15:05:23 +0100, Valentine Barshak > <[EMAIL PROTECTED]> wrote: > >>> Well, arch/ppc calculates the mtd2 dynamically and doesn't create >>> a separate partition for kozio. >> >> That dynamic size calculation

Re: [PATCH] MTD support for the AMCC Taishan

2008-02-07 Thread Valentine Barshak
size). So AFAIU if such board exists, we'll need a cuboot flash-size fixup. Thanks, Valentine. > > I've based this on how it's currently done for the Sequoia, too. > > > Imre > > On Thu, 07 Feb 2008 14:46:43 +0100, Valentine Barshak > <[EMAIL PROTECTE

Re: [PATCH] MTD support for the AMCC Taishan

2008-02-07 Thread Valentine Barshak
ernel" mtd1: 0020 0004 "root" mtd2: 03bc 0004 "user" mtd3: 00080000 00040000 "env" mtd4: 0004 0004 "u-boot" Thanks, Valentine. > > Nothing wrong that I could see. I just need to test it first. > > josh > _

[RFC][PATCH] PowerPC: 4xx PCIe indirect DCR spinlock fix.

2008-02-05 Thread Valentine Barshak
twice. To avoid this error, I've added __mfdcri()/__mtdcri() inline functions that take the lock after register name fix-up. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- include/asm-powerpc/dcr-native.h | 49 +++ 1 files changed, 30 inser

[RFC][PATCH] PowerPC: 4xx PCIe indirect DCR spinlock fix.

2008-02-04 Thread Valentine Barshak
To avoid this error, I've added set_dcri() and clr_dcri() macros which set/clear the specified bits. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/ppc4xx_pci.c | 13 + include/asm-powerpc/dcr-native.h | 22 ++ 2 fil

[PATCH] PowerPC: add missing native dcr dcr_ind_lock spinlock

2008-02-04 Thread Valentine Barshak
The include/asm-powerpc/dcr-native.h declares extern spinlock_t dcr_ind_lock; but it's actually isn't defined. This patch adds a missing dcr_ind_lock. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/dcr.c |5 +++-- 1 files changed, 3 insertions

Re: [PATCH] PowerPC: add missing native dcr dcr_ind_lock spinlock

2008-02-04 Thread Valentine Barshak
Oops, sorry, please discard this one. DEFINE_SPINLOCK should be used here. Valentine Barshak wrote: > The include/asm-powerpc/dcr-native.h declares extern spinlock_t dcr_ind_lock, > but it's actually isn't defined. This patch adds a missing dcr_ind_lock. > > Signed-off

[PATCH] PowerPC: add missing native dcr dcr_ind_lock spinlock

2008-02-04 Thread Valentine Barshak
The include/asm-powerpc/dcr-native.h declares extern spinlock_t dcr_ind_lock, but it's actually isn't defined. This patch adds a missing dcr_ind_lock. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/dcr.c |5 +++-- 1 files changed, 3 insertions

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-29 Thread Valentine Barshak
) { >> -if (val && 0x1) >> +if (val & 0x1) >> cs++; >> val = val >> 1; >> } > > Hm, good catch. Yes, thanks! Sequoia and Rainier are currently the only boards using denali control

Re: [PATCH 2/4] PowerPC: update 440EP(x)/440GR(x) identical PVR issue workaround

2007-12-24 Thread Valentine Barshak
Stefan Roese wrote: > Hi Valentine, > > On Friday 21 December 2007, Valentine Barshak wrote: >>> Good catch. I'll have to look more closely to see if anything else >>> would be broken by changing the cpu node name from "PowerPC,[EMAIL >>> PROTEC

Re: [PATCH 2/4] PowerPC: update 440EP(x)/440GR(x) identical PVR issue workaround

2007-12-21 Thread Valentine Barshak
Josh Boyer wrote: > On Fri, 21 Dec 2007 19:24:02 +0300 > Valentine Barshak <[EMAIL PROTECTED]> wrote: > >> Commit 3ee133269861dc449ad5be761aa8570b1b05571f introduced >> a CPU "model" property and thus broke PowerPC 440EP(x)/440GR(x) >> identical PVR work

[PATCH 4/4] PowerPC: Add PCI entry to 440GRx Rainier DTS.

2007-12-21 Thread Valentine Barshak
This adds PCI entry to PowerPC 440GRx Rainier DTS. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/rainier.dts | 27 +++ 1 files changed, 27 insertions(+) --- linux-2.6.orig/arch/powerpc/boot/dts/rainier.dts2007-12-19

Re: [PATCH 4/4] PowerPC: Add PCI node to 440GRx Rainier DTS.

2007-12-21 Thread Valentine Barshak
o dts, which have been fixed :). I'll send the corrected patch right away. Thanks, Valentine. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 4/4] PowerPC: Add PCI node to 440GRx Rainier DTS.

2007-12-21 Thread Valentine Barshak
This adds PCI entry to PowerPC 440GRx Rainier DTS. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/rainier.dts | 27 +++ 1 files changed, 27 insertions(+) --- linux-2.6.orig/arch/powerpc/boot/dts/rainier.dts2007-12-19

[PATCH 3/4] PowerPC: Add PCI entry to 440EPx Sequoia DTS.

2007-12-21 Thread Valentine Barshak
This adds PCI entry to PowerPC 440EPx Sequoia DTS. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/sequoia.dts | 27 +++ 1 files changed, 27 insertions(+) --- linux-2.6.orig/arch/powerpc/boot/dts/sequoia.dts2007-12-21

[PATCH 2/4] PowerPC: update 440EP(x)/440GR(x) identical PVR issue workaround

2007-12-21 Thread Valentine Barshak
Commit 3ee133269861dc449ad5be761aa8570b1b05571f introduced a CPU "model" property and thus broke PowerPC 440EP(x)/440GR(x) identical PVR workaround. The patch updates it to use the new model property for CPU identification. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> -

[PATCH 1/4] PowerPC: Correct 440GRx machine_check callback

2007-12-21 Thread Valentine Barshak
Correct the PowerPC 440GRx machine check callback. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/kernel/cputable.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -pruN linux-2.6.orig/arch/powerpc/kernel/cputable.c linux-2.6/arch/powerpc/kernel/cput

[PATCH 0/4] PowerPC: more Sequoia/Rainier updates for 2.6.25

2007-12-21 Thread Valentine Barshak
This patch series has a couple of PowerPC 440EPx/GRx fixes and adds PCI to Sequoia/Rainier DTS. Thanks, Valentine. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 11/20] [POWERPC] Wire up PCI on Bamboo board

2007-12-20 Thread Valentine Barshak
Benjamin Herrenschmidt wrote: > On Wed, 2007-12-19 at 16:34 +0300, Valentine Barshak wrote: > >>> --- linux-work.orig/arch/powerpc/boot/dts/bamboo.dts2007-12-10 >>> 15:56:59.0 +1100 >>> +++ linux-work/arch/powerpc/boot/dts/bamboo.dts 2007-12

Re: [PATCH 11/20] [POWERPC] Wire up PCI on Bamboo board

2007-12-19 Thread Valentine Barshak
* Config space access */ > +0 eed8 4 /* IACK */ > +0 eed8 4 /* Special cycle */ > +0 ef48 40>; /* Internal registers */ Why ef48 here? IIRC, the docs say it should be ef40, while

[PATCH] PowerPC 4xx: rework UIC cascade irq handling

2007-12-06 Thread Valentine Barshak
rq. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/uic.c | 36 +++- 1 files changed, 19 insertions(+), 17 deletions(-) diff -pruN linux-2.6.orig/arch/powerpc/sysdev/uic.c linux-2.6/arch/powerpc/sysdev/uic.c --- linux-2.6.ori

[PATCH 3/3] PowerPC: ibm_newemac call dev_set_drvdata() before tah_reset()

2007-11-23 Thread Valentine Barshak
The patch moves dev_set_drvdata(&ofdev->dev, dev) up before tah_reset(ofdev) is called to avoid a NULL pointer dereference, since tah_reset uses drvdata. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/tah.c |3 ++- 1 files changed, 2 ins

[PATCH 2/3] PowerPC: ibm_newemac tah_ph typo fix

2007-11-23 Thread Valentine Barshak
This patch fixes a typo in ibm_newemac/core.c (tah_port should be used instead of tah_ph) Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -pruN linux-2.6.orig/drivers/net/ibm_newemac/

[PATCH 1/3] PowerPC: ibm_newemac correct opb_bus_freq value

2007-11-23 Thread Valentine Barshak
The EMAC4_MR1_OBCI(freq) macro expects freg in MHz, while opb_bus_freq is kept in Hz. Correct this. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -pruN linux-2.6.orig/drivers/net/ibm_n

[PATCH 0/3] PowerPC: ibm_newemac minor fixes.

2007-11-23 Thread Valentine Barshak
These patches have some minor ibm_newemac fixes. Thanks, Valentine. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 2/2] PowerPC: make 4xx uic use generic level irq handler

2007-11-14 Thread Valentine Barshak
ral source. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/uic.c | 81 ++ 1 files changed, 19 insertions(+), 62 deletions(-) --- linux-2.6.orig/arch/powerpc/sysdev/uic.c2007-11-14 15:57:37.0 +0300 ++

Re: [PATCH 2/2] PowerPC: make 4xx uic use generic edge and level irq handlers

2007-11-14 Thread Valentine Barshak
't > totally agree here. Basically, what handle_edge_irq() does is lazy > masking. Now there -is- an issue here is that if you do lazy masking, > you need to be able to re-emit in some convenient way. With the ack quirks added we can use handle_level_irq for edge-triggered interrupts. I'

[PATCH 2/2] PowerPC: make 4xx uic use generic edge and level irq handlers

2007-11-14 Thread Valentine Barshak
after the ISR has de-asserted the external interrupt source. Even if we ack the interrupt that we didn't handle (unmask/ack it at the end of the handler, while next irq is already pending) it will not de-assert the irq, untill we de-assert its exteral source. Signed-off-by: Valentine Barsh

[PATCH 1/2] PowerPC: 4xx uic: add mask_ack callback

2007-11-13 Thread Valentine Barshak
This adds uic_mask_ack_irq() callback to PowerPC 4xx uic code to avoid kernel crash. It is used for edge-triggered interrupts by handle_uic_irq(). Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/uic.c | 18 +- 1 files changed, 17 insertions

[PATCH 0/2] PowerPC: 4xx uic updates

2007-11-13 Thread Valentine Barshak
lways stays asserted untill the external source is removed and ack'ed on UIC. These have been tested on Sequoia PowerPC 440EPx board. Thanks, Valentine. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] balance ioremap/iounmap in {sycamore, walnut}_setup_arch()

2007-11-08 Thread Valentine Barshak
ign pointers here, not actually reading the registers. Also, looks like you unmap the fpga registers too early. Thanks, Valentine. > -- > Balance ioremap/iounmap > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/arch/ppc/platforms/4xx/sycamore.c > b/arc

Re: [PATCH 0/3] Add device-tree aware NDFC driver

2007-11-06 Thread Valentine Barshak
Thomas Gleixner wrote: > Valentine, >> You know, you're really too tense Thomas. I'm not sure of the reason why >> you're being a complete nerve, but I'm feeling sorry for you. > > You have a perception problem. I'm not tense, I'm grumpy. :) &g

Re: [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-11-01 Thread Valentine Barshak
hanging to the usb-ohci with a property sounds fine to me if you > really want to but don't drop support for the old values. They are not > "bad". Change the dts to reflect the fact that the new "way" is preferred > and a comment somewhere in the code and that should

Re: [PATCH 2/4] PowerPC: 440GRx Rainier DTS.

2007-10-31 Thread Valentine Barshak
Olof Johansson wrote: > On Wed, Oct 31, 2007 at 10:08:05AM +1100, David Gibson wrote: >> On Tue, Oct 30, 2007 at 07:56:50PM +0300, Valentine Barshak wrote: >>> PowerPC 440GRx Rainier DTS. >> [snip] >>> + SDRAM0: sdram { >>> +

Re: [PATCH 3/4] PowerPC: 440GRx Rainier board support.

2007-10-31 Thread Valentine Barshak
Stephen Rothwell wrote: > On Tue, 30 Oct 2007 19:57:39 +0300 Valentine Barshak <[EMAIL PROTECTED]> > wrote: >> +++ linux-2.6/arch/powerpc/platforms/44x/rainier.c 2007-10-30 >> 18:00:15.0 +0300 >> +#include >> +#include >> +#include

Re: [PATCH 0/4] PowerPC: 440GRx Rainier board support.

2007-10-31 Thread Valentine Barshak
Josh Boyer wrote: > On Tue, 30 Oct 2007 19:45:11 +0300 > Valentine Barshak <[EMAIL PROTECTED]> wrote: > >> The following patches add PowerPC 440GRx Rainier board support. >> The board is almost identical to Sequoia, but doesn't have USB >> and FPU is not supp

Re: [PATCH 0/4] PowerPC: 440GRx Rainier board support.

2007-10-30 Thread Valentine Barshak
Josh Boyer wrote: > On Tue, 30 Oct 2007 19:45:11 +0300 > Valentine Barshak <[EMAIL PROTECTED]> wrote: > >> The following patches add PowerPC 440GRx Rainier board support. >> The board is almost identical to Sequoia, but doesn't have USB >> and FPU is not sup

[PATCH 4/4] PowerPC: 440GRx Rainier default config

2007-10-30 Thread Valentine Barshak
PowerPC 440GRx Rainier default config. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/configs/rainier_defconfig | 868 + 1 files changed, 868 insertions(+) diff -pruN linux-2.6.orig/arch/powerpc/configs/rainier_defconfig linux-2.

[PATCH 3/4] PowerPC: 440GRx Rainier board support.

2007-10-30 Thread Valentine Barshak
PowerPC 440GRx Rainier board support. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/platforms/44x/Kconfig | 16 - arch/powerpc/platforms/44x/Makefile |3 + arch/powerpc/platforms/44x/rainier.c | 61 +++ 3 files c

[PATCH 2/4] PowerPC: 440GRx Rainier DTS.

2007-10-30 Thread Valentine Barshak
PowerPC 440GRx Rainier DTS. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/rainier.dts | 312 ++ 1 files changed, 312 insertions(+) diff -pruN linux-2.6.orig/arch/powerpc/boot/dts/rainier.dts linux-2.6/arch/powerpc/bo

[PATCH 1/4] PowerPC: 440GRx Rainier bootwrapper.

2007-10-30 Thread Valentine Barshak
Bootwrapper code for PowerPC 440GRx Rainier board. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile |3 + arch/powerpc/boot/cuboot-rainier.c | 56 + 2 files changed, 58 insertions(+), 1 deletion(-) diff

[PATCH 0/4] PowerPC: 440GRx Rainier board support.

2007-10-30 Thread Valentine Barshak
The following patches add PowerPC 440GRx Rainier board support. The board is almost identical to Sequoia, but doesn't have USB and FPU is not supported. Thanks, Valentine. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/ma

Re: [PATCH 0/3] Add device-tree aware NDFC driver

2007-10-30 Thread Valentine Barshak
Thomas Gleixner wrote: > On Mon, 29 Oct 2007, Valentine Barshak wrote: > >> This adds a device-tree aware PowerPC 44x NanD Flash Controller driver >> The code is based on the original NDFC driver by Thomas Gleixner, but >> since it's been changed much and has initi

[PATCH] MTD: small physmap_of partition parsing fixes

2007-10-29 Thread Valentine Barshak
Use of_get_next_child for proper ref counting as suggested by Stephen Rothwell and remove add_mtd_partitions from parse_partitions to avoid duplicate mtd device registration for RedBoot partitions. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/mtd/maps/physmap_of.c

  1   2   3   >