Re: [PATCH] fsl-diu-fb: remove the ioctl interface

2011-09-21 Thread Anatolij Gustschin
On Wed, 21 Sep 2011 02:10:42 + Tabi Timur-B04825 b04...@freescale.com wrote: ... The definitions of MFB_SET_PIXFMT and MFB_GET_PIXFMT are wrong: #define MFB_SET_PIXFMT 0x80014d08 #define MFB_GET_PIXFMT 0x40014d08 The 01 is the size. However, these ioctls take a __u32

Re: [PATCH] fsl-diu-fb: remove the ioctl interface

2011-09-20 Thread Tabi Timur-B04825
Anatolij, I'm sorry to resurrect an old thread, but ... On Wed, Jun 22, 2011 at 3:11 PM, Anatolij Gustschin ag...@denx.de wrote: On Tue, 21 Jun 2011 23:13:11 + Tabi Timur-B04825 b04...@freescale.com wrote: Anatolij Gustschin wrote: No! We are using ioctl interface of this driver in

Re: [PATCH] fsl-diu-fb: remove the ioctl interface

2011-06-23 Thread Anatolij Gustschin
On Wed, 22 Jun 2011 11:39:49 +0100 Jenkins, Clive clive.jenk...@xerox.com wrote: ... Removing the ioctl interface also allows us to clean up the header file and remove other unusued stuff. No! We are using ioctl interface of this driver in many video rendering applications on overlay

Re: [PATCH] fsl-diu-fb: remove the ioctl interface

2011-06-23 Thread Tabi Timur-B04825
Anatolij Gustschin wrote: I do not have the code of the real applications since I didn't wrote it. All I can share is the test and sample code that I used when working on driver fixes: test-app:http://pastebin.com/J2RvKb6n What's the VIU? -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] fsl-diu-fb: remove the ioctl interface

2011-06-23 Thread Anatolij Gustschin
On Thu, 23 Jun 2011 11:29:42 + Tabi Timur-B04825 b04...@freescale.com wrote: ... test-app:http://pastebin.com/J2RvKb6n What's the VIU? Video-IN unit on mpc5121e (for capturing ITU656 video stream data). ___ Linuxppc-dev mailing list

RE: [PATCH] fsl-diu-fb: remove the ioctl interface

2011-06-22 Thread Jenkins, Clive
The ioctl interface in the Freescale DIU framebuffer driver is just a collection of miscellaneous functions which were only used in a one-time demo application that was never distributed. Plus, the ioctls were spread across two types (both conflicting), and the demo app didn't even use

Re: [PATCH] fsl-diu-fb: remove the ioctl interface

2011-06-22 Thread Anatolij Gustschin
On Tue, 21 Jun 2011 23:13:11 + Tabi Timur-B04825 b04...@freescale.com wrote: Anatolij Gustschin wrote: No! We are using ioctl interface of this driver in many video rendering applications on overlay planes on huge number of boards. So, please don't remove it. Ok, I had no idea

[PATCH] fsl-diu-fb: remove the ioctl interface

2011-06-21 Thread Timur Tabi
The ioctl interface in the Freescale DIU framebuffer driver is just a collection of miscellaneous functions which were only used in a one-time demo application that was never distributed. Plus, the ioctls were spread across two types (both conflicting), and the demo app didn't even use all of

Re: [PATCH] fsl-diu-fb: remove the ioctl interface

2011-06-21 Thread Anatolij Gustschin
On Tue, 21 Jun 2011 16:27:35 -0500 Timur Tabi ti...@freescale.com wrote: The ioctl interface in the Freescale DIU framebuffer driver is just a collection of miscellaneous functions which were only used in a one-time demo application that was never distributed. Plus, the ioctls were spread

Re: [PATCH] fsl-diu-fb: remove the ioctl interface

2011-06-21 Thread Tabi Timur-B04825
Anatolij Gustschin wrote: No! We are using ioctl interface of this driver in many video rendering applications on overlay planes on huge number of boards. So, please don't remove it. Ok, I had no idea anyone was using it. Can you email me details about how you use the ioctl interface? If I