Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-24 Thread David Brownell
On Wednesday 24 October 2007, Matt Sealey wrote: > Can we just make sure real quickly that the changing of compatibles > doesn't break existing, not-easily-flashable firmwares? Yeah, I'm not keen on such breakage either... ___ Linuxppc-dev mailing list L

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-24 Thread Grant Likely
On 10/24/07, David Brownell <[EMAIL PROTECTED]> wrote: > On Wednesday 24 October 2007, Matt Sealey wrote: > > Can we just make sure real quickly that the changing of compatibles > > doesn't break existing, not-easily-flashable firmwares? > > Yeah, I'm not keen on such breakage either... Add my voi

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-25 Thread Valentine Barshak
Grant Likely wrote: > On 10/24/07, David Brownell <[EMAIL PROTECTED]> wrote: >> On Wednesday 24 October 2007, Matt Sealey wrote: >>> Can we just make sure real quickly that the changing of compatibles >>> doesn't break existing, not-easily-flashable firmwares? >> Yeah, I'm not keen on such breakage

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-25 Thread Grant Likely
On 10/25/07, Valentine Barshak <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > > On 10/24/07, David Brownell <[EMAIL PROTECTED]> wrote: > >> On Wednesday 24 October 2007, Matt Sealey wrote: > >>> Can we just make sure real quickly that the changing of compatibles > >>> doesn't break existing, no

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-25 Thread Valentine Barshak
Grant Likely wrote: > On 10/25/07, Valentine Barshak <[EMAIL PROTECTED]> wrote: >> Grant Likely wrote: >>> On 10/24/07, David Brownell <[EMAIL PROTECTED]> wrote: On Wednesday 24 October 2007, Matt Sealey wrote: > Can we just make sure real quickly that the changing of compatibles > doe

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-25 Thread Matt Sealey
Compatible property on /[EMAIL PROTECTED]/[EMAIL PROTECTED] is ohci-bigendian ohci-be mpc5200-ohci mpc5200-usb device_type is "usb", model is "mpc5200-ohci". Although I worry about cluttering up the cleanup, it is probably just adding an "if property(big-endian) OR compatible(mpc5200-ohci)" to t

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-25 Thread Matt Sealey
Grant Likely wrote: > On 10/25/07, Valentine Barshak <[EMAIL PROTECTED]> wrote: > > If it doesn't, it can be added during prom_init.c We're already doing > a bunch of efika fixups there anyway. I want those to go away. Far, far away. http://www.powerdeveloper.org/platforms/efika/devicetree No

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-25 Thread Matt Sealey
Valentine, Please do the very minimal required to keep supporting the Efika. As for an little endian OHCI controller on an OF bus, I would not consider it an impossibility. But, not having the big-endian property fixes this; OHCI is little-endian by default. You need only report "difference" in d

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-25 Thread Valentine Barshak
Matt Sealey wrote: > Valentine, > > Please do the very minimal required to keep supporting the Efika. > > As for an little endian OHCI controller on an OF bus, I would not > consider it an impossibility. But, not having the big-endian > property fixes this; OHCI is little-endian by default. You n

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-25 Thread Valentine Barshak
Matt Sealey wrote: > Compatible property on /[EMAIL PROTECTED]/[EMAIL PROTECTED] is > > ohci-bigendian > ohci-be > mpc5200-ohci > mpc5200-usb > > device_type is "usb", model is "mpc5200-ohci". > > Although I worry about cluttering up the cleanup, it is probably just > adding an "if property(big-

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-25 Thread Matt Sealey
Valentine Barshak wrote: > Matt Sealey wrote: >> Compatible property on /[EMAIL PROTECTED]/[EMAIL PROTECTED] is > > We should also keep "ohci-bigendian" and "ohci-be" in the match table. Eh.. maybe. >> I am currently moving on the assumption that the "correct" device >> tree for the Efika (notwi

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-10-26 Thread Valentine Barshak
Matt Sealey wrote: > Valentine Barshak wrote: >> Matt Sealey wrote: >>> Compatible property on /[EMAIL PROTECTED]/[EMAIL PROTECTED] is >> >> We should also keep "ohci-bigendian" and "ohci-be" in the match table. > > Eh.. maybe. > >>> I am currently moving on the assumption that the "correct" devi

Re: [linux-usb-devel] [PATCH 1/2] USB: Rework OHCI PPC OF for new bindings

2007-11-01 Thread Dale Farnsworth
Sylvain Munaut wrote: > > Valentine Barshak wrote: > >> Rework ohci-ppc-of driver to use big-endian property instead of > >> ohci-be/ohci-le compatible strings. Also remove unnecessary > >> user-selectable USB_OHCI_HCD_PPC_OF_LE/BE stuff, because > >> USB_OHCI_BIG_ENDIAN_DESC/MMIO should always be