Re: [PATCH 2/2] powerpc: Make context bits depend on virtual addr size.

Hi Aneesh, On Wed, 2013-02-13 at 17:10 +0530, Aneesh Kumar K.V wrote: Ok. How about the below patch. This is based on the suggestion from Paulus. I still have to take care of few comments in the code. Phileas and Geoff, Can we check whether this fix the PS3 boot hang ? I did a quick

Re: [PATCH] powerpc: Apply early paca fixups to boot_paca and the boot cpu's paca

cpu. Signed-off-by: Michael Ellerman mich...@ellerman.id.au Tested-by: Geoff Levand ge...@infradead.org This fixes a boot hang on the PS3 with ps3_defconfig builds of linux-3.7. Please consider applying for linux-3.7.x stable. -Geoff ___ Linuxppc-dev

[PATCH 1/4] powerpc/ps3: Add macro PS3_VERBOSE_RESULT

To allow more control of the verbosity of ps3_result() add a check for the preprocessor macro PS3_VERBOSE_RESULT that builds a verbose verion of the ps3_result() routine. Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/include/asm/ps3.h |2 +- 1 file changed, 1 insertion

[PATCH 2/4] powerpc/ps3: Increase verbosity of htab errors

Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/platforms/ps3/htab.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/ps3/htab.c b/arch/powerpc/platforms/ps3/htab.c index d00d7b0..6cc5820 100644 --- a/arch/powerpc

[PATCH 3/4] powerpc/ps3: Refresh ps3_defconfig

Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/configs/ps3_defconfig | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/configs/ps3_defconfig b/arch/powerpc/configs/ps3_defconfig index c2f4b4a..7a5c15f 100644 --- a/arch/powerpc

[PATCH 4/4] powerpc: Move boot_paca into early_setup

The powerpc boot_paca symbol is now only used within the early_setup() routine, so move it from its global definition into early_setup(). Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/include/asm/paca.h |1 - arch/powerpc/kernel/paca.c |2 -- arch/powerpc/kernel

[PATCH 0/4] PS3 patches for 3.9

://git.kernel.org/pub/scm/linux/kernel/git/geoff/ps3-linux.git for-powerpc for you to fetch changes up to f9fda8ea9d2ef07dd5b3313892ec20b6cbad2ce8: powerpc: Move boot_paca into early_setup (2013-02-13 18:07:41 -0800) Geoff Levand

Re: PS3: Strange issue with kexec and FreeBSD loader

Hi Phileas, On Sun, 2013-02-17 at 00:12 +0100, Phileas Fogg wrote: I found new clues about the problem. Normally the device tree memory segment is allocated at the top of the boot memory region. The boot memory size on the PS3 console is 128MB. root@ps3-linux:~# kexec -l loader.ps3

Re: [PATCH] ps3: remove driver_data direct access of struct device

Hi Roel, On 05/11/2009 12:34 PM, Roel Kluin wrote: To avoid direct access to the driver_data pointer in struct device, the functions dev_get_drvdata() and dev_set_drvdata() should be used. Signed-off-by: Roel Kluin roel.kl...@gmail.com --- Please review. especially note that I removed a

[patch] powerpc/ps3: Update ps3_defconfig

Refresh and set these options: CONFIG_SYSFS_DEPRECATED_V2: y - n CONFIG_INPUT_JOYSTICK: y - n CONFIG_HID_SONY:n - m CONFIG_RTC_DRV_PS3: - - m Signed-off-by: Geoff Levand geoffrey.lev...@am.sony.com --- Ben, Please apply for 2.6.30. -Geoff arch/powerpc/configs

Re: [PATCH 18/33] ps3: ps3_system_bus_device - Use dev_[gs]et_drvdata() instead of direct access

On 06/10/2009 07:38 AM, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert.uytterhoe...@sonycom.com Cc: Geoff Levand geoffrey.lev...@am.sony.com --- arch/powerpc/include/asm/ps3.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Acked-by: Geoff Levand

Re: [PATCH 25/33] drivers/ps3: Add missing annotations

On 06/10/2009 07:39 AM, Geert Uytterhoeven wrote: probe functions should be __devinit initialization functions should be __init Signed-off-by: Geert Uytterhoeven geert.uytterhoe...@sonycom.com Cc: Geoff Levand geoffrey.lev...@am.sony.com --- drivers/ps3/ps3-sys-manager.c |2

Re: [PATCH 23/33] net/ps3: gelic - Add missing annotations

On 06/10/2009 07:38 AM, Geert Uytterhoeven wrote: probe functions should be __devinit Signed-off-by: Geert Uytterhoeven geert.uytterhoe...@sonycom.com Cc: Geoff Levand geoffrey.lev...@am.sony.com --- drivers/net/ps3_gelic_net.c | 22 -- drivers/net

Re: [PATCH 24/33] usb/ps3: Add missing annotations

On 06/10/2009 07:38 AM, Geert Uytterhoeven wrote: probe functions should be __devinit initialization functions should be __init Signed-off-by: Geert Uytterhoeven geert.uytterhoe...@sonycom.com Cc: Geoff Levand geoffrey.lev...@am.sony.com --- drivers/usb/host/ehci-ps3.c |4

Re: [PATCH 19/33] ps3: shorten ps3_system_bus_[gs]et_driver_data to ps3_system_bus_[gs]et_drvdata

On 06/10/2009 07:38 AM, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert.uytterhoe...@sonycom.com Cc: Geoff Levand geoffrey.lev...@am.sony.com Cc: Jim Paris j...@jtan.com --- arch/powerpc/include/asm/ps3.h |4 +- drivers/block/ps3disk.c| 23

Re: [PATCH] powerpc/ps3: Use pr_devel() in ps3/mm.c

-by: Geoff Levand geoffrey.lev...@am.sony.com ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [Bugme-new] [Bug 13304] New: ehci_hcd module causing problems in using usb head phone

Hi, On 06/26/2009 08:54 AM, Alan Stern wrote: On Fri, 26 Jun 2009, abhishekkumar wrote: bus ps3_system_bus, device sb_05 (driver 10 Dec 2004) PS3 EHCI Host Controller EHCI ff.ff, hcd state 1 structural params 0x capability params 0x status Async Periodic Recl Halt

Re: [Bugme-new] [Bug 13304] New: ehci_hcd module causing problems in using usb head phone

On 06/26/2009 01:42 PM, Alan Stern wrote: On Fri, 26 Jun 2009, Geoff Levand wrote: There is a known but yet unfixed bug for the PS3's EHCI Async Periodic (typically audio recording) device handling. There are a few related hardware errata that I have not yet implemented driver fixes

Re: [PATCH 05/62] arch/powerpc: Remove unnecessary semicolons

/pic.c|2 +- arch/powerpc/platforms/ps3/system-bus.c |1 - arch/powerpc/sysdev/fsl_rio.c|2 +- arch/powerpc/sysdev/ppc4xx_pci.c |4 ++-- 7 files changed, 7 insertions(+), 8 deletions(-) For ps3/system-bus.c only. Acked-by: Geoff Levand

Re: [Bugme-new] [Bug 13304] New: ehci_hcd module causing problems in using usb head phone

On 06/26/2009 06:33 PM, Alan Stern wrote: On Fri, 26 Jun 2009, Geoff Levand wrote: Where is the information about the hardware errata you mentioned? Sorry, I should have mentioned it. Unfortunately, that info is not in the public as far as I know. I think only someone with access

[PATCH 0/2] PS3 fixes for 3.2

Ben, Here are two fixes for PS3. Please apply for 3.2. -Geoff The following changes are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/geoff/ps3-linux.git for-powerpc Geoff Levand (2): powerpc/ps3: Fix lost SMP IPIs powerpc/ps3: Fix SMP lockdep boot

[PATCH 1/2] powerpc/ps3: Fix lost SMP IPIs

to the same target in a relatively short period of time the second IPI event can become lost when lv1_end_of_interrupt_ext() is called from ps3_chip_eoi(). CC: sta...@kernel.org Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/platforms/ps3/interrupt.c | 23

[PATCH 2/2] powerpc/ps3: Fix SMP lockdep boot warning

Move the PS3 IPI message setup from ps3_smp_setup_cpu() to ps3_smp_probe(). Fixes startup warnings like these: [ cut here ] WARNING: at kernel/lockdep.c:2649 Modules linked in: ... ---[ end trace 31fd0ba7d8756001 ]--- Signed-off-by: Geoff Levand ge

[GIT PULL] PS3 updates for powerpc next

-rc3 are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/geoff/ps3-linux.git for-powerpc Geoff Levand (8): powerpc/ps3: Interrupt code cleanup powerpc/ps3: Fix hcall lv1_net_stop_rx_dma powerpc/ps3: Fix hcall

[PATCH 5/8] powerpc/ps3: Fix hcall lv1_read_repository_node

The lv1 hcall #91 should be named lv1_read_repository_node, and not lv1_get_repository_node_value. Adjust the lv1 hcall table and all calls. Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/include/asm/lv1call.h |2 +- arch/powerpc/platforms/ps3/repository.c |4

[PATCH 3/8] powerpc/ps3: Fix hcall lv1_get_virtual_address_space_id_of_ppe

The lv1_get_virtual_address_space_id_of_ppe hcall takes 0, not 1 input arguments. Adjust the lv1 hcall table and all calls. Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/include/asm/lv1call.h |2 +- arch/powerpc/platforms/ps3/spu.c |2 +- 2 files changed, 2

[PATCH 2/8] powerpc/ps3: Fix hcall lv1_net_stop_rx_dma

The lv1_net_stop_tx_dma and net_stop_rx_dma hcalls take 2, not 3 input arguments. Adjust the lv1 hcall table and all calls. Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/include/asm/lv1call.h |4 ++-- drivers/net/ethernet/toshiba/ps3_gelic_net.c |4 ++-- 2

[PATCH 1/8] powerpc/ps3: Interrupt code cleanup

pr_debug to pr_devel o Add new macro FAIL to replace pr_debug calls Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/platforms/ps3/interrupt.c | 103 --- 1 files changed, 53 insertions(+), 50 deletions(-) diff --git a/arch/powerpc/platforms/ps3

[PATCH 8/8] powerpc/ps3: Update ps3_defconfig

Refresh ps3_defconfig to latest kernel sources and change the options: CONFIG_PPP=m to CONFIG_PPP=n. CONFIG_NAMESPACES=y to CONFIG_NAMESPACES=n CONFIG_NUMA=y to CONFIG_NUMA=n Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/configs/ps3_defconfig | 39

[PATCH 6/8] powerpc/ps3: Fix pr_debug build warnings

Fix some PS3 build warnings when DEBUG is defined. Fixes warnings like these: format '%lx' expects type 'long unsigned int', but argument 7 has type 'u64' Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/platforms/ps3/repository.c | 14 -- 1 files changed, 8

[PATCH 7/8] powerpc/ps3: Add __init to ps3_smp_probe

Add an __init annotation to the ps3_smp_probe() routine. Fixes build warnings like these when CONFIG_DEBUG_SECTION_MISMATCH=y: WARNING: Section mismatch in reference from the function .ps3_smp_probe() Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/platforms/ps3/smp.c |2

Re: [PATCH 2/8] powerpc/ps3: Fix hcall lv1_net_stop_rx_dma

Hi Dave, Unfortunately, your address got cut off for this patch. I think Ben can merge this one through his powerpc tree since it is just a trivial change to the ps3 gelic net driver. Please consider. -Geoff On Wed, 2011-11-30 at 01:38 +, Geoff Levand wrote: The lv1_net_stop_tx_dma

[PATCH 6/8 v2] powerpc/ps3: Fix PS3 repository build warnings

Fix some PS3 repository.c build warnings when DEBUG is defined. Also change most pr_debug calls to pr_devel calls. Fixes warnings like these: format '%lx' expects type 'long unsigned int', but argument 7 has type 'u64' Signed-off-by: Geoff Levand ge...@infradead.org --- Hi Ben, I rebased my

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote: Remove the function ps3_repository_write_highmem_info() that is not used anywhere. NAK ps3_repository_write_highmem_info() is needed by otheros++. What we need is a kernel patch to add the highmem info to the repository once it is

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

Hi Michael, On Tue, 2014-12-23 at 11:26 +1100, Michael Ellerman wrote: On Mon, 2014-12-22 at 09:26 -0800, Geoff Levand wrote: ps3_repository_write_highmem_info() is needed by otheros++. What we need is a kernel patch to add the highmem info to the repository once it is known. OK so

[PATCH 2/6] powerpc/ps3: Add ps3_mm_set_repository_highmem

region entry (at index 0). Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/platforms/ps3/mm.c | 68 +++-- 1 file changed, 38 insertions(+), 30 deletions(-) diff --git a/arch/powerpc/platforms/ps3/mm.c b/arch/powerpc/platforms/ps3/mm.c index 0c9f643

[PATCH 6/6] powerpc/ps3: Update ps3_defconfig

Refresh ps3_defconfig and add CONFIG_PS3_REPOSITORY_WRITE=y. Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/configs/ps3_defconfig | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/arch/powerpc/configs/ps3_defconfig b/arch/powerpc/configs

[PATCH 0/6] *** SUBJECT HERE ***

to c9fc20b63c625d8d5c136f1e72d9930a6b0070df: powerpc/ps3: Update ps3_defconfig (2014-12-23 14:56:29 -0800) Geoff Levand (6): powerpc/ps3: Add empty repository highmem routines powerpc/ps3: Add ps3_mm_set_repository_highmem

[PATCH 3/6] powerpc/ps3: Write highmem info to repository

Add calls to the ps3_mm_set_repository_highmem() routine when the ps3 r1 highmem region is either created or destroyed. Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/platforms/ps3/mm.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/powerpc

[PATCH 5/6] powerpc/ps3: Fix sys-manager-core sparse warnings

Fixes warnings like these: drivers/ps3/sys-manager-core.c: error: symbol 'ps3_sys_manager_power_off' redeclared with different type Signed-off-by: Geoff Levand ge...@infradead.org --- drivers/ps3/sys-manager-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 4/6] powerpc/ps3: Fix vuart sparse warnings

Fix sparse warnings like these: drivers/ps3/ps3-vuart.c: warning: symbol 'ps3_vuart_disable_interrupt_tx' was not declared. Should it be static? Signed-off-by: Geoff Levand ge...@infradead.org --- drivers/ps3/ps3-vuart.c | 5 - drivers/ps3/vuart.h | 16 2 files

[PATCH 1/6] powerpc/ps3: Add empty repository highmem routines

To avoid the need for preprocessor conditionals in C source files add a set of empty inline repository highmem write routines to platform.h that are used when CONFIG_PS3_REPOSITORY_WRITE is not defined. Signed-off-by: Geoff Levand ge...@infradead.org --- arch/powerpc/platforms/ps3/platform.h

Re: [PATCH 3/6] powerpc/ps3: Write highmem info to repository

Hi Michael, On Tue, 2015-01-13 at 14:04 +1100, Michael Ellerman wrote: On Tue, 2015-01-13 at 01:00 +, Geoff Levand wrote: Add calls to the ps3_mm_set_repository_highmem() routine when the ps3 r1 highmem region is either created or destroyed. What does this actually do? ie. from a user

Re: [PATCH] ps3: Fix trivial typos in comment and debug message

On Sat, 2015-03-07 at 13:03 +0100, Yannick Guerrini wrote: Change 'prosessor' to 'processor' Change 'set_inteval' to 'set_interval' Signed-off-by: Yannick Guerrini yguerr...@tomshardware.fr --- drivers/ps3/ps3-lpm.c | 4 ++-- Looks good. Thanks for the fixes. Acked-by: Geoff Levand ge

[PATCH 0/3] block/ps3vram: Minor updates and fixes

to 1d082300a03a735c006739907e6aea082007663c: MAINTAINERS: Update ps3vram block driver (2015-06-10 10:46:25 -0700) Geert Uytterhoeven (1): block/ps3vram: Remove obsolete reference to MTD Geoff Levand (2): block/ps3vram: Fix sparse warnings

[PATCH 1/3] block/ps3vram: Fix sparse warnings

...@kernel.dk Signed-off-by: Geoff Levand ge...@infradead.org --- drivers/block/ps3vram.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c index ef45cfb..a7bf836 100644 --- a/drivers/block/ps3vram.c

[PATCH] net/ps3_gelic: Fix build error with DEBUG

gelic_descr_get_status Signed-off-by: Geoff Levand ge...@infradead.org --- Dave, please apply. -Geoff The following changes since commit d4a4f75cd8f29cd9464a5a32e9224a91571d6649: Linux 4.1-rc7 (2015-06-07 20:23:50 -0700) are available in the git repository at: git://git.kernel.org/pub/scm

[PATCH 3/3] MAINTAINERS: Update ps3vram block driver

Add myself as co-maintainer of the ps3vram block driver, and add linuxppc-dev as a relevant mailing list. I have been acting as maintainer of this driver for the last several years, and if there is some inquiry regarding it I would like to be notified. Signed-off-by: Geoff Levand ge

[PATCH] drivers/ps3: Fix ps3-lpm white space

From: Rudhresh Kumar J rudhresh...@gmail.com Fixed a coding style issue. Signed-off-by: Rudhresh Kumar J rudhresh...@gmail.com Signed-off-by: Geoff Levand ge...@infradead.org --- Please apply to trivial. Thanks. -Geoff drivers/ps3/ps3-lpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: Time to remove platforms/cell?

Hi, On Fri, 2015-10-09 at 23:13 +0200, Marc Dietrich wrote: > Am Freitag, 9. Oktober 2015, 10:45:42 schrieb Geoff Levand: > > With the 4.2-rc4 kernel, kexec seems to work when CONFIG_SPU_FS=n. > > I > > have not tried with petitboot release white-09.09.01-15.56 yet though.

Re: Time to remove platforms/cell?

> Hi, > > > On Mon, 2015-10-05 at 12:27 +0200, Marc Dietrich wrote: > > > I tried with ps3-queue and still no luck. Petitboot just says > > > "Booting kernel > > > ..." thats all - no output. > > > > > > FW is 3.15 of course > > > Petitboot says (white-09.09.01-15.56) > > I spent a few minutes

[PATCH] powerpc: Add run_cmd function to boot wrapper

Add a boot wrapper script function run_cmd which will run a shell command quietly and only print the output if either V=1 or an error occurs. Also, run the ps3 dd commands with run_cmd to clean up the build output. Signed-off-by: Geoff Levand <ge...@infradead.org> --- Hi Michael, How

Re: Time to remove platforms/cell?

On Mon, 2015-10-05 at 12:27 +0200, Marc Dietrich wrote: > Am Sonntag, 4. Oktober 2015, 12:27:19 schrieb Geoff Levand: > > I just tested the ps3-queue branch (v4.3-rc4 based) of my ps3-linux > > git > > repo and it works OK. > > > > Do you see any output on

Re: Time to remove platforms/cell?

Hi Marc, On Thu, 2015-10-08 at 11:10 -0700, Geoff Levand wrote: > > On Mon, 2015-10-05 at 12:27 +0200, Marc Dietrich wrote: > > > > I tried with ps3-queue and still no luck. Petitboot just says > > > > "Booting kernel > > > > ..." thats al

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

On Tue, 2015-09-01 at 11:21 +0100, Colin King wrote: > On the unlikely event that drv is null, the current code will > perform a null pointer dereference with it when printing a dev_dbg > message. Instead, the BUG_ON check on drv should be performed > before we emit the dev_dbg message. > >

Re: [PATCH] powerpc: Kconfig: remove BE-only platforms from LE kernel build

On Mon, 2015-09-07 at 07:58 +0800, Boqun Feng wrote: > arch/powerpc/platforms/ps3/Kconfig | 2 +- Looks OK for PS3. Acked-by: Geoff Levand <ge...@infradead.org> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.

[PATCH V2 3/3] powerpc/ps3: Refresh ps3_defconfig

Refresh and remove obsolete CONFIG_EXT3_FS. Signed-off-by: Geoff Levand <ge...@infradead.org> --- V2: Remove ext3 as suggested by Geert. arch/powerpc/configs/ps3_defconfig | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/powerpc/configs/ps3_defconfig b/arch/powerpc/c

Re: Time to remove platforms/cell?

On Thu, 2015-09-17 at 20:05 +1000, Michael Ellerman wrote: > Right. I wouldn't bet money that the oprofile code still works, but spufs > definitely would have to stay. oprofile on PS3 needed additional patches [1] that I never merged upstream, and no longer plan to, so oprofile support should be

[PATCH 3/3] powerpc/ps3: Refresh ps3_defconfig

Signed-off-by: Geoff Levand <ge...@infradead.org> --- arch/powerpc/configs/ps3_defconfig | 4 1 file changed, 4 deletions(-) diff --git a/arch/powerpc/configs/ps3_defconfig b/arch/powerpc/configs/ps3_defconfig index adc14e8..09f117e 100644 --- a/arch/powerpc/configs/ps3_defconfig

[PATCH 0/3] PS3 updates for 4.3

-powerpc for you to fetch changes up to f9c28dfbef66b7f23f1e542397bd6a77d1258ddd: powerpc/ps3: Refresh ps3_defconfig (2015-09-14 12:28:10 -0700) Colin Ian King (1): drivers/ps3: Fix ps3-vuart null dereference Geoff Levand (1

Re: Time to remove platforms/cell?

Hi, On Thu, 2015-09-17 at 12:28 +0200, Marc Dietrich wrote: > well, I like to but I couldn't get the kernel booting for some reason. Still > trying. I just tested the ps3-queue branch (v4.3-rc4 based) of my ps3-linux git repo and it works OK. Do you see any output on the display, maybe some

Re: [PATCH] powerpc/ps3: Remove unused os_area_db_id_video_mode

history if anyone needs it. Looks OK. Acked-by: Geoff Levand <ge...@infradead.org> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 0/4] powerpc/ps3: gelic_udbg: drop local versions of network data structs

from These all look fine.  Thanks for taking time to do this clean up.  I'll try to test next chance I get.Acked-by: Geoff Levand <ge...@infradead.org> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 0867/1285] Replace numeric parameter like 0444 with macro

On Tue, 2016-08-02 at 19:53 +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access > permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and

Re: [PATCH 06/35] powerpc: Convert remaining uses of pr_warning to pr_warn

On 02/16/2017 11:11 PM, Joe Perches wrote: > To enable eventual removal of pr_warning > --- > arch/powerpc/platforms/ps3/device-init.c| 14 +++--- > arch/powerpc/platforms/ps3/mm.c | 4 ++-- > arch/powerpc/platforms/ps3/os-area.c| 2 +- PS3 parts look

Re: [PATCH] powerpc: Use pr_warn instead of pr_warning

| 4 ++-- > arch/powerpc/platforms/ps3/os-area.c| 2 +- PS3 parts look OK. Acked-by: Geoff Levand <ge...@infradead.org>

Re: [V2,10/68] powerpc/mm: Update _PAGE_KERNEL_RO

Hi Aneesh, On 11/23/2016 02:41 AM, Aneesh Kumar K.V wrote: Can you try this patch ? commit 43e05fa840330f0f2deae1e8cc2effd5df68079f Author: Aneesh Kumar K.V Date: Wed Nov 23 15:23:05 2016 +0530 powerpc/mm: Kernel RO fixup for cell I tested your patch

RE: [V2,10/68] powerpc/mm: Update _PAGE_KERNEL_RO

Hi Aneesh, > --- a/arch/powerpc/platforms/ps3/spu.c > +++ b/arch/powerpc/platforms/ps3/spu.c > @@ -205,7 +205,7 @@ static void spu_unmap(struct spu *spu) > static int __init setup_areas(struct spu *spu) > { > struct table {char* name; unsigned long addr; unsigned long size;}; > -

Re: [V2,10/68] powerpc/mm: Update _PAGE_KERNEL_RO

Hi Aneesh, On 11/20/2016 10:03 AM, Aneesh Kumar K.V wrote: > So I am trying to understand what the PPP bit value should be. I haven't > studied PS3 enough to figure this out myself. So we use the SLB class > value of 0 for the kernel and 1 for user. What is the expected PPP bit > value for the

powerpc/ps3: Fix system hang with GCC 5 builds

GCC 5 generates different code for this bootwrapper null check that causes the PS3 to hang very early in its bootup. This check is of limited value, so just get rid of it. Signed-off-by: Geoff Levand <ge...@infradead.org> --- arch/powerpc/boot/ps3-head.S | 5 - arch/powerpc/boot

Re: [PATCH] net: toshiba: ps3_genic_net: use new api ethtool_{get|set}_link_ksettings

OK. Thanks for your contribution. Tested-by: Geoff Levand <ge...@infradead.org>

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 11:34 AM, SF Markus Elfring wrote: >> I didn't consider one would be triggered by the kzalloc failure. > > Do you reconsider any special system settings for further > software evolution then? Sorry, I don't quite understand your question. I think your original patch is OK, and I

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 09:27 AM, SF Markus Elfring wrote: >>> Omit an extra message for a memory allocation failure in this function. >>> >>> This issue was detected by using the Coccinelle software. >> >> NACK >> >> When a user asks me for help I would certainly like to get >> 'Could not allocate cache

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 12:04 PM, SF Markus Elfring wrote: >> I think your original patch is OK, > > How does this feedback fit to the initial response “Not Applicable”? > https://patchwork.ozlabs.org/patch/798575/ I submitted your patch and a fix to ps3vram_probe() with the other patches in my queue.

[PATCH 3/3] powerpc/ps3: Refresh ps3_defconfig

Signed-off-by: Geoff Levand <ge...@infradead.org> --- arch/powerpc/configs/ps3_defconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/configs/ps3_defconfig b/arch/powerpc/configs/ps3_defconfig index ee0ec5a682fc..378382683180 100644 --- a/arch/powerpc/configs/ps3_def

[PATCH 2/3] block/ps3vram: Check return of ps3vram_cache_init

Cc: Markus Elfring <elfr...@users.sourceforge.net> Cc: Jim Paris <j...@jtan.com> Cc: Jens Axboe <ax...@kernel.dk> Signed-off-by: Geoff Levand <ge...@infradead.org> --- drivers/block/ps3vram.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 1/3] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Cc: Jim Paris <j...@jtan.com> Cc: Jens Axboe <ax...@kernel.dk> Signed-off-by: Geoff Levand <ge...@infradead.org> --- drivers/block/ps3vram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dri

[PATCH 0/3] Minor updates for PS3

-linux.git for-merge-powerpc for you to fetch changes up to 1c2ef56f08fcfcf74aa281c33363197f8c01e5ab: powerpc/ps3: Refresh ps3_defconfig (2017-08-07 12:49:07 -0700) Geoff Levand (2): block/ps3vram: Check return

Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 03:52 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 7 Aug 2017 12:37:01 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. NACK When a

Re: ps3 linux: os_area_queue_work_handler: Could not update FLASH ROM

Hi Sombat, On 06/26/2017 02:26 AM, Sombat Tragolgosol wrote: > 1) Is it normal for os_area_queue_work_handler: Could not update FLASH ROM? You should try to find the exact cause of the error. It could be due to a corrupted os-area. > 2) My Date time is not correct. Is the problem is not able

Re: [PATCH 08/16] powerpc: ps3: use dev_groups and not dev_attrs for bus_type

On 06/06/2017 12:22 PM, Greg Kroah-Hartman wrote: > The dev_attrs field has long been "depreciated" and is finally being > removed, so move the driver to use the "correct" dev_groups field > instead for struct bus_type. > arch/powerpc/platforms/ps3/system-bus.c | 10 ++ > 1 file changed,

Re: [PATCH 0/2] PowerPC-PS3: Adjustments for three function implementations

On 10/17/2017 11:54 AM, SF Markus Elfring wrote: > Markus Elfring (2): > Delete an error message for a failed memory allocation in update_flash_db() > Improve a size determination in two functions For consistency, please use 'powerpc/ps3' not 'powerpc-ps3' as the commit log subject prefix.

Boot new kernel on PS3

Hi, On 11/21/2017 12:41 PM, Kevin Yeske wrote: > I have been working on trying to get a newer kernel and Ubuntu version > running on the PS3 within otherOS on a PS3 slim. There was a breakage in the kernel ABI, and the old petitboot bootloader (ps3-petitboot-09.11.30) cannot boot kernels newer

Re: [PATCH 2/2] ps3: Improve a size determination in five functions

Hi, On 12/16/2017 05:54 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Dec 2017 14:21:04 +0100 > > Replace the specification of data structures by variable references > as the parameter for the operator "sizeof" to make the corresponding size

Re: ps3: Improve a size determination in five functions

On 12/18/2017 12:45 PM, SF Markus Elfring wrote: >> but you are also removing empty lines and changing the coding format. > > * Why do you not like such a change combination? > > * Do you really want to integrate further update steps in this case? I want to keep the coding style consistent

Re: [PATCH 0/2] PS3: Adjustments for six function implementations

Hi, On 12/16/2017 05:50 AM, SF Markus Elfring wrote: > Markus Elfring (2): > Delete an error message for a failed memory allocation in two functions > Improve a size determination in five functions As I mentioned before, please keep your commit message subjects to 50 chars or less. -Geoff

Re: [PATCH 1/2] ps3: Delete an error message for a failed memory allocation in two functions

On 12/16/2017 05:51 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Dec 2017 12:32:42 +0100 > > Omit an extra message for a memory allocation failure in these functions. This is OK, I'll add it to my ps3-queue branch. -Geoff

Re: Getting kernel 4.14 to run on PS3

Hi Nathan, On 12/08/2017 01:25 PM, Nathan Whitehorn wrote: > I submitted patches to libfdt that resolve this particular ABI breakage > yesterday. If the patch gets merged, newer kernels should become bootable > again. Here's the link: https://github.com/dgibson/dtc/pull/12 (Add limited

Re: Getting kernel 4.14 to run on PS3

Hi Sascha, On 12/08/2017 01:24 AM, Sascha Schroeder wrote: > I yesterday tried to compile the newest kernel 4.14 for my PS3 running > OtherOS++ and "Red Ribbon GNU Linux" from 2014. I even succeeded and > created the three *.deb files and installed them afterwards. > > Unfortunately, my machine

Re: [PATCH] ps3_gelic_net: Delete an error message for a failed memory allocation in gelic_descr_prepare_rx()

On 01/03/2018 06:40 AM, SF Markus Elfring wrote: > Omit an extra message for a memory allocation failure in this function. I applied this to my ps3-queue branch. As I mentioned to you several times before, please keep the commit subject line to less than 50 characters. Also, in this case the

Re: [PATCH 2/2] ps3: Improve a size determination in five functions

Hi, On 12/16/2017 05:54 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Dec 2017 14:21:04 +0100 > > Replace the specification of data structures by variable references > as the parameter for the operator "sizeof" to make the corresponding size

Re: ps3: Improve a size determination in five functions

On 12/20/2017 01:20 PM, SF Markus Elfring wrote: >> o Your patch fixes no bug nor replaces any depreciated feature. > > How do you think about information from the section “14) Allocating memory” > in the document “coding-style.rst” for the shown source code transformation? In terms of

[PATCH] powerpc/ps3: Set driver coherent_dma_mask

Set the coherent_dma_mask for the PS3 ehci, ohci, and snd devices. Silences WARN_ON_ONCE messages emitted by the dma_alloc_attrs() routine. Reported-by: Fredrik Noring Signed-off-by: Geoff Levand --- Hi Michael, This just silences some warnings. Can you take it through the powerpc tree

Re: Improvements for the PS3

Hi Fredrik, On 07/14/2018 09:49 AM, Fredrik Noring wrote: > so I added a sleep with > > + msleep(1); > + > return 0; > > et voilà, the screen came alive and the kernel panic was revealed! It seems > the kernel panics so fast that the PS3 frame buffer is unprepared. This is, > of

Re: Improvements for the PS3

Hi Geert, Fredrik, On 07/19/2018 12:45 AM, Geert Uytterhoeven wrote: >> On 07/14/2018 09:49 AM, Fredrik Noring wrote: >>> >>> et voilà, the screen came alive and the kernel panic was revealed! It seems >>> the kernel panics so fast that the PS3 frame buffer is unprepared. This is, >>> of course,

Re: [PATCH] powerpc/ps3: Set driver coherent_dma_mask

Hi Alan, On 07/19/2018 07:33 AM, Alan Stern wrote: > On Wed, 18 Jul 2018, Geoff Levand wrote: > >> diff --git a/drivers/usb/host/ehci-ps3.c b/drivers/usb/host/ehci-ps3.c >> index 8c733492d8fe..454d8c624a3f 100644 >> --- a/drivers/usb/host/ehci-ps3.c >> +++

Re: [PATCH] powerpc/ps3: remove an unneeded NULL check

Hi Dan, On 01/23/2018 12:33 AM, Dan Carpenter wrote: > @@ -43,7 +43,7 @@ void ps3_sys_manager_register_ops(const struct > ps3_sys_manager_ops *ops) > { > BUG_ON(!ops); > BUG_ON(!ops->dev); > - ps3_sys_manager_ops = ops ? *ops : ps3_sys_manager_ops; > + ps3_sys_manager_ops =

Re: [PATCH] Documentation: fix spelling mistake, EACCESS -> EACCES

Hi Everyone, On 11/12/2018 04:57 AM, Michael Ellerman wrote: > But maybe Geoff has a better feel for how many people (other than him) > are still running upstream on PS3s. There are still PS3 users out there. They are hobbyists who generally don't post to Linux kernel mailing lists. I usually

Re: [PATCH] powerpc: signedness bug in update_flash_db()

if (count < sizeof(struct os_area_db)) { > + if (count < 0 || count < sizeof(struct os_area_db)) { > pr_debug("%s: os_area_flash_write failed %zd\n", __func__, > count); > error = count < 0 ? count : -EIO; > Seems OK. Acked-by: Geoff Levand

Re: [PATCH net-next] net: toshiba: fix return type of ndo_start_xmit function

netdev_tx_t. > > Found by coccinelle. > > Signed-off-by: YueHaibing I tested this against Linux-4.19-rc4, and it seemed to work OK. Please remove the irrelevant line 'Found by coccinelle.' from the commit message. With that change: Acked-by: Geoff Levand -Geoff

<    1   2   3   4   5   6   >