[Linuxptp-devel] Setting DSCP values in PTP messages

Hi, I would like to propose a patch for linuxptp v1.6, that will add the possibility to set DSCP values into PTP messages. This patch adds the global configuration options "tosEventMessages" and "tosGeneralMessages" to be able to set different DSCP values for those kinds of messages. These opt

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

Hi, sorry, the last patch contained a bug, on setting the DSCP value on the correct sockets. So please use the newly attached one here. Best regards Henry Jesuiter Von: Jesuiter, Henry (ALC NetworX GmbH) Gesendet: Mittwoch, 6. Juli 2016 11:11 An: 'linuxptp-devel@lists.sourceforg

[Linuxptp-devel] Setting DSCP values in PTP messages

Oh yes, my fault. Please find it below: --- Index: config.c === --- config.c(Revision 827) +++ config.c(Revision 830) @@ -236,6 +236,8 @@ GLOB_ITEM_INT("use_syslog", 1, 0, 1), GLOB_ITEM_STR("userDescription", "

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

Thank you very much for your fast reply and the notes. Please find below a modified patch according to your annotations: --- diff -rwbBu a/config.c b/config.c --- a/config.c 2015-09-19 16:25:11.0 +0200 +++ b/config.c 2016-07-06 17:07:38.176449373 +0200 @@ -226,6 +226,8 @@ PORT_IT

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

In the last years there are several media standards evolving that are relying on PTP. These standards make requirements about the DSCP priority of PTP messages. This patch introduces two new configuration options 'tos_event' and 'tos_general' to address that issue and to be able to set the DSCP

Re: [Linuxptp-devel] Setting DSCP values in PTP messages

In the last years there are several media streaming standards evolving that are relying on PTP. These standards make requirements about the DSCP priority of PTP messages. This patch introduces two new configuration options 'tos_event' and 'tos_general' to address that issue and to be able to set

[Linuxptp-devel] [PATCH] Introduce options to set DSCP values in PTP messages

Richard, please find below the new patch and commit message. Thanks for your patience especially respective the makefile-issue. As you may already assume, we are using our own build system here. BTW: Are you interested in some patches that remove gcc warnings if the code is compiled using -Wsi

[Linuxptp-devel] [PATCH] Fix data type for return value of vasprintf()

-- Since size_t is an unsigned data type, it won't evaluate correctly on errors of vasprintf(). This patch makes 'len2' a signed integer, as expected by vasprintf(). Signed-off-by: Henry Jesuiter --- diff -rwbBu a/util.c b/util.c --- a/util.c2015-09-19 16:25:11.0 +0200 +++ b/util.c

[Linuxptp-devel] [PATCH] Silence gcc comparison signedness warnings

--- This is a convenience patch to silence gcc warnings if compiled with '-Wsign-compare' option. It does not change the runtime behavior of the binaries (or even harm them) in any way. Signed-off-by: Henry Jesuiter --- diff -rwbBu a/clock.c b/clock.c --- a/clock.c 2015-09-19 16:25:11.0

Re: [Linuxptp-devel] [PATCH] Introduce options to set DSCP values in PTP messages

gards Henry Jesuiter -Ursprüngliche Nachricht- Von: Miroslav Lichvar [mailto:mlich...@redhat.com] Gesendet: Dienstag, 12. Juli 2016 08:54 An: Jesuiter, Henry (ALC NetworX GmbH) Cc: Richard Cochran ; linuxptp-devel@lists.sourceforge.net Betreff: Re: [Linuxptp-devel] [PATCH] Introduce options to set

Re: [Linuxptp-devel] [PATCH] Introduce options to set DSCP values in PTP messages

- Von: Miroslav Lichvar [mailto:mlich...@redhat.com] Gesendet: Dienstag, 12. Juli 2016 08:54 An: Jesuiter, Henry (ALC NetworX GmbH) Cc: Richard Cochran ; linuxptp-devel@lists.sourceforge.net Betreff: Re: [Linuxptp-devel] [PATCH] Introduce options to set DSCP values in PTP messages On Fri, Jul

Re: [Linuxptp-devel] [PATCH RFC 1/1] Introduce options to set DSCP values in PTP messages.

In the last years there are several media streaming standards evolving that are relying on PTP. These standards make requirements about the DSCP priority of PTP messages. This patch introduces two new configuration options 'tos_event' and 'tos_general' to address that issue and to be able to set th

Re: [Linuxptp-devel] Planning release 1.7

Hello, as a bug fix release, it may be useful if you consider my patch from last Friday ([PATCH] Fix data type for return value of vasprintf()), regarding the the data type issue in util.c. 'len2' is of type 'size_t' in util.c:451, but vasprintf in line 457 returns '-1' on error which is chec

[Linuxptp-devel] transportSpecific field

Hello, according to IEEE 1588-2008 Annex D.4 it is possible to set the transport specific bit to signal that PTP event (and Announce) messages have to be padded. Now we are discussing here, if that consequently allows to have a mixed mode PTP-Network, where one or more hosts set this bit and o

Re: [Linuxptp-devel] transportSpecific field

> We don't support the hardwareCompatibility bit. It conflicts with > gPTP according to 802.1AS. It is hack (I guess for a particular > vendor) for compatitibiliy with some legacy PTP Version 1 hardware. > Why on earth would you want it? Thank you for your quick answer. In fact we have a pro

Re: [Linuxptp-devel] transportSpecific field

> When I first looked at it, I made a conscious decision *not* to > support it, because it appeared to me as a special hack for someone > pulling strings in the standards process. That's exactly our opinion. > Do you mind telling us what HW is using the hardwareCompatibility bit? In the audio

[Linuxptp-devel] [PATCH]Recognize PTP port link status

--- This patch implements a primitive way to recognize a PTP ports operational link status. If a link on a network interface goes down, it will create an EV_DESIGNATED_DISABLED transition for the appropriate PTP port (setting it into PS_DISABLED state). If a link on a network interface goes up,

Re: [Linuxptp-devel] [PATCH]Recognize PTP port link status

Hi, > I agree that the log noise can be annoying. However, this can be > mitigated by increasing the fault reset interval, if your links are > not reliable. It's indeed some kind of issue for us. We have several devices here, utilizing more than one Ethernet-Port (but having only one PHC per de

Re: [Linuxptp-devel] [PATCH RFC 7/7] clock: Monitor the link status using a RT netlink socket.

-Ursprüngliche Nachricht- Von: Richard Cochran [mailto:richardcoch...@gmail.com] Gesendet: Sonntag, 31. Juli 2016 23:49 An: linuxptp-devel@lists.sourceforge.net Cc: Jesuiter, Henry (ALC NetworX GmbH) Betreff: [PATCH RFC 7/7] clock: Monitor the link status using a RT netlink socket

Re: [Linuxptp-devel] [PATCH RFC 7/7] clock: Monitor the link status using a RT netlink socket.

9. August 2016 13:21 An: Jesuiter, Henry (ALC NetworX GmbH) Cc: linuxptp-devel@lists.sourceforge.net Betreff: Re: [PATCH RFC 7/7] clock: Monitor the link status using a RT netlink socket. On Tue, Aug 09, 2016 at 08:45:44AM +, Jesuiter, Henry (ALC NetworX GmbH) wrote: > After trying out

Re: [Linuxptp-devel] [PATCH RFC 7/7] clock: Monitor the link status using a RT netlink socket.

That helps us much. Best regards Henry -Ursprüngliche Nachricht- Von: Richard Cochran [mailto:richardcoch...@gmail.com] Gesendet: Dienstag, 9. August 2016 14:40 An: Jesuiter, Henry (ALC NetworX GmbH) Cc: linuxptp-devel@lists.sourceforge.net Betreff: Re: [PATCH RFC 7/7] clock: Monitor the

[Linuxptp-devel] Config option "assume_two_step"

Hello, recently I stumbled upon the "assume_two_step" config option (we accidentally set this flag two '1' ;-)). As I read in the source, this is used to skip the TWO_STEP flag inside the PTP messages, and just return '0' for one_step() status. Could someone please explain, why this option is t

[Linuxptp-devel] Missing state transition on PS_PASSIVE ports

Hi, I did recently some more tests with multiple ports on out devices here. So I connected a two port device to a switch and started ptp4l that way: > ptp4l -m -i eth0 -i eth1 Then the output on ptp4l is as following: ptp4l[174593.550]: eth0: SO_SELECT_ERR_QUEUE: Protocol not available ptp4l[17

Re: [Linuxptp-devel] Missing state transition on PS_PASSIVE ports

Sorry, I thought I already answered a week ago. These patches work fine for us, and I already integrated them in our current firmware for further real live tests. Best regards Henry > Am 14.02.2017 um 07:44 schrieb Richard Cochran : > >> On Sun, Feb 05, 2017 at 06:37:13PM +0100, Richard Cochr

[Linuxptp-devel] linuxptp GM BC with two ports into the same subnet

Hello, I've recently stumbled across an - according to IEEE1588-2008 - strange behavior in linuxptp. Setup (kind of abnormal, as state in IEEE 1588-2008 😉): - Boundary Clock - 2 Ports into the same subnet - linuxptp client (v1.8) as Grandmaster on that device Seen behavior: - both ports ign

Re: [Linuxptp-devel] Prioritizing PTP traffic

Hi, please have a look at dscp_event and dscp_general config options. These options use DSCP to prioritise PTP traffic according to the message type (event or general messages). Regards Henry Holen Sie sich Outlook für iOS - Unsere Datenschutzerklärung finden Sie h

Re: [Linuxptp-devel] [PATCH RFC 0/1] Introduce inclusive terminology

Hi, in regard of „master at doing something“, what about „Stalwart“ instead of „Slave“? You can keep the abbreviation „s“ (as in „slave“ or „sink“), it refers to „follower“ as in „fan“ and even means „loyal“ (as for synchronisation). The only drawback: It‘s very uncommon in technical context an