Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Keller, Jacob E
-Original Message- From: Keller, Jacob E [mailto:jacob.e.kel...@intel.com] Sent: Monday, August 17, 2015 1:54 AM To: Richard Cochran Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation -Original Message

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Keller, Jacob E
-Original Message- From: Richard Cochran [mailto:richardcoch...@gmail.com] Sent: Monday, August 17, 2015 8:44 AM To: Miroslav Lichvar Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation On Mon, Aug 17, 2015

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Richard Cochran
On Mon, Aug 17, 2015 at 05:14:18PM +0200, Miroslav Lichvar wrote: Nice. I like the design. I guess it won't be too difficult to add string to the supported types and convert the remaining old config code. Maybe, but I need to take breather from my conversion marathon! BTW, I ran your

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Richard Cochran
On Mon, Aug 17, 2015 at 06:53:35AM +, Keller, Jacob E wrote: You converted the PI options, but I can't figure exactly how they were read. There doesn't appear to be any calls to config_get_int or config_get_dbl for them in their respective patches. You are right, Jake. I forgot the

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Keller, Jacob E
-Original Message- From: Richard Cochran [mailto:richardcoch...@gmail.com] Sent: Monday, August 17, 2015 1:49 PM To: Keller, Jacob E Cc: Miroslav Lichvar; linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Keller, Jacob E
Hi Richard, This series looks excellent with a few minor questions. -Original Message- From: Richard Cochran [mailto:richardcoch...@gmail.com] Sent: Sunday, August 16, 2015 1:15 PM To: linuxptp-devel@lists.sourceforge.net Subject: [Linuxptp-devel] [PATCH RFC v3 00/69] New

Re: [Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-17 Thread Richard Cochran
On Mon, Aug 17, 2015 at 04:15:59PM +, Keller, Jacob E wrote: Where is the linuxptp-testsuite hosted? https://github.com/mlichvar/linuxptp-testsuite.git You also need: https://github.com/mlichvar/clknetsim.git Cheers, Richard

[Linuxptp-devel] [PATCH RFC v3 00/69] New configuration implementation

2015-08-16 Thread Richard Cochran
Changes in V3: - Reduced interface to two types, double and int (enums are accessed like ints) - Converted almost everything Changes in V2: - API is much simpler to use - numerous details in the implementation have been improved - half dozen legacy options converted The diffstat over the