On Tue, Mar 29, 2011 at 9:21 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Tue, Mar 29, 2011 at 04:18:38PM -0700, Jason Gerecke wrote:
@@ -1782,41 +1797,118 @@ static int get_special_button_map(Display *dpy,
XDevice *dev,
TRACE(%s\n, buff);
- XFree(btnact_data);
+
On Tue, Mar 29, 2011 at 9:03 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
applied, but from a cursory glance I'm not sure why. In fact, I would have
guessed the other way round. anyway, I've added a comment to avoid this in
the future (at least until we find the reason why and fixed it).
On Tue, Mar 29, 2011 at 11:21:58PM -0700, Jason Gerecke wrote:
On Tue, Mar 29, 2011 at 9:21 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Tue, Mar 29, 2011 at 04:18:38PM -0700, Jason Gerecke wrote:
@@ -1782,41 +1797,118 @@ static int get_special_button_map(Display *dpy,
XDevice
On Tue, Mar 29, 2011 at 11:37 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Tue, Mar 29, 2011 at 11:21:58PM -0700, Jason Gerecke wrote:
On Tue, Mar 29, 2011 at 9:21 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Tue, Mar 29, 2011 at 04:18:38PM -0700, Jason Gerecke wrote:
@@
On Tue, Mar 29, 2011 at 10:53 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Chris, can you comment on the fixme I have added here. The current code
seems to increase the number of buttons on the device when mouse buttons are
These two functions are very similar, and have been merged together
to provide a single conduit for all action mappings. Button-handling
code requires a little bit of special-casing (we need to be sure to
get a button to modify, and to change the arguments appropriately),
but nothing remotely
'get_map' is the new getter entrypoint and attempts to determine
the mapping present on buttons, wheels, and strips. It calls on
'get_actions' (essentially get_special_button_map) and 'get_button'
(an 8-bit XA_INTEGER version of the same) to determine this. If
both fail to find a mapping, it falls
Hi
I join the discussion, because I have to deal with Array of Atom
constructs also for my OLED Images.
2011/3/30 Peter Hutterer peter.hutte...@who-t.net:
applied, but from a cursory glance I'm not sure why. In fact, I would have
guessed the other way round. anyway, I've added a comment to
Adding to the only-kinda-hackish use of XGetDeviceButtonMapping,
in get_map, this total hackjob of a patch fixes the problem with
us having no way of knowing the driver's defaults for wheels and
strips.
Thankfully, the defaults aren't changing anytime soon so its
not likely to break.
Patches 1-4 improve argument validation and make xsetwacom noiser when
it fails. Patches 5-7 finish up the remaining raw button removal from
xsetwacom.
Jason Gerecke (7):
Fail with warnings where possible
More explicit input check for set_rotate
Change from prop_extra to arg_count
More
For many commands, improper arguments cause a silent failure. The
user is often given no indication if their command succeeded or
failed. I've tried to find all the silent return; statements and
provide some kind of warning message where possible.
In some cases I've added in new checks to ensure
Add/replace checks in functions to ensure that they have the right
number of arguments to do their job properly. The worst offender
here was the set() function -- providing too many arguments would
result in it walking off the end of data structures (often resulting
in a segfault)
Signed-off-by:
Since the worker functions now check that they have the appropriate
number of arguments, its possible to decrease the number of arguments
required by 'set'. Since all it really needs is a device number and
a property, the minimum argc is now 2.
A handy side-effect of this change is that its now
Continuing with removing raw button code, we create the wheel and
strip properties ready to hold actions. Prior to this, the properties
would be initialized with the raw buttons; before xsetwacom could
set them to actions they would need to be converted.
This does away with the conversion step by
Don't wait before we can post the events. Verify the serial number
as soon as the information is accessible.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmCommon.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
It will be used more often when we need to compare touch events
with pen events.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmCommon.c |2 +-
src/xf86WacomDefs.h |2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index
On Wed, Mar 30, 2011 at 04:24:15PM -0700, Ping Cheng wrote:
Don't wait before we can post the events. Verify the serial number
as soon as the information is accessible.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmCommon.c | 16
1 files changed, 8
On Wed, Mar 30, 2011 at 04:24:43PM -0700, Ping Cheng wrote:
It will be used more often when we need to compare touch events
with pen events.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmCommon.c |2 +-
src/xf86WacomDefs.h |2 ++
2 files changed, 3 insertions(+), 1
On Wed, Mar 30, 2011 at 01:54:43PM -0700, Jason Gerecke wrote:
When setting an XInternAtom property, 'prop_extra' listed
the number of extra properties beyond the first that needed
to be set. For instance WACOM_PROP_TABLET_AREA had a total
of 4 properties, so prop_extra=3.
To provide better
On Wed, Mar 30, 2011 at 01:54:45PM -0700, Jason Gerecke wrote:
Since the worker functions now check that they have the appropriate
number of arguments, its possible to decrease the number of arguments
required by 'set'. Since all it really needs is a device number and
a property, the minimum
Hi Peter,
That sounds reasonable to me given that we are still linking to Aris'
repository in the mediawiki's Linuxwacom HOWTO and FAQ:
http://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=Linuxwacom_HOWTO#Hotplugging_the_device
Favux
On Wed, Mar 30, 2011 at 01:54:47PM -0700, Jason Gerecke wrote:
Adding to the only-kinda-hackish use of XGetDeviceButtonMapping,
in get_map, this total hackjob of a patch fixes the problem with
us having no way of knowing the driver's defaults for wheels and
strips.
Thankfully, the defaults
22 matches
Mail list logo
