Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-06 Thread Bryan Hundven
On Fri, Mar 5, 2010 at 11:59 PM, Timo Aaltonen wrote: > On Fri, 5 Mar 2010, Bryan Hundven wrote: > >> On Fri, Mar 5, 2010 at 11:20 PM, Timo Aaltonen wrote: >>> >>> Looks like you haven't done your homework then. The package is maintained >>> by >>> the X-SWAT team, feel free to join and start tri

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Timo Aaltonen
On Fri, 5 Mar 2010, Bryan Hundven wrote: > On Fri, Mar 5, 2010 at 11:20 PM, Timo Aaltonen wrote: >> Looks like you haven't done your homework then. The package is maintained by >> the X-SWAT team, feel free to join and start triaging the bugs :) >> >> "Rebranding" means we have to bump the packag

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Timo Aaltonen
On Fri, 5 Mar 2010, Bryan Hundven wrote: > The wacom package in ubuntu seems to be just the debian package - re-branded. > The alternative to jhbuild would be me just posting my own ppa on > launchpad until my package makes it into ubuntu. > But as it is now, _I_ don't think anyone on the ubuntu p

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Bryan Hundven
On Fri, Mar 5, 2010 at 11:20 PM, Timo Aaltonen wrote: > Looks like you haven't done your homework then. The package is maintained by > the X-SWAT team, feel free to join and start triaging the bugs :) > > "Rebranding" means we have to bump the package epoch because someone fd > it up several y

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Chris Bagwell
On Fri, Mar 5, 2010 at 2:12 PM, Chris Bagwell wrote: > Because your still seeing "bad magic" messages, I've got a concern > that we are throwing out packets that are related to going out of > proximity.  If this occurs, we will never switch tools because for > case of pen to eraser, it will only

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Ping Cheng
On Fri, Mar 5, 2010 at 5:02 PM, Bryan Hundven wrote: > > I guess if you poke the maintainer and get nothing, put up your own repo: > https://launchpad.net/~bryanhundven/+archive/xorg-wacom-testing > Hi Bryan, You have a very good open source attitude. Keep up the great spirit! Ping BTW, -11 wi

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Bryan Hundven
On Fri, Mar 5, 2010 at 3:00 PM, Peter Hutterer wrote: > On Fri, Mar 05, 2010 at 12:25:05PM -0800, Bryan Hundven wrote: >> On Fri, Mar 5, 2010 at 12:12 PM, Chris Bagwell wrote: >> > On Fri, Mar 5, 2010 at 1:47 PM, Bryan Hundven >> > wrote: >> >> On Fri, Mar 5, 2010 at 6:33 AM, Chris Bagwell >>

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Peter Hutterer
On Fri, Mar 05, 2010 at 12:25:05PM -0800, Bryan Hundven wrote: > On Fri, Mar 5, 2010 at 12:12 PM, Chris Bagwell wrote: > > On Fri, Mar 5, 2010 at 1:47 PM, Bryan Hundven > > wrote: > >> On Fri, Mar 5, 2010 at 6:33 AM, Chris Bagwell wrote: > >>> I see some cleanup logic that I don't understand th

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Peter Hutterer
On Fri, Mar 05, 2010 at 08:33:56AM -0600, Chris Bagwell wrote: > On Fri, Mar 5, 2010 at 6:29 AM, Peter Hutterer > wrote: > > On Fri, Mar 05, 2010 at 01:02:18AM -0800, Bryan Hundven wrote: > > > >> EVENT type 17 > >>     device: 2 > >>     detail: 0 > >>     valuators: > >>           0: 3078.00 (3

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Chris Bagwell
On Fri, Mar 5, 2010 at 2:25 PM, Bryan Hundven wrote: > On Fri, Mar 5, 2010 at 12:12 PM, Chris Bagwell wrote: >> On Fri, Mar 5, 2010 at 1:47 PM, Bryan Hundven >> Something strange is going on with Peter's git.  It can't see these >> changes.  Its the "devel" branch, right?  Everything on freedeskt

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Bryan Hundven
On Fri, Mar 5, 2010 at 12:12 PM, Chris Bagwell wrote: > On Fri, Mar 5, 2010 at 1:47 PM, Bryan Hundven wrote: >> On Fri, Mar 5, 2010 at 6:33 AM, Chris Bagwell wrote: >>> I see some cleanup logic that I don't understand that fixes when it >>> thinks its an eraser but really is a stylus... but I do

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Chris Bagwell
On Fri, Mar 5, 2010 at 1:47 PM, Bryan Hundven wrote: > On Fri, Mar 5, 2010 at 6:33 AM, Chris Bagwell wrote: >> I see some cleanup logic that I don't understand that fixes when it >> thinks its an eraser but really is a stylus... but I do not see the >> opposite cleanup to fix stylus that are real

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Bryan Hundven
On Fri, Mar 5, 2010 at 6:33 AM, Chris Bagwell wrote: > On Fri, Mar 5, 2010 at 6:29 AM, Peter Hutterer > wrote: >> On Fri, Mar 05, 2010 at 01:02:18AM -0800, Bryan Hundven wrote: >> >>> EVENT type 17 >>>     device: 2 >>>     detail: 0 >>>     valuators: >>>           0: 3078.00 (3078.00) >>>    

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Bryan Hundven
On Fri, Mar 5, 2010 at 4:29 AM, Peter Hutterer wrote: > so the bad news for you is that this bug may be present for a bit until it's > sweeped up. If you're willing to help, please let me know and I'll show you > how to get started building from git and hunting bugs down. I have been packaging my

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Chris Bagwell
On Fri, Mar 5, 2010 at 6:29 AM, Peter Hutterer wrote: > On Fri, Mar 05, 2010 at 01:02:18AM -0800, Bryan Hundven wrote: > >> EVENT type 17 >>     device: 2 >>     detail: 0 >>     valuators: >>           0: 3078.00 (3078.00) >>           1: 1548.00 (1548.00) >>           2: 0.00 (0.00) >>          

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-05 Thread Peter Hutterer
On Fri, Mar 05, 2010 at 01:02:18AM -0800, Bryan Hundven wrote: > >> When I draw fast with the pen the circle is more of a polygon, but > >> when I draw the circle slowly it looks fine. Some kind of tracking > >> issue? > > > > hmm. good question. Please run "xinput --test-xi2" and then move in a >

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Peter Hutterer
Hi Bryan, Thanks much for the testing. On Thu, Mar 04, 2010 at 10:20:42PM -0800, Bryan Hundven wrote: > Attached is a test I did in xournal, exported to pdf. This test was > only with the pen. I pulled from the devel branch on sf. > > On the left side I tried to draw fast, and on the right slow.

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Bryan Hundven
Peter, Attached is a test I did in xournal, exported to pdf. This test was only with the pen. I pulled from the devel branch on sf. On the left side I tried to draw fast, and on the right slow. First of all, this does seem to fix what I was seeing in #2952501. It also provides more evidence tha

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Bryan Hundven
I'll give Peter's repo a spin tonight, and report back. On Mar 4, 2010 5:36 PM, "Chris Bagwell" wrote: For all in series: Reviewed-by: Chris Bagwell For this patch, I also noticed this mis-placed code while reviewing isdv4GetRanges() recently. It seems the basic issue is that serial ports ca

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Chris Bagwell
On Thu, Mar 4, 2010 at 8:09 PM, Peter Hutterer wrote: > On Thu, Mar 04, 2010 at 07:29:05PM -0600, Chris Bagwell wrote: >> For all in series: >> >> Reviewed-by: Chris Bagwell >> >> For this patch, I also noticed this mis-placed code while reviewing >> isdv4GetRanges() recently.  It seems the basic

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Peter Hutterer
On Thu, Mar 04, 2010 at 07:29:05PM -0600, Chris Bagwell wrote: > For all in series: > > Reviewed-by: Chris Bagwell > > For this patch, I also noticed this mis-placed code while reviewing > isdv4GetRanges() recently. It seems the basic issue is that serial > ports can return variable sized packe

Re: [Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Chris Bagwell
For all in series: Reviewed-by: Chris Bagwell For this patch, I also noticed this mis-placed code while reviewing isdv4GetRanges() recently. It seems the basic issue is that serial ports can return variable sized packets based on what user is doing. That tells me setting initial values for wcmP

[Linuxwacom-devel] [PATCH 5/5] Remove ISDV4-specific code from wcmReadPacket().

2010-03-04 Thread Peter Hutterer
The packet length only matters on ISDV4, the code should be in the matching part of the source. Signed-off-by: Peter Hutterer --- src/wcmISDV4.c | 15 +++ src/xf86Wacom.c | 22 -- 2 files changed, 15 insertions(+), 22 deletions(-) diff --git a/src/wcmISDV4.c