Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep updated this revision to Diff 34199. jaydeep added a comment. In this patch: The bit #0 has been cleared from addresses in the line tables. However we are relying upon ArchSpec instead of Target while clearing this bit in ParseDWARFLineTableCallback because SymbolContext may not have a

[Lldb-commits] [lldb] r247046 - SBThread::StepOutOfFrame should check that the SBStackFrame it gets passed

Author: jingham Date: Tue Sep 8 13:40:59 2015 New Revision: 247046 URL: http://llvm.org/viewvc/llvm-project?rev=247046=rev Log: SBThread::StepOutOfFrame should check that the SBStackFrame it gets passed is valid, and that its thread is the same as this SBThread. Modified:

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

If the patch is busted, pretty much every test should start failing. As long as ninja check-lldb actually runs, completes, and behaves pretty much the same way as before, that's pretty much all that needs to be verified. Ctrl+C shouldn't behave any differently with this patch, the idea was to

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

zturner added a comment. If the patch is busted, pretty much every test should start failing. As long as ninja check-lldb actually runs, completes, and behaves pretty much the same way as before, that's pretty much all that needs to be verified. Ctrl+C shouldn't behave any differently with this

[Lldb-commits] LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12661: NetBSD doesn't provide struct statfs, make use of struct statvfs

krytarowski added a comment. Thank you. Place commit. Repository: rL LLVM http://reviews.llvm.org/D12661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r247082 - Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness

Author: enrico Date: Tue Sep 8 17:09:19 2015 New Revision: 247082 URL: http://llvm.org/viewvc/llvm-project?rev=247082=rev Log: Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness Modified:

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

Cool, lgtm as well. Sorry for the holdup On Tue, Sep 8, 2015 at 1:58 PM Adrian McCarthy wrote: > amccarth added a comment. > > It seems to be general flakiness. In three runs without the patch, I got > the lower numbers every time. In three runs with the patch, I got

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

zturner added a comment. Cool, lgtm as well. Sorry for the holdup http://reviews.llvm.org/D12651 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r247085 - ExpressionVariable now uses llvm::cast() instead of As...() for RTTI.

Author: spyffe Date: Tue Sep 8 17:23:39 2015 New Revision: 247085 URL: http://llvm.org/viewvc/llvm-project?rev=247085=rev Log: ExpressionVariable now uses llvm::cast() instead of As...() for RTTI. As part of our overall switch from hand-rolling RTTI to using LLVM-compatible methods, I've done

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

zturner added a comment. Can you confirm with 2 runs before and 2 runs after the patch that you see the same results every time? Todd, can you think of a reason why this might happen? I don't think it's worth holding the patch up too long over this because I want to see the other improvements

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

tfiala added a comment. In http://reviews.llvm.org/D12651#241810, @zturner wrote: > Can you confirm with 2 runs before and 2 runs after the patch that you see > the same results every time? > > Todd, can you think of a reason why this might happen? Hmm, I vaguely recall finding what looked

Re: [Lldb-commits] [PATCH] D12699: Change the looping stack detection code

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I'm fine with this change. On x86, where the CALL instruction pushes the return address on the stack, you can't have two stack frames with the CFA. If we have a loop, I don't

[Lldb-commits] [lldb] r247013 - Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD

Author: emaste Date: Tue Sep 8 08:33:21 2015 New Revision: 247013 URL: http://llvm.org/viewvc/llvm-project?rev=247013=rev Log: Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD This test passes locally but was disabled due to pexpect issues on

[Lldb-commits] [PATCH] D12714: Fix log message warning in SBThread.

brucem created this revision. brucem added reviewers: clayborg, jingham. brucem added a subscriber: lldb-commits. The format string was not set up correctly as it was missing the %. This resulted in a warning (correctly) that the data arguments were not all used. http://reviews.llvm.org/D12714

[Lldb-commits] [lldb] r247101 - Fix regressions in dotest.py when passing filters or directories.

Author: tfiala Date: Tue Sep 8 18:22:19 2015 New Revision: 247101 URL: http://llvm.org/viewvc/llvm-project?rev=247101=rev Log: Fix regressions in dotest.py when passing filters or directories. See https://llvm.org/bugs/show_bug.cgi?id=24708 for details. Using '-f FILTER' or unnamed arguments

[Lldb-commits] [lldb] r247090 - Reverting r247000 since it's causing TestRegisters.test_fp_special_purpose_register_read to fail on OSX.

Author: ovyalov Date: Tue Sep 8 17:41:13 2015 New Revision: 247090 URL: http://llvm.org/viewvc/llvm-project?rev=247090=rev Log: Reverting r247000 since it's causing TestRegisters.test_fp_special_purpose_register_read to fail on OSX. Modified:

Re: [Lldb-commits] [PATCH] D12677: Bug 24733: TestRegisters.py for Clang inferiors

ovyalov added a subscriber: ovyalov. ovyalov added a comment. I reverted the CL because it was causing TestRegisters.test_fp_special_purpose_register_read to fail on OSX: - stop reason = EXC_BREAKPOINT - "register read ftag" yields 0x80 instead of expected 0x8000

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. One minor IsValid() fix in DWARFDIE to avoid crashes and this is good to go. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp:28-35 @@ -27,1 +27,10 @@

Re: [Lldb-commits] [PATCH] D12615: Teach utilsOsType about NetBSD

sas added a comment. I suppose you'll want this to go in as well so I'll just do it along with the rest. Repository: rL LLVM http://reviews.llvm.org/D12615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r247111 - Fix log message warning in SBThread.

Author: brucem Date: Tue Sep 8 19:56:25 2015 New Revision: 247111 URL: http://llvm.org/viewvc/llvm-project?rev=247111=rev Log: Fix log message warning in SBThread. Summary: The format string was not set up correctly as it was missing the %. This resulted in a warning (correctly) that the data

Re: [Lldb-commits] [PATCH] D12662: Prevent from a redefinition of _GLIBCXX_USE_NANOSLEEP

sas closed this revision. sas added a comment. Committed as r247114. Repository: rL LLVM http://reviews.llvm.org/D12662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r247115 - NetBSD doesn't provide struct statfs, make use of struct statvfs

Author: sas Date: Tue Sep 8 20:19:05 2015 New Revision: 247115 URL: http://llvm.org/viewvc/llvm-project?rev=247115=rev Log: NetBSD doesn't provide struct statfs, make use of struct statvfs Reviewers: joerg, sas Subscribers: labath, lldb-commits Differential Revision:

Re: [Lldb-commits] [PATCH] D12615: Teach utilsOsType about NetBSD

sas closed this revision. sas added a comment. Committed as r247116. Repository: rL LLVM http://reviews.llvm.org/D12615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r247114 - Prevent from a redefinition of _GLIBCXX_USE_NANOSLEEP

Author: sas Date: Tue Sep 8 20:17:24 2015 New Revision: 247114 URL: http://llvm.org/viewvc/llvm-project?rev=247114=rev Log: Prevent from a redefinition of _GLIBCXX_USE_NANOSLEEP Summary: Build warning caught on NetBSD. Reviewers: joerg, sas Subscribers: lldb-commits Differential Revision:

[Lldb-commits] [lldb] r247120 - A change I'm open to reverting if there is disagreement:

Author: jmolenda Date: Tue Sep 8 22:24:52 2015 New Revision: 247120 URL: http://llvm.org/viewvc/llvm-project?rev=247120=rev Log: A change I'm open to reverting if there is disagreement: When lldb receives a gdb-remote protocol packet that has nonprintable characters, it will print the packet in

[Lldb-commits] [lldb] r247121 - When lldb gets the register definitions from the response of a

Author: jmolenda Date: Tue Sep 8 22:36:24 2015 New Revision: 247121 URL: http://llvm.org/viewvc/llvm-project?rev=247121=rev Log: When lldb gets the register definitions from the response of a qXfer:features:read:target.xml packet, or via the plugin.process.gdb-remote.target-definition-file

[Lldb-commits] [lldb] r247023 - Fix debugger shutdown when Python interpreter is loaded.

Author: ovyalov Date: Tue Sep 8 11:26:32 2015 New Revision: 247023 URL: http://llvm.org/viewvc/llvm-project?rev=247023=rev Log: Fix debugger shutdown when Python interpreter is loaded. http://reviews.llvm.org/D12683 Modified: lldb/trunk/source/Core/Debugger.cpp Modified:

Re: [Lldb-commits] [PATCH] D12683: Fix debugger shutdown when Python interpreter is loaded

ovyalov closed this revision. ovyalov added a comment. Files: /lldb/trunk/source/Core/Debugger.cpp Users: ovyalov (Author) http://reviews.llvm.org/rL247023 http://reviews.llvm.org/D12683 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r247022 - Fix assertion failure caused by a bug in 128bit register handling in RegisterValue

Author: tberghammer Date: Tue Sep 8 11:22:23 2015 New Revision: 247022 URL: http://llvm.org/viewvc/llvm-project?rev=247022=rev Log: Fix assertion failure caused by a bug in 128bit register handling in RegisterValue Modified: lldb/trunk/include/lldb/Core/RegisterValue.h

Re: [Lldb-commits] [PATCH] D12667: [cmake] Remove LLDB_ENABLE_PYTHON_SCRIPTS_SWIG_API_GENERATION.

clayborg added a comment. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Open issues: - In FormatEntity.cpp we probably don't need any changes to DumpAddress() - Remove MIPS comment from generic code and let the "Target::GetOpcodeLoadAddress (...)

[Lldb-commits] [lldb] r247024 - Revert "Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD"

Author: emaste Date: Tue Sep 8 11:35:28 2015 New Revision: 247024 URL: http://llvm.org/viewvc/llvm-project?rev=247024=rev Log: Revert "Enable StopHookForMultipleThreadsTestCase::test_stop_hook_multiple_threads_with_dwarf on FreeBSD" And update the comment describing the reason this test is

[Lldb-commits] [lldb] r247012 - Remove expectedFailureFreeBSD from passing PluginCommandTestCase::test_load_plugin

Author: emaste Date: Tue Sep 8 08:27:27 2015 New Revision: 247012 URL: http://llvm.org/viewvc/llvm-project?rev=247012=rev Log: Remove expectedFailureFreeBSD from passing PluginCommandTestCase::test_load_plugin This test was failing due to a libc++ vs libsdc++ conflict which should be fixed by

[Lldb-commits] [lldb] r247034 - Add missing include for va_list in MIUtilString.h

Author: sas Date: Tue Sep 8 12:47:17 2015 New Revision: 247034 URL: http://llvm.org/viewvc/llvm-project?rev=247034=rev Log: Add missing include for va_list in MIUtilString.h Summary: Problem was caught on NetBSD. Reviewers: joerg, sas Subscribers: lldb-commits Differential Revision:

Re: [Lldb-commits] [PATCH] D12654: Add missing include for va_list in MIUtilString.h

sas closed this revision. sas added a comment. Committed as r247034. Repository: rL LLVM http://reviews.llvm.org/D12654 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D12699: Change the looping stack detection code

tberghammer created this revision. tberghammer added a reviewer: jasonmolenda. tberghammer added a subscriber: lldb-commits. Change the looping stack detection code In some special case (e.g. signal handlers, hand written assembly) it is valid to have 2 stack frame with the same CFA value. This

[Lldb-commits] [lldb] r247041 - Use LLVM casting for TypeSystem so you can cast it to subclasses.

Author: gclayton Date: Tue Sep 8 13:15:05 2015 New Revision: 247041 URL: http://llvm.org/viewvc/llvm-project?rev=247041=rev Log: Use LLVM casting for TypeSystem so you can cast it to subclasses. This will keep our code cleaner and it removes the need for intrusive additions to TypeSystem like: