abidh added a comment.
Please also indicate if a revision is dependent on some other revisions that
has not yet been committed as this one is on http://reviews.llvm.org/D13657.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:126
@@ -125,12 +125,3 @@
{
-if (m_bHa
evgeny777 added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:126
@@ -125,12 +125,3 @@
{
-if (m_bHandleCharType && IsCharType())
-{
-vwrValue = GetSimpleValueChar();
-return MIstatus::success;
-}
-e
evgeny777 updated this revision to Diff 37733.
evgeny777 added a comment.
Review updated to reflect Enrico comments regarding signed/unsigned char.
Now all character types are evaluated as ASCII code (signed or unsigned) +
value.
Additional method introduced to SBValue to check if type is signed
Author: slthakur
Date: Mon Oct 19 06:21:20 2015
New Revision: 250696
URL: http://llvm.org/viewvc/llvm-project?rev=250696&view=rev
Log:
[LLDB][MIPS] Use the correct ptrace buffer for writing register value for o32
applications
For o32 applications on mips we were getting segmentation fault while
mohit.bhakkad created this revision.
mohit.bhakkad added reviewers: clayborg, zturner.
mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain,
lldb-commits.
mohit.bhakkad set the repository for this revision to rL LLVM.
Some machines of an arch may not have all the regs listed for
tberghammer added a comment.
I agree with Greg that the Platform should hand out the value but I would
suggest to create a Platform::GetMemoryCacheLineSize() function what will be
overwritten in PlatfromAndroid.
> ADB packets have a fixed size of 4k.
It is not true. ADB packets have a maximum
abidh created this revision.
abidh added a reviewer: clayborg.
abidh added a subscriber: lldb-commits.
I saw following gcc warnings in 3 places and they seem to make sense.
"comparison of unsigned expression >= 0 is always true [-Wtype-limits]"
To fix the warnings, I have removed the offending c
tberghammer added a comment.
I thought a bit about the points raised by Todd and in general I am happy with
overloading the system during testing with a very high number of tests as it
will most likely help us to detect race conditions and based on my testing (on
a 40 core Linux machine) it isn
omjavaid updated this revision to Diff 37748.
omjavaid added a comment.
This patch fixes unexpected behaviour of watchpoint code on Nexus 9 (AArch64).
http://reviews.llvm.org/D12522
Files:
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
Index: source/Plugins/Process/Linux/N
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D12522
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
labath added a subscriber: labath.
labath added a comment.
If the registers are not present, wouldn't it be better to *not* include them
in qRegisterInfo response in the first place?
Repository:
rL LLVM
http://reviews.llvm.org/D13859
___
lldb-co
On Mon, Oct 19, 2015 at 12:59:25PM +, Hafiz Abid Qadeer via lldb-commits
wrote:
> I saw following gcc warnings in 3 places and they seem to make sense.
>
> "comparison of unsigned expression >= 0 is always true [-Wtype-limits]"
>
> To fix the warnings, I have removed the offending checks. OK
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I think this can go in now. Currently, the paralelization happens on compile
unit level, and the test programs generally only have one compile unit. Since
the threads are created on an as-need
Author: omjavaid
Date: Mon Oct 19 09:54:33 2015
New Revision: 250700
URL: http://llvm.org/viewvc/llvm-project?rev=250700&view=rev
Log:
Fix for random watchpoint testsuite failures on AArch64 targets.
This patch corrects the number of bytes of debug register resources which are
written while insta
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250700: Fix for random watchpoint testsuite failures on
AArch64 targets. (authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D12522?vs=37748&id=37758#toc
Repository:
rL LLVM
htt
tfiala added a comment.
That seems totally reasonable. We're fine with "this isn't an issue until it's
proven to be an issue."
(And I like stressing the concurrency - we initially found a number of issues
when the concurrent test runner came online in the first place).
http://reviews.llvm.or
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Ok, makes sense then.
Repository:
rL LLVM
http://reviews.llvm.org/D13646
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
Author: zturner
Date: Mon Oct 19 12:35:02 2015
New Revision: 250710
URL: http://llvm.org/viewvc/llvm-project?rev=250710&view=rev
Log:
Py3'ify some of the examples that get run at startup.
Even though these are under examples/, they actually get loaded
when LLDB starts up during initialization of
Author: zturner
Date: Mon Oct 19 12:34:51 2015
New Revision: 250709
URL: http://llvm.org/viewvc/llvm-project?rev=250709&view=rev
Log:
Disable libxml2 on Windows for now.
Newer versions of CMake include a "smarter" FindLibxml2 package.
In theory this is a good thing, but on Windows it's now smart
labath updated this revision to Diff 37776.
labath added a comment.
Adress review comments.
http://reviews.llvm.org/D13812
Files:
include/lldb/Target/Platform.h
source/Plugins/Platform/Android/PlatformAndroid.cpp
source/Plugins/Platform/Android/PlatformAndroid.h
source/Target/Process.cp
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Please don't check this in. If dwarf_r0 changes from 0 to another value, then
this code will fail. We will need to live with these warnings.
http://reviews.llvm.org/D13866
__
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We can't rely on any specific error codes since different GDB remote servers
will hand back different errors for any packet. Do you have control over the
MIPS debugserver? Is thi
labath added a comment.
New version of the patch. I agree that it looks better like this.
I have put the setting logic in the process constructor, rather than doing it
lazily - if anyone was observing the setting value, it would seem strange that
the value of setting changed suddenly after the
clayborg added a comment.
Yes, lets get this in an iterate on it afterwards!
http://reviews.llvm.org/D13727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
granata.enrico added inline comments.
Comment at: include/lldb/API/SBValue.h:372
@@ +371,3 @@
+bool
+IsIntegerType(bool& is_signed);
+
Greg pointed me to SBType::GetBasicType() - this will return to you one of
```
eBasicTypeSignedChar,
eBa
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. The other way to do this would be to add a key/value pair to the
qHostInfo like "memory_cache_line_byte_size" and return a value that makes
sense for the current Andriod debug
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250721: Fix Clang-tidy modernize-use-override warnings in
some files in… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D13840?vs=37663&id=37782#toc
Repository:
rL LLVM
Author: eugenezelenko
Date: Mon Oct 19 13:52:10 2015
New Revision: 250721
URL: http://llvm.org/viewvc/llvm-project?rev=250721&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13840
Mo
evgeny777 added inline comments.
Comment at: include/lldb/API/SBValue.h:372
@@ +371,3 @@
+bool
+IsIntegerType(bool& is_signed);
+
granata.enrico wrote:
> Greg pointed me to SBType::GetBasicType() - this will return to you one of
>
> ```
> eBasicTy
> On Aug 14, 2015, at 1:47 PM, Paul Herman wrote:
>
> paulherman added a comment.
>
> This patch does exactly that. It detects the language of the frame and
> upgrades it according to the rules you said (I think I might've missed ObjC
> -> ObjC++, but that can be added).
>
> Regarding the gl
Author: enrico
Date: Mon Oct 19 15:40:50 2015
New Revision: 250734
URL: http://llvm.org/viewvc/llvm-project?rev=250734&view=rev
Log:
Teach the lldbinline test cases to run in DWO mode
Modified:
lldb/trunk/test/lldbinline.py
Modified: lldb/trunk/test/lldbinline.py
URL:
http://llvm.org/viewv
Author: gclayton
Date: Mon Oct 19 15:44:01 2015
New Revision: 250735
URL: http://llvm.org/viewvc/llvm-project?rev=250735&view=rev
Log:
Allow LLDB.framework to locate debugserver even when it doesn't exist in the
LLDB.framework.
This allows open source MacOSX clients to not have to build debugser
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6.
Repository:
rL LLVM
http://reviews.ll
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13877
Files:
source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
Index: source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
sivachandra added a comment.
Putting this in as obvious. It fixes the build on Linux and Windows.
http://reviews.llvm.org/D13877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sivachandra
Date: Mon Oct 19 16:43:07 2015
New Revision: 250740
URL: http://llvm.org/viewvc/llvm-project?rev=250740&view=rev
Log:
[PlatformDarwin.cpp] Include for std::once_flag.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13877
Modifi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250740: [PlatformDarwin.cpp] Include for
std::once_flag. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D13877?vs=37796&id=37797#toc
Repository:
rL LLVM
http://reviews.
Author: enrico
Date: Mon Oct 19 17:04:25 2015
New Revision: 250744
URL: http://llvm.org/viewvc/llvm-project?rev=250744&view=rev
Log:
Let Language plugins vend a default DeclPrintingHelper in case a custom one is
not specified for the specific invocation
Added:
lldb/trunk/include/lldb/DataFo
ribrdb created this revision.
ribrdb added a reviewer: clayborg.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
Files:
cmake/LLDBDependencies.cmake
lldb.xcodeproj/project.pbxproj
source/A
ribrdb updated this revision to Diff 37800.
ribrdb added a comment.
Add tests.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
Files:
cmake/LLDBDependencies.cmake
lldb.xcodeproj/project.pbxproj
source/API/SystemInitializerFull.cpp
source/Plugins/Language/CMakeLists.txt
source/Pl
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
This patch was generating by running `2to3` on the files in the
lldb/test directory. This patch should be NFC, but it does
introduce the `from __future__ import print_function` l
clayborg added a comment.
Thanks for doing this.
Repository:
rL LLVM
http://reviews.llvm.org/D13877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg resigned from this revision.
clayborg edited reviewers, added: granata.enrico; removed: clayborg.
clayborg added a comment.
Enrico should take a look and OK this.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
___
lldb-commits mailin
sivachandra added a comment.
Pinging to ensure that it did not get lost in the title change.
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner updated this revision to Diff 37808.
zturner added a comment.
I missed a few files, this gets everything. (Still only print statements)
http://reviews.llvm.org/D13879
Files:
test/dosep.py
test/dotest.py
test/lldbtest.py
Index: test/lldbtest.py
===
zturner updated this revision to Diff 37811.
zturner added a comment.
Sorry, uploaded the wrong patch the second time. This should be the one that
gets everything.
http://reviews.llvm.org/D13879
Files:
test/bench.py
test/curses_results.py
test/dosep.py
test/dotest.py
test/dotest_arg
Author: enrico
Date: Mon Oct 19 17:53:34 2015
New Revision: 250750
URL: http://llvm.org/viewvc/llvm-project?rev=250750&view=rev
Log:
Add a flakey category for flakey tests
Modified:
lldb/trunk/test/dotest.py
Modified: lldb/trunk/test/dotest.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/t
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
LGTM, Zachary!
http://reviews.llvm.org/D13879
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: kfischer
Date: Mon Oct 19 17:59:16 2015
New Revision: 250751
URL: http://llvm.org/viewvc/llvm-project?rev=250751&view=rev
Log:
Revert r248047 and fix the problem properly
In r248047, I attempted to fix a build breakage introduced by using
llvm's regex support from lldb-mi. However, my app
zturner created this revision.
zturner added reviewers: tfiala, clayborg, dberlin.
zturner added a subscriber: lldb-commits.
`six` is a Python module licensed under MIT which provides a compatibility
layer between Python 2 and Python 3. You can read about it at the project's
homepage, here. ht
Author: spyffe
Date: Mon Oct 19 18:11:07 2015
New Revision: 250753
URL: http://llvm.org/viewvc/llvm-project?rev=250753&view=rev
Log:
Added the concept of a Read-Eval-Print-Loop to LLDB.
A REPL takes over the command line and typically treats input as source code.
REPLs can also do code completion
Author: spyffe
Date: Mon Oct 19 18:18:49 2015
New Revision: 250755
URL: http://llvm.org/viewvc/llvm-project?rev=250755&view=rev
Log:
Added REPL.cpp to the relevant CMakeLists.txt
Modified:
lldb/trunk/source/Expression/CMakeLists.txt
Modified: lldb/trunk/source/Expression/CMakeLists.txt
URL:
ovyalov created this revision.
ovyalov added reviewers: clayborg, labath, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
This CL provides logic for running lldb-server on domain sockets and required
gdb-remote infrastructure chang
> On Oct 19, 2015, at 4:18 PM, Zachary Turner via lldb-commits
> wrote:
>
> I think this is going to break the CMake build. Can you update the relevant
> CMakeLists.txt file?
>
> Also, are there any tests for this?
This doesn't actually add a REPL for any of the languages that the current L
granata.enrico added inline comments.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:104
@@ +103,3 @@
+size_t m_len;
+std::vector m_children;
+};
This worries me a little bit
Imagine I have one of these slices with a million elements, and
Author: zturner
Date: Mon Oct 19 18:45:25 2015
New Revision: 250762
URL: http://llvm.org/viewvc/llvm-project?rev=250762&view=rev
Log:
Run py2to3 on lldb/scripts folder.
This mostly fixes some print statements, but there were also some
instances of dict.iteritems() lingering that this found.
Modi
Author: zturner
Date: Mon Oct 19 18:45:41 2015
New Revision: 250763
URL: http://llvm.org/viewvc/llvm-project?rev=250763&view=rev
Log:
Convert print statements to print function calls.
This patch was generating by running `2to3` on the files in the
lldb/test directory. This patch should be NFC, b
zturner closed this revision.
zturner added a comment.
Submitted in http://reviews.llvm.org/rL250763
http://reviews.llvm.org/D13879
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: enrico
Date: Mon Oct 19 19:13:19 2015
New Revision: 250767
URL: http://llvm.org/viewvc/llvm-project?rev=250767&view=rev
Log:
Introduce the concept of a type that is meaningless without dynamic resolution,
which are essentially placeholder types meant to appease a language's type
system b
Author: gclayton
Date: Mon Oct 19 19:14:20 2015
New Revision: 250768
URL: http://llvm.org/viewvc/llvm-project?rev=250768&view=rev
Log:
Make sure we restore the process events so they aren't hijacked when using the
async attach when attaching to a process by name and with waitfor.
Modified:
Author: gclayton
Date: Mon Oct 19 19:17:39 2015
New Revision: 250770
URL: http://llvm.org/viewvc/llvm-project?rev=250770&view=rev
Log:
When calling FileSpec::AppendPathComponent() we don't need to include "." in
the path if m_filename is set to exactly '.'. Previously this would cause a
FileSpec
Author: gclayton
Date: Mon Oct 19 19:22:50 2015
New Revision: 250772
URL: http://llvm.org/viewvc/llvm-project?rev=250772&view=rev
Log:
Fixed PlatformDarwin to locate Xcode by using HostInfo::GetProgramFileSpec().
This function returns the FileSpec to the program that is running the
LLDB.framewor
Author: spyffe
Date: Mon Oct 19 19:23:46 2015
New Revision: 250773
URL: http://llvm.org/viewvc/llvm-project?rev=250773&view=rev
Log:
Added support for the "--repl" argument to LLDB.
This makes LLDB launch and create a REPL, specifying no target so that the REPL
can create one for itself. Also
sivachandra created this revision.
sivachandra added reviewers: zturner, spyffe.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13882
Files:
test/functionalities/completion/TestCompletion.py
test/functionalities/data-formatter/dump_dynamic/main.cpp
Index: test/functio
zturner added a comment.
Todd, do you have any good ideas on how to organize this and make it play
nicely with python's module / package system? `dotest` is just an arbitrary
script under lldb/test and is not part of any installed package or anything.
At the same time, third party code needs
Author: spyffe
Date: Mon Oct 19 19:55:21 2015
New Revision: 250780
URL: http://llvm.org/viewvc/llvm-project?rev=250780&view=rev
Log:
Added support to the expression command for dropping into the REPL at will.
"expr -r" does this. It also returns to a REPL if the LLDB command interpreter
is neset
sivachandra added a comment.
I am going to put this in to get the bots back to green.
http://reviews.llvm.org/D13882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250782: Adjust TestCompletion.py and TestDumpDynamic.py
after recent changes. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D13882?vs=37819&id=37822#toc
Repository:
rL L
Author: sivachandra
Date: Mon Oct 19 20:03:18 2015
New Revision: 250782
URL: http://llvm.org/viewvc/llvm-project?rev=250782&view=rev
Log:
Adjust TestCompletion.py and TestDumpDynamic.py after recent changes.
Reviewers: zturner, spyffe
Subscribers: lldb-commits
Differential Revision: http://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250789: Fix Clang-tidy modernize-use-override warnings in
source/Plugins/Language… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D13876?vs=37794&id=37823#toc
Repository:
Author: eugenezelenko
Date: Mon Oct 19 20:10:59 2015
New Revision: 250789
URL: http://llvm.org/viewvc/llvm-project?rev=250789&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in source/Plugins/Language;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D13876
Modifie
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:10
@@ +9,3 @@
+
+#include
+
Please add include section comments. Same for other sections.
Comment at: source/Plugins/Language/Go/G
Eugene.Zelenko added inline comments.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.h:1
@@ +1,2 @@
+//===-- GoFormatterFunctions.h*- C++
-*-===//
+//
Such comments should be 80 characters long.
C
Eugene.Zelenko added a comment.
I think will be good idea to format code with Clang-format.
See also http://reviews.llvm.org/rL250789 I just committed with similar
cleanups for other languages.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
__
Eugene.Zelenko added inline comments.
Comment at: source/Plugins/Language/Go/GoFormatterFunctions.cpp:107
@@ +106,3 @@
+
+} // anonymous namespace
+
One space should be enough.
Repository:
rL LLVM
http://reviews.llvm.org/D13878
___
Hello everyone,
LLVM buildmaster will restarted in few minutes.
Thank you for understanding.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: enrico
Date: Mon Oct 19 23:50:09 2015
New Revision: 250798
URL: http://llvm.org/viewvc/llvm-project?rev=250798&view=rev
Log:
Rationalization of includes in the data formatters code
Modified:
lldb/trunk/include/lldb/DataFormatters/CXXFunctionPointer.h
lldb/trunk/include/lldb/DataFo
77 matches
Mail list logo
