[Lldb-commits] [lldb] r297120 - Fix FreeBSD build.

Author: zturner Date: Mon Mar 6 22:58:53 2017 New Revision: 297120 URL: http://llvm.org/viewvc/llvm-project?rev=297120=rev Log: Fix FreeBSD build. Modified: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp Modified: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp

[Lldb-commits] [lldb] r297119 - Remove FileSpec dependency on FileSystem.

Author: zturner Date: Mon Mar 6 22:58:06 2017 New Revision: 297119 URL: http://llvm.org/viewvc/llvm-project?rev=297119=rev Log: Remove FileSpec dependency on FileSystem. Modified: lldb/trunk/source/Host/common/FileSpec.cpp Modified: lldb/trunk/source/Host/common/FileSpec.cpp URL:

[Lldb-commits] [lldb] r297117 - Fix linux build.

Author: zturner Date: Mon Mar 6 21:58:59 2017 New Revision: 297117 URL: http://llvm.org/viewvc/llvm-project?rev=297117=rev Log: Fix linux build. Modified: lldb/trunk/source/Host/common/FileSpec.cpp Modified: lldb/trunk/source/Host/common/FileSpec.cpp URL:

[Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

This revision was automatically updated to reflect the committed changes. Closed by commit rL297116: Use LLVM for all stat-related functionality. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D30624?vs=90619=90786#toc Repository: rL LLVM

[Lldb-commits] [lldb] r297116 - Use LLVM for all stat-related functionality.

Author: zturner Date: Mon Mar 6 21:43:17 2017 New Revision: 297116 URL: http://llvm.org/viewvc/llvm-project?rev=297116=rev Log: Use LLVM for all stat-related functionality. This deletes LLDB's FileType enumeration and replaces all users, and all calls to functions that check whether a file

[Lldb-commits] Buildbot numbers for the week of 02/19/2017 - 02/25/2017

Hello everyone, Below are some buildbot numbers for the week of 02/19/2017 - 02/25/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[Lldb-commits] Buildbot numbers for the week of 02/26/2017 - 03/04/2017

Hello everyone, Below are some buildbot numbers for the last week of 02/26/2017 - 03/04/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

Re: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

Yes formally that seems problematic. It wouldn't be a problem in practice because you should only call ResetNeedsUpdating in UpdateAutomaticSignalFiltering, and the only place where UpdateAutomaticSignalFiltering should be called is when Launching or Resuming, and you can't call either of

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ok, sounds like everyone thought through the solution. Lets start with this and we can iterate if needed. https://reviews.llvm.org/D30520

Re: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

UnixSignals::NeedsUpdating() method suggests that there is always at most one observer of changes in UnixSignals, the guys who clear the flag. Even though it might be the case now, it still feels like a bomb waiting to explode when another observer starts calling UnixSignals::ResetNeedsUpdating().

Re: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

I like it in the base class and Greg was okay with that too. So let's leave that where it is. The only bit of this behavior that could be moved into UnixSignals as it seemed to me was the handling of "needs updating". I was mostly proposing that because then you can already pass the

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

eugene added a comment. UnixSignals is a nice self contained class that already does 99% of the work (see UnixSignals::GetFilteredSignals). I don't think we should have it call anybody. Only process knows when it is the right time to send actual QPassSignals packet, there is not need to

Re: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

The UnixSignals class produces the array of signal numbers that it knows it doesn't want to hear about. But it has no idea how any particular Process plugin would implement ignoring those symbols. So that part belongs to the Process plugin. I suggested in a previous comment also adding a

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

clayborg added a comment. Jim Ingham said (in email): > I disagree. The different processes are at this point more about transport > than about the platform details. That indicates to me that it's more likely > that different process implementations will have different ways of >

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

eugene added inline comments. Comment at: include/lldb/Target/Process.h:3148 + virtual Error UpdateAutomaticSignalFiltering(); + clayborg wrote: > Can we remove this and only have it in ProcessGDBRemote? Then we just call it > when we need to in

Re: [Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

> On Mar 6, 2017, at 4:10 PM, Greg Clayton via Phabricator > wrote: > > clayborg requested changes to this revision. > clayborg added a comment. > This revision now requires changes to proceed. > > Very close. Can we try to get UpdateAutomaticSignalFiltering out of

[Lldb-commits] [lldb] r297104 - cleanup.

Author: jmolenda Date: Mon Mar 6 18:00:35 2017 New Revision: 297104 URL: http://llvm.org/viewvc/llvm-project?rev=297104=rev Log: cleanup. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Very close. Can we try to get UpdateAutomaticSignalFiltering out of lldb_private::Process as my inline comments suggest? It would be cleaner and I am not sure we actually need

[Lldb-commits] [lldb] r297102 - Add missing include in FileSpec.

Author: zturner Date: Mon Mar 6 17:52:57 2017 New Revision: 297102 URL: http://llvm.org/viewvc/llvm-project?rev=297102=rev Log: Add missing include in FileSpec. Modified: lldb/trunk/source/Host/common/FileSpec.cpp Modified: lldb/trunk/source/Host/common/FileSpec.cpp URL:

[Lldb-commits] [lldb] r297095 - Remove FileSpec::ReadFileContents.

Author: zturner Date: Mon Mar 6 17:42:14 2017 New Revision: 297095 URL: http://llvm.org/viewvc/llvm-project?rev=297095=rev Log: Remove FileSpec::ReadFileContents. This functionality is subsumed by DataBufferLLVM, which is also more efficient since it will try to mmap. However, we don't yet

[Lldb-commits] [lldb] r297096 - Remove dependency from FileSpec to ArchSpec.

Author: zturner Date: Mon Mar 6 17:42:44 2017 New Revision: 297096 URL: http://llvm.org/viewvc/llvm-project?rev=297096=rev Log: Remove dependency from FileSpec to ArchSpec. All it really needs is the llvm::Triple, so make FileSpec take the Triple directly instead of the ArchSpec. Modified:

[Lldb-commits] [PATCH] D30622: Remove FileSpec::ReadFileContents

This revision was automatically updated to reflect the committed changes. Closed by commit rL297095: Remove FileSpec::ReadFileContents. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D30622?vs=90617=90759#toc Repository: rL LLVM https://reviews.llvm.org/D30622

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

eugene marked 3 inline comments as done. eugene added a comment. Addressing review comments. Comment at: unittests/Signals/UnixSignalsTest.cpp:43 + +#define ASSERT_EQ_ARRAYS(expected, observed) \ + AssertEqArrays((expected), (observed),

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

eugene updated this revision to Diff 90755. eugene added a comment. Addressing review comments on SignalTests and getting rid of dependency on DidLaunch and WillResume https://reviews.llvm.org/D30520 Files: include/lldb/Target/Process.h include/lldb/Target/UnixSignals.h

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

clayborg added a comment. My main objection is that if we have 10 "lldb_private::Process::Will*" functions and only some require you to call the superclass, then it is confusing. It is also hard to enforce. We probably have other process subclasses that override these functions and they all

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Pretty close. My only objection is we have many "lldb_private::Process::Will" and "lldb_private::Process::Did" prefixed functions and none of them are required to call the

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

jingham added a comment. That looks good. This is a good addition for processes that are really chatty with some signals. Thanks for working on this. https://reviews.llvm.org/D30520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29581: Initial implementation of SB APIs for Tracing support.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Much better. Found some extra stuff. In general we should be using SBStructuredData when ever we want to get/set stuff from structured data like JSON, XML or Apple plist, etc.

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

clayborg added a comment. So a ModuleSpec allows you to specify a module by path, UUID and many other things. This is falling down for a magic file that doesn't actually exist right? "vsdo" is just a made up name for the table of loaded shared libraries? Is that correct? I need to understand

[Lldb-commits] [lldb] r297053 - Update log_options unit test

Author: labath Date: Mon Mar 6 13:10:19 2017 New Revision: 297053 URL: http://llvm.org/viewvc/llvm-project?rev=297053=rev Log: Update log_options unit test it was accessing the details of the Log class directly. Let it go through the channel class instead. This also discovered a bug when we

[Lldb-commits] [lldb] r297036 - A few improvements to deps analysis scripts.

Author: zturner Date: Mon Mar 6 11:41:00 2017 New Revision: 297036 URL: http://llvm.org/viewvc/llvm-project?rev=297036=rev Log: A few improvements to deps analysis scripts. 1) Looks in Plugins and clang 2) Adds a mode to display the deps sorted by the number of times the deps occurs in a

[Lldb-commits] [lldb] r297035 - Fix line endings of deps analysis script.

Author: zturner Date: Mon Mar 6 11:40:36 2017 New Revision: 297035 URL: http://llvm.org/viewvc/llvm-project?rev=297035=rev Log: Fix line endings of deps analysis script. Modified: lldb/trunk/scripts/analyze-project-deps.py Modified: lldb/trunk/scripts/analyze-project-deps.py URL:

Re: [Lldb-commits] [lldb] r297013 - Fix Log unit tests

Weird, I could have sworn I fixed this. But looking at my disk, it's sitting uncommitted :-/ On Mon, Mar 6, 2017 at 7:29 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Mon Mar 6 09:17:36 2017 > New Revision: 297013 > > URL:

[Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. I would find `using fs = llvm::sys::fs` (or whatever is the correct namespace alias syntax) more readable, as you then still have `fs::` in the references, but maybe that's just my

[Lldb-commits] [PATCH] D30622: Remove FileSpec::ReadFileContents

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great. One thing I'd consider is adding a function which returns the data buffer as a StringRef (`AsStringRef()` ?) instead of the GetChars function, but I don't feel strongly about it.

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

labath added a comment. Looks great, just a couple of style nits in the tests. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:82 +#include "llvm/ADT/SmallVector.h" #include "llvm/ADT/StringSwitch.h" Is this include still necessary?

[Lldb-commits] [lldb] r297013 - Fix Log unit tests

Author: labath Date: Mon Mar 6 09:17:36 2017 New Revision: 297013 URL: http://llvm.org/viewvc/llvm-project?rev=297013=rev Log: Fix Log unit tests the llvm function for getting the thread name dropped the _np suffix during review. Zachary's commit did not reflect that. Modified: