clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.
Comment at: source/Core/Section.cpp:30
-static const char *GetSectionTypeAsCString(lldb::SectionType sect_type) {
+const char
labath added a comment.
The patch looks fine to me. I think I'd make the arm test (I guess that is
interesting because of the bit 0 twiddling ?) a non-execution test, but this is
fine as well.
Comment at:
Now with the correct e-mail.
How is this different from llvm-objdump or llvm-readobj?
(also you might want to update your commit e-mail as reply-to seems to
still be set to your @apple address and bounces back).
Thanks,
--
Davide
On Mon, Apr 2, 2018 at 10:25 AM, Davide Italiano
clayborg added a comment.
No real functional change, just fixing layering and moving code. Also a
renaming from GetCompileUnitDIEOnly to GetUnitDIEOnly.
https://reviews.llvm.org/D45170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg added a comment.
Yes this is just moving all ivars from DWARFCompileUnit to DWARFUnit, moving
all functions that used those accessors to DWARFUnit and remove the indirection
through DWARFCompileUnit that was in DWARFUnit using:
virtual DWARFCompileUnit () = 0;
davide added a comment.
Thanks Greg. This is a very large patch, but it seems mostly churn. I'll try to
find the time to review it carefully tomorrow.
https://reviews.llvm.org/D45170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328985: [Core] Grab-bag of improvements for Scalar.
(authored by davide, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: davide
Date: Mon Apr 2 09:50:54 2018
New Revision: 328985
URL: http://llvm.org/viewvc/llvm-project?rev=328985=rev
Log:
[Core] Grab-bag of improvements for Scalar.
Remove Scalar::Cast.
It was noted on the list that this method is unused. So, this patch
removes it.
Fix Scalar::Promote
clayborg created this revision.
clayborg added reviewers: labath, davide, aprantl, jasonmolenda.
Herald added a subscriber: JDevlieghere.
Many things that were in DWARFCompileUnit actually need to be in DWARFUnit.
This patch moves all DWARFUnit specific things over into DWARFUnit and fixes
the
davide closed this revision.
davide added a comment.
Lang committed this a while ago (r323163)
Repository:
rL LLVM
https://reviews.llvm.org/D41997
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
davide abandoned this revision.
davide added a comment.
I think this is obsolete by now.
https://reviews.llvm.org/D42656
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328984: Support template template parameters (authored by
friss, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44613
Files:
Author: friss
Date: Mon Apr 2 09:18:32 2018
New Revision: 328984
URL: http://llvm.org/viewvc/llvm-project?rev=328984=rev
Log:
Support template template parameters
Summary:
We would fail to resolve (and thus display the value of) any
templated type which contained a template template argument
davide accepted this revision.
davide added a comment.
LGTM. I'll commit for you once Greg reviews it again.
Comment at:
packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/main.c:1
+__attribute__((section("__codesection")))
+int f(int a) {
kbaladurin added inline comments.
Comment at:
packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/main.c:1
+__attribute__((section("__codesection")))
+int f(int a) {
clayborg wrote:
> Will this work with all compilers we currently run the test suite
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at:
packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/main.c:1
+__attribute__((section("__codesection")))
+int f(int a) {
kbaladurin updated this revision to Diff 140628.
kbaladurin added a comment.
@davide thank you! I've updated diff. Yes, I need somebody to commit this, so I
haven't commit access.
https://reviews.llvm.org/D44998
Files:
include/lldb/Core/Section.h
lit/Modules/elf-code-section.yaml
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Sorry for the delay.
https://reviews.llvm.org/D44613
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
davide added a comment.
I think this is almost ready to go in modulo minors. I'll let also @labath
comment on it. Thanks for your contribution!
Do you need somebody to commit this on your behalf?
Comment at:
Author: jdevlieghere
Date: Mon Apr 2 03:44:36 2018
New Revision: 328966
URL: http://llvm.org/viewvc/llvm-project?rev=328966=rev
Log:
[test] Exit lldb-dotest in a more Pythonic way.
As suggested by Keith Smiley in:
https://github.com/apple/swift-lldb/pull/486
Modified:
kbaladurin updated this revision to Diff 140609.
kbaladurin added a comment.
Herald added a subscriber: javed.absar.
Thank you! I've extended `lldb-test` utility to dump section type:
Showing 6 sections
Index: 0
Type: regular
Name:
VM size: 0
File size: 0
Index: 1
21 matches
Mail list logo
