[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

mgorny added a comment. This is still breaking NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/19339/steps/ninja%20build%20local/logs/stdio FAILED: tools/lldb/source/API/CMakeFiles/liblldb.dir/SBHostOS.cpp.o /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

tamur updated this revision to Diff 189652. tamur added a comment. Herald added a subscriber: jdoerfert. Discarded changes to the unit test and added a lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

jankratochvil added a comment. In D58962#1420626 , @stella.stamenova wrote: > This caused a failure on the Windows bot: Checked in rL355579 to skip the test on Windows as `lldb-server` is not being built on Windows.

[Lldb-commits] [lldb] r355579 - Skip TestGdbserverPort.test on Windows

Author: jankratochvil Date: Wed Mar 6 19:41:00 2019 New Revision: 355579 URL: http://llvm.org/viewvc/llvm-project?rev=355579=rev Log: Skip TestGdbserverPort.test on Windows lldb/cmake/modules/LLDBConfig.cmake does not build lldb-server on Windows: if (CMAKE_SYSTEM_NAME MATCHES

[Lldb-commits] [PATCH] D59072: [ExpressionParser] Implement ComputeClangResourceDir for Windows

xiaobai created this revision. xiaobai added reviewers: aprantl, labath. Herald added subscribers: jdoerfert, teemperor. Herald added a project: LLDB. This function is useful for expression evaluation, especially when doing swift debugging on windows. Repository: rLLDB LLDB

[Lldb-commits] [lldb] r355578 - When disassembling Aarch64 target and vendor Apple, set the cpu to

Author: jmolenda Date: Wed Mar 6 19:16:45 2019 New Revision: 355578 URL: http://llvm.org/viewvc/llvm-project?rev=355578=rev Log: When disassembling Aarch64 target and vendor Apple, set the cpu to "apple-latest" which llvm uses to indicate the newest supported ISA. Add a unit test; I'm only

[Lldb-commits] [PATCH] D59056: Repair the build when LLDB_DISABLE_PYTHON is set

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355575: Repair the build when LLDB_DISABLE_PYTHON is set (authored by xiaobai, committed by ). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] r355575 - Repair the build when LLDB_DISABLE_PYTHON is set

Author: xiaobai Date: Wed Mar 6 17:02:55 2019 New Revision: 355575 URL: http://llvm.org/viewvc/llvm-project?rev=355575=rev Log: Repair the build when LLDB_DISABLE_PYTHON is set Summary: If LLDB_DISABLE_PYTHON is set, some functions are unavailable but SBReproducer assumes they are. Let's

[Lldb-commits] [lldb] r355573 - Avoid using -S in combination with "script"; it's unreliable.

Author: adrian Date: Wed Mar 6 16:46:56 2019 New Revision: 355573 URL: http://llvm.org/viewvc/llvm-project?rev=355573=rev Log: Avoid using -S in combination with "script"; it's unreliable. Modified: lldb/trunk/lit/Python/crashlog.test Modified: lldb/trunk/lit/Python/crashlog.test URL:

[Lldb-commits] [lldb] r355572 - crashlog.py: Catch exception from subprocess.

Author: adrian Date: Wed Mar 6 16:41:51 2019 New Revision: 355572 URL: http://llvm.org/viewvc/llvm-project?rev=355572=rev Log: crashlog.py: Catch exception from subprocess. Modified: lldb/trunk/examples/python/crashlog.py Modified: lldb/trunk/examples/python/crashlog.py URL:

[Lldb-commits] [lldb] r355571 - Relax testcase.

Author: adrian Date: Wed Mar 6 16:34:13 2019 New Revision: 355571 URL: http://llvm.org/viewvc/llvm-project?rev=355571=rev Log: Relax testcase. Recent versions of llvm monorepo builds build libc++abi.dylib as libc++abi.1.dylib. This accespts both variants. Modified:

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rL355570: [Reproducers] Add tests for different types of functionality (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r355570 - [Reproducers] Add tests for different types of functionality

Author: jdevlieghere Date: Wed Mar 6 16:24:44 2019 New Revision: 355570 URL: http://llvm.org/viewvc/llvm-project?rev=355570=rev Log: [Reproducers] Add tests for different types of functionality This patch adds test that check that functionality in lldb continues to work when replaying a

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/lit/Reproducer/Functionalities/TestDataFormatter.test:6 +# RUN: rm -rf %t.repro +# RUN: %clang -x c++ %S/Inputs/foo.cpp -g -o %t.out +

[Lldb-commits] [lldb] r355569 - Promote more debug-only assertions to regular assertions.

Author: adrian Date: Wed Mar 6 16:14:20 2019 New Revision: 355569 URL: http://llvm.org/viewvc/llvm-project?rev=355569=rev Log: Promote more debug-only assertions to regular assertions. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

[Lldb-commits] [lldb] r355568 - Promote more debug-only assertions to regular assertions.

Author: adrian Date: Wed Mar 6 16:10:11 2019 New Revision: 355568 URL: http://llvm.org/viewvc/llvm-project?rev=355568=rev Log: Promote more debug-only assertions to regular assertions. Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lit/Reproducer/Functionalities/TestImagineList.test:17 + +# RUN: rm -rf + aprantl wrote: > really? ;-) 樂樂樂 CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

JDevlieghere updated this revision to Diff 189610. JDevlieghere added a comment. Remove spurious RUN command. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55626/new/ https://reviews.llvm.org/D55626 Files: lldb/lit/Reproducer/Functionalities/Inputs/DataFormatter.in

[Lldb-commits] [lldb] r355566 - [Python] Unbreak the recently modified tests for python 2.

Author: davide Date: Wed Mar 6 15:50:36 2019 New Revision: 355566 URL: http://llvm.org/viewvc/llvm-project?rev=355566=rev Log: [Python] Unbreak the recently modified tests for python 2. Modified: lldb/trunk/examples/darwin/heap_find/heap.py lldb/trunk/examples/python/crashlog.py

[Lldb-commits] [lldb] r355565 - Remove the warning in

Author: jmolenda Date: Wed Mar 6 15:47:52 2019 New Revision: 355565 URL: http://llvm.org/viewvc/llvm-project?rev=355565=rev Log: Remove the warning in DynamicLoaderDarwinKernel::KextImageInfo::LoadImageUsingMemoryModule which would list every kext that failed to load when doing kernel debugging.

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl added inline comments. Comment at: lldb/lit/Reproducer/Functionalities/TestImagineList.test:8 + +# RUN: rm -rf %T/imagelist +# RUN: rm -rf %t.txt There's still a %T CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55626/new/

[Lldb-commits] [PATCH] D59056: Repair the build when LLDB_DISABLE_PYTHON is set

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, Thank you for fixing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59056/new/ https://reviews.llvm.org/D59056

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

JDevlieghere updated this revision to Diff 189608. JDevlieghere marked 8 inline comments as done. JDevlieghere added a comment. Feedback Adrian CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55626/new/ https://reviews.llvm.org/D55626 Files:

[Lldb-commits] [PATCH] D59056: Repair the build when LLDB_DISABLE_PYTHON is set

xiaobai updated this revision to Diff 189603. xiaobai added a comment. Group function registrations to cut down on ifdefs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59056/new/ https://reviews.llvm.org/D59056 Files: source/API/SBReproducer.cpp Index: source/API/SBReproducer.cpp

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl requested changes to this revision. aprantl added inline comments. This revision now requires changes to proceed. Herald added a subscriber: jdoerfert. Comment at: lit/Reproducer/Functionalities/Inputs/foo.cpp:3 +public: + Foo(int i, double d) : m_i(i), m_d(d){}; +

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl added inline comments. Comment at: lit/Reproducer/Functionalities/TestDataFormatter.test:5 + +# RUN: rm -rf %T/dataformatter +# RUN: %clang -x c++ %S/Inputs/foo.cpp -g -o %t.out same here Comment at:

[Lldb-commits] [lldb] r355562 - [testsuite] Port crashlog to python 3, second attempt.

Author: davide Date: Wed Mar 6 14:54:11 2019 New Revision: 355562 URL: http://llvm.org/viewvc/llvm-project?rev=355562=rev Log: [testsuite] Port crashlog to python 3, second attempt. Modified: lldb/trunk/examples/darwin/heap_find/heap.py lldb/trunk/examples/python/crashlog.py

[Lldb-commits] [lldb] r355561 - Fix Cmake files for ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp.

Author: jingham Date: Wed Mar 6 14:53:38 2019 New Revision: 355561 URL: http://llvm.org/viewvc/llvm-project?rev=355561=rev Log: Fix Cmake files for ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp. Modified: lldb/trunk/source/Expression/CMakeLists.txt

[Lldb-commits] [PATCH] D59056: Repair the build when LLDB_DISABLE_PYTHON is set

JDevlieghere added inline comments. Comment at: source/API/SBReproducer.cpp:821 (lldb::SBTypeNameSpecifier)); +#ifndef LLDB_DISABLE_PYTHON LLDB_REGISTER_METHOD(lldb::SBTypeSummary, SBDebugger, GetSummaryForType, The order of the

[Lldb-commits] [PATCH] D59056: Repair the build when LLDB_DISABLE_PYTHON is set

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, labath. If LLDB_DISABLE_PYTHON is set, some functions are unavailable but SBReproducer assumes they are. Let's conditionally register those functions since they are conditionally declared. https://reviews.llvm.org/D59056

[Lldb-commits] [PATCH] D59040: Move ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355560: Factor the clang specific parts of ExpressionSourceCode.{h,cpp} into the clang… (authored by jingham, committed by ). Changed prior to commit:

[Lldb-commits] [lldb] r355560 - Factor the clang specific parts of ExpressionSourceCode.{h, cpp} into the clang plugin.

Author: jingham Date: Wed Mar 6 14:43:25 2019 New Revision: 355560 URL: http://llvm.org/viewvc/llvm-project?rev=355560=rev Log: Factor the clang specific parts of ExpressionSourceCode.{h,cpp} into the clang plugin. NFC Differential Revision: https://reviews.llvm.org/D59040 Added:

[Lldb-commits] [lldb] r355559 - Pass /bigobj for SBReproducer.cpp with MSVC

Author: zturner Date: Wed Mar 6 14:42:34 2019 New Revision: 39 URL: http://llvm.org/viewvc/llvm-project?rev=39=rev Log: Pass /bigobj for SBReproducer.cpp with MSVC /BIGOBJ is used to bypass certain COFF file format limitations and is used with, unsurprisingly, very big object files.

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

stella.stamenova added a comment. This caused a failure on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/2356 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58962/new/ https://reviews.llvm.org/D58962

[Lldb-commits] [PATCH] D59040: Move ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp

jingham marked 3 inline comments as done. jingham added a comment. I want to keep this commit simple so I'm leaving Adrian's substantial comments for a future commit. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:136 + else +

[Lldb-commits] [lldb] r355557 - [lldb-vscode] Correctly propagate errors back to VS Code.

Author: zturner Date: Wed Mar 6 14:30:06 2019 New Revision: 37 URL: http://llvm.org/viewvc/llvm-project?rev=37=rev Log: [lldb-vscode] Correctly propagate errors back to VS Code. Modified: lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp Modified:

[Lldb-commits] [PATCH] D59030: Pass ConstString by value

clayborg added a comment. LGTM! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59030/new/ https://reviews.llvm.org/D59030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D58912: [debugserver] Fix IsUserReady thread filtering

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB35: [debugserver] Fix IsUserReady thread filtering (authored by friss, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

jankratochvil added a comment. In D58962#1420137 , @JDevlieghere wrote: > There's a tools folder (`lit/tools`) where this would fit. It's lowercase, > possibly to match llvm's `test/tools` directory? Yes, `lit/tools/lldb-server/TestGdbserverPort.test`

[Lldb-commits] [lldb] r355555 - [debugserver] Fix IsUserReady thread filtering

Author: friss Date: Wed Mar 6 13:56:14 2019 New Revision: 35 URL: http://llvm.org/viewvc/llvm-project?rev=35=rev Log: [debugserver] Fix IsUserReady thread filtering Summary: In 2010 (r118866), filtering code was added to debugserver to avoid reporting threads that were "not ready to be

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB34: Sanity check --max-gdbserver-port (authored by jankratochvil, committed by ). Changed prior to commit: https://reviews.llvm.org/D58962?vs=189338=189584#toc Repository: rLLDB LLDB CHANGES

[Lldb-commits] [lldb] r355554 - Sanity check --max-gdbserver-port

Author: jankratochvil Date: Wed Mar 6 13:52:19 2019 New Revision: 34 URL: http://llvm.org/viewvc/llvm-project?rev=34=rev Log: Sanity check --max-gdbserver-port In mail [lldb-dev] Remote debugging a docker process

[Lldb-commits] [PATCH] D59043: [lldb-vscode] Correctly propagate errors back to VS Code

zturner created this revision. zturner added a reviewer: clayborg. I tried installing this, and I couldn't get it working. VS Code would launch the adapter and then it would get stuck waiting for something to happen. Eventually, I tracked this down to the fact that it couldn't locate

[Lldb-commits] [PATCH] D59030: Pass ConstString by value

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: lldb/www/architecture/varformats.html:121 virtual size_t -

[Lldb-commits] [PATCH] D59040: Move ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM although there are some good comments by @aprantl Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59040/new/ https://reviews.llvm.org/D59040

[Lldb-commits] [PATCH] D59040: Move ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp

aprantl added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:136 + else +return; + break; This `else return` doesn't do anything. Is it needed for swift-lldb? Otherwise I'd just delete it.

[Lldb-commits] [lldb] r355548 - Remove redundant second os.path.join call [NFC]

Author: teemperor Date: Wed Mar 6 12:51:28 2019 New Revision: 355548 URL: http://llvm.org/viewvc/llvm-project?rev=355548=rev Log: Remove redundant second os.path.join call [NFC] Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified:

[Lldb-commits] [PATCH] D59040: Move ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp

jingham added a comment. I forgot to sort the project file before making the diff. I'll do that on commit. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59040/new/ https://reviews.llvm.org/D59040 ___

[Lldb-commits] [PATCH] D59040: Move ExpressionSourceCode.cpp -> ClangExpressionSourceCode.cpp

jingham created this revision. jingham added a reviewer: shafik. Herald added subscribers: lldb-commits, jdoerfert, teemperor, abidh, jfb, aprantl, srhines. Herald added a project: LLDB. ExpressionSourceCode.cpp is in source/Expressions - which should indicate that it is a generic part of the

[Lldb-commits] [PATCH] D32149: [lldb] [Process] Add proper support for NetBSD core files with threads

mgorny updated this revision to Diff 189545. mgorny added a comment. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: jdoerfert. Added two tests, more pending. Sadly, I wasn't able to reuse even the test cases since `-nostdlib` doesn't really work on NetBSD (resulting

[Lldb-commits] [PATCH] D58975: Introduce MinidumpEnums.def textual header

amccarth accepted this revision. amccarth added inline comments. Comment at: include/lldb/Formats/MinidumpEnums.def:91 + +LLDB_HANDLE_PLATFORM(0x, Win32S) // Windows 3.1 +LLDB_HANDLE_PLATFORM(0x0001, Win32Windows) // Windows 95-98-Me I know you're just

[Lldb-commits] [lldb] r355536 - Try again to fix OSX compilation failure.

Author: zturner Date: Wed Mar 6 11:14:41 2019 New Revision: 355536 URL: http://llvm.org/viewvc/llvm-project?rev=355536=rev Log: Try again to fix OSX compilation failure. Modified: lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp Modified:

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false;

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

JDevlieghere added a comment. In D58962#1419628 , @jankratochvil wrote: > In D58962#1419613 , @labath wrote: > > > I'd consider moving the test to `lit/lldb-server` (new folder) > > > Don't you mean

[Lldb-commits] [PATCH] D32149: [lldb] [Process] Add proper support for NetBSD core files with threads

mgorny updated this revision to Diff 189536. mgorny retitled this revision from "Correct handling NetBSD core(5) files with threads" to "[lldb] [Process] Add proper support for NetBSD core files with threads". mgorny edited the summary of this revision. mgorny added a comment. Updated to read

[Lldb-commits] [lldb] r355531 - Try to fix OSX compilation failure.

Author: zturner Date: Wed Mar 6 10:44:27 2019 New Revision: 355531 URL: http://llvm.org/viewvc/llvm-project?rev=355531=rev Log: Try to fix OSX compilation failure. Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp Modified:

[Lldb-commits] [lldb] r355528 - Resubmit "Don't include UnixSignals.h from Host."

Author: zturner Date: Wed Mar 6 10:20:23 2019 New Revision: 355528 URL: http://llvm.org/viewvc/llvm-project?rev=355528=rev Log: Resubmit "Don't include UnixSignals.h from Host." This was reverted because it breaks the GreenDragon bot, but the reason for the breakage is lost, so I'm resubmitting

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

sfertile added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:165 +case MCObjectFileInfo::IsXCOFF: + // TODO: Need to implement class MCSymbolXCOFF. + break; jasonliu wrote: > JDevlieghere wrote: > > See previous comment. > It is certain

[Lldb-commits] [PATCH] D58790: Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355525: Adding test to cover the correct import of SourceLocation pertaining to a built… (authored by shafik, committed by ). Herald added a project: LLDB. Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D58985: Fix core files for 32 bit architectures that are supported in ProcessELFCore.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355526: Fix core files for 32 bit architectures that are supported in ProcessELFCore.cpp (authored by gclayton, committed by ). Herald added a project: LLDB. Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [lldb] r355526 - Fix core files for 32 bit architectures that are supported in ProcessELFCore.cpp

Author: gclayton Date: Wed Mar 6 10:04:10 2019 New Revision: 355526 URL: http://llvm.org/viewvc/llvm-project?rev=355526=rev Log: Fix core files for 32 bit architectures that are supported in ProcessELFCore.cpp Core files need to know the size of the PRSTATUS header so that we can grab the

[Lldb-commits] [lldb] r355525 - Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing

Author: shafik Date: Wed Mar 6 10:03:54 2019 New Revision: 355525 URL: http://llvm.org/viewvc/llvm-project?rev=355525=rev Log: Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing Summary: This tests a fix in the ASTImpoter.cpp to ensure

[Lldb-commits] [lldb] r355523 - Re-apply "Fix embedded Python initialization according to changes in version 3.7"

Author: tkrasnukha Date: Wed Mar 6 09:27:40 2019 New Revision: 355523 URL: http://llvm.org/viewvc/llvm-project?rev=355523=rev Log: Re-apply "Fix embedded Python initialization according to changes in version 3.7" Modified:

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; davide wrote: >

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

davide requested changes to this revision. davide added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Thanks Tatyana! Comment at: source/API/SBReproducer.cpp:40 + // write into the replay buffer. + char buffer[arch_name_len]; + return SBDebugger::GetDefaultArchitecture(buffer, arch_name_len);

[Lldb-commits] [lldb] r355519 - [Reproducers] Guard register macros that take lldb::thread_t on Windows

Author: jdevlieghere Date: Wed Mar 6 08:42:33 2019 New Revision: 355519 URL: http://llvm.org/viewvc/llvm-project?rev=355519=rev Log: [Reproducers] Guard register macros that take lldb::thread_t on Windows On Windows, lldb::thread_t is just a void*, so the we will try to allocate an object of

[Lldb-commits] [lldb] r355518 - [Reproducers] Don't use VLA in SBReproducer redirect

Author: jdevlieghere Date: Wed Mar 6 08:33:48 2019 New Revision: 355518 URL: http://llvm.org/viewvc/llvm-project?rev=355518=rev Log: [Reproducers] Don't use VLA in SBReproducer redirect This should unbreak the Windows bot. Modified: lldb/trunk/source/API/SBReproducer.cpp Modified:

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189514. jasonliu added a comment. Address comments in last revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/BackendUtil.cpp

[Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

labath planned changes to this revision. labath added a comment. I'm going to wait to see how the llvm option pans out. If minidump parsing code ends up there, we lose the biggest customer of this and so we may revisit the name and/or scope of the new module. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D58971: Move MemoryRegionInfo into the Utility module

labath added a comment. In D58971#1418843 , @zturner wrote: > One idea for a new module name could be `AbstractProcess`, but I can't think > of anything else better at the moment. Yeah, naming the new module might be the hardest problem here. :) I'd

[Lldb-commits] [lldb] r355510 - [lldb] [lit] Attempt to fix regex in toolchain-clang.test

Author: mgorny Date: Wed Mar 6 06:49:48 2019 New Revision: 355510 URL: http://llvm.org/viewvc/llvm-project?rev=355510=rev Log: [lldb] [lit] Attempt to fix regex in toolchain-clang.test Modified: lldb/trunk/lit/BuildScript/toolchain-clang.test Modified:

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

mgorny updated this revision to Diff 189503. mgorny added a comment. I've attempted to rebase Kamil's patch against the current sources. Please note that this is not the final version; I'll add a test case and PID reading later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32149/new/

[Lldb-commits] [PATCH] D58970: Move RangeMap.h into Utility

This revision was automatically updated to reflect the committed changes. Closed by commit rL355509: Move RangeMap.h into Utility (authored by labath, committed by ). Herald added subscribers: llvm-commits, jdoerfert. Herald added a project: LLVM. Changed prior to commit:

[Lldb-commits] [lldb] r355509 - Move RangeMap.h into Utility

Author: labath Date: Wed Mar 6 06:41:43 2019 New Revision: 355509 URL: http://llvm.org/viewvc/llvm-project?rev=355509=rev Log: Move RangeMap.h into Utility Summary: This file implements some general purpose data structures, and so it belongs to the Utility module. Reviewers: zturner, jingham,

[Lldb-commits] [PATCH] D58630: [lldb] [test] Pass appropriate -L&-Wl, -rpath for libc++ on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL355502: [lldb] [test] Pass appropriate -L-Wl,-rpath for libc++ on NetBSD (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r355502 - [lldb] [test] Pass appropriate -L&-Wl, -rpath for libc++ on NetBSD

Author: mgorny Date: Wed Mar 6 06:03:18 2019 New Revision: 355502 URL: http://llvm.org/viewvc/llvm-project?rev=355502=rev Log: [lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD Pass appropriate -L and -Wl,-rpath flags pointing out to the LLVM library directory on NetBSD. This

Re: [Lldb-commits] [lldb] r355469 - [Reproducers] Don't intercept SBDebugger::SetInputFileHandle

On 06/03/2019 02:49, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Tue Mar 5 17:49:54 2019 New Revision: 355469 URL: http://llvm.org/viewvc/llvm-project?rev=355469=rev Log: [Reproducers] Don't intercept SBDebugger::SetInputFileHandle With the reproducer logic in place

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

jankratochvil added a comment. In D58962#1419613 , @labath wrote: > I'd consider moving the test to `lit/lldb-server` (new folder) Don't you mean `lit/LldbServer`? As directories there are UpperCamelCased. Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

labath added a comment. Would a test similar to `lit/SymbolFile/DWARF/array-sizes.s` be possible/appropriate? I'm thinking of something like: - produce debug info in the form of a .s file (either with clang of via hand-tuning dwarf) which uses DW_OP_addrx - assemble it - run lldb, have it open

[Lldb-commits] [PATCH] D58962: Sanity check --max-gdbserver-port

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thank you for fixing this. I'd consider moving the test to `lit/lldb-server` (new folder) to mirror the location of the code being tested. (`Driver` refers to the main lldb exe).

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

Davide, Stella, thank you for investigating the issue! I'll re-submit changes when the build will be recovered from compilation errors. -Original Message- From: Stella Stamenova Sent: Wednesday, March 6, 2019 2:06 AM To: Davide Italiano Cc: Tatyana Krasnukha ; lldb-commits Subject:

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

tatyana-krasnukha added a comment. Run into a few compilation errors building on Windows with msvc. Comment at: source/API/SBReproducer.cpp:40 + // write into the replay buffer. + char buffer[arch_name_len]; + return SBDebugger::GetDefaultArchitecture(buffer,

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

anton.kolesov created this revision. anton.kolesov added a project: LLDB. Herald added subscribers: lldb-commits, abidh, ki.stfu. Simple "file" might not be enough for Eclipse CDT to find the file, therefore it is preferable for -data-disassemble response to include full absolute file path in the