[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

labath added inline comments. Herald added a subscriber: dexonsmith. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteKill.py:17-23 +reg_expr = r"^\$X[0-9a-fA-F]+([^#]*)#[0-9A-Fa-f]{2}" +triple = self.dbg.GetSelectedPlatform().GetTriple()

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

labath added inline comments. Comment at: include/lldb/Host/windows/PosixApi.h:106-109 +inline pid_t waitpid(pid_t pid, int *status, int options) { + // To be implemented. + return pid_t(-1); +} As discussed in the review where this was forked from, we shouldn'

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

labath added a comment. In D60153#1495725 , @stella.stamenova wrote: > A couple of the tests from TestVSCode_attach.py (test_by_pid and > test_by_name) are failing for us on Ubuntu because they are failing to > attach: `AssertionError: False is not True

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds reasonable. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61713/new/ https://reviews.llvm.org/D61713 __

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

labath added a comment. BTW, there's some existing tests for build.py in `lit/BuildScript`. Could you check if it's feasible to make an analogous test for the fix you're making here? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61713/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

labath added a comment. Thanks for adding the test. It looks like it was much easier than I feared. I do wonder if the test couldn't be made to run on more platforms. It sounds like it is generic enough for that, and given that this is our first and only jit test, it would be great if that were

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

labath created this revision. labath added reviewers: jasonmolenda, clayborg. some unwind formats are specific to a single symbol file and so it does not make sense for their parsing code live in the general Symbol library (as is the case with eh_frame for instance). This is the case for the unwin

[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

labath created this revision. labath added reviewers: amccarth, clayborg, markmentovai. Herald added a subscriber: aprantl. This patch implements the GetUnwindPlan interface (added in the previous patch) for SymbolFileBreakpad, and uses it to generate unwind plans from STACK CFI records in breakpa

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong marked 8 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:5039 + if (!ToOrErr) +// FIXME: return the error? +consumeError(ToOrErr.takeError()); aprantl wrote: > We don't typ

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198822. martong marked 3 inline comments as done. martong added a comment. - Remove FIXME and return the error - Use early return where possible and remove redundant else Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:378 + // Unwind rules are of the form + // register1: expression1 register2: expression2 ... + // We assume none of the tokens in expression end with a colon. --

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

sgraenitz updated this revision to Diff 198823. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Generalize lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61611/new/ https://reviews.llvm.org/D61611 Files: lldb/lit/B

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong updated this revision to Diff 198824. martong added a comment. - Remove remaining FIXMEs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61438/new/ https://reviews.llvm.org/D61438 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AS

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

clayborg added a comment. Looks good except the inline comment about all the unwind plans we have now. Would love to simplify this so that EH frame, compact unwind, ARM unwind, breakpad unwind all come from the symbol file or object files. Also be nice to have a register resolver that works wit

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

sgraenitz marked 2 inline comments as done. sgraenitz added a comment. @stella.stamenova Can you have a look at the lit test please? It works on macOS and Linux, but I didn't test Windows. Should I add something like `# REQUIRES: nowindows` or is it fine like this? Comment at

[Lldb-commits] [PATCH] D61423: MinidumpYAML: add support for the ThreadList stream

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM, with the suggested fixes. Comment at: test/tools/obj2yaml/basic-minidump.yaml:47-49 + - Thread Id: 0x5C5D5E5F +Priority Class: 0x60616263 +

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

clayborg accepted this revision. clayborg added a comment. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61611/new/ https://reviews.llvm.org/D61611 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

labath accepted this revision. labath added a comment. In D61611#1496580 , @sgraenitz wrote: > @stella.stamenova Can you have a look at the lit test please? It works on > macOS and Linux, but I didn't test Windows. Should I add something like `# > REQUIR

[Lldb-commits] [PATCH] D61423: MinidumpYAML: add support for the ThreadList stream

labath marked 6 inline comments as done. labath added a comment. Thanks for the review. Comment at: test/tools/obj2yaml/basic-minidump.yaml:47-49 + - Thread Id: 0x5C5D5E5F +Priority Class: 0x60616263 +Environment Block: 0x6465666768696A6B ---

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

probinson added a comment. In D61611#1496580 , @sgraenitz wrote: > @stella.stamenova Can you have a look at the lit test please? It works on > macOS and Linux, but I didn't test Windows. Should I add something like `# > REQUIRES: nowindows` or is it fine

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

sgraenitz updated this revision to Diff 198834. sgraenitz marked an inline comment as done. sgraenitz added a comment. 1. XFAIL: system-windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61611/new/ https://reviews.llvm.org/D61611 Files: lldb/

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteKill.py:17 def attach_commandline_kill_after_initial_stop(self): +re

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

sgraenitz added a comment. In D61611#1496644 , @probinson wrote: > Sorry for the drive-by... what is this `REQUIRES: nowindows`? I don't see > where lit generates this property. I grepped all of llvm-project.git and I > see it used in two tests, but no

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: lldb/lit/Breakpoint/jitbp_elf.test:1 +# REQUIRES: target-x86_64, system-linux, native + labath wrote: > sgraenitz wrote: > > labath wrote: > > > sgraenitz wrote: > > > > The

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

labath added inline comments. Comment at: lldb/lit/Breakpoint/jitbp_elf.test:1 +# REQUIRES: target-x86_64, system-linux, native + sgraenitz wrote: > labath wrote: > > sgraenitz wrote: > > > labath wrote: > > > > sgraenitz wrote: > > > > > The test only works with

[Lldb-commits] [PATCH] D61423: MinidumpYAML: add support for the ThreadList stream

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL360350: MinidumpYAML: add support for the ThreadList stream (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D61423?vs=1986

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To ease the adoption of LLDB for users coming from GDB, I've added the command line option `-ex` to the `lldb` binary. It is an alias the the `--one-line` option which > Tells the debugger to execute

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

sgraenitz updated this revision to Diff 198843. sgraenitz added a comment. Add back test requirement target-x86_64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61611/new/ https://reviews.llvm.org/D61611 Files: lldb/lit/Breakpoint/Inputs/jitbp.c

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

stella.stamenova added a comment. In D61611#1496681 , @sgraenitz wrote: > In D61611#1496644 , @probinson wrote: > > > Sorry for the drive-by... what is this `REQUIRES: nowindows`? I don't see > > where lit generat

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *Import(TypeSourceInfo *FromTSI); +llvm

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

labath added a comment. In D61732#1496575 , @clayborg wrote: > Looks good except the inline comment about all the unwind plans we have now. > Would love to simplify this so that EH frame, compact unwind, ARM unwind, > breakpad unwind all come from the sy

[Lldb-commits] [lldb] r360354 - [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

Author: stefan.graenitz Date: Thu May 9 09:40:57 2019 New Revision: 360354 URL: http://llvm.org/viewvc/llvm-project?rev=360354&view=rev Log: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors Summary: First part of a fix for JITed code debugging. This has been a regression from 5

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

jgorbe updated this revision to Diff 198853. jgorbe added a comment. Added a new test that checks that, when a full path to a compiler is specified: - That compiler is used in build commands - The flag style used in build commands matches the toolchain type autodetected from the compiler executa

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

sgraenitz added a comment. In D61611#1496782 , @stella.stamenova wrote: > I can update config.py to create the right features, but we can also use > UNSUPPORTED: system-windows, so I'll look into the best way to do this. Perfect, thanks > For your tes

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

This revision was automatically updated to reflect the committed changes. Closed by commit rL360354: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

labath accepted this revision. labath added a comment. Awesome, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61713/new/ https://reviews.llvm.org/D61713 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] r360355 - [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

Author: jgorbe Date: Thu May 9 09:47:07 2019 New Revision: 360355 URL: http://llvm.org/viewvc/llvm-project?rev=360355&view=rev Log: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler All the other paths in the find_toolchain function return a tuple (detected_toolchain_type,

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

jgorbe updated this revision to Diff 198858. jgorbe added a comment. Removed trailing blank lines from test case, will commit now. Thanks for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61713/new/ https://reviews.llvm.org/D61713 Files: lldb/lit/BuildScript/compiler-ful

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

labath added a comment. In D61611#1496838 , @probinson wrote: > @stella.stamenova I'm not familiar with any lit feature that gives a special > meaning to the prefix "no". The opposite of "REQUIRES: windows" is not > "REQUIRES: nowindows" but "UNSUPPORTE

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

probinson added a comment. @stella.stamenova I'm not familiar with any lit feature that gives a special meaning to the prefix "no". The opposite of "REQUIRES: windows" is not "REQUIRES: nowindows" but "UNSUPPORTED: windows" AFAIK. This part of the discussion should probably be taken to llvm-dev

[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

labath marked 4 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:418 + if (name == ".ra") +return resolver.ResolveNumber(eRegisterKindGeneric, LLDB_REGNUM_GENERIC_PC); + return ResolveRegister(reso

[Lldb-commits] [PATCH] D61713: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler

This revision was automatically updated to reflect the committed changes. Closed by commit rL360355: [lldb] build.py: fix behavior when passing --compiler=/path/to/compiler (authored by jgorbe, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

stella.stamenova added a comment. In D61611#1496838 , @probinson wrote: > @stella.stamenova I'm not familiar with any lit feature that gives a special > meaning to the prefix "no". The opposite of "REQUIRES: windows" is not > "REQUIRES: nowindows" but "

[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for the clarification! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61733/new/ https://reviews.llvm.org/D61733 ___ lldb

[Lldb-commits] [PATCH] D61686: Enable lldb-server on Windows

compnerd added inline comments. Comment at: include/lldb/Host/windows/PosixApi.h:106-109 +inline pid_t waitpid(pid_t pid, int *status, int options) { + // To be implemented. + return pid_t(-1); +} labath wrote: > As discussed in the review where this was forked

[Lldb-commits] [PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors

probinson added a comment. In D61611#1496865 , @stella.stamenova wrote: > In D61611#1496838 , @probinson wrote: > > > @stella.stamenova I'm not familiar with any lit feature that gives a > > special meaning to the

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, jingham, clayborg. Herald added a subscriber: mgorny. Breakpoint shouldn't need to depend on any specific details from a programming language. Currently the only language-specific detail it takes advantage of are the different q

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

JDevlieghere added a comment. Looks good to me. Added some reviewers to make sure everyone is fine with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61737/new/ https://reviews.llvm.org/D61737 __

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

teemperor added a comment. Not sure if I like this change. We don't have single dash flags with multiple characters in LLDB, so this flag looks a bit out of place. And there is the bigger question if we really want to be compatible with the GDB flags (which are already incompatible with the fla

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

JDevlieghere added inline comments. Comment at: include/lldb/Target/Language.h:197 + virtual void + GetVariantMethodNames(ConstString method_name, +std::vector &variant_names) const { GetMethodNameVariants? Comment at

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

jankratochvil added a comment. In D61737#1497004 , @teemperor wrote: > We don't have single dash flags with multiple characters in LLDB OK, true. > And there is the bigger question if we really want to be compatible with the > GDB flags Then do you pr

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

teemperor added a comment. If it's just about adding some commonly used GDB flags I'm fine with adding them to the normal LLDB flags. If the plan is to implement most/all of the flags GDB supports, then I would prefer having something like `--gdb` or `lldb-gdb` (which seems anyway necessary to

[Lldb-commits] [PATCH] D61752: Re-enable a test for non-Windows

probinson created this revision. probinson added reviewers: stella.stamenova, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Required teaching lit.cfg.py to distinguish Windows the same way other projects do. Repository: rLLDB LLDB https://reviews.llvm.org/D61

[Lldb-commits] [PATCH] D61752: Re-enable a test for non-Windows

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: lldb/lit/Breakpoint/case-sensitive.test:1 -# REQUIRES: nowindows +# UNSUPPORTED: windows # This should be syst

[Lldb-commits] [lldb] r360368 - Use UNSUPPORTED: system-windows instead of REQUIRES: nowindows or UNSUPPORTED: windows. nowindows is not currently defined and windows does not cover all cases. system-

Author: stella.stamenova Date: Thu May 9 12:40:21 2019 New Revision: 360368 URL: http://llvm.org/viewvc/llvm-project?rev=360368&view=rev Log: Use UNSUPPORTED: system-windows instead of REQUIRES: nowindows or UNSUPPORTED: windows. nowindows is not currently defined and windows does not cover all

[Lldb-commits] [lldb] r360371 - Fix TestVSCode_attach on Linux

Author: stella.stamenova Date: Thu May 9 12:49:26 2019 New Revision: 360371 URL: http://llvm.org/viewvc/llvm-project?rev=360371&view=rev Log: Fix TestVSCode_attach on Linux The test is failing sometimes because the debugger is failing to attach for lack of permissions. The fix is to call lldb_e

[Lldb-commits] [PATCH] D60153: Re-enable most lldb-vscode tests on Linux.

stella.stamenova added a comment. Thanks, Pavel! I tested out the proposed change and all of our Ubuntu bots now work. I've committed it as well. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60153/new/ https://reviews.llvm.org/D60153 _

[Lldb-commits] [PATCH] D61752: Re-enable a test for non-Windows

probinson abandoned this revision. probinson added a comment. @stella.stamenova fixed this using system-windows instead. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61752/new/ https://reviews.llvm.org/D61752 ___

[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

amccarth accepted this revision. amccarth added a comment. LGTM once you double-check the return value in the error case at the end of `SymbolFileBreakpad::ParseUnwindRow`. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:472 + if (!unwind_rules.empty())

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks fine, thanks for untangling this. I do like Jonas' suggestion better. GetVariantMethodNames sounds like "VariantMethods" are a specific thing and you are trying to find their nam

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I would rather not clutter up the lldb command driver's options with gdb command flags. That seems like it will make lldb harder to figure out and reduce our freedom to choose rea

[Lldb-commits] [lldb] r360375 - Improve step over performance by not stopping at branches that are function calls and stepping into and them out of each one

Author: gclayton Date: Thu May 9 13:39:34 2019 New Revision: 360375 URL: http://llvm.org/viewvc/llvm-project?rev=360375&view=rev Log: Improve step over performance by not stopping at branches that are function calls and stepping into and them out of each one Currently when we single step over a

[Lldb-commits] [PATCH] D58678: Improve step over performance by not stopping at branches that are function calls and stepping into and them out of each one

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360375: Improve step over performance by not stopping at branches that are function… (authored by gclayton, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D61759: Switch to FindSymbolsMatchingRegExAndType() from FindFunctions() in FindLibCppStdFunctionCallableInfo()

shafik created this revision. shafik added reviewers: friss, jingham, jasonmolenda. FindLibCppStdFunctionCallableInfo() currently uses FindFunctions() in order to find a lambdas `operator()()` but using `FindSymbolsMatchingRegExAndType()` is cheaper and if we also anchor the regex using `^` this

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

xiaobai added a comment. Thanks for the feedback! I don't quite feel that "Method" is a great descriptor here either, but I think that it's probably fine for now until we can think of a better name. I'll update this when I get the chance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

xiaobai updated this revision to Diff 198911. xiaobai added a comment. Rework function GetVariantMethodNames -> GetMethodNameVariants CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61746/new/ https://reviews.llvm.org/D61746 Files: include/lldb/Target/Language.h source/Breakpoint/Bre

[Lldb-commits] [lldb] r360386 - [Docs] Port python reference page

Author: jdevlieghere Date: Thu May 9 15:14:14 2019 New Revision: 360386 URL: http://llvm.org/viewvc/llvm-project?rev=360386&view=rev Log: [Docs] Port python reference page I somehow forgot to port over this page from the old website. Thank you Jim for the heads up! Added: lldb/trunk/docs/us

[Lldb-commits] Fwd: buildbot failure in LLVM on lldb-x64-windows-ninja

Can anyone that builds the windows lldb compile the following file as the test suite would: trunk/packages/Python/lldbsuite/test/python_api/thread/main2.cpp and send me the binary that is produced by the test suite? I see the windows bot is failing and need to see binary that we produce so I

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

JDevlieghere updated this revision to Diff 198935. JDevlieghere added a comment. Move the function into SBDebugger CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61090/new/ https://reviews.llvm.org/D61090 Files: lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/API/SBFileSpec.h

[Lldb-commits] [PATCH] D61501: 02/06: Finish renaming CompileUnit->Unit

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with Pavel's comment addressed. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61501/new/ https://reviews.llvm.org/D61501 ___ lldb-commits mail

[Lldb-commits] [lldb] r360397 - Disable the step over skipping calls feature since buildbots are not happy.

Author: gclayton Date: Thu May 9 17:13:03 2019 New Revision: 360397 URL: http://llvm.org/viewvc/llvm-project?rev=360397&view=rev Log: Disable the step over skipping calls feature since buildbots are not happy. Modified: lldb/trunk/source/Core/Disassembler.cpp Modified: lldb/trunk/source/Co

[Lldb-commits] [lldb] r360398 - [Docs] Fix table formatting in Pytho reference

Author: jdevlieghere Date: Thu May 9 17:23:02 2019 New Revision: 360398 URL: http://llvm.org/viewvc/llvm-project?rev=360398&view=rev Log: [Docs] Fix table formatting in Pytho reference Modified: lldb/trunk/docs/use/python-reference.rst Modified: lldb/trunk/docs/use/python-reference.rst URL:

[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

jasonmolenda accepted this revision. jasonmolenda added inline comments. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:418 + if (name == ".ra") +return resolver.ResolveNumber(eRegisterKindGeneric, LLDB_REGNUM_GENERIC_PC); + return ResolveRegister(re

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good to me. Yes, we need to change from a model of "the remote stub teaches lldb everything about registers" to "lldb knows all the architectural / ABI register number detai

[Lldb-commits] [PATCH] D58678: Improve step over performance by not stopping at branches that are function calls and stepping into and them out of each one

jingham added a comment. The one outstanding bit of work here is that this change requires that the MSInst "IsCall" function has to mean "will return to the next instruction after call" or we might lose control of the program. It seems obvious that that SHOULD be what it means, but we need to

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai created this revision. xiaobai added reviewers: davide, JDevlieghere, jingham, kubamracek, clayborg. I don't think there's a good reason for this behavior to be considered ObjC-specific. We can generalize this. https://reviews.llvm.org/D61776 Files: source/Target/Thread.cpp Index: s

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

labath added a comment. Selecting the option parsing mode explicitly sounds like the way to go to me too. I'm wondering if we should call it `--driver-mode=gdb` to match the equivalent functionality in clang. Having a symlink (lldb-gdb or whatever) which automatically selects "gdb" as the "driv

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

labath added inline comments. Comment at: include/lldb/Target/Language.h:198 + GetMethodNameVariants(ConstString method_name, +std::vector &variant_names) const { +return; Return the vector by value ? CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D61778: [Docs] Replace SVN revisions with lldb versions

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Replaces references to svn commits with the lldb version number those commits first appeared in. Themotivation is to show that these features are n

[Lldb-commits] [lldb] r360407 - Revert "Disable the step over skipping calls feature since buildbots are not happy."

Author: labath Date: Thu May 9 23:57:25 2019 New Revision: 360407 URL: http://llvm.org/viewvc/llvm-project?rev=360407&view=rev Log: Revert "Disable the step over skipping calls feature since buildbots are not happy." While this fixed the windows bot failures, it also broke all other bots. Upon