[Lldb-commits] [PATCH] D65647: Fix line table resolution near the end of a section

labath added a comment. (I eventually decided to skip the test, as without the extra flag, the same functionality can be exercised in a much more conventional way with "image lookup -a") Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65647/new/ https://reviews.ll

[Lldb-commits] [PATCH] D65647: Fix line table resolution near the end of a section

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL367983: Fix line table resolution near the end of a section (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commi

[Lldb-commits] [lldb] r367983 - Fix line table resolution near the end of a section

Author: labath Date: Mon Aug 5 23:52:05 2019 New Revision: 367983 URL: http://llvm.org/viewvc/llvm-project?rev=367983&view=rev Log: Fix line table resolution near the end of a section Summary: lld r367537 changed the way the linker organizes sections and segments. This exposed an lldb bug and ca

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

labath added a comment. I just wanted to note that the CWD is not the only thing about a filesystem that's transient -- it's contents can change over time too. This is particularly important for a long-lived process like lldb, which explicitly supports things like rebuilding an executable and t

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; amccarth wrote: > hhb wrote: > > amccart

[Lldb-commits] [lldb] r367976 - [Gardening] Remove dead code from IOHandler (NFC)

Author: jdevlieghere Date: Mon Aug 5 21:45:55 2019 New Revision: 367976 URL: http://llvm.org/viewvc/llvm-project?rev=367976&view=rev Log: [Gardening] Remove dead code from IOHandler (NFC) These functions are not referenced. Modified: lldb/trunk/source/Core/IOHandler.cpp Modified: lldb/trun

[Lldb-commits] [lldb] r367977 - [Gardening] Remove dead code from ScriptInterpreterPython (NFC)

Author: jdevlieghere Date: Mon Aug 5 21:45:59 2019 New Revision: 367977 URL: http://llvm.org/viewvc/llvm-project?rev=367977&view=rev Log: [Gardening] Remove dead code from ScriptInterpreterPython (NFC) The terminal state is never saved or restored. Modified: lldb/trunk/source/Plugins/Scrip

[Lldb-commits] [lldb] r367978 - [Gardening] Remove dead code from ASTDumper (NFC)

Author: jdevlieghere Date: Mon Aug 5 21:46:02 2019 New Revision: 367978 URL: http://llvm.org/viewvc/llvm-project?rev=367978&view=rev Log: [Gardening] Remove dead code from ASTDumper (NFC) These functions are not referenced. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ASTDumpe

[Lldb-commits] [lldb] r367975 - Remove unused function 'SetMangledCounterparts' (NFC)

Author: jdevlieghere Date: Mon Aug 5 21:01:58 2019 New Revision: 367975 URL: http://llvm.org/viewvc/llvm-project?rev=367975&view=rev Log: Remove unused function 'SetMangledCounterparts' (NFC) This function is not referenced. Modified: lldb/trunk/source/Utility/ConstString.cpp Modified: lld

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

bruno added a comment. >> It seems conceptually a little strange to have the working directory be part >> of a serialized "FS", as it's fundamentally a property of a process and only >> transiently a property of the VFS. I tend to agree with @sammccall, it's odd that something that's usually

[Lldb-commits] [PATCH] D65784: [lldb] delete "--platform-path" option from "target create"

jasonmolenda added a comment. Yeah, it's not currently hooked up to anything; I'm returning to remote-platform testing soon, if we've lost some necessary functionality I can re-add it, but this option right now isn't doing anything. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb updated this revision to Diff 213505. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65691/new/ https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/PosixApi.h lldb/source/Host/windows/FileSystem

[Lldb-commits] [PATCH] D65784: [lldb] delete "--platform-path" option from "target create"

kusmour created this revision. kusmour added a reviewer: xiaobai. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. This option is dead. lldb under platform mode can resolve the path wether it's on remote platform or not clean the option to avoid misleading Repository

[Lldb-commits] [lldb] r367963 - Revert "[CompilerType] Simplify the interface a bit more.."

Author: davide Date: Mon Aug 5 17:42:11 2019 New Revision: 367963 URL: http://llvm.org/viewvc/llvm-project?rev=367963&view=rev Log: Revert "[CompilerType] Simplify the interface a bit more.." There's actually a test downstream that fails with this. I think we can still get rid of it, but I need

[Lldb-commits] [PATCH] D65782: [CompilerType] Simplify the interface a bit more..

davide added a comment. In D65782#1615959 , @alex wrote: > I was marked as a review on this, but I suspect you intended to get some > other Alex :-) yes, sorry. My bad. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65782

[Lldb-commits] [PATCH] D65782: [CompilerType] Simplify the interface a bit more..

This revision was automatically updated to reflect the committed changes. Closed by commit rL367957: [CompilerType] Simplify the interface a bit more.. (authored by davide, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [lldb] r367957 - [CompilerType] Simplify the interface a bit more..

Author: davide Date: Mon Aug 5 17:01:52 2019 New Revision: 367957 URL: http://llvm.org/viewvc/llvm-project?rev=367957&view=rev Log: [CompilerType] Simplify the interface a bit more.. Summary: .. removing IsMeaninglessWithoutTypeResolution(). I'm fairly confident this was introduced to support sw

[Lldb-commits] [lldb] r367956 - [CMake] Remove check for the readline target.

Author: jdevlieghere Date: Mon Aug 5 16:54:13 2019 New Revision: 367956 URL: http://llvm.org/viewvc/llvm-project?rev=367956&view=rev Log: [CMake] Remove check for the readline target. This was introduced when we were building a custom readline Python module on Linux [1]. Now that the readline t

[Lldb-commits] [PATCH] D65782: [CompilerType] Simplify the interface a bit more..

alex added a comment. I was marked as a review on this, but I suspect you intended to get some other Alex :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65782/new/ https://reviews.llvm.org/D65782 _

[Lldb-commits] [PATCH] D65782: [CompilerType] Simplify the interface a bit more..

davide created this revision. davide added reviewers: shafik, JDevlieghere, alex, compnerd, teemperor. Herald added a project: LLDB. .. removing IsMeaninglessWithoutTypeResolution(). I'm fairly confident this was introduced to support swift, where static types [without dynamic counterpart] don't c

[Lldb-commits] [PATCH] D65781: [CompilerType] Remove an unused function.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367946: [CompilerType] Remove an unused function. (authored by davide, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [lldb] r367946 - [CompilerType] Remove an unused function.

Author: davide Date: Mon Aug 5 16:18:00 2019 New Revision: 367946 URL: http://llvm.org/viewvc/llvm-project?rev=367946&view=rev Log: [CompilerType] Remove an unused function. Summary: This simplifies the interface, as I'm trying to understand how we can upstream swift support. Reviewers: teemp

[Lldb-commits] [PATCH] D65781: [CompilerType] Remove an unused function.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Interesting... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65781/new/ https://reviews.llvm.org/D65781 _

[Lldb-commits] [PATCH] D65781: [CompilerType] Remove an unused function.

davide created this revision. davide added reviewers: teemperor, JDevlieghere, xiaobai, compnerd, friss. Herald added a project: LLDB. This simplifies the interface, as I'm trying to understand how we can upstream swift support. rdar://problem/36377967 Repository: rG LLVM Github Monorepo htt

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

amccarth marked an inline comment as done. amccarth added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; hhb wrote: > amccarth wrote: > > Nothing in the rest of this .cpp file uses

[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

JDevlieghere added a comment. In D65566#1612051 , @sgraenitz wrote: > In D65566#1611007 , @JDevlieghere > wrote: > > > Is there a way to use the debugserver in the framework instead? > > > This patch is about the d

[Lldb-commits] [lldb] r367936 - [lldb][NFC] Document and refactor ClangPersistentVariables::RemovePersistentVariable

Author: teemperor Date: Mon Aug 5 14:43:53 2019 New Revision: 367936 URL: http://llvm.org/viewvc/llvm-project?rev=367936&view=rev Log: [lldb][NFC] Document and refactor ClangPersistentVariables::RemovePersistentVariable Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangPersis

[Lldb-commits] [lldb] r367922 - [lldb][NFC] Refactor ClangUserExpression::UpdateLanguageForExpr

Author: teemperor Date: Mon Aug 5 13:31:47 2019 New Revision: 367922 URL: http://llvm.org/viewvc/llvm-project?rev=367922&view=rev Log: [lldb][NFC] Refactor ClangUserExpression::UpdateLanguageForExpr The UpdateLanguageForExpr should only update the language, but over time it started to do also do

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb updated this revision to Diff 213448. hhb marked 4 inline comments as done. hhb added a comment. Fix comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65691/new/ https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/Pos

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; amccarth wrote: > Nothing in the rest of this .cpp file uses PATH_MAX, so just delete the > `#define` instead of executing

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

so I can crash LLDB now with: $ clang -c main.s $ lldb main.o (lldb) target create "main.o" Current executable set to 'main.o' (x86_64). (lldb) image lookup --verbose --address 0x0008 I can make a python test that can easily do this. Is there a better way that people would prefer? W

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

> On Aug 5, 2019, at 11:54 AM, Pavel Labath wrote: > > On 05/08/2019 20:20, Greg Clayton via lldb-commits wrote: >>> On Aug 5, 2019, at 11:11 AM, >>> wrote: >>> I also tried to obj2yaml the good DWARF and change it, but once you add bytes all of the section sizes and offsets are o

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

On 05/08/2019 20:20, Greg Clayton via lldb-commits wrote: On Aug 5, 2019, at 11:11 AM, wrote: I also tried to obj2yaml the good DWARF and change it, but once you add bytes all of the section sizes and offsets are off so that was not very fruitful, so I ran into errors when trying to conve

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

> On Aug 5, 2019, at 11:11 AM, > wrote: > >> I also tried to obj2yaml the good DWARF and change it, but once you >> add bytes all of the section sizes and offsets are off so that was >> not very fruitful, so I ran into errors when trying to convert the >> yaml back to and ELF file. >> >> Gre

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

> I also tried to obj2yaml the good DWARF and change it, but once you > add bytes all of the section sizes and offsets are off so that was > not very fruitful, so I ran into errors when trying to convert the > yaml back to and ELF file. > > Greg Yet another case where a "DWARF assembler" would be

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

I also tried to obj2yaml the good DWARF and change it, but once you add bytes all of the section sizes and offsets are off so that was not very fruitful, so I ran into errors when trying to convert the yaml back to and ELF file. Greg > On Aug 5, 2019, at 10:01 AM, Greg Clayton wrote: > > The

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere added a comment. In D65611#1615083 , @labath wrote: > So what if the user doesn't do `lldb ./foo` but instead does `file ./foo` at > the lldb comand prompt? Then, you'll be back at square one as far as > reproducers are concerned... We def

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

labath added a comment. or `lldb -o "file ./foo"` for that matter. I've seen people who are unaware of `-O` do that when they want to execute stuff before the target is set... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D65611 __

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

The issue is found when parsing the "hb_font_make_immutable" function: 0x00084270: DW_TAG_subprogram DW_AT_low_pc (0x2fb0) DW_AT_high_pc (0x2fe4) DW_AT_frame_base (DW_OP_reg29 W29) DW_AT_name("hb_fon

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

labath added a comment. So what if the user doesn't do `lldb ./foo` but instead does `file ./foo` at the lldb comand prompt? Then, you'll be back at square one as far as reproducers are concerned... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65611/new/ https://reviews.llvm.org/D656

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

clayborg added a comment. In D65611#1615018 , @JDevlieghere wrote: > In D65611#1613052 , @clayborg wrote: > > > Also be careful if the user uses a symlink to not resolve the link. If a > > user tries to debug clan

[Lldb-commits] [PATCH] D65611: [Driver] Expand the target in the driver.

JDevlieghere added a comment. In D65611#1613052 , @clayborg wrote: > Also be careful if the user uses a symlink to not resolve the link. If a user > tries to debug clang++: > > $ ls -AFlG > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDef

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

JDevlieghere added a comment. In D65677#1614595 , @sammccall wrote: > It seems conceptually a little strange to have the working directory be part > of a serialized "FS", as it's fundamentally a property of a process and only > transiently a property of

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

amccarth added a comment. Yes, zturner isn't as active here as he was before. I'm happy to review patches regarding LLDB on Windows, even though I don't know much about Mingw. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:19 #endif +#ifdef __MINGW32

[Lldb-commits] [PATCH] D65717: [lldb][clang] Reflect LangStandard.h move to clang/Basic

This revision was automatically updated to reflect the committed changes. Closed by commit rL367865: [lldb][clang] Reflect LangStandard.h move to clang/Basic (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[Lldb-commits] [lldb] r367857 - [lldb][NFC] Fix documentation for ClangPersistentVariables::m_next_persistent_variable_id

Author: teemperor Date: Mon Aug 5 06:40:39 2019 New Revision: 367857 URL: http://llvm.org/viewvc/llvm-project?rev=367857&view=rev Log: [lldb][NFC] Fix documentation for ClangPersistentVariables::m_next_persistent_variable_id Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangP

[Lldb-commits] [PATCH] D65647: Fix line table resolution near the end of a section

labath updated this revision to Diff 213342. labath added a comment. Herald added a reviewer: jdoerfert. - redo the patch to keep the logic inside the line table code. I've been considering whether to do that my self. On one hand, this functionality seems like it could be useful in other places,

[Lldb-commits] [lldb] r367843 - [lldb][NFC] Clang format GetNextPersistentVariableName signature

Author: teemperor Date: Mon Aug 5 05:37:54 2019 New Revision: 367843 URL: http://llvm.org/viewvc/llvm-project?rev=367843&view=rev Log: [lldb][NFC] Clang format GetNextPersistentVariableName signature Modified: lldb/trunk/include/lldb/Expression/ExpressionVariable.h lldb/trunk/source/Plug

[Lldb-commits] [PATCH] D65739: [API] Have SBCommandReturnObject::GetOutput/Error return "" instead of nullptr

labath created this revision. labath added reviewers: jingham, clayborg. It seems this was an unintended side-effect of D26698 . AFAICT, these functions did return an empty string before that patch, and the patch contained code which attempted to ensure that, but

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Oops, didn't mean to mark as accepted. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews.llvm.org/D65677 __

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. It seems conceptually a little strange to have the working directory be part of a serialized "FS", as it's fundamentally a property of a process and only transiently a property of the VF

[Lldb-commits] [lldb] r367842 - [lldb] Move redundant persistent variable counter to ClangPersistentVariables

Author: teemperor Date: Mon Aug 5 05:32:59 2019 New Revision: 367842 URL: http://llvm.org/viewvc/llvm-project?rev=367842&view=rev Log: [lldb] Move redundant persistent variable counter to ClangPersistentVariables Currently Target::m_next_persistent_variable_index is counting up for our persisten

[Lldb-commits] [lldb] r367835 - Fix PDB tests after r367820

Author: labath Date: Mon Aug 5 04:29:01 2019 New Revision: 367835 URL: http://llvm.org/viewvc/llvm-project?rev=367835&view=rev Log: Fix PDB tests after r367820 The commit changed Module dumping code to call SymbolFile::Dump directly, which meant that we were no longer showing the plugin name in

[Lldb-commits] [lldb] r367830 - [lldb][NFC] Remove unimplemented ClangExpressionSourceCode::GetNumBodyLines

Author: teemperor Date: Mon Aug 5 04:08:47 2019 New Revision: 367830 URL: http://llvm.org/viewvc/llvm-project?rev=367830&view=rev Log: [lldb][NFC] Remove unimplemented ClangExpressionSourceCode::GetNumBodyLines Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceC

[Lldb-commits] [PATCH] D65560: ObjectFile[ELF]: Refactor gnu_debuglink interface

This revision was automatically updated to reflect the committed changes. Closed by commit rL367824: ObjectFile[ELF]: Refactor gnu_debuglink interface (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE L

[Lldb-commits] [lldb] r367824 - ObjectFile[ELF]: Refactor gnu_debuglink interface

Author: labath Date: Mon Aug 5 02:55:07 2019 New Revision: 367824 URL: http://llvm.org/viewvc/llvm-project?rev=367824&view=rev Log: ObjectFile[ELF]: Refactor gnu_debuglink interface Summary: The contents of the gnu_debuglink section were passed through the GetDebugSymbolFilePaths interface, whic

[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

labath updated this revision to Diff 213298. labath added a comment. - don't go off searching for separate files if the main one already contains debug info. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65561/new/ https://reviews.llvm.org/D65561 Files: lit/Modules/ELF/build-id-case

[Lldb-commits] [PATCH] D65569: Remove SymbolVendor::GetSymtab

This revision was automatically updated to reflect the committed changes. Closed by commit rL367820: Remove SymbolVendor::GetSymtab (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https:

[Lldb-commits] [lldb] r367820 - Remove SymbolVendor::GetSymtab

Author: labath Date: Mon Aug 5 02:21:47 2019 New Revision: 367820 URL: http://llvm.org/viewvc/llvm-project?rev=367820&view=rev Log: Remove SymbolVendor::GetSymtab Summary: This patch removes the GetSymtab method from the SymbolVendor, which is a no-op as it's implementation just forwards to the

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

labath added subscribers: stella.stamenova, amccarth, labath. labath added a comment. I took @xbolva00's suggestion one step further, and removed the usleep and the related compat code in r367814. So, some of your changes are no longer needed once you rebase past that. I have a couple of additi

[Lldb-commits] [lldb] r367814 - Remove usage of usleep in generic code

Author: labath Date: Mon Aug 5 01:23:25 2019 New Revision: 367814 URL: http://llvm.org/viewvc/llvm-project?rev=367814&view=rev Log: Remove usage of usleep in generic code This function is not portable, and there are only a handful of usages of it anyway. Replacing it with std::this_thread::sleep

[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

jankratochvil added a comment. In D65561#1614293 , @labath wrote: > That would seem to at odds with your " .gnu_debuglink is considered as a > flag" assertion, but I am not sure how you came to believe that. I see I remembered it wrongly, already the in

[Lldb-commits] [PATCH] D65717: [lldb][clang] Reflect LangStandard.h move to clang/Basic

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. > building lldb with an existing (pre-Langstandard.h move) > clang: is this supposed to work in the general case No, this isn't something that is supposed to work in the general case. master

[Lldb-commits] [PATCH] D65561: SymbolVendorELF: Perform build-id lookup even without a debug link

labath added a comment. The "real" goal is being able to search for external debug files using the build-id without them having the gnu_debuglink thingy. :) That would seem to at odds with your " .gnu_debuglink is considered as a flag" assertion, but I am not sure how you came to believe that.