[Lldb-commits] [PATCH] D76476: Add formatter for libc++ std::unique_ptr

shafik created this revision. shafik added reviewers: vsk, jingham. This adds a formatter for libc++ `std::unique_ptr`. We currently already have formatters for `std::shared_ptr` and `std::weak_ptr`. I also refactored `GetValueOfCompressedPair(...)` out of `LibCxxList.cpp` since I need the

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl updated this revision to Diff 251526. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76471/new/ https://reviews.llvm.org/D76471 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Target/Platform.h lldb/include/lldb/Utility/SDK.h lldb/source/Core/Module.cpp

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl created this revision. aprantl added reviewers: JDevlieghere, jingham, friss. aprantl updated this revision to Diff 251526. This is mostly useful for Swift support; it allows LLDB to substitute a matching SDK it shipped with instead of the sysroot path that was used at compile time.

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace updated this revision to Diff 251527. wallace added a comment. Now using the latest SBEnvironment API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1414 +auto kv = llvm::StringRef(name_and_value).split("="); +env.Set(kv.first.str().c_str(), kv.second.str().c_str(), true); + } We want to have a function in

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss created this revision. friss added reviewers: labath, jingham. Herald added a project: LLDB. friss added a comment. This needs some tests, but I wanted to put it out there for comments. The interactions between the environment settings (`target.env-vars`, `target.inherit-env`) and the

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss added a comment. This needs some tests, but I wanted to put it out there for comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76470/new/ https://reviews.llvm.org/D76470 ___ lldb-commits

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jarin updated this revision to Diff 251512. jarin added a comment. Adding a tighter x64 test as suggested by labath@. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74398/new/ https://reviews.llvm.org/D74398 Files:

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Re-enabled with the d9b962100942 . If we face a failure again, since this enables the whole feature, I recommend reverting smaller pieces of the feature that was causing the problem, rather than

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 251375. HsiangKai added a comment. Replace std::find_if with llvm::find_if. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:47-48 +// For pre-standard ones, which correspond to sections being deprecated in +// DWARFv5, the values are chosen more or less arbitrary and a tag "_EXT_" +// is added to the names.

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2164 + unsigned int curr_scalar = curr_piece.GetScalar().UInt(); + curr_scalar = curr_scalar << curr_width; +

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

mib added a comment. Note that this diff is more a quick draft than a “finished” patch, I’m not expecting to submit this until the DW_OP_bit_piece support is done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76449/new/

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:936 /// Insertion point for evaluating multi-piece expression. - uint64_t op_piece_offset = 0; - Value pieces; // Used for DW_OP_piece + llvm::BitVector

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

vsk added a reviewer: labath. vsk added a comment. Excited to see this take shape :) Comment at: lldb/source/Expression/DWARFExpression.cpp:935 /// Insertion point for evaluating multi-piece expression. + llvm::BitVector bit_pieces; Stale comment here,

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace updated this revision to Diff 251479. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

aprantl added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:936 /// Insertion point for evaluating multi-piece expression. - uint64_t op_piece_offset = 0; - Value pieces; // Used for DW_OP_piece + llvm::BitVector bit_pieces; + llvm::BitVector

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace updated this revision to Diff 251472. wallace added a comment. fix grammar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.org/D76111 Files: lldb/bindings/headers.swig

[Lldb-commits] [PATCH] D76450: [lldb/PlatformDarwin] Always delete destination file first in PutFile

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. nice catch, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76450/new/ https://reviews.llvm.org/D76450

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace updated this revision to Diff 251470. wallace added a comment. - Added both kinds of APIs we were discussing. It will come handy for all different kind of usages - Added an SBEnvironment API for SBLaunchInfo, which will be used in https://reviews.llvm.org/D74636 - Address all sorts of

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

fche2 added inline comments. Comment at: lldb/source/Host/common/DebugInfoD.cpp:59 + char *cache_path = nullptr; + int rc = debuginfod_find_source(client, buildID.GetBytes().data(), + buildID.GetBytes().size(), path.c_str(),

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/source/API/SBEnvironment.cpp:62-73 + ConstString(std::next(m_opaque_up->begin(), index)->first()) + .AsCString("")); +} + +const char *SBEnvironment::GetValueAtIndex(size_t

[Lldb-commits] [PATCH] D76450: [lldb/PlatformDarwin] Always delete destination file first in PutFile

friss created this revision. friss added a reviewer: jasonmolenda. Herald added a project: LLDB. The default behavior of Platform::PutFile is to open the file and truncate it if it already exists. This works fine and is a sensible default, but it interacts badly with code-signing on iOS, as doing

[Lldb-commits] [PATCH] D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector

mib created this revision. mib added reviewers: aprantl, vsk, friss. mib added a project: LLDB. Herald added a subscriber: lldb-commits. This patch changes the implementation of DW_OP_piece to use llvm::BitVector instead of the lldb_private::Value. This allow to have more granularity which would

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

clayborg added a comment. In D76111#1930783 , @labath wrote: > The new interface is ok for me, but there are two things I want to mention: > > - the iteration via `Get{Name,Value}AtIndex` is going to be slow because the > underlying map (like most maps)

[Lldb-commits] [PATCH] D76411: [debugserver] Implement hardware breakpoints for ARM64

This revision was automatically updated to reflect the committed changes. Closed by commit rG90308a4da167: [debugserver] Implement hardware breakpoints for ARM64 (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace updated this revision to Diff 251428. wallace added a comment. support python2.7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 Files: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace added a comment. Well, I think I'll implement both kind of accessors in the API to account for all possible cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.org/D76111

[Lldb-commits] [PATCH] D76411: [debugserver] Implement hardware breakpoints for ARM64

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice patch, thanks for doing this. I wouldn't have added the fallback code in `DNBArchMachARM64::NumSupportedHardwareBreakpoints` to handle the case where the sysctl fails - it

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace updated this revision to Diff 251425. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 Files: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

[Lldb-commits] [lldb] 90308a4 - [debugserver] Implement hardware breakpoints for ARM64

Author: Jonas Devlieghere Date: 2020-03-19T11:55:48-07:00 New Revision: 90308a4da167c531a16fcecc3927596fffd5d5d5 URL: https://github.com/llvm/llvm-project/commit/90308a4da167c531a16fcecc3927596fffd5d5d5 DIFF:

[Lldb-commits] [PATCH] D76216: Improve step over performance

jarin added a comment. Pavel or Jim, could you possibly land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 7b24425 - Reland [lldb] Fix string summary of an empty NSPathStore2

Author: Raphael Isemann Date: 2020-03-19T18:50:26+01:00 New Revision: 7b2442584e40f97693c38c0d79b83f770d557039 URL: https://github.com/llvm/llvm-project/commit/7b2442584e40f97693c38c0d79b83f770d557039 DIFF:

[Lldb-commits] [lldb] 50f1985 - [lldb][NFC] Delete the original UserExpression before trying to reparse it with FixIts.

Author: Raphael Isemann Date: 2020-03-19T18:10:57+01:00 New Revision: 50f198535363c6882b02c3dde7bec31e723c4762 URL: https://github.com/llvm/llvm-project/commit/50f198535363c6882b02c3dde7bec31e723c4762 DIFF:

[Lldb-commits] [PATCH] D76216: Improve step over performance

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Sorry, forgot to select the action... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216

[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

jingham added a comment. This test just seems wrong to me. We can pretend that processes that haven't crashed don't have crash_info, and manually suppress the output in lldb if the stop state isn't a crash. But it seems useful to ask "what are the crash_info bits in flight right now" even if

[Lldb-commits] [lldb] 76a5451 - [lldb/testsuite] un-XFail TestInlineStepping.py on linux and windows

Author: Fred Riss Date: 2020-03-19T09:24:11-07:00 New Revision: 76a5451a524c0cecdf21a03844ba628bfe857369 URL: https://github.com/llvm/llvm-project/commit/76a5451a524c0cecdf21a03844ba628bfe857369 DIFF: https://github.com/llvm/llvm-project/commit/76a5451a524c0cecdf21a03844ba628bfe857369.diff

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

jankratochvil added inline comments. Comment at: lldb/source/Host/common/DebugInfoD.cpp:39 + +llvm::Expected findSource(UUID buildID, const std::string ) { + if (!buildID.IsValid()) `const UUID ` as it is even bigger (40 bytes) than `std::string` (32 bytes).

[Lldb-commits] [PATCH] D76408: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux

This revision was automatically updated to reflect the committed changes. Closed by commit rGe154cbb124a6: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76408/new/

[Lldb-commits] [PATCH] D76406: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers

This revision was automatically updated to reflect the committed changes. Closed by commit rGecc6c426977f: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

jankratochvil added inline comments. Comment at: lldb/source/Core/SourceManager.cpp:422 if (num_matches > 1) { -SymbolContext sc; +// SymbolContext sc; CompileUnit *test_cu = nullptr; This comment should not stay

[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

friss abandoned this revision. friss added a comment. I skipped the test for embedded in 8758d02074be7b80b804fad19e8b7de6ebd43c31 . I'll abandon this for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 99a0cbb - [lldb/Test] Remove debug print in supports_hw_breakpoints.

Author: Jonas Devlieghere Date: 2020-03-19T08:35:22-07:00 New Revision: 99a0cbb42321ef5b967ba4aac51cea5f5804bb81 URL: https://github.com/llvm/llvm-project/commit/99a0cbb42321ef5b967ba4aac51cea5f5804bb81 DIFF:

[Lldb-commits] [lldb] 8758d02 - [lldb/testsuite] Skip part of TestProcessCrashInfo.py on Darwin embedded

Author: Fred Riss Date: 2020-03-19T08:26:00-07:00 New Revision: 8758d02074be7b80b804fad19e8b7de6ebd43c31 URL: https://github.com/llvm/llvm-project/commit/8758d02074be7b80b804fad19e8b7de6ebd43c31 DIFF: https://github.com/llvm/llvm-project/commit/8758d02074be7b80b804fad19e8b7de6ebd43c31.diff

[Lldb-commits] [lldb] e154cbb - [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux

Author: Fred Riss Date: 2020-03-19T08:25:59-07:00 New Revision: e154cbb124a63057356dede8bca5bdbd2f60d44c URL: https://github.com/llvm/llvm-project/commit/e154cbb124a63057356dede8bca5bdbd2f60d44c DIFF: https://github.com/llvm/llvm-project/commit/e154cbb124a63057356dede8bca5bdbd2f60d44c.diff

[Lldb-commits] [lldb] ecc6c42 - [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers

Author: Fred Riss Date: 2020-03-19T08:25:59-07:00 New Revision: ecc6c426977f59f69b683d67ceb3157fb694ce09 URL: https://github.com/llvm/llvm-project/commit/ecc6c426977f59f69b683d67ceb3157fb694ce09 DIFF: https://github.com/llvm/llvm-project/commit/ecc6c426977f59f69b683d67ceb3157fb694ce09.diff

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251383. kwk added a comment. - Validate that the server received the request from debuginfod client Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files:

[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

friss marked an inline comment as done. friss added a comment. In D76407#1930693 , @labath wrote: > Could the inferior manually wipe the crash annotation? This is not something you're supposed to wipe. It's additional information that is going to b

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251376. kwk marked 6 inline comments as done. kwk added a comment. - Removed not needed forward decl - Format comments for better readability in my test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk added a comment. @labath I've improved my test file for readability. Comment at: lldb/include/lldb/Host/DebugInfoD.h:26 + +llvm::Error findSource(UUID buildID, const std::string , + std::string _path); labath wrote: > Expected ?

[Lldb-commits] [lldb] 4436178 - [lldb] fix typo in comment for lldbtest.py

Author: Konrad Kleine Date: 2020-03-19T10:08:11-04:00 New Revision: 44361782e2c252c8886cd77f6b7d4ebe64fb6e8d URL: https://github.com/llvm/llvm-project/commit/44361782e2c252c8886cd77f6b7d4ebe64fb6e8d DIFF: https://github.com/llvm/llvm-project/commit/44361782e2c252c8886cd77f6b7d4ebe64fb6e8d.diff

[Lldb-commits] [lldb] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Author: Djordje Todorovic Date: 2020-03-19T13:57:30+01:00 New Revision: d9b962100942c71a4c26debaa716f7ab0c4ea8a1 URL: https://github.com/llvm/llvm-project/commit/d9b962100942c71a4c26debaa716f7ab0c4ea8a1 DIFF:

[Lldb-commits] [lldb] 718d941 - Revert "[lldb] Fix string summary of an empty NSPathStore2"

Author: Raphael Isemann Date: 2020-03-19T13:08:39+01:00 New Revision: 718d94187dbb2388dbc84deb5d49004fd552817c URL: https://github.com/llvm/llvm-project/commit/718d94187dbb2388dbc84deb5d49004fd552817c DIFF:

[Lldb-commits] [PATCH] D68010: [lldb] Fix string summary of an empty NSPathStore2

This revision was automatically updated to reflect the committed changes. Closed by commit rG939ca455e72e: [lldb] Fix string summary of an empty NSPathStore2 (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68010/new/

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Since we landed the fix for the issue related to the D75036 , I'll reland this again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin marked 2 inline comments as done. ikudrin added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:47-48 +// For pre-standard ones, which correspond to sections being deprecated in +// DWARFv5, the values are chosen more or less arbitrary and

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai marked 2 inline comments as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1727 + + if (Tag % 2) +IsIntegerValue = false; jhenderson wrote: > I don't understand why this line changed, but more

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 251244. HsiangKai added a comment. Address @jhenderson's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 251287. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnitIndex.h:47-48 +// For pre-standard ones, which correspond to sections being deprecated in +// DWARFv5, the values are chosen more or less arbitrary and a tag "_EXT_" +// is added to the names.

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin marked 3 inline comments as done. ikudrin added a comment. In D75929#1926834 , @labath wrote: > (btw, is there a test case for the "unknown column" code path?) Yes, it is checked in `llvm/test/DebugInfo/X86/debug-cu-index-unknown-section.s`,

[Lldb-commits] [lldb] 939ca45 - [lldb] Fix string summary of an empty NSPathStore2

Author: Raphael Isemann Date: 2020-03-19T12:20:35+01:00 New Revision: 939ca455e72e822450013eff37c9ea7746850350 URL: https://github.com/llvm/llvm-project/commit/939ca455e72e822450013eff37c9ea7746850350 DIFF:

[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

mib added inline comments. Comment at: lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py:72 -def test_on_sane_process(self): -"""Test that lldb doesn't fetch the extended crash information What about adding a

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

labath added a comment. In D75750#1929124 , @kwk wrote: > @labath I've updated my patch and would love to hear your opinion on it. So > far I've only written the python `ServeDirectoryWithHTTP()` function with > proper doctest and documentation but

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

labath added a comment. The new interface is ok for me, but there are two things I want to mention: - the iteration via `Get{Name,Value}AtIndex` is going to be slow because the underlying map (like most maps) does not have random access iterators. This is the problem I was trying to solve with

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

labath added a comment. Thanks for updating this patch. This seems ok to me (modulo comments here and the other patch), but I think it would be better to move all of the SB changes into that other patch. (the reason I requested this update was to see whether the other patch has all that's

[Lldb-commits] [PATCH] D76406: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This doesn't sound too bad. I am not sure if "nop" is a valid opcode on all targets, but if it isn't we could try hiding it in a macro, or replace it with an increment of a volatile/atomic

[Lldb-commits] [PATCH] D76216: Improve step over performance

labath added a comment. In D76216#1930689 , @jarin wrote: > I also see that build-bot is not happy about my patch. Clang-tidy somewhat > mysteriously fails on missing lldb/Target/ThreadPlanStepOverRange.h, which I > did not touch at all (neither the

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py:50-53 +time.sleep(1) +# lldb-vscode process must have already finished even though +# we didn't close the communication socket explicitly +

[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

labath added a comment. Could the inferior manually wipe the crash annotation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76407/new/ https://reviews.llvm.org/D76407 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

labath added a comment. In D74398#1930021 , @jarin wrote: > In D74398#1929019 , @labath wrote: > > > Thanks. Could you also add the other kind of test (the one inline asm) I > > mentioned. In an ideal world we'd

[Lldb-commits] [PATCH] D76408: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux

labath accepted this revision. labath added a reviewer: omjavaid. labath added a comment. This revision is now accepted and ready to land. I don't currently have arm hardware to try this on, but it sounds like a safe assumption. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76216: Improve step over performance

jarin added a comment. Thanks Greg, I will wait for Jim's comment. I also see that build-bot is not happy about my patch. Clang-tidy somewhat mysteriously fails on missing lldb/Target/ThreadPlanStepOverRange.h, which I did not touch at all (neither the fail nor the #include). Any idea what

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251297. kwk added a comment. - Fix NameError: name 'TRUE' is not defined Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindDebuginfod.cmake

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

clayborg added a comment. Just watch the build bots carefully when you check this in! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk planned changes to this revision. kwk added a comment. In D75750#1929967 , @jankratochvil wrote: > On Fedora 31 x86_64 with LLDB using python3 I got: > > llvm-lit: .../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py:102: > fatal: unable to

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just some header doc cleanup before we submit. Thanks for sticking with these changes! Comment at: lldb/include/lldb/API/SBEnvironment.h:24 + + const

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

clayborg accepted this revision. clayborg added a comment. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D76216: Improve step over performance

clayborg added a comment. Jim is the one that really needs to mark this as accepted as the thread plans are one of his many areas of expertise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216

[Lldb-commits] [PATCH] D76411: [debugserver] Implement hardware breakpoints for ARM64

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added subscribers: danielkiss, kristof.beyls. Add support for hardware breakpoints on ARM64 Repository: rLLDB LLDB https://reviews.llvm.org/D76411 Files: