[Lldb-commits] [PATCH] D78077: Fix bug in UnwindAssemblyInstEmulation with fp-using codegen and mid-function epilogues

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1cd92e480c12: Bug where insn-based unwind plans on arm64 could be wrong (authored by jasonmolenda). Repository: rG

[Lldb-commits] [lldb] 1cd92e4 - Bug where insn-based unwind plans on arm64 could be wrong

Author: Jason Molenda Date: 2020-04-14T16:57:25-07:00 New Revision: 1cd92e480c12c03ab9a381b29e4e3964892afa01 URL: https://github.com/llvm/llvm-project/commit/1cd92e480c12c03ab9a381b29e4e3964892afa01 DIFF: https://github.com/llvm/llvm-project/commit/1cd92e480c12c03ab9a381b29e4e3964892afa01.diff

[Lldb-commits] [PATCH] D78077: Fix bug in UnwindAssemblyInstEmulation with fp-using codegen and mid-function epilogues

jasonmolenda updated this revision to Diff 257557. jasonmolenda added a comment. Update to address mistake Greg identified; also remove two unused variables that were in this method before my changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

shafik updated this revision to Diff 257552. shafik marked 4 inline comments as done. shafik added a comment. Addressing comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78000/new/ https://reviews.llvm.org/D78000 Files: clang/lib/AST/ASTImporter.cpp

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 257542. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

sdesmalen added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:411 SmallVector WhatToStore; -if (ArgType->isFPOrFPVectorTy() && -(ArgType->getTypeID() != Type::VectorTyID)) { +if

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau marked an inline comment as done. ctetreau added inline comments. Comment at: llvm/include/llvm/IR/DerivedTypes.h:430 + /// Construct a VectorType that has the same shape as some other VectorType + static VectorType *get(Type *ElementType, VectorType *Other) { +

[Lldb-commits] [lldb] 81aba6c - Initiallize property getters as being property accessors (NFC)

Author: Adrian Prantl Date: 2020-04-14T15:56:17-07:00 New Revision: 81aba6cd7252bd4c2226466faccdcf8bf04ad092 URL: https://github.com/llvm/llvm-project/commit/81aba6cd7252bd4c2226466faccdcf8bf04ad092 DIFF: https://github.com/llvm/llvm-project/commit/81aba6cd7252bd4c2226466faccdcf8bf04ad092.diff

[Lldb-commits] [lldb] ca99a70 - [lldb/Test] s/lldb-repo/lldb-repro/ (NFC)

Author: Jonas Devlieghere Date: 2020-04-14T14:51:41-07:00 New Revision: ca99a70237c0c762c5d9872625865a8ac19e6c10 URL: https://github.com/llvm/llvm-project/commit/ca99a70237c0c762c5d9872625865a8ac19e6c10 DIFF:

[Lldb-commits] [lldb] cc220d4 - [lldb/Test] Use RAII for reproducer instrumentation data in unittest.

Author: Jonas Devlieghere Date: 2020-04-14T14:46:39-07:00 New Revision: cc220d40315be9512a7fda369811c4714cc8fdfb URL: https://github.com/llvm/llvm-project/commit/cc220d40315be9512a7fda369811c4714cc8fdfb DIFF:

[Lldb-commits] [lldb] 208a11a - Reapply "llvm-dwarfdump: Report errors when failing to parse loclist/debug_loc entries""

Author: David Blaikie Date: 2020-04-14T14:44:32-07:00 New Revision: 208a11ab3a7be7c3e5d3fae9dd4affdb01a0ed1f URL: https://github.com/llvm/llvm-project/commit/208a11ab3a7be7c3e5d3fae9dd4affdb01a0ed1f DIFF: https://github.com/llvm/llvm-project/commit/208a11ab3a7be7c3e5d3fae9dd4affdb01a0ed1f.diff

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support new replay mode: passive replay

JDevlieghere updated this revision to Diff 257491. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77602/new/ https://reviews.llvm.org/D77602 Files: lldb/include/lldb/Utility/Reproducer.h

[Lldb-commits] [PATCH] D78077: Fix bug in UnwindAssemblyInstEmulation with fp-using codegen and mid-function epilogues

jasonmolenda added a comment. In D78077#1980116 , @clayborg wrote: > If you test worked, then there is something wrong with this test? See inline > comment for copy and paste error Thanks for catching that. The test definitely fails without the patch,

[Lldb-commits] [PATCH] D78141: [lldb/Reproducers] Simplify LLDB_RECORD macros

JDevlieghere updated this revision to Diff 257460. JDevlieghere added a comment. Add a comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78141/new/ https://reviews.llvm.org/D78141 Files: lldb/include/lldb/Utility/ReproducerInstrumentation.h Index:

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 257450. wallace added a comment. move the skipping logic to the actual test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.org/D77452 Files:

[Lldb-commits] [PATCH] D77878: [lldb] Fix a typo in a test name

This revision was automatically updated to reflect the committed changes. Closed by commit rGcea112f422ce: [lldb] Fix a typo in a test name (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77878/new/

[Lldb-commits] [PATCH] D78141: [lldb/Reproducers] Simplify LLDB_RECORD macros

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. JDevlieghere added a project: LLDB. Redefine the LLDB_RECORD macros in terms of a common uber-macro to reduce code duplication across them. Repository: rLLDB LLDB https://reviews.llvm.org/D78141 Files:

[Lldb-commits] [lldb] cea112f - [lldb] Fix a typo in a test name

Author: Walter Erquinigo Date: 2020-04-14T12:18:58-07:00 New Revision: cea112f422cea3e6fab7cefffef2e09eadec279e URL: https://github.com/llvm/llvm-project/commit/cea112f422cea3e6fab7cefffef2e09eadec279e DIFF:

[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG664fda72eaa3: Fix setting Python3_ROOT_DIR on Windows (authored by isuruf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77842/new/

[Lldb-commits] [lldb] 664fda7 - Fix setting Python3_ROOT_DIR on Windows

Author: Isuru Fernando Date: 2020-04-14T12:50:54-05:00 New Revision: 664fda72eaa3d950ce28f893f5d3ded0c7e7b716 URL: https://github.com/llvm/llvm-project/commit/664fda72eaa3d950ce28f893f5d3ded0c7e7b716 DIFF:

[Lldb-commits] [lldb] ba10840 - [lldb/Reproducers] Make static methods go through the invoke wrapper.

Author: Jonas Devlieghere Date: 2020-04-14T10:22:04-07:00 New Revision: ba10840eebcd2ba9df62e423c596f7a583f5e9d9 URL: https://github.com/llvm/llvm-project/commit/ba10840eebcd2ba9df62e423c596f7a583f5e9d9 DIFF:

[Lldb-commits] [PATCH] D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE

jankratochvil updated this revision to Diff 257395. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77970/new/ https://reviews.llvm.org/D77970 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp

[Lldb-commits] [PATCH] D77970: 2/2: [nfc] [lldb] DWARF callbacks: DIERef -> DWARFDIE

jankratochvil updated this revision to Diff 257390. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77970/new/ https://reviews.llvm.org/D77970 Files: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

jankratochvil added a comment. In D77327#1980079 , @labath wrote: > The normal semantics of callbacks like these is to return `true` when one > wants to continue iterating OK, fixed, thanks for catching it. > One cannot guarantee that the

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

jankratochvil updated this revision to Diff 257389. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc410138939f: [lldb/Reproducers] Capture reproducers from the API test suite. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] fc41013 - [lldb/Reproducers] Capture reproducers from the API test suite.

Author: Jonas Devlieghere Date: 2020-04-14T09:24:23-07:00 New Revision: fc410138939fbc98d7eb700e0e898500a00efc4d URL: https://github.com/llvm/llvm-project/commit/fc410138939fbc98d7eb700e0e898500a00efc4d DIFF:

[Lldb-commits] [PATCH] D77771: [lldb/Docs] Document active and passive replay.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5a399189589: [lldb/Docs] Document active and passive replay. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c5a3991 - [lldb/Docs] Document active and passive replay.

Author: Jonas Devlieghere Date: 2020-04-14T08:40:26-07:00 New Revision: c5a399189589f889155c2e2ba093d2dea4b0da69 URL: https://github.com/llvm/llvm-project/commit/c5a399189589f889155c2e2ba093d2dea4b0da69 DIFF:

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257313. kwk added a comment. Ran git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp

[Lldb-commits] [PATCH] D78109: Ran git clang-format

kwk abandoned this revision. kwk added a comment. Sorry, wrong `arc diff` invocation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78109/new/ https://reviews.llvm.org/D78109 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D77793: Fix LLDB elf core dump register access for ARM/AArch64

labath added a comment. Thanks for doing this. The patch is pretty straight-forward. I'd just like to get some clarification about the defensive read register checks. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm.cpp:46

[Lldb-commits] [PATCH] D78109: Ran git clang-format

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Depends on D74136 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78109 Files: lldb/source/Core/SearchFilter.cpp Index:

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

labath added a comment. In D77043#1980208 , @omjavaid wrote: > For current implementation I dont think it will break any stubs because newly > introduced regnum is totally optional. If regnum is not provided then mocked > up register index is used and

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

labath added a comment. In D77047#1980248 , @omjavaid wrote: > In D77047#1971454 , @labath wrote: > > > In D77047#1966539 , @omjavaid > > wrote: > > > > > @labath Core file

[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

labath added a comment. I haven't looked at the code in detail, but it seems ok to me. What does not seem ok is the hand-rolled matching in the tests. A more idiomatic approach would be to replace `isFormatCorrect` with a wrapper function which can be called from a test macro, and let gtest do

[Lldb-commits] [PATCH] D78094: [lldb/test] Fix TestLoadUnload

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0be92ebcd8d: [lldb/test] Fix TestLoadUnload (authored by mib, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78094/new/

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D77588#1972418 , @JDevlieghere wrote: > In D77588#1971345 , @labath wrote: > > > Ok, I'm starting to

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support new replay mode: passive replay

labath added a comment. In D77602#1973804 , @JDevlieghere wrote: > - Simplify `LLDB_RECORD_CONSTRUCTOR` macro. The other macros have `return` > statements that need to be inlined in the caller for replay, and the boundary > tracking needs to be updated

[Lldb-commits] [lldb] f0be92e - [lldb/test] Fix TestLoadUnload

Author: Med Ismail Bennani Date: 2020-04-14T13:53:51+02:00 New Revision: f0be92ebcd8d53a86c7f03bcd8f4492f259fc59c URL: https://github.com/llvm/llvm-project/commit/f0be92ebcd8d53a86c7f03bcd8f4492f259fc59c DIFF:

[Lldb-commits] [PATCH] D78094: [lldb/test] Fix TestLoadUnload

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, thanks. This is a leftover from a previous version of that patch caused by me mailing patches between different operating systems. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 01cfe88 - [LLDB] Remove xfail aarch64-linux from test_step_over_load*

Author: Muhammad Omair Javaid Date: 2020-04-14T16:21:06+05:00 New Revision: 01cfe88a17db72323502f1e47a64e75ea266e8e2 URL: https://github.com/llvm/llvm-project/commit/01cfe88a17db72323502f1e47a64e75ea266e8e2 DIFF:

[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

teemperor added a comment. @isuruf Do you have commit access or do you need this committed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77842/new/ https://reviews.llvm.org/D77842 ___ lldb-commits

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid added a comment. In D77047#1971454 , @labath wrote: > In D77047#1966539 , @omjavaid wrote: > > > @labath Core file FP register access is not supported on AArch64. I am > > working on a follow up patch to

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid marked 2 inline comments as done. omjavaid added a comment. In D77043#1971486 , @labath wrote: > Register infos in lldb are a mess. However lldb seems to be able to > communicate (more or less successfully) with stub which know nothing about >

[Lldb-commits] [PATCH] D78094: [lldb/test] Fix TestLoadUnload

mib created this revision. mib added a reviewer: labath. mib added a project: LLDB. Herald added a subscriber: lldb-commits. [lldb/test] Fix TestLoadUnload failure introduced in e0dbd025131c4d77d8a5050a91d391d950529a8c It

[Lldb-commits] [PATCH] D78077: Fix bug in UnwindAssemblyInstEmulation with fp-using codegen and mid-function epilogues

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. If you test worked, then there is something wrong with this test? See inline comment for copy and paste error Comment at:

[Lldb-commits] [PATCH] D77662: [lldb/test] Make TestLoadUnload compatible with windows

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rGe0dbd025131c: [lldb/test] Make TestLoadUnload compatible with windows (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

labath added a comment. In D77327#1971794 , @jankratochvil wrote: > In D77327#1971435 , @labath wrote: > > > The `bool` return value on all of these methods, is that here just to > > implement the `fallback`

[Lldb-commits] [lldb] e0dbd02 - [lldb/test] Make TestLoadUnload compatible with windows

Author: Pavel Labath Date: 2020-04-14T11:10:59+02:00 New Revision: e0dbd025131c4d77d8a5050a91d391d950529a8c URL: https://github.com/llvm/llvm-project/commit/e0dbd025131c4d77d8a5050a91d391d950529a8c DIFF: https://github.com/llvm/llvm-project/commit/e0dbd025131c4d77d8a5050a91d391d950529a8c.diff

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

labath added a comment. Heh.. I wasn't an attempt expecting a fully generic solution. Since we don't invoke dotest.py manually these days (we have lldb-dotest for that) making a separate argument specifically for this plugin would be just fine. However, I don't see anything inherently wrong

[Lldb-commits] [PATCH] D77878: [lldb] Fix a typo in a test name

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77878/new/ https://reviews.llvm.org/D77878

Re: [Lldb-commits] [lldb] 680082a - [lldb/Reproducers] Add a small artificial delay before exiting

On 09/04/2020 20:51, Jonas Devlieghere via lldb-commits wrote: > > > On Thu, Apr 9, 2020 at 11:39 AM Davide Italiano > wrote: > > > > > On Apr 9, 2020, at 11:05, Jonas Devlieghere via lldb-commits > mailto:lldb-commits@lists.llvm.org>> > wrote: > >

[Lldb-commits] [PATCH] D77771: [lldb/Docs] Document active and passive replay.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1/new/ https://reviews.llvm.org/D1 ___ lldb-commits mailing list