[Lldb-commits] [lldb] acfee72 - Another attempt of D77452 - da0e91fee614e8686f48db28e6507c8abe061fc2

Author: Walter Erquinigo Date: 2020-04-15T17:52:36-07:00 New Revision: acfee72a053575f52a0922d2182d76eb42edff76 URL: https://github.com/llvm/llvm-project/commit/acfee72a053575f52a0922d2182d76eb42edff76 DIFF:

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

jingham added a comment. This is great, thanks for doing this. You point people at lldbutils.py as a source for utility functions (like print_stacktrace, etc...) But it is maybe also worth pointing them at the lldbtest.py for extensions runCmd and some of the other testing primitives we've

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

This revision was automatically updated to reflect the committed changes. Closed by commit rGda0e91fee614: [intel-pt] Improve the way the test determines whether to run (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f17a85c - Revert "[intel-pt] Improve the way the test determines whether to run"

Author: Walter Erquinigo Date: 2020-04-15T16:35:29-07:00 New Revision: f17a85cf362c96b0e501402049ffe16b97c093a2 URL: https://github.com/llvm/llvm-project/commit/f17a85cf362c96b0e501402049ffe16b97c093a2 DIFF:

[Lldb-commits] [lldb] da0e91f - [intel-pt] Improve the way the test determines whether to run

Author: Walter Erquinigo Date: 2020-04-15T16:03:31-07:00 New Revision: da0e91fee614e8686f48db28e6507c8abe061fc2 URL: https://github.com/llvm/llvm-project/commit/da0e91fee614e8686f48db28e6507c8abe061fc2 DIFF:

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/docs/resources/test.rst:45 +build around checking the output of ``lldb`` (the command line driver) or +``lldb-test`` using ``FileCheck``. Shell tests are generally small and

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

JDevlieghere updated this revision to Diff 257869. JDevlieghere marked 17 inline comments as done. JDevlieghere added a comment. Thanks for the review, Jan! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78242/new/ https://reviews.llvm.org/D78242 Files: lldb/docs/resources/test.rst

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

JDevlieghere added inline comments. Comment at: lldb/docs/resources/test.rst:45 +build around checking the output of ``lldb`` (the command line driver) or +``lldb-test`` using ``FileCheck``. Shell tests are generally small and fast to +write because they require little

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e04b5f2fa84: [nfc] [lldb] Introduce DWARF callbacks (fixed-up) (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

jankratochvil added inline comments. Comment at: lldb/docs/resources/test.rst:18 + as *lit tests* in LLVM, although lit is the test driver and ShellTest is the + test format that uses ``RUN:`` lines. ``FileCheck`` is used to verify the + output.

[Lldb-commits] [lldb] 5e04b5f - [nfc] [lldb] Introduce DWARF callbacks (fixed-up)

Author: Jan Kratochvil Date: 2020-04-15T23:40:54+02:00 New Revision: 5e04b5f2fa84a65ecf37b9aa2c014493232793b0 URL: https://github.com/llvm/llvm-project/commit/5e04b5f2fa84a65ecf37b9aa2c014493232793b0 DIFF:

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

mib accepted this revision. mib added a comment. It looks like there's no more regression. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 ___

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

JDevlieghere updated this revision to Diff 257840. JDevlieghere marked 6 inline comments as done. JDevlieghere added a comment. Thanks for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78242/new/ https://reviews.llvm.org/D78242 Files: lldb/docs/resources/test.rst Index:

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

mib added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:143 + if (m_apple_types_up->FindByName(context[1].name, + [&](DIERef ref) { return false; })) return;

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

aprantl added a comment. This is great! Comment at: lldb/docs/resources/test.rst:15 + line. These tests interact with the debugger either through the command line + driver or though ``lldb-test`` which is binary that exposes the internal data + structures in an

[Lldb-commits] [lldb] 1349ca4 - [lldb/Docs] Split testing in running and debugging

Author: Jonas Devlieghere Date: 2020-04-15T13:48:58-07:00 New Revision: 1349ca4359b118b0df47c8b2849bed19684e0cb1 URL: https://github.com/llvm/llvm-project/commit/1349ca4359b118b0df47c8b2849bed19684e0cb1 DIFF:

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, jankratochvil. JDevlieghere added a project: LLDB. I gave a short presentation internally with an overview of our test suite. Adrian suggested converting (part of it) for the lldb website, which I thought was a

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:143 + if (m_apple_types_up->FindByName(context[1].name, + [&](DIERef ref) { return

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

jankratochvil updated this revision to Diff 257830. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h

[Lldb-commits] [PATCH] D77608: [lldb/Scripts] Add script to replay multiple reproducers

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ce1a93efd07: [lldb/Scripts] Add script to replay multiple reproducers (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 7ce1a93 - [lldb/Scripts] Add script to replay multiple reproducers

Author: Jonas Devlieghere Date: 2020-04-15T10:55:41-07:00 New Revision: 7ce1a93efd0700770f7c5c368999a44db0d222e8 URL: https://github.com/llvm/llvm-project/commit/7ce1a93efd0700770f7c5c368999a44db0d222e8 DIFF:

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support new replay mode: passive replay

JDevlieghere updated this revision to Diff 257751. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Address Pavel's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77602/new/ https://reviews.llvm.org/D77602 Files:

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support new replay mode: passive replay

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:305 if (is_trivially_serializable::value) - return; + return const_cast(t); // We need to make a copy as the

[Lldb-commits] [PATCH] D78141: [lldb/Reproducers] Simplify LLDB_RECORD macros

JDevlieghere updated this revision to Diff 257738. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Address Pavel's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78141/new/ https://reviews.llvm.org/D78141 Files:

[Lldb-commits] [PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

martong added a comment. Looks okay to me (other than the redundant import code that I have a comment about). > Also this seems to be testable via a Clang unit test, so I think this patch > should have one. Yeah, would be nice to have a Clang unit test. I believe we have the infrastructure

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

jankratochvil reopened this revision. jankratochvil added a comment. This revision is now accepted and ready to land. I had to revert it: rG9289f34390da It has caused a regression:

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257691. kwk added a comment. - Revert "Honor the module" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added a comment. In D74136#1889066 , @labath wrote: > Yes, I believe this matches the behavior we were talking about. > > I could make a bunch of comments on the implementation and the test, but I'm > not sure if

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257688. kwk added a comment. - Honor the module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp

[Lldb-commits] [lldb] 9289f34 - Revert "[nfc] [lldb] Introduce DWARF callbacks"

Author: Jan Kratochvil Date: 2020-04-15T15:12:59+02:00 New Revision: 9289f34390daa07b60af07fdd0576ad52001e0a5 URL: https://github.com/llvm/llvm-project/commit/9289f34390daa07b60af07fdd0576ad52001e0a5 DIFF:

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257682. kwk added a comment. - Modify SearchFilterByModuleListAndCU - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files:

[Lldb-commits] [PATCH] D77608: [lldb/Scripts] Add script to replay multiple reproducers

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/scripts/reproducer-replay.py:1 +#! /usr/bin/env python3 + JDevlieghere wrote: > This is needed for the timeout. I'd rather not rely on

[Lldb-commits] [lldb] ff18a6a - [lldb] Fix -Wparentheses in ThreadPlanStack.cpp

Author: Pavel Labath Date: 2020-04-15T12:47:57+02:00 New Revision: ff18a6acea318f739ced2a1d35a39cb874d2be91 URL: https://github.com/llvm/llvm-project/commit/ff18a6acea318f739ced2a1d35a39cb874d2be91 DIFF: https://github.com/llvm/llvm-project/commit/ff18a6acea318f739ced2a1d35a39cb874d2be91.diff

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd47c470d13b: [nfc] [lldb] Introduce DWARF callbacks (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/

[Lldb-commits] [lldb] bd47c47 - [nfc] [lldb] Introduce DWARF callbacks

Author: Jan Kratochvil Date: 2020-04-15T10:37:38+02:00 New Revision: bd47c470d13b1c57ecf37c1faf0324833d3a4542 URL: https://github.com/llvm/llvm-project/commit/bd47c470d13b1c57ecf37c1faf0324833d3a4542 DIFF:

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support new replay mode: passive replay

labath added a comment. I think we're getting closer, though there is still some duplication that I'd like to eradicate. Comment at: lldb/include/lldb/Utility/Reproducer.h:312 + void SetPassiveReplay(bool b) { m_passive_replay = b; } + Now it looks like

[Lldb-commits] [PATCH] D77968: [lldb][NFC] Remove FormatterChoiceCriterion

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e3701f8a0bf: [lldb][NFC] Remove FormatterChoiceCriterion (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D78141: [lldb/Reproducers] Simplify LLDB_RECORD macros

labath added a comment. This looks even better than I hoped. I think this is a worthwhile simplification even without the followup patches. Just a couple of questions inline... Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:117-135 #define

[Lldb-commits] [lldb] 3e3701f - [lldb][NFC] Remove FormatterChoiceCriterion

Author: Raphael Isemann Date: 2020-04-15T09:47:15+02:00 New Revision: 3e3701f8a0bfafdbca91d4a9cae56c69242c754c URL: https://github.com/llvm/llvm-project/commit/3e3701f8a0bfafdbca91d4a9cae56c69242c754c DIFF:

[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327